Fwd: Re: [8u-dev] Request for Review + Request for Approval for Backport 8049171: Additional tests for jarsigner's warnings

[Seán Coffey]

Thanks for the improved test coverage. Approved for jdk8u-dev.

Regards,
Sean.

On 11/05/16 11:24, Svetlana Nikandrova wrote:
> May I ask for an approval to push it to 8u-dev?
>
> Thank you,
> Svetlana
>
>
> -------- Original Message --------
> Subject:     Re: [8u-dev] Request for Review + Request for Approval 
> for Backport 8049171: Additional tests for jarsigner's warnings
> Date:     Wed, 11 May 2016 12:40:06 +0800
> From:     Wang Weijun <weijun.wang at oracle.com>
> To:     Svetlana Nikandrova <svetlana.nikandrova at oracle.com>
> CC:     security-dev at openjdk.java.net, "jdk8u-dev at openjdk.java.net" 
> <jdk8u-dev at openjdk.java.net>, "Ilya N. Dergalin" 
> <Ilya.Dergalin at oracle.com>
>
>
>
> Looks fine to me.
>
> Just curious, why choose BUFFER_SIZE = 1024 in Utils.java? In JDK 9, 
> DEFAULT_BUFFER_SIZE = 8192.
>
> Thanks
> Max
>
>> On May 11, 2016, at 2:16 AM, Svetlana Nikandrova 
>> <svetlana.nikandrova at oracle.com> wrote:
>>
>> Little remainder.
>>
>> On 06.05.2016 21:14, Svetlana Nikandrova wrote:
>>> Hello,
>>>
>>> I would be grateful if someone could find time to review this 
>>> backport of tests enhancement.
>>> I received few off-line notes and decided to rework this backport a 
>>> little.
>>>
>>> Here is my new webrev:
>>> http://cr.openjdk.java.net/~snikandrova/8049171/webrev.01/ 
>>> <http://cr.openjdk.java.net/%7Esnikandrova/8049171/webrev.01/>
>>>
>
>
>