Approval request: JDK-8156478: 3 Buffer overrun defect groups in jexec.c

[Seán Coffey]

Please follow the approval template for future requests. I didn't see a 
reply to your review request but it looks identical to JDK 9.

Approved for jdk8u-dev. Please add a noreg- label to the bug report.

JDK 9 changeset : http://hg.openjdk.java.net/jdk9/dev/jdk/rev/078eda57a82b
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8156478
Review thread : 
http://mail.openjdk.java.net/pipermail/jdk8u-dev/2016-May/005477.html

Regards,
Sean.

On 24/05/2016 15:39, Henry Jen wrote:
> Please approve this fix for backporting to jdk8u.
>
> Cheers,
> Henry
>
> On May 20, 2016 at 1:45:29 PM, Henry Jen (henry.jen at oracle.com) wrote:
>> Hi,
>>
>> Please review this backport request for launcher, the fix is trivial,
>>
>> diff -r 561c1038f71a src/solaris/bin/jexec.c
>> --- a/src/solaris/bin/jexec.c Fri May 13 18:39:58 2016 +0300
>> +++ b/src/solaris/bin/jexec.c Fri May 20 13:44:51 2016 -0700
>> @@ -331,6 +331,7 @@
>> off_t end = start + xlen;
>>
>> if (end <= count) {
>> + end -= 4; // make sure there are 4 bytes to read at start
>> while (start < end) {
>> off_t xhid = SH(buf, start);
>> off_t xdlen = SH(buf, start + 2);
>>
>> Cheers,
>> Henry
>>
>>