[8u-dev] Request for Review + Approval: Backport of 8163181: Further improvements for Unix NetworkInterface native implementation

Rob McKenna rob.mckenna at oracle.com
Wed Oct 19 19:53:59 UTC 2016


Yup. Please add an appropriate noreg label to the bug though.

Approved.

	-Rob

On 19/10/16 07:40, Langer, Christoph wrote:
> Hi,
> 
> ping: Can I get approval for this downport?
> 
> Thanks
> Christoph
> 
> > -----Original Message-----
> > From: Langer, Christoph
> > Sent: Dienstag, 18. Oktober 2016 12:55
> > To: jdk8u-dev at openjdk.java.net
> > Cc: Mark Sheppard <mark.sheppard at oracle.com>; net-dev at openjdk.java.net;
> > 'Chris Hegarty' <chris.hegarty at oracle.com>
> > Subject: RE: [8u-dev] Request for Review + Approval: Backport of 8163181:
> > Further improvements for Unix NetworkInterface native implementation
> > 
> > Thanks, Chris.
> > 
> > So then I'm asking for approval now...
> > 
> > Best regards
> > Christoph
> > 
> > > -----Original Message-----
> > > From: Chris Hegarty [mailto:chris.hegarty at oracle.com]
> > > Sent: Dienstag, 18. Oktober 2016 12:53
> > > To: Langer, Christoph <christoph.langer at sap.com>
> > > Cc: jdk8u-dev at openjdk.java.net; Mark Sheppard
> > > <mark.sheppard at oracle.com>; net-dev at openjdk.java.net
> > > Subject: Re: [8u-dev] Request for Review + Approval: Backport of 8163181:
> > > Further improvements for Unix NetworkInterface native implementation
> > >
> > >
> > > > On 17 Oct 2016, at 09:38, Langer, Christoph <christoph.langer at sap.com>
> > > wrote:
> > > >
> > > > Hi,
> > > >
> > > > please review (@Chris or Mark) and approve the following downpour.
> > >
> > > From my point of view, I’m ok with this.  You still need 8u maintainer
> > approval.
> > >
> > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8163181
> > > > Original Change:
> > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/40c3550625a2
> > > > New Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8163181.8udev/
> > > > Mail discussion: http://mail.openjdk.java.net/pipermail/net-dev/2016-
> > > September/010207.html
> > > >
> > > > The main motivation for this downport is the bug in the AIX version of
> > > enumIPv6Interfaces.
> > > >
> > > > As the whole change is merely formatting, I decided to ask for a full
> > > downport. The patch does not apply cleanly, I had to resolve a little bit and
> > also
> > > added some further formatting cleanups to be mostly identical with the JDK 9
> > > version of NetworkInterface.c now.
> > > >
> > > > Thanks and best regards
> > > > Christoph
> > >
> > > -Chris.


More information about the jdk8u-dev mailing list