From martinrb at google.com Thu Sep 1 01:54:17 2016 From: martinrb at google.com (Martin Buchholz) Date: Wed, 31 Aug 2016 18:54:17 -0700 Subject: [8u-dev] Request for review: JDK-8151295: runtime/ErrorHandling fails when using jtreg 4.1 b13 In-Reply-To: References: <542E8041.1010101@oracle.com> <5718DC9E.6070907@oracle.com> <571A0E80.80903@oracle.com> Message-ID: Jonathan Gibbons will know what to do. On Wed, Aug 31, 2016 at 8:12 AM, Alexander Vorobyev < alexander.vorobyev at oracle.com> wrote: > Please review this fix for JDK 8. > > I explained in my previous comment, why current code works in JDK 9 but > does not work in JDK 8. > > > > On 22.04.2016 14:44, Alexander Vorobyev wrote: > >> JDK 9 does contain jdk.test.lib.* in hotspot/test/testlibrary so there is >> no problem. >> But we are talking about JDK 8 here. There is no jdk.test.lib.* in >> hotspot/test/teslibray. Instead, it contains com.oracle.java.testlibrary.* >> So the main point of this fix is to use libraries which are available in >> the hotspot testsuite. >> >> In the future, I guess, com.oracle.java.testlibrary.* should be renamed >> to jdk.test.lib.* (like in JDK 9 https://bugs.openjdk.java.net/ >> browse/JDK-8067013) >> >> On 21.04.2016 19:14, Martin Buchholz wrote: >> >>> How does jdk9 work then? >>> Answering my own question, I think it's: >>> >>> # Path to libraries in the topmost test directory. This is needed so >>> @library >>> # does not need ../../ notation to reach them >>> external.lib.roots = ../../ >>> >>> On Thu, Apr 21, 2016 at 6:58 AM, Alexander Vorobyev >>> wrote: >>> >>>> Hi All, >>>> >>>> I'd like review for JDK-8151295 >>>> (https://bugs.openjdk.java.net/browse/JDK-8151295) >>>> >>>> Looks like new version of jtreg by default does not allow to use >>>> libraries >>>> from the outside of test suite. So I guess jdk.test.lib.* in affected >>>> tests >>>> should be changed to com.oracle.java.testlibrary.* which is available >>>> in the >>>> hotspot/test testsuite. At least until it renamed to jdk.testlibrary >>>> (like >>>> here https://bugs.openjdk.java.net/browse/JDK-8067013). >>>> >>>> >>>> >>>> Here is webrev: >>>> http://cr.openjdk.java.net/~avorobye/8151295/ >>>> >>>> >>>> Thanks, >>>> Alexander >>>> >>>> >>>> >>>> >> > From christoph.langer at sap.com Thu Sep 1 10:34:05 2016 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 1 Sep 2016 10:34:05 +0000 Subject: Request for review and approval: 8162598: XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace Message-ID: <70d82e36a5dc4ee784a1442d94eaf93f@DEWDFE13DE11.global.corp.sap> Hi, can you please approve the backport of this fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8162598 JDK9 Change: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/e66cdc2de6b0 Discussion thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-July/042635.html The actual changes and the test have to be split between jdk and jaxp repos: JAXP change: http://cr.openjdk.java.net/~clanger/webrevs/8162598_jaxp.8udev/ Test change in jdk repo: http://cr.openjdk.java.net/~clanger/webrevs/8162598_jdk.8udev/ Unfortunately, the patch does not apply after unshuffling. I also had to transport some of the cleanups that were made in other changes to resolve. But now everything builds and tests run cleanly. The test had to be extracted into an own test as the test structure differs between jdk9 and 8. @Joe: Please review the jdk8 changes in order to get approval. Thanks & Best regards Christoph From HORII at jp.ibm.com Thu Sep 1 14:26:33 2016 From: HORII at jp.ibm.com (Hiroshi H Horii) Date: Thu, 1 Sep 2016 23:26:33 +0900 Subject: RFR(m): java.nio.Bits.unaligned() doesn't return true on ppc Message-ID: Dear all: Can I please request reviews for the following change? This change was created for JDK 8. Some open sources (such as Spark 2.0) check java.nio.Bits.unaligned() to recognize support of unaligned memory access in platform. Though ppc64 and ppc64le support it, unaligned() returns false. In JDK 9, this method returns unalignedAccess() of jdk.internal.misc.Unsafe that doesn't exist in JDK8. jira: https://bugs.openjdk.java.net/browse/JDK-8165231 webrev: http://cr.openjdk.java.net/~gromero/8165231/ (Due to my login issue to the cs.openjdk.java.net, Gustavo thankfully created this webrev.) Regards, Hiroshi ----------------------- Hiroshi Horii, Ph.D. IBM Research - Tokyo From dmitry.markov at oracle.com Fri Sep 2 10:45:50 2016 From: dmitry.markov at oracle.com (dmitry markov) Date: Fri, 02 Sep 2016 13:45:50 +0300 Subject: [8u-dev] Request for approval 8050478: [macosx] Cursor not updating correctly after closing a modal dialog Message-ID: <57C9585E.6000703@oracle.com> Hello, Could you approve the back-port of the fix for 8050478 to jdk8u-dev, please? The jdk9 patch applies cleanly. The bug: https://bugs.openjdk.java.net/browse/JDK-8050478 The webrev: http://cr.openjdk.java.net/~dmarkov/8050478/jdk8u/webrev.00/ The review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2016-August/011817.html The jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/d63da458491c Thanks, Dmitry From rob.mckenna at oracle.com Fri Sep 2 12:49:44 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 2 Sep 2016 13:49:44 +0100 Subject: [8u-dev] Request for approval 8050478: [macosx] Cursor not updating correctly after closing a modal dialog In-Reply-To: <57C9585E.6000703@oracle.com> References: <57C9585E.6000703@oracle.com> Message-ID: <20160902124944.GA5505@vimes> Approved -Rob On 02/09/16 01:45, dmitry markov wrote: > Hello, > > Could you approve the back-port of the fix for 8050478 to jdk8u-dev, please? > The jdk9 patch applies cleanly. > > The bug: > https://bugs.openjdk.java.net/browse/JDK-8050478 > The webrev: > http://cr.openjdk.java.net/~dmarkov/8050478/jdk8u/webrev.00/ > The review thread: > http://mail.openjdk.java.net/pipermail/awt-dev/2016-August/011817.html > The jdk9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/d63da458491c > > Thanks, > Dmitry From christoph.langer at sap.com Fri Sep 2 14:02:56 2016 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 2 Sep 2016 14:02:56 +0000 Subject: [8u-dev] RFR (XXS) and request for approval: 8165320: Small flaw when integrating 8160174 to JDK8 Message-ID: <7734b71fa5cf437bada1cd2a4bc55141@DEWDFE13DE11.global.corp.sap> Hi, can you please review and approve a tiny and straightforward fix for AIX only in JDK8. Bug: https://bugs.openjdk.java.net/browse/JDK-8165320 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8165320.8udev/ When integrating 8160174, I oversaw 2 minor places where JVM_Socket should be used instead of calling the socket API directly for the AIX branch. All other operating systems are not affected and the code is correct there. @Chris: Maybe you can review this straightforward? Thanks & Best regards Christoph From chris.hegarty at oracle.com Fri Sep 2 15:00:07 2016 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 2 Sep 2016 16:00:07 +0100 Subject: [8u-dev] RFR (XXS) and request for approval: 8165320: Small flaw when integrating 8160174 to JDK8 In-Reply-To: <7734b71fa5cf437bada1cd2a4bc55141@DEWDFE13DE11.global.corp.sap> References: <7734b71fa5cf437bada1cd2a4bc55141@DEWDFE13DE11.global.corp.sap> Message-ID: <087925a1-adc8-bdac-bb22-6cf232bd5463@oracle.com> On 02/09/16 15:02, Langer, Christoph wrote: > Hi, > > > > can you please review and approve a tiny and straightforward fix for AIX > only in JDK8. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8165320 > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8165320.8udev/ This looks fine. Reviewed. -Chris. > > When integrating 8160174, I oversaw 2 minor places where JVM_Socket > should be used instead of calling the socket API directly for the AIX > branch. All other operating systems are not affected and the code is > correct there. > > > > @Chris: Maybe you can review this straightforward? > > > > Thanks & Best regards > > Christoph > > > From martin.doerr at sap.com Thu Sep 1 15:06:04 2016 From: martin.doerr at sap.com (Doerr, Martin) Date: Thu, 1 Sep 2016 15:06:04 +0000 Subject: RFR(m): java.nio.Bits.unaligned() doesn't return true on ppc In-Reply-To: References: Message-ID: <8ac308450e3c4a9d92346c16cae553ad@DEWDFE13DE14.global.corp.sap> Hi Hiroshi, thanks for providing a fix. The fix 8158260: PPC64: unaligned Unsafe.getInt can lead to the generation of illegal instructions was downported to 8, so I think your change is good. Best regards, Martin From: Hiroshi H Horii [mailto:HORII at jp.ibm.com] Sent: Donnerstag, 1. September 2016 16:27 To: jdk8u-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net Cc: Gustavo Bueno Romero ; Volker Simonis (volker.simonis at gmail.com) ; Doerr, Martin Subject: RFR(m): java.nio.Bits.unaligned() doesn't return true on ppc Dear all: Can I please request reviews for the following change? This change was created for JDK 8. Some open sources (such as Spark 2.0) check java.nio.Bits.unaligned() to recognize support of unaligned memory access in platform. Though ppc64 and ppc64le support it, unaligned() returns false. In JDK 9, this method returns unalignedAccess() of jdk.internal.misc.Unsafe that doesn't exist in JDK8. jira: https://bugs.openjdk.java.net/browse/JDK-8165231 webrev: http://cr.openjdk.java.net/~gromero/8165231/ (Due to my login issue to the cs.openjdk.java.net, Gustavo thankfully created this webrev.) Regards, Hiroshi ----------------------- Hiroshi Horii, Ph.D. IBM Research - Tokyo From tobias.hartmann at oracle.com Fri Sep 2 15:39:56 2016 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 2 Sep 2016 17:39:56 +0200 Subject: [8u] Request for approval: Backport of 8161147, 8162603 Message-ID: <57C99D4C.3080206@oracle.com> Hi, please approve the following backports to JDK 8u. 8161147: jvm crashes when -XX:+UseCountedLoopSafepoints is enabled https://bugs.openjdk.java.net/browse/JDK-8161147 http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/286ad75013e2 http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-July/023700.html And the follow up test fix: 8162603: Unrecognized VM option 'UseCountedLoopSafepoints' https://bugs.openjdk.java.net/browse/JDK-8162603 http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/40b4cb7908a1 http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-July/023915.html Both fixes were pushed to JDK 9 months ago and showed no problems. The patches apply cleanly to JDK 8u. Thanks, Tobias From rob.mckenna at oracle.com Fri Sep 2 16:18:38 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 2 Sep 2016 17:18:38 +0100 Subject: [8u] Request for approval: Backport of 8161147, 8162603 In-Reply-To: <57C99D4C.3080206@oracle.com> References: <57C99D4C.3080206@oracle.com> Message-ID: <20160902161838.GD5505@vimes> Approved -Rob On 02/09/16 05:39, Tobias Hartmann wrote: > Hi, > > please approve the following backports to JDK 8u. > > 8161147: jvm crashes when -XX:+UseCountedLoopSafepoints is enabled > https://bugs.openjdk.java.net/browse/JDK-8161147 > http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/286ad75013e2 > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-July/023700.html > > And the follow up test fix: > > 8162603: Unrecognized VM option 'UseCountedLoopSafepoints' > https://bugs.openjdk.java.net/browse/JDK-8162603 > http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/40b4cb7908a1 > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-July/023915.html > > Both fixes were pushed to JDK 9 months ago and showed no problems. The patches apply cleanly to JDK 8u. > > Thanks, > Tobias From tobias.hartmann at oracle.com Sun Sep 4 10:09:35 2016 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Sun, 4 Sep 2016 12:09:35 +0200 Subject: [8u] Request for approval: Backport of 8161147, 8162603 In-Reply-To: <20160902161838.GD5505@vimes> References: <57C99D4C.3080206@oracle.com> <20160902161838.GD5505@vimes> Message-ID: <57CBF2DF.5080607@oracle.com> Thanks, Rob! Best regards, Tobias On 02.09.2016 18:18, Rob McKenna wrote: > Approved > > -Rob > > > On 02/09/16 05:39, Tobias Hartmann wrote: >> Hi, >> >> please approve the following backports to JDK 8u. >> >> 8161147: jvm crashes when -XX:+UseCountedLoopSafepoints is enabled >> https://bugs.openjdk.java.net/browse/JDK-8161147 >> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/286ad75013e2 >> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-July/023700.html >> >> And the follow up test fix: >> >> 8162603: Unrecognized VM option 'UseCountedLoopSafepoints' >> https://bugs.openjdk.java.net/browse/JDK-8162603 >> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/40b4cb7908a1 >> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-July/023915.html >> >> Both fixes were pushed to JDK 9 months ago and showed no problems. The patches apply cleanly to JDK 8u. >> >> Thanks, >> Tobias From christoph.langer at sap.com Mon Sep 5 06:36:11 2016 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 5 Sep 2016 06:36:11 +0000 Subject: [8u-dev] RFR (XXS) and request for approval: 8165320: Small flaw when integrating 8160174 to JDK8 In-Reply-To: <087925a1-adc8-bdac-bb22-6cf232bd5463@oracle.com> References: <7734b71fa5cf437bada1cd2a4bc55141@DEWDFE13DE11.global.corp.sap> <087925a1-adc8-bdac-bb22-6cf232bd5463@oracle.com> Message-ID: <476358d76ef84a68b868182ca82a8ff9@DEWDFE13DE11.global.corp.sap> Hi, I still need approval... Thanks Christoph > -----Original Message----- > From: Chris Hegarty [mailto:chris.hegarty at oracle.com] > Sent: Freitag, 2. September 2016 17:00 > To: Langer, Christoph ; jdk8u- > dev at openjdk.java.net > Cc: net-dev at openjdk.java.net > Subject: Re: [8u-dev] RFR (XXS) and request for approval: 8165320: Small flaw > when integrating 8160174 to JDK8 > > On 02/09/16 15:02, Langer, Christoph wrote: > > Hi, > > > > > > > > can you please review and approve a tiny and straightforward fix for AIX > > only in JDK8. > > > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8165320 > > > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8165320.8udev/ > > This looks fine. Reviewed. > > -Chris. > > > > > When integrating 8160174, I oversaw 2 minor places where JVM_Socket > > should be used instead of calling the socket API directly for the AIX > > branch. All other operating systems are not affected and the code is > > correct there. > > > > > > > > @Chris: Maybe you can review this straightforward? > > > > > > > > Thanks & Best regards > > > > Christoph > > > > > > From rob.mckenna at oracle.com Mon Sep 5 11:50:04 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 5 Sep 2016 12:50:04 +0100 Subject: [8u-dev] RFR (XXS) and request for approval: 8165320: Small flaw when integrating 8160174 to JDK8 In-Reply-To: <476358d76ef84a68b868182ca82a8ff9@DEWDFE13DE11.global.corp.sap> References: <7734b71fa5cf437bada1cd2a4bc55141@DEWDFE13DE11.global.corp.sap> <087925a1-adc8-bdac-bb22-6cf232bd5463@oracle.com> <476358d76ef84a68b868182ca82a8ff9@DEWDFE13DE11.global.corp.sap> Message-ID: <20160905115004.GB8263@tecra> Apologies Tobias, missed the review. Approved. -Rob On 05/09/16 06:36, Langer, Christoph wrote: > Hi, > > I still need approval... > > Thanks > Christoph > > > -----Original Message----- > > From: Chris Hegarty [mailto:chris.hegarty at oracle.com] > > Sent: Freitag, 2. September 2016 17:00 > > To: Langer, Christoph ; jdk8u- > > dev at openjdk.java.net > > Cc: net-dev at openjdk.java.net > > Subject: Re: [8u-dev] RFR (XXS) and request for approval: 8165320: Small flaw > > when integrating 8160174 to JDK8 > > > > On 02/09/16 15:02, Langer, Christoph wrote: > > > Hi, > > > > > > > > > > > > can you please review and approve a tiny and straightforward fix for AIX > > > only in JDK8. > > > > > > > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8165320 > > > > > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8165320.8udev/ > > > > This looks fine. Reviewed. > > > > -Chris. > > > > > > > > When integrating 8160174, I oversaw 2 minor places where JVM_Socket > > > should be used instead of calling the socket API directly for the AIX > > > branch. All other operating systems are not affected and the code is > > > correct there. > > > > > > > > > > > > @Chris: Maybe you can review this straightforward? > > > > > > > > > > > > Thanks & Best regards > > > > > > Christoph > > > > > > > > > From Sergey.Bylokhov at oracle.com Mon Sep 5 18:24:14 2016 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Mon, 5 Sep 2016 21:24:14 +0300 Subject: [8u-dev] Request for approval: 8159696 java.beans.MethodRef#get throws NullPointerException Message-ID: Hello, These is a direct back port from jdk 9 to jdk 8u-dev. 8159696: java.beans.MethodRef#get throws NullPointerException Bug: https://bugs.openjdk.java.net/browse/JDK-8159696 Webrev can be found at: http://cr.openjdk.java.net/~serb/8159696/webrev.00 jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/fc61e14681ac Review: http://mail.openjdk.java.net/pipermail/beans-dev/2016-August/000334.html Reviewers: Alexandr Scherbatiy -- Best regards, Sergey. From rob.mckenna at oracle.com Mon Sep 5 18:45:32 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 5 Sep 2016 19:45:32 +0100 Subject: [8u-dev] Request for approval: 8159696 java.beans.MethodRef#get throws NullPointerException In-Reply-To: References: Message-ID: <20160905184532.GA6236@vimes> Approved -Rob On 05/09/16 09:24, Sergey Bylokhov wrote: > Hello, > These is a direct back port from jdk 9 to jdk 8u-dev. > > 8159696: java.beans.MethodRef#get throws NullPointerException > Bug: https://bugs.openjdk.java.net/browse/JDK-8159696 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8159696/webrev.00 > jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/fc61e14681ac > Review: > http://mail.openjdk.java.net/pipermail/beans-dev/2016-August/000334.html > Reviewers: Alexandr Scherbatiy > > -- > Best regards, Sergey. From huizhe.wang at oracle.com Tue Sep 6 05:49:34 2016 From: huizhe.wang at oracle.com (Joe Wang) Date: Mon, 05 Sep 2016 22:49:34 -0700 Subject: Request for review and approval: 8162598: XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace In-Reply-To: <70d82e36a5dc4ee784a1442d94eaf93f@DEWDFE13DE11.global.corp.sap> References: <70d82e36a5dc4ee784a1442d94eaf93f@DEWDFE13DE11.global.corp.sap> Message-ID: <57CE58EE.2040500@oracle.com> Hi Langer, The backport looks good to me. But you'll need approval from either Sean or Rob in order to put back into JDK 8. Best, Joe On 9/1/16, 3:34 AM, Langer, Christoph wrote: > > Hi, > > can you please approve the backport of this fix: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8162598 > > JDK9 Change: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/e66cdc2de6b0 > > Discussion thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-July/042635.html > > The actual changes and the test have to be split between jdk and jaxp > repos: > > JAXP change: > http://cr.openjdk.java.net/~clanger/webrevs/8162598_jaxp.8udev/ > > > Test change in jdk repo: > http://cr.openjdk.java.net/~clanger/webrevs/8162598_jdk.8udev/ > > > Unfortunately, the patch does not apply after unshuffling. I also had > to transport some of the cleanups that were made in other changes to > resolve. But now everything builds and tests run cleanly. The test had > to be extracted into an own test as the test structure differs between > jdk9 and 8. > > @Joe: Please review the jdk8 changes in order to get approval. > > Thanks & Best regards > > Christoph > From christoph.langer at sap.com Tue Sep 6 05:51:02 2016 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 6 Sep 2016 05:51:02 +0000 Subject: Request for review and approval: 8162598: XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace In-Reply-To: <57CE58EE.2040500@oracle.com> References: <70d82e36a5dc4ee784a1442d94eaf93f@DEWDFE13DE11.global.corp.sap> <57CE58EE.2040500@oracle.com> Message-ID: Thanks Joe for reviewing. Then I request approval now... Best regards Christoph From: Joe Wang [mailto:huizhe.wang at oracle.com] Sent: Dienstag, 6. September 2016 07:50 To: Langer, Christoph Cc: jdk8u-dev at openjdk.java.net; Daniel Fuchs Subject: Re: Request for review and approval: 8162598: XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace Hi Langer, The backport looks good to me. But you'll need approval from either Sean or Rob in order to put back into JDK 8. Best, Joe On 9/1/16, 3:34 AM, Langer, Christoph wrote: Hi, can you please approve the backport of this fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8162598 JDK9 Change: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/e66cdc2de6b0 Discussion thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-July/042635.html The actual changes and the test have to be split between jdk and jaxp repos: JAXP change: http://cr.openjdk.java.net/~clanger/webrevs/8162598_jaxp.8udev/ Test change in jdk repo: http://cr.openjdk.java.net/~clanger/webrevs/8162598_jdk.8udev/ Unfortunately, the patch does not apply after unshuffling. I also had to transport some of the cleanups that were made in other changes to resolve. But now everything builds and tests run cleanly. The test had to be extracted into an own test as the test structure differs between jdk9 and 8. @Joe: Please review the jdk8 changes in order to get approval. Thanks & Best regards Christoph From sean.coffey at oracle.com Tue Sep 6 08:22:16 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Tue, 6 Sep 2016 09:22:16 +0100 Subject: Request for review and approval: 8162598: XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace In-Reply-To: References: <70d82e36a5dc4ee784a1442d94eaf93f@DEWDFE13DE11.global.corp.sap> <57CE58EE.2040500@oracle.com> Message-ID: Approved for jdk8u-dev. regards, Sean. On 06/09/2016 06:51, Langer, Christoph wrote: > Thanks Joe for reviewing. Then I request approval now... > > Best regards > Christoph > > From: Joe Wang [mailto:huizhe.wang at oracle.com] > Sent: Dienstag, 6. September 2016 07:50 > To: Langer, Christoph > Cc: jdk8u-dev at openjdk.java.net; Daniel Fuchs > Subject: Re: Request for review and approval: 8162598: XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace > > Hi Langer, > > The backport looks good to me. But you'll need approval from either Sean or Rob in order to put back into JDK 8. > > Best, > Joe > > On 9/1/16, 3:34 AM, Langer, Christoph wrote: > Hi, > > can you please approve the backport of this fix: > Bug: https://bugs.openjdk.java.net/browse/JDK-8162598 > JDK9 Change: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/e66cdc2de6b0 > Discussion thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-July/042635.html > > The actual changes and the test have to be split between jdk and jaxp repos: > JAXP change: http://cr.openjdk.java.net/~clanger/webrevs/8162598_jaxp.8udev/ > Test change in jdk repo: http://cr.openjdk.java.net/~clanger/webrevs/8162598_jdk.8udev/ > > Unfortunately, the patch does not apply after unshuffling. I also had to transport some of the cleanups that were made in other changes to resolve. But now everything builds and tests run cleanly. The test had to be extracted into an own test as the test structure differs between jdk9 and 8. > > @Joe: Please review the jdk8 changes in order to get approval. > > Thanks & Best regards > Christoph > From ivan.gerasimov at oracle.com Wed Sep 7 10:54:36 2016 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 7 Sep 2016 13:54:36 +0300 Subject: [8u-dev] Request for approval to backport: 8153438: Avoid repeated "Please insert a smart card" popup windows Message-ID: <92f2d10c-3c07-e124-c388-f82b80d8ea42@oracle.com> Hello! I'd like to get an approval to backport this fix to jdk8u. Unshuffled patch applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8153438 Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/e7f78523d41d Jdk9 review: http://mail.openjdk.java.net/pipermail/security-dev/2016-August/014543.html Would you please approve? With kind regards, Ivan From david.buck at oracle.com Wed Sep 7 12:09:16 2016 From: david.buck at oracle.com (david buck) Date: Wed, 7 Sep 2016 21:09:16 +0900 Subject: [8u-dev] Request for approval to backport: 8153438: Avoid repeated "Please insert a smart card" popup windows In-Reply-To: <92f2d10c-3c07-e124-c388-f82b80d8ea42@oracle.com> References: <92f2d10c-3c07-e124-c388-f82b80d8ea42@oracle.com> Message-ID: <6ac3da56-6d26-421a-1aa6-2518f0808b71@oracle.com> approved for backport to 8u-dev Cheers, -Buck On 2016/09/07 19:54, Ivan Gerasimov wrote: > Hello! > > I'd like to get an approval to backport this fix to jdk8u. > > Unshuffled patch applies cleanly. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8153438 > Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/e7f78523d41d > Jdk9 review: > http://mail.openjdk.java.net/pipermail/security-dev/2016-August/014543.html > > Would you please approve? > > With kind regards, > Ivan > From vladimir.kozlov at oracle.com Wed Sep 7 19:17:05 2016 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 7 Sep 2016 12:17:05 -0700 Subject: [8u-dev] Request for approval to backport: 8157306 and 8162496 Message-ID: Hi! I'd like to get an approval to backport this fix to jdk8u. https://bugs.openjdk.java.net/browse/JDK-8157306 "Random infrequent null pointer exceptions in javac" https://bugs.openjdk.java.net/browse/JDK-8162496 "missing precedence edge for anti_dependence" http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/f6c7981c093e http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/6f10754f85d9 Changes are applied cleanly to 8u sources. They were tested in JDK 9 for more then 2 weeks already. No new tests were added since the problem showed with existing Hotspot jtreg tests for both bugs. We found very dangerous problem which should be fixed in all releases. It is rare but cause incorrect behavior due to wrong ordering of depending stores and loads. The verification added for JDK-8162496 found several places which cause this. Thanks, Vladimir From rob.mckenna at oracle.com Wed Sep 7 19:33:01 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 7 Sep 2016 20:33:01 +0100 Subject: [8u-dev] Request for approval to backport: 8157306 and 8162496 In-Reply-To: References: Message-ID: <20160907193301.GE5531@vimes> Approved -Rob On 07/09/16 12:17, Vladimir Kozlov wrote: > Hi! > > I'd like to get an approval to backport this fix to jdk8u. > > https://bugs.openjdk.java.net/browse/JDK-8157306 "Random infrequent null > pointer exceptions in javac" > https://bugs.openjdk.java.net/browse/JDK-8162496 "missing precedence edge > for anti_dependence" > > http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/f6c7981c093e > http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/6f10754f85d9 > > Changes are applied cleanly to 8u sources. They were tested in JDK 9 for > more then 2 weeks already. > > No new tests were added since the problem showed with existing Hotspot jtreg > tests for both bugs. > > We found very dangerous problem which should be fixed in all releases. It is > rare but cause incorrect behavior due to wrong ordering of depending stores > and loads. The verification added for JDK-8162496 found several places which > cause this. > > Thanks, > Vladimir From vladimir.kozlov at oracle.com Wed Sep 7 21:49:22 2016 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 7 Sep 2016 14:49:22 -0700 Subject: [8u-dev] Request for approval to backport: 8157306 and 8162496 In-Reply-To: <20160907193301.GE5531@vimes> References: <20160907193301.GE5531@vimes> Message-ID: <9a022ac5-25e5-9a2b-3e32-58ba53b83489@oracle.com> thank you, Rob Vladimir On 9/7/16 12:33 PM, Rob McKenna wrote: > Approved > > -Rob > > On 07/09/16 12:17, Vladimir Kozlov wrote: >> Hi! >> >> I'd like to get an approval to backport this fix to jdk8u. >> >> https://bugs.openjdk.java.net/browse/JDK-8157306 "Random infrequent null >> pointer exceptions in javac" >> https://bugs.openjdk.java.net/browse/JDK-8162496 "missing precedence edge >> for anti_dependence" >> >> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/f6c7981c093e >> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/6f10754f85d9 >> >> Changes are applied cleanly to 8u sources. They were tested in JDK 9 for >> more then 2 weeks already. >> >> No new tests were added since the problem showed with existing Hotspot jtreg >> tests for both bugs. >> >> We found very dangerous problem which should be fixed in all releases. It is >> rare but cause incorrect behavior due to wrong ordering of depending stores >> and loads. The verification added for JDK-8162496 found several places which >> cause this. >> >> Thanks, >> Vladimir From christoph.langer at sap.com Mon Sep 5 06:36:11 2016 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 5 Sep 2016 00:36:11 -0600 Subject: [8u-dev] RFR (XXS) and request for approval: 8165320: Small flaw when integrating 8160174 to JDK8 In-Reply-To: <087925a1-adc8-bdac-bb22-6cf232bd5463@oracle.com> References: <7734b71fa5cf437bada1cd2a4bc55141@DEWDFE13DE11.global.corp.sap> <087925a1-adc8-bdac-bb22-6cf232bd5463@oracle.com> Message-ID: <476358d76ef84a68b868182ca82a8ff9@DEWDFE13DE11.global.corp.sap> Hi, I still need approval... Thanks Christoph > -----Original Message----- > From: Chris Hegarty [mailto:chris.hegarty at oracle.com] > Sent: Freitag, 2. September 2016 17:00 > To: Langer, Christoph ; jdk8u- > dev at openjdk.java.net > Cc: net-dev at openjdk.java.net > Subject: Re: [8u-dev] RFR (XXS) and request for approval: 8165320: Small flaw > when integrating 8160174 to JDK8 > > On 02/09/16 15:02, Langer, Christoph wrote: > > Hi, > > > > > > > > can you please review and approve a tiny and straightforward fix for AIX > > only in JDK8. > > > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8165320 > > > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8165320.8udev/ > > This looks fine. Reviewed. > > -Chris. > > > > > When integrating 8160174, I oversaw 2 minor places where JVM_Socket > > should be used instead of calling the socket API directly for the AIX > > branch. All other operating systems are not affected and the code is > > correct there. > > > > > > > > @Chris: Maybe you can review this straightforward? > > > > > > > > Thanks & Best regards > > > > Christoph > > > > > > From rob.mckenna at oracle.com Thu Sep 8 11:29:15 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 8 Sep 2016 12:29:15 +0100 Subject: [8u-dev] RFR (XXS) and request for approval: 8165320: Small flaw when integrating 8160174 to JDK8 In-Reply-To: <476358d76ef84a68b868182ca82a8ff9@DEWDFE13DE11.global.corp.sap> References: <7734b71fa5cf437bada1cd2a4bc55141@DEWDFE13DE11.global.corp.sap> <087925a1-adc8-bdac-bb22-6cf232bd5463@oracle.com> <476358d76ef84a68b868182ca82a8ff9@DEWDFE13DE11.global.corp.sap> Message-ID: <20160908112915.GA5484@vimes> Approved -Rob On 05/09/16 12:36, Langer, Christoph wrote: > Hi, > > I still need approval... > > Thanks > Christoph > > > -----Original Message----- > > From: Chris Hegarty [mailto:chris.hegarty at oracle.com] > > Sent: Freitag, 2. September 2016 17:00 > > To: Langer, Christoph ; jdk8u- > > dev at openjdk.java.net > > Cc: net-dev at openjdk.java.net > > Subject: Re: [8u-dev] RFR (XXS) and request for approval: 8165320: Small flaw > > when integrating 8160174 to JDK8 > > > > On 02/09/16 15:02, Langer, Christoph wrote: > > > Hi, > > > > > > > > > > > > can you please review and approve a tiny and straightforward fix for AIX > > > only in JDK8. > > > > > > > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8165320 > > > > > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8165320.8udev/ > > > > This looks fine. Reviewed. > > > > -Chris. > > > > > > > > When integrating 8160174, I oversaw 2 minor places where JVM_Socket > > > should be used instead of calling the socket API directly for the AIX > > > branch. All other operating systems are not affected and the code is > > > correct there. > > > > > > > > > > > > @Chris: Maybe you can review this straightforward? > > > > > > > > > > > > Thanks & Best regards > > > > > > Christoph > > > > > > > > > > From shafi.s.ahmad at oracle.com Fri Sep 9 05:56:36 2016 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Thu, 8 Sep 2016 22:56:36 -0700 (PDT) Subject: [8u] RFA for JDK-8044575: File Leak in CompileBroker::init_compiler_thread_log of compileBroker.cpp:1665 Message-ID: <2a989b89-c743-4606-b7ae-3ef5c511226e@default> Hi, Please approve this clean backport of 'JDK-8152730: File Leak in CompileBroker::init_compiler_thread_log of compileBroker.cpp:1665' to 8u-dev. Jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8152730 Review link: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-March/022107.html Jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/ae6a4f50437b Testing: jprt Regards, Shafi From david.buck at oracle.com Fri Sep 9 10:13:50 2016 From: david.buck at oracle.com (david buck) Date: Fri, 9 Sep 2016 19:13:50 +0900 Subject: [8u] RFA for JDK-8044575: File Leak in CompileBroker::init_compiler_thread_log of compileBroker.cpp:1665 In-Reply-To: <2a989b89-c743-4606-b7ae-3ef5c511226e@default> References: <2a989b89-c743-4606-b7ae-3ef5c511226e@default> Message-ID: <1bdd564a-5675-8f48-c261-3346d53a5bdc@oracle.com> approved for backport to 8u-dev Cheers, -Buck On 2016/09/09 14:56, Shafi Ahmad wrote: > Hi, > > Please approve this clean backport of 'JDK-8152730: File Leak in CompileBroker::init_compiler_thread_log of compileBroker.cpp:1665' to 8u-dev. > > Jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8152730 > Review link: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-March/022107.html > Jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/ae6a4f50437b > > Testing: jprt > > Regards, > Shafi > From ivan.gerasimov at oracle.com Fri Sep 9 15:43:20 2016 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 9 Sep 2016 18:43:20 +0300 Subject: [8u-dev] Request for Review and Approval to backport: 8165243: Base64.Encoder.wrap(os).write(byte[], int, int) with incorrect arguments should not produce output Message-ID: <9cd8af6e-11c4-ee7f-9bfe-0a00b750c006@oracle.com> Hello! I'd like to backport this fix to jdk8u. The unshuffled fix applies almost clearly: I only had to slightly modify the regression test. Bug: https://bugs.openjdk.java.net/browse/JDK-8165243 Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a81f30fb7d8c Jdk9 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-September/043266.html Jdk8u webrev: http://cr.openjdk.java.net/~igerasim/8165243/03/webrev/ Would you please help review the change and approve the backport? Thanks in advance, Ivan From sean.coffey at oracle.com Fri Sep 9 15:50:28 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 9 Sep 2016 16:50:28 +0100 Subject: [8u-dev] Request for Review and Approval to backport: 8165243: Base64.Encoder.wrap(os).write(byte[], int, int) with incorrect arguments should not produce output In-Reply-To: <9cd8af6e-11c4-ee7f-9bfe-0a00b750c006@oracle.com> References: <9cd8af6e-11c4-ee7f-9bfe-0a00b750c006@oracle.com> Message-ID: <57D2DA44.4090809@oracle.com> Looks fine Ivan. Reviewed. Approved for jdk8u-dev. Regards, Sean. On 09/09/16 16:43, Ivan Gerasimov wrote: > Hello! > > I'd like to backport this fix to jdk8u. > > The unshuffled fix applies almost clearly: I only had to slightly > modify the regression test. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8165243 > Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a81f30fb7d8c > Jdk9 review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-September/043266.html > Jdk8u webrev: http://cr.openjdk.java.net/~igerasim/8165243/03/webrev/ > > Would you please help review the change and approve the backport? > > Thanks in advance, > Ivan > From ivan.gerasimov at oracle.com Fri Sep 9 15:53:08 2016 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 9 Sep 2016 18:53:08 +0300 Subject: [8u-dev] Request for Review and Approval to backport: 8165243: Base64.Encoder.wrap(os).write(byte[], int, int) with incorrect arguments should not produce output In-Reply-To: <57D2DA44.4090809@oracle.com> References: <9cd8af6e-11c4-ee7f-9bfe-0a00b750c006@oracle.com> <57D2DA44.4090809@oracle.com> Message-ID: <94e297e1-fcfb-aca9-fdb8-bb4a700d851c@oracle.com> Thank you very much Se?n! On 09.09.2016 18:50, Se?n Coffey wrote: > Looks fine Ivan. Reviewed. > > Approved for jdk8u-dev. > > Regards, > Sean. > > On 09/09/16 16:43, Ivan Gerasimov wrote: >> Hello! >> >> I'd like to backport this fix to jdk8u. >> >> The unshuffled fix applies almost clearly: I only had to slightly >> modify the regression test. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8165243 >> Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a81f30fb7d8c >> Jdk9 review: >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-September/043266.html >> Jdk8u webrev: http://cr.openjdk.java.net/~igerasim/8165243/03/webrev/ >> >> Would you please help review the change and approve the backport? >> >> Thanks in advance, >> Ivan >> > > From shafi.s.ahmad at oracle.com Mon Sep 12 06:33:17 2016 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Sun, 11 Sep 2016 23:33:17 -0700 (PDT) Subject: [8u] RFA for JDK-8153176: Long pause in ParOldGC, because ParallelTaskTerminator peeks wrong TaskQueueSet Message-ID: <419e1dc5-dda2-4ae1-964c-39dff2ef6595@default> Hi, Please approve this clean backport of ' JDK-8153176: Long pause in ParOldGC, because ParallelTaskTerminator peeks wrong TaskQueueSet' to 8u-dev. Please note the backport is clean after changing the path from " src/share/vm/gc/parallel/" to " src/share/vm/gc_implementation/parallelScavenge/" in the original changeset. Jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8153176 Review link: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-March/017456.html http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-April/017484.html Jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/d19a9badb2df Testing: jprt Regards, Shafi From rob.mckenna at oracle.com Mon Sep 12 12:23:33 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 12 Sep 2016 13:23:33 +0100 Subject: [8u] RFA for JDK-8153176: Long pause in ParOldGC, because ParallelTaskTerminator peeks wrong TaskQueueSet In-Reply-To: <419e1dc5-dda2-4ae1-964c-39dff2ef6595@default> References: <419e1dc5-dda2-4ae1-964c-39dff2ef6595@default> Message-ID: <20160912122333.GA12948@tecra> Approved, please add a suitable noreg label. -Rob On 11/09/16 11:33, Shafi Ahmad wrote: > Hi, > > Please approve this clean backport of ' JDK-8153176: Long pause in ParOldGC, because ParallelTaskTerminator peeks wrong TaskQueueSet' to 8u-dev. > Please note the backport is clean after changing the path from " src/share/vm/gc/parallel/" to " src/share/vm/gc_implementation/parallelScavenge/" in the original changeset. > > Jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8153176 > Review link: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-March/017456.html > http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-April/017484.html > Jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/d19a9badb2df > > Testing: jprt > > Regards, > Shafi From anton.tarasov at jetbrains.com Tue Sep 13 07:53:23 2016 From: anton.tarasov at jetbrains.com (Anton Tarasov) Date: Tue, 13 Sep 2016 10:53:23 +0300 Subject: [8u-dev] Request for approval 8160570: [macosx] modal dialog can skip the activation/focus events Message-ID: Hello, Could you please approve a direct back-port of 8160570 to 8u-dev? bug: https://bugs.openjdk.java.net/browse/JDK-8160570 webrev: http://cr.openjdk.java.net/~ant/JDK-8160570/8u-dev/webrev.0 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2016-September/011891.html jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/e30c36db6c44 Thanks, Anton. From volker.simonis at gmail.com Tue Sep 13 08:37:08 2016 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 13 Sep 2016 10:37:08 +0200 Subject: [8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() doesn't return true on ppc Message-ID: Hi Alan, Sean, can we please get a review for this rather trivial change? > jira: https://bugs.openjdk.java.net/browse/JDK-8165231 > webrev: http://cr.openjdk.java.net/~gromero/8165231/ As outlined in Hiroshi's initial mail, we can not simply downport the solution used in jdk9 for querying the unaligned access support in nio because of differences in Unsafe. So this is a jsk8u-only change. But I think it is simple enough and doesn't affect any other platform except ppc to justify it. As nobody from the ppc porting team is jdk8u reviewer, I kindly ask you for a review and the permission to integrate into jdk8u. Thanks a lot and best regards, Volker On Thu, Sep 1, 2016 at 5:06 PM, Doerr, Martin wrote: > Hi Hiroshi, > > > > thanks for providing a fix. > > > > The fix > > 8158260: PPC64: unaligned Unsafe.getInt can lead to the generation of > illegal instructions > > was downported to 8, so I think your change is good. > > > > Best regards, > > Martin > > > > > > From: Hiroshi H Horii [mailto:HORII at jp.ibm.com] > Sent: Donnerstag, 1. September 2016 16:27 > To: jdk8u-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net > Cc: Gustavo Bueno Romero ; Volker Simonis > (volker.simonis at gmail.com) ; Doerr, Martin > > Subject: RFR(m): java.nio.Bits.unaligned() doesn't return true on ppc > > > > Dear all: > > Can I please request reviews for the following change? > This change was created for JDK 8. > > Some open sources (such as Spark 2.0) check java.nio.Bits.unaligned() > to recognize support of unaligned memory access in platform. > Though ppc64 and ppc64le support it, unaligned() returns false. > > In JDK 9, this method returns unalignedAccess() of jdk.internal.misc.Unsafe > that doesn't exist in JDK8. > > jira: https://bugs.openjdk.java.net/browse/JDK-8165231 > webrev: http://cr.openjdk.java.net/~gromero/8165231/ > (Due to my login issue to the cs.openjdk.java.net, Gustavo thankfully > created this webrev.) > > Regards, > Hiroshi > ----------------------- > Hiroshi Horii, Ph.D. > IBM Research - Tokyo From sean.coffey at oracle.com Tue Sep 13 10:35:16 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Tue, 13 Sep 2016 11:35:16 +0100 Subject: [8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() doesn't return true on ppc In-Reply-To: References: Message-ID: <13e66bbd-d896-673f-23ce-ea2eef45b230@oracle.com> Hi Volker, The fix looks fine to me. Please add the '9-na' label to the bug report. Also add a suitable noreg- label. It would also be useful to link the issue to JDK-8158260 Approved for jdk8u-dev. regards, Sean. On 13/09/2016 09:37, Volker Simonis wrote: > Hi Alan, Sean, > > can we please get a review for this rather trivial change? > >> jira: https://bugs.openjdk.java.net/browse/JDK-8165231 >> webrev: http://cr.openjdk.java.net/~gromero/8165231/ > As outlined in Hiroshi's initial mail, we can not simply downport the > solution used in jdk9 for querying the unaligned access support in nio > because of differences in Unsafe. So this is a jsk8u-only change. But > I think it is simple enough and doesn't affect any other platform > except ppc to justify it. > > As nobody from the ppc porting team is jdk8u reviewer, I kindly ask > you for a review and the permission to integrate into jdk8u. > > Thanks a lot and best regards, > Volker > > > On Thu, Sep 1, 2016 at 5:06 PM, Doerr, Martin wrote: >> Hi Hiroshi, >> >> >> >> thanks for providing a fix. >> >> >> >> The fix >> >> 8158260: PPC64: unaligned Unsafe.getInt can lead to the generation of >> illegal instructions >> >> was downported to 8, so I think your change is good. >> >> >> >> Best regards, >> >> Martin >> >> >> >> >> >> From: Hiroshi H Horii [mailto:HORII at jp.ibm.com] >> Sent: Donnerstag, 1. September 2016 16:27 >> To: jdk8u-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net >> Cc: Gustavo Bueno Romero ; Volker Simonis >> (volker.simonis at gmail.com) ; Doerr, Martin >> >> Subject: RFR(m): java.nio.Bits.unaligned() doesn't return true on ppc >> >> >> >> Dear all: >> >> Can I please request reviews for the following change? >> This change was created for JDK 8. >> >> Some open sources (such as Spark 2.0) check java.nio.Bits.unaligned() >> to recognize support of unaligned memory access in platform. >> Though ppc64 and ppc64le support it, unaligned() returns false. >> >> In JDK 9, this method returns unalignedAccess() of jdk.internal.misc.Unsafe >> that doesn't exist in JDK8. >> >> jira: https://bugs.openjdk.java.net/browse/JDK-8165231 >> webrev: http://cr.openjdk.java.net/~gromero/8165231/ >> (Due to my login issue to the cs.openjdk.java.net, Gustavo thankfully >> created this webrev.) >> >> Regards, >> Hiroshi >> ----------------------- >> Hiroshi Horii, Ph.D. >> IBM Research - Tokyo From volker.simonis at gmail.com Tue Sep 13 12:09:39 2016 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 13 Sep 2016 14:09:39 +0200 Subject: [8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() doesn't return true on ppc In-Reply-To: <13e66bbd-d896-673f-23ce-ea2eef45b230@oracle.com> References: <13e66bbd-d896-673f-23ce-ea2eef45b230@oracle.com> Message-ID: Hi Sean, thanks a lot for the fast response. I've updated the bug entry as requested and will push the change - maybe with the following potential improvement: @Hiroshi: also maybe not that performance relevant, I think we should we also fix sun/security/provider/ByteArrayAccess.java which contains the same construct: // Return whether this platform supports full speed int/long memory access // at unaligned addresses. // This code was copied from java.nio.Bits because there is no equivalent // public API. private static boolean unaligned() { String arch = java.security.AccessController.doPrivileged (new sun.security.action.GetPropertyAction("os.arch", "")); return arch.equals("i386") || arch.equals("x86") || arch.equals("amd64") || arch.equals("x86_64"); } Regards, Volker From sean.coffey at oracle.com Tue Sep 13 12:45:19 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Tue, 13 Sep 2016 13:45:19 +0100 Subject: [8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() doesn't return true on ppc In-Reply-To: References: <13e66bbd-d896-673f-23ce-ea2eef45b230@oracle.com> Message-ID: <962ae958-5897-6e9b-eec3-33680358ad0b@oracle.com> Sounds good Volker. Good catch. regards, Sean. On 13/09/2016 13:09, Volker Simonis wrote: > Hi Sean, > > thanks a lot for the fast response. I've updated the bug entry as > requested and will push the change - maybe with the following > potential improvement: > > @Hiroshi: also maybe not that performance relevant, I think we should > we also fix sun/security/provider/ByteArrayAccess.java which contains > the same construct: > > // Return whether this platform supports full speed int/long memory access > // at unaligned addresses. > // This code was copied from java.nio.Bits because there is no equivalent > // public API. > private static boolean unaligned() { > String arch = java.security.AccessController.doPrivileged > (new sun.security.action.GetPropertyAction("os.arch", "")); > return arch.equals("i386") || arch.equals("x86") || arch.equals("amd64") > || arch.equals("x86_64"); > } > > Regards, > Volker From rob.mckenna at oracle.com Tue Sep 13 14:00:58 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 13 Sep 2016 15:00:58 +0100 Subject: [8u-dev] Request for approval 8160570: [macosx] modal dialog can skip the activation/focus events In-Reply-To: References: Message-ID: <20160913140058.GA4669@vimes> Approved -Rob On 13/09/16 10:53, Anton Tarasov wrote: > Hello, > > Could you please approve a direct back-port of 8160570 to 8u-dev? > > bug: https://bugs.openjdk.java.net/browse/JDK-8160570 > > webrev: http://cr.openjdk.java.net/~ant/JDK-8160570/8u-dev/webrev.0 > > > review thread: > http://mail.openjdk.java.net/pipermail/awt-dev/2016-September/011891.html > > jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/e30c36db6c44 > > Thanks, > Anton. From sean.coffey at oracle.com Wed Sep 14 13:11:14 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 14 Sep 2016 14:11:14 +0100 Subject: [jdk8u-dev] Request for approval : 8164846 :CertificateException missing cause of underlying exception Message-ID: <57D94C72.3030105@oracle.com> I'd like to backport this fix to jdk8u-dev. Patch applies cleanly post patch unshuffling. Tests are green. https://bugs.openjdk.java.net/browse/JDK-8164846 jdk 9 changeset : http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/1c28399f1b50 review thread : http://mail.openjdk.java.net/pipermail/security-dev/2016-September/014779.html -- Regards, Sean. From rob.mckenna at oracle.com Wed Sep 14 13:18:27 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 14 Sep 2016 14:18:27 +0100 Subject: [jdk8u-dev] Request for approval : 8164846 :CertificateException missing cause of underlying exception In-Reply-To: <57D94C72.3030105@oracle.com> References: <57D94C72.3030105@oracle.com> Message-ID: <20160914131827.GB5356@vimes> Approved -Rob On 14/09/16 02:11, Se?n Coffey wrote: > I'd like to backport this fix to jdk8u-dev. Patch applies cleanly post patch > unshuffling. Tests are green. > > https://bugs.openjdk.java.net/browse/JDK-8164846 > jdk 9 changeset : http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/1c28399f1b50 > review thread : http://mail.openjdk.java.net/pipermail/security-dev/2016-September/014779.html > > -- > Regards, > Sean. > From HORII at jp.ibm.com Thu Sep 15 06:08:41 2016 From: HORII at jp.ibm.com (Hiroshi H Horii) Date: Thu, 15 Sep 2016 15:08:41 +0900 Subject: [8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() doesn't return true on ppc In-Reply-To: <962ae958-5897-6e9b-eec3-33680358ad0b@oracle.com> References: <13e66bbd-d896-673f-23ce-ea2eef45b230@oracle.com> <962ae958-5897-6e9b-eec3-33680358ad0b@oracle.com> Message-ID: Hi Volker, and Sean, Thank you for your comments and suggestion. I and Gustavo created a webrev that includes Bits and ByteArrayAccess. http://cr.openjdk.java.net/~gromero/8165231/02/ I believe there is no other similar methods in jdk. Regards, Hiroshi ----------------------- Hiroshi Horii, Ph.D. IBM Research - Tokyo From: Sean Coffey To: Volker Simonis Cc: "jdk8u-dev at openjdk.java.net" , Java Core Libs , Hiroshi H Horii/Japan/IBM at IBMJP, "ppc-aix-port-dev at openjdk.java.net" , Gustavo Bueno Romero , "Doerr, Martin" Date: 09/13/2016 21:46 Subject: Re: [8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() doesn't return true on ppc Sounds good Volker. Good catch. regards, Sean. On 13/09/2016 13:09, Volker Simonis wrote: > Hi Sean, > > thanks a lot for the fast response. I've updated the bug entry as > requested and will push the change - maybe with the following > potential improvement: > > @Hiroshi: also maybe not that performance relevant, I think we should > we also fix sun/security/provider/ByteArrayAccess.java which contains > the same construct: > > // Return whether this platform supports full speed int/long memory access > // at unaligned addresses. > // This code was copied from java.nio.Bits because there is no equivalent > // public API. > private static boolean unaligned() { > String arch = java.security.AccessController.doPrivileged > (new sun.security.action.GetPropertyAction("os.arch", "")); > return arch.equals("i386") || arch.equals("x86") || arch.equals("amd64") > || arch.equals("x86_64"); > } > > Regards, > Volker From shafi.s.ahmad at oracle.com Tue Sep 20 05:56:02 2016 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Mon, 19 Sep 2016 22:56:02 -0700 (PDT) Subject: [8u] RFA for JDK-8157548: JVM crashes sometimes while starting Message-ID: Hi, Please approve the code change for bug ''JDK-8157548: JVM crashes sometimes while starting" to jdk8u-dev Jdk8 bug: https://bugs.openjdk.java.net/browse/JDK-8157548 Review link: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-September/024555.html Webrev: http://cr.openjdk.java.net/~shshahma/8157548/webrev.00/ Regards, Shafi From anton.tarasov at jetbrains.com Thu Sep 8 16:55:46 2016 From: anton.tarasov at jetbrains.com (Anton Tarasov) Date: Thu, 8 Sep 2016 19:55:46 +0300 Subject: [8u-dev] Request for approval 8156116: [macosx] two JNI locals to delete in AWTWindow.m, CGraphicsEnv.m Message-ID: <438B2930-11C0-4845-A9B7-F6715B9B29F0@jetbrains.com> Hello, Could you please approve a direct back-port of 8156116 to 8u-dev? bug: https://bugs.openjdk.java.net/browse/JDK-8156116 webrev: http://cr.openjdk.java.net/~ant/JDK-8156116/jdk8u/webrev.0 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2016-May/011314.html jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/db28db07924c Thanks, Anton. From anton.tarasov at jetbrains.com Tue Sep 20 09:47:04 2016 From: anton.tarasov at jetbrains.com (Anton Tarasov) Date: Tue, 20 Sep 2016 12:47:04 +0300 Subject: [8u-dev] Request for approval 8156116: [macosx] two JNI locals to delete in AWTWindow.m, CGraphicsEnv.m Message-ID: Hello, Could you please approve a direct back-port of 8156116 to 8u-dev? bug: https://bugs.openjdk.java.net/browse/JDK-8156116 webrev: http://cr.openjdk.java.net/~ant/JDK-8156116/jdk8u/webrev.0 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2016-May/011314.html jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/db28db07924c Thanks, Anton. From rob.mckenna at oracle.com Tue Sep 20 11:16:19 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 20 Sep 2016 12:16:19 +0100 Subject: [8u] RFA for JDK-8157548: JVM crashes sometimes while starting In-Reply-To: References: Message-ID: <20160920111619.GA6046@vimes> Approved -Rob On 19/09/16 10:56, Shafi Ahmad wrote: > Hi, > > Please approve the code change for bug ''JDK-8157548: JVM crashes sometimes while starting" to jdk8u-dev > > Jdk8 bug: https://bugs.openjdk.java.net/browse/JDK-8157548 > Review link: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-September/024555.html > Webrev: http://cr.openjdk.java.net/~shshahma/8157548/webrev.00/ > > Regards, > Shafi From rob.mckenna at oracle.com Tue Sep 20 11:17:10 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 20 Sep 2016 12:17:10 +0100 Subject: [8u-dev] Request for approval 8156116: [macosx] two JNI locals to delete in AWTWindow.m, CGraphicsEnv.m In-Reply-To: References: Message-ID: <20160920111710.GB6046@vimes> Approved. Please add an appropriate noreg label. -Rob On 20/09/16 12:47, Anton Tarasov wrote: > Hello, > > Could you please approve a direct back-port of 8156116 to 8u-dev? > > bug: https://bugs.openjdk.java.net/browse/JDK-8156116 > > webrev: http://cr.openjdk.java.net/~ant/JDK-8156116/jdk8u/webrev.0 > > review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2016-May/011314.html > > jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/db28db07924c > > Thanks, > Anton. From anton.tarasov at jetbrains.com Tue Sep 20 12:30:04 2016 From: anton.tarasov at jetbrains.com (Anton Tarasov) Date: Tue, 20 Sep 2016 15:30:04 +0300 Subject: [8u-dev] Request for approval 8156116: [macosx] two JNI locals to delete in AWTWindow.m, CGraphicsEnv.m In-Reply-To: <20160920111710.GB6046@vimes> References: <20160920111710.GB6046@vimes> Message-ID: <0db9a13c-5cb2-7a42-3788-8cc21a8389a7@jetbrains.com> On 9/20/2016 2:17 PM, Rob McKenna wrote: > Approved. Please add an appropriate noreg label. Done, thanks. Anton. > > -Rob > > On 20/09/16 12:47, Anton Tarasov wrote: >> Hello, >> >> Could you please approve a direct back-port of 8156116 to 8u-dev? >> >> bug: https://bugs.openjdk.java.net/browse/JDK-8156116 >> >> webrev: http://cr.openjdk.java.net/~ant/JDK-8156116/jdk8u/webrev.0 >> >> review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2016-May/011314.html >> >> jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/db28db07924c >> >> Thanks, >> Anton. From rob.mckenna at oracle.com Tue Sep 20 21:04:54 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 20 Sep 2016 22:04:54 +0100 Subject: [8u-dev] Request for approval: 6947916 & 8165988 Message-ID: <20160920210454.GH6046@vimes> Hi folks, Looking to bring back these changes. Both apply cleanly with the exception of the unneeded ProblemList.txt modification in 8165988 6947916: JarURLConnection does not handle useCaches correctly 9 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e173966d872b Review: http://mail.openjdk.java.net/pipermail/net-dev/2016-September/010254.html 8165988: Test JarURLConnectionUseCaches.java fails at windows: failed to clean up files after test 9 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/109fde5b023a Review: http://mail.openjdk.java.net/pipermail/net-dev/2016-September/010280.html -Rob From sean.coffey at oracle.com Tue Sep 20 22:04:01 2016 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Tue, 20 Sep 2016 23:04:01 +0100 Subject: [8u-dev] Request for approval: 6947916 & 8165988 In-Reply-To: <20160920210454.GH6046@vimes> References: <20160920210454.GH6046@vimes> Message-ID: <8EC126B5-1412-40D1-99BB-00F50ECBF7DE@oracle.com> Approved. Regards, Sean. On 20 September 2016 22:04:54 GMT+01:00, Rob McKenna wrote: >Hi folks, > >Looking to bring back these changes. Both apply cleanly with the >exception of the unneeded ProblemList.txt modification in 8165988 > >6947916: JarURLConnection does not handle useCaches correctly >9 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e173966d872b >Review: >http://mail.openjdk.java.net/pipermail/net-dev/2016-September/010254.html > >8165988: Test JarURLConnectionUseCaches.java fails at windows: failed >to clean up files after test >9 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/109fde5b023a >Review: >http://mail.openjdk.java.net/pipermail/net-dev/2016-September/010280.html > > -Rob From shafi.s.ahmad at oracle.com Wed Sep 21 06:21:23 2016 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Tue, 20 Sep 2016 23:21:23 -0700 (PDT) Subject: [8u] RFA for JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command Message-ID: <320e48cd-cdf5-4b8a-94fd-5ac3e33dfac9@default> Hi, Please approve this backport of ' JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command' to 8u-dev. Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-6515172 Webrev: http://cr.openjdk.java.net/~shshahma/8154324/webrev.02/ Jdk8 review link: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-September/024540.html Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-January/017692.html Regards, Shafi From sean.coffey at oracle.com Wed Sep 21 08:05:25 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Wed, 21 Sep 2016 09:05:25 +0100 Subject: [8u] RFA for JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command In-Reply-To: <320e48cd-cdf5-4b8a-94fd-5ac3e33dfac9@default> References: <320e48cd-cdf5-4b8a-94fd-5ac3e33dfac9@default> Message-ID: <5d9a472d-e289-b8f7-51e2-603e7ea44db8@oracle.com> Shafi, David, Is JDK-8165153 [1] an issue for this port? I'm not sure but would like to know that it's been assessed for purpose of this backport. regards, Sean. [1] https://bugs.openjdk.java.net/browse/JDK-8165153 On 21/09/2016 07:21, Shafi Ahmad wrote: > Hi, > > Please approve this backport of ' JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command' to 8u-dev. > > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-6515172 > Webrev: http://cr.openjdk.java.net/~shshahma/8154324/webrev.02/ > Jdk8 review link: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-September/024540.html > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-January/017692.html > > Regards, > Shafi From shafi.s.ahmad at oracle.com Wed Sep 21 09:02:01 2016 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Wed, 21 Sep 2016 02:02:01 -0700 (PDT) Subject: [8u] RFA for JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command In-Reply-To: <5d9a472d-e289-b8f7-51e2-603e7ea44db8@oracle.com> References: <320e48cd-cdf5-4b8a-94fd-5ac3e33dfac9@default> <5d9a472d-e289-b8f7-51e2-603e7ea44db8@oracle.com> Message-ID: <8c95e060-f827-4ce9-b1ab-90ee6c7e8b0e@default> Hi Sean, David has already replied to the similar query raised by 'Chris Plummer' in review thread http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-September/024550.html Regards, Shafi > -----Original Message----- > From: Sean Coffey > Sent: Wednesday, September 21, 2016 1:35 PM > To: Shafi Ahmad; jdk8u-dev at openjdk.java.net; DAVID > Subject: Re: [8u] RFA for JDK-6515172: Runtime.availableProcessors() ignores > Linux taskset command > > Shafi, David, > > Is JDK-8165153 [1] an issue for this port? I'm not sure but would like to know > that it's been assessed for purpose of this backport. > > regards, > Sean. > > [1] https://bugs.openjdk.java.net/browse/JDK-8165153 > > > On 21/09/2016 07:21, Shafi Ahmad wrote: > > Hi, > > > > Please approve this backport of ' JDK-6515172: > Runtime.availableProcessors() ignores Linux taskset command' to 8u-dev. > > > > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-6515172 > > Webrev: http://cr.openjdk.java.net/~shshahma/8154324/webrev.02/ > > Jdk8 review link: > > http://mail.openjdk.java.net/pipermail/hotspot-dev/2016- > September/0245 > > 40.html > > Jdk9 review thread: > > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-Januar > > y/017692.html > > > > Regards, > > Shafi > From david.holmes at oracle.com Wed Sep 21 09:06:58 2016 From: david.holmes at oracle.com (David Holmes) Date: Wed, 21 Sep 2016 19:06:58 +1000 Subject: [8u] RFA for JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command In-Reply-To: <5d9a472d-e289-b8f7-51e2-603e7ea44db8@oracle.com> References: <320e48cd-cdf5-4b8a-94fd-5ac3e33dfac9@default> <5d9a472d-e289-b8f7-51e2-603e7ea44db8@oracle.com> Message-ID: <8435ec08-3235-4120-9ea1-df31c1a6638b@oracle.com> On 21/09/2016 6:05 PM, Sean Coffey wrote: > Shafi, David, > > Is JDK-8165153 [1] an issue for this port? I'm not sure but would like > to know that it's been assessed for purpose of this backport. Good pick up Sean! Yes that needs to be backported as well. Thanks, David > regards, > Sean. > > [1] https://bugs.openjdk.java.net/browse/JDK-8165153 > > > On 21/09/2016 07:21, Shafi Ahmad wrote: >> Hi, >> >> Please approve this backport of ' JDK-6515172: >> Runtime.availableProcessors() ignores Linux taskset command' to 8u-dev. >> >> Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-6515172 >> Webrev: http://cr.openjdk.java.net/~shshahma/8154324/webrev.02/ >> Jdk8 review link: >> http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-September/024540.html >> >> Jdk9 review thread: >> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-January/017692.html >> >> >> Regards, >> Shafi > From sean.coffey at oracle.com Wed Sep 21 09:54:45 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 21 Sep 2016 10:54:45 +0100 Subject: [8u] RFA for JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command In-Reply-To: <8c95e060-f827-4ce9-b1ab-90ee6c7e8b0e@default> References: <320e48cd-cdf5-4b8a-94fd-5ac3e33dfac9@default> <5d9a472d-e289-b8f7-51e2-603e7ea44db8@oracle.com> <8c95e060-f827-4ce9-b1ab-90ee6c7e8b0e@default> Message-ID: <57E258E5.6020707@oracle.com> Shafi, David, thanks for the extra detail. I hadn't read all review replies. OK, so looks like your 6515172 push takes care of everything for this then. Please add a comment to JDK-8165153 stating how the 6515172 8u port addresses this issue for that family release. Approved for jdk8u-dev. Regards, Sean. On 21/09/16 10:02, Shafi Ahmad wrote: > Hi Sean, > > David has already replied to the similar query raised by 'Chris Plummer' in review thread http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-September/024550.html > > Regards, > Shafi > > >> -----Original Message----- >> From: Sean Coffey >> Sent: Wednesday, September 21, 2016 1:35 PM >> To: Shafi Ahmad; jdk8u-dev at openjdk.java.net; DAVID >> Subject: Re: [8u] RFA for JDK-6515172: Runtime.availableProcessors() ignores >> Linux taskset command >> >> Shafi, David, >> >> Is JDK-8165153 [1] an issue for this port? I'm not sure but would like to know >> that it's been assessed for purpose of this backport. >> >> regards, >> Sean. >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8165153 >> >> >> On 21/09/2016 07:21, Shafi Ahmad wrote: >>> Hi, >>> >>> Please approve this backport of ' JDK-6515172: >> Runtime.availableProcessors() ignores Linux taskset command' to 8u-dev. >>> Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-6515172 >>> Webrev: http://cr.openjdk.java.net/~shshahma/8154324/webrev.02/ >>> Jdk8 review link: >>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2016- >> September/0245 >>> 40.html >>> Jdk9 review thread: >>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-Januar >>> y/017692.html >>> >>> Regards, >>> Shafi From david.holmes at oracle.com Wed Sep 21 10:14:17 2016 From: david.holmes at oracle.com (David Holmes) Date: Wed, 21 Sep 2016 20:14:17 +1000 Subject: [8u] RFA for JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command In-Reply-To: <8c95e060-f827-4ce9-b1ab-90ee6c7e8b0e@default> References: <320e48cd-cdf5-4b8a-94fd-5ac3e33dfac9@default> <5d9a472d-e289-b8f7-51e2-603e7ea44db8@oracle.com> <8c95e060-f827-4ce9-b1ab-90ee6c7e8b0e@default> Message-ID: <819789f6-1c83-0a64-1fc2-3133506885d4@oracle.com> On 21/09/2016 7:02 PM, Shafi Ahmad wrote: > Hi Sean, > > David has already replied to the similar query raised by 'Chris Plummer' in review thread http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-September/024550.html Yes and I made a big mistake, as I assumed Chris was referring to JDK-8148987. Sorry. David > Regards, > Shafi > > >> -----Original Message----- >> From: Sean Coffey >> Sent: Wednesday, September 21, 2016 1:35 PM >> To: Shafi Ahmad; jdk8u-dev at openjdk.java.net; DAVID >> Subject: Re: [8u] RFA for JDK-6515172: Runtime.availableProcessors() ignores >> Linux taskset command >> >> Shafi, David, >> >> Is JDK-8165153 [1] an issue for this port? I'm not sure but would like to know >> that it's been assessed for purpose of this backport. >> >> regards, >> Sean. >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8165153 >> >> >> On 21/09/2016 07:21, Shafi Ahmad wrote: >>> Hi, >>> >>> Please approve this backport of ' JDK-6515172: >> Runtime.availableProcessors() ignores Linux taskset command' to 8u-dev. >>> >>> Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-6515172 >>> Webrev: http://cr.openjdk.java.net/~shshahma/8154324/webrev.02/ >>> Jdk8 review link: >>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2016- >> September/0245 >>> 40.html >>> Jdk9 review thread: >>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-Januar >>> y/017692.html >>> >>> Regards, >>> Shafi >> From sean.coffey at oracle.com Wed Sep 21 10:22:30 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 21 Sep 2016 11:22:30 +0100 Subject: [8u] RFA for JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command In-Reply-To: <819789f6-1c83-0a64-1fc2-3133506885d4@oracle.com> References: <320e48cd-cdf5-4b8a-94fd-5ac3e33dfac9@default> <5d9a472d-e289-b8f7-51e2-603e7ea44db8@oracle.com> <8c95e060-f827-4ce9-b1ab-90ee6c7e8b0e@default> <819789f6-1c83-0a64-1fc2-3133506885d4@oracle.com> Message-ID: <57E25F66.9030606@oracle.com> OK - thanks for clarifying. Shafi, in that case, you'll also need to backport 8165153 with this fix. (you can document both bug fixes in your commit comment) Regards, Sean. On 21/09/16 11:14, David Holmes wrote: > On 21/09/2016 7:02 PM, Shafi Ahmad wrote: >> Hi Sean, >> >> David has already replied to the similar query raised by 'Chris >> Plummer' in review thread >> http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-September/024550.html > > Yes and I made a big mistake, as I assumed Chris was referring to > JDK-8148987. > > Sorry. > > David > >> Regards, >> Shafi >> >> >>> -----Original Message----- >>> From: Sean Coffey >>> Sent: Wednesday, September 21, 2016 1:35 PM >>> To: Shafi Ahmad; jdk8u-dev at openjdk.java.net; DAVID >>> Subject: Re: [8u] RFA for JDK-6515172: Runtime.availableProcessors() >>> ignores >>> Linux taskset command >>> >>> Shafi, David, >>> >>> Is JDK-8165153 [1] an issue for this port? I'm not sure but would >>> like to know >>> that it's been assessed for purpose of this backport. >>> >>> regards, >>> Sean. >>> >>> [1] https://bugs.openjdk.java.net/browse/JDK-8165153 >>> >>> >>> On 21/09/2016 07:21, Shafi Ahmad wrote: >>>> Hi, >>>> >>>> Please approve this backport of ' JDK-6515172: >>> Runtime.availableProcessors() ignores Linux taskset command' to 8u-dev. >>>> >>>> Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-6515172 >>>> Webrev: http://cr.openjdk.java.net/~shshahma/8154324/webrev.02/ >>>> Jdk8 review link: >>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2016- >>> September/0245 >>>> 40.html >>>> Jdk9 review thread: >>>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-Januar >>>> y/017692.html >>>> >>>> Regards, >>>> Shafi >>> From shafi.s.ahmad at oracle.com Thu Sep 22 05:06:33 2016 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Wed, 21 Sep 2016 22:06:33 -0700 (PDT) Subject: [8u] RFA for JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command and JDK-8165153: Crash in rebuild_cpu_to_node_map Message-ID: Hi, Please approve this backport of 1. JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command 2. JDK-8165153: Crash in rebuild_cpu_to_node_map to 8u-dev. I am sending single RFA because both the backport is tightly dependent. Please note that backport of JDK-8165153 is clean. JDK-6515172: Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-6515172 Webrev: http://cr.openjdk.java.net/~shshahma/8154324/webrev.02/ Jdk8 review link: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-September/024540.html Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-January/017692.html JDK-8165153: Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8165153 Jdk9 changeset: http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/0fc5c6ca654e Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-September/021025.html Regards, Shafi From sean.coffey at oracle.com Thu Sep 22 08:13:34 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Thu, 22 Sep 2016 09:13:34 +0100 Subject: [8u] RFA for JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command and JDK-8165153: Crash in rebuild_cpu_to_node_map In-Reply-To: References: Message-ID: <9ee18a05-c489-baaa-1b43-bd3d61c72295@oracle.com> Approved. regards, Sean. On 22/09/2016 06:06, Shafi Ahmad wrote: > Hi, > > Please approve this backport of > 1. JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command > 2. JDK-8165153: Crash in rebuild_cpu_to_node_map > to 8u-dev. > > I am sending single RFA because both the backport is tightly dependent. Please note that backport of JDK-8165153 is clean. > > JDK-6515172: > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-6515172 > Webrev: http://cr.openjdk.java.net/~shshahma/8154324/webrev.02/ > Jdk8 review link: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-September/024540.html > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-January/017692.html > > JDK-8165153: > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8165153 > Jdk9 changeset: http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/0fc5c6ca654e > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-September/021025.html > > Regards, > Shafi From sean.coffey at oracle.com Thu Sep 22 12:02:10 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Thu, 22 Sep 2016 13:02:10 +0100 Subject: [jdk8u-dev] Request for Review and Approval : 8139870:sun.management.LazyCompositeData.isTypeMatched() fails for composite types with items of ArrayType Message-ID: <5d1e5653-ae89-8e7f-7b8d-217f85a73e9e@oracle.com> Looking to backport this to jdk8u-dev. Bug report : https://bugs.openjdk.java.net/browse/JDK-8139870 jdk8u-dev webrev : http://cr.openjdk.java.net/~coffeys/webrev.8139870.jdk8u/webrev/ Some minor tweaks to the src code were necessary due to method access method modifier changes introduced for modules in JDK 9. (getBoolean, getLong getInt). regards, Sean. From boris.molodenkov at oracle.com Thu Sep 22 12:37:53 2016 From: boris.molodenkov at oracle.com (Boris Molodenkov) Date: Thu, 22 Sep 2016 15:37:53 +0300 Subject: [8u-dev] Request for approval: backport of JDK-8160119 Message-ID: <57E3D0A1.4070709@oracle.com> Hi, I would like to backport JDK-8160119 to 8u-dev The changeset from JDK9 is almost the same. File location and lines offset differ only. diff -r 65847ffbff14 test/testlibrary/com/oracle/java/testlibrary/Utils.java --- a/test/testlibrary/com/oracle/java/testlibrary/Utils.java Wed Sep 07 16:43:32 2016 -0400 +++ b/test/testlibrary/com/oracle/java/testlibrary/Utils.java Thu Sep 22 15:32:43 2016 +0300 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -260,8 +260,8 @@ output = ProcessTools.executeProcess(jcmdLauncher.getCommand()); output.shouldHaveExitValue(0); - // Search for a line starting with numbers (pid), follwed by the key. - Pattern pattern = Pattern.compile("([0-9]+)\\s.*(" + key + ").*\\r?\\n"); + // Search for a line starting with numbers (pid), followed by the key. + Pattern pattern = Pattern.compile("^([0-9]+)\\s.*(" + key + ")", Pattern.MULTILINE); Matcher matcher = pattern.matcher(output.getStdout()); int pid = -1; Bug id: https://bugs.openjdk.java.net/browse/JDK-8160119 Changeset: http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/9f5a448947a4 Review thread for original fix: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-July/023866.html Thanks, Boris From li.jiang at oracle.com Fri Sep 23 04:53:44 2016 From: li.jiang at oracle.com (Leo Jiang) Date: Fri, 23 Sep 2016 12:53:44 +0800 Subject: [8u] Request for review and approval 8145952 8164784 : Currency update for ISO 4217 Amendment 161 162 Message-ID: <0ee32703-d050-411b-f1ff-d5a204859d72@oracle.com> Hi, Please review and approve JDK8u bugs: https://bugs.openjdk.java.net/browse/JDK-8165240 Backport for ISO 4217 Amendment 161 https://bugs.openjdk.java.net/browse/JDK-8165241 Backport for ISO 4217 Amendment 162 JDK8u Webrev: http://cr.openjdk.java.net/~ljiang/8165240/webrev/ JPRT: http://scaaa637.us.oracle.com//archive/2016/09/2016-09-22-151236.lljiang.jdk8udev-currency162-b01 Only run on linux platform as lack of Windows platform. this is backport of https://bugs.openjdk.java.net/browse/JDK-8145952 Currency update needed for ISO 4217 Amendment #161 https://bugs.openjdk.java.net/browse/JDK-8164784 Currency update needed for ISO 4217 Amendment #162 After replace the paths in the patch, the patch for product code works well but have conflicts in the @bug line in test cases. Now I solved the conflicts and passed the JPRT build and test. Just for your reference: JDK9 Webrev: http://cr.openjdk.java.net/~ljiang/8145952/webrev.02/ JDK9 review thread: http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-August/004768.html http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-September/004784.html Thanks, Leo From li.jiang at oracle.com Fri Sep 23 06:04:16 2016 From: li.jiang at oracle.com (Leo Jiang) Date: Fri, 23 Sep 2016 14:04:16 +0800 Subject: [8u-dev] Request for approval: 8163145: Remove two "null" lines in the end of message.properties Message-ID: <1cb4f188-0817-0a77-1f33-8963b7e6ea27@oracle.com> Hi, JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8163145 webrev: http://cr.openjdk.java.net/~fyuan/leo/8163145/ review thread: http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-August/004580.html JDK9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/55f2b1691a7b This fix cleanup the two lines with text "null" in message.properties. Thanks, Leo From li.jiang at oracle.com Fri Sep 23 06:08:47 2016 From: li.jiang at oracle.com (Leo Jiang) Date: Fri, 23 Sep 2016 14:08:47 +0800 Subject: [8u-dev] Request for approval: 8159408: duplicated data in rmic's javac.properties Message-ID: Hi, JDK9 Bug: https://bugs.openjdk.java.net/browse/JDK-8159408 Webrev: http://cr.openjdk.java.net/~ljiang/8159408/webrev/ Webrev thread: http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-September/004788.html JDK9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/23f1f1cf47da This fix cleanup the duplicated entry in properties file. Thanks, Leo From ramanand.patil at oracle.com Fri Sep 23 06:59:02 2016 From: ramanand.patil at oracle.com (Ramanand Patil) Date: Thu, 22 Sep 2016 23:59:02 -0700 (PDT) Subject: [8u-dev] Request for Approval: Backport of 8155049: New tests from 8144566 fail with "No expected Server Name Indication" Message-ID: Hi, Please approve the backport of 8155049 to 8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8155049 JDK9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ee022b8f5e2d JDK9 Review Thread: http://mail.openjdk.java.net/pipermail/security-dev/2016-May/013904.html Changes apply cleanly to jdk8u-dev. Regards, Ramanand. From sean.coffey at oracle.com Fri Sep 23 07:35:06 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Fri, 23 Sep 2016 08:35:06 +0100 Subject: [8u-dev] Request for approval: backport of JDK-8160119 In-Reply-To: <57E3D0A1.4070709@oracle.com> References: <57E3D0A1.4070709@oracle.com> Message-ID: Approved. regards, Sean. On 22/09/2016 13:37, Boris Molodenkov wrote: > Hi, > > I would like to backport JDK-8160119 to 8u-dev > The changeset from JDK9 is almost the same. > File location and lines offset differ only. > > diff -r 65847ffbff14 > test/testlibrary/com/oracle/java/testlibrary/Utils.java > --- a/test/testlibrary/com/oracle/java/testlibrary/Utils.java Wed Sep > 07 16:43:32 2016 -0400 > +++ b/test/testlibrary/com/oracle/java/testlibrary/Utils.java Thu Sep > 22 15:32:43 2016 +0300 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -260,8 +260,8 @@ > output = > ProcessTools.executeProcess(jcmdLauncher.getCommand()); > output.shouldHaveExitValue(0); > > - // Search for a line starting with numbers (pid), follwed > by the key. > - Pattern pattern = Pattern.compile("([0-9]+)\\s.*(" + key > + ").*\\r?\\n"); > + // Search for a line starting with numbers (pid), > followed by the key. > + Pattern pattern = Pattern.compile("^([0-9]+)\\s.*(" + key > + ")", Pattern.MULTILINE); > Matcher matcher = pattern.matcher(output.getStdout()); > > int pid = -1; > > Bug id: https://bugs.openjdk.java.net/browse/JDK-8160119 > Changeset: http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/9f5a448947a4 > Review thread for original fix: > http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-July/023866.html > > Thanks, > Boris > From sean.coffey at oracle.com Fri Sep 23 07:38:04 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Fri, 23 Sep 2016 08:38:04 +0100 Subject: [8u] Request for review and approval 8145952 8164784 : Currency update for ISO 4217 Amendment 161 162 In-Reply-To: <0ee32703-d050-411b-f1ff-d5a204859d72@oracle.com> References: <0ee32703-d050-411b-f1ff-d5a204859d72@oracle.com> Message-ID: Looks good Leo. Reviewed. Approved for jdk8u-dev. regards, Sean. On 23/09/2016 05:53, Leo Jiang wrote: > Hi, > > Please review and approve > JDK8u bugs: > https://bugs.openjdk.java.net/browse/JDK-8165240 Backport for ISO 4217 > Amendment 161 > https://bugs.openjdk.java.net/browse/JDK-8165241 Backport for ISO 4217 > Amendment 162 > > JDK8u Webrev: > http://cr.openjdk.java.net/~ljiang/8165240/webrev/ > > JPRT: > http://scaaa637.us.oracle.com//archive/2016/09/2016-09-22-151236.lljiang.jdk8udev-currency162-b01 > > Only run on linux platform as lack of Windows platform. > > this is backport of > https://bugs.openjdk.java.net/browse/JDK-8145952 Currency update > needed for ISO 4217 Amendment #161 > https://bugs.openjdk.java.net/browse/JDK-8164784 Currency update > needed for ISO 4217 Amendment #162 > > After replace the paths in the patch, the patch for product code works > well but have conflicts in the @bug line in test cases. Now I solved > the conflicts and passed the JPRT build and test. > > > Just for your reference: > JDK9 Webrev: > http://cr.openjdk.java.net/~ljiang/8145952/webrev.02/ > > JDK9 review thread: > http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-August/004768.html > http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-September/004784.html > > > > Thanks, > Leo From sean.coffey at oracle.com Fri Sep 23 07:38:40 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Fri, 23 Sep 2016 08:38:40 +0100 Subject: [8u-dev] Request for approval: 8163145: Remove two "null" lines in the end of message.properties In-Reply-To: <1cb4f188-0817-0a77-1f33-8963b7e6ea27@oracle.com> References: <1cb4f188-0817-0a77-1f33-8963b7e6ea27@oracle.com> Message-ID: Please add a noreg label to the master bug report. Approved for jdk8u-dev. regards, Sean. On 23/09/2016 07:04, Leo Jiang wrote: > Hi, > > JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8163145 > webrev: http://cr.openjdk.java.net/~fyuan/leo/8163145/ > review thread: > http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-August/004580.html > > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/55f2b1691a7b > > This fix cleanup the two lines with text "null" in message.properties. > > Thanks, > Leo > From sean.coffey at oracle.com Fri Sep 23 07:39:45 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Fri, 23 Sep 2016 08:39:45 +0100 Subject: [8u-dev] Request for approval: 8159408: duplicated data in rmic's javac.properties In-Reply-To: References: Message-ID: <3619de32-671d-29fc-1ea8-37b104892820@oracle.com> Please add a suitable noreg label to the master bug report. Approved for jdk8u-dev. Regards, Sean. On 23/09/2016 07:08, Leo Jiang wrote: > Hi, > > JDK9 Bug: https://bugs.openjdk.java.net/browse/JDK-8159408 > Webrev: http://cr.openjdk.java.net/~ljiang/8159408/webrev/ > Webrev thread: > http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-September/004788.html > > > JDK9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/23f1f1cf47da > > This fix cleanup the duplicated entry in properties file. > > Thanks, > Leo > From sean.coffey at oracle.com Fri Sep 23 07:58:51 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Fri, 23 Sep 2016 08:58:51 +0100 Subject: [8u-dev] Request for Approval: Backport of 8155049: New tests from 8144566 fail with "No expected Server Name Indication" In-Reply-To: References: Message-ID: Ramanand, I don't see 8144566 in the jdk8u-dev forest yet. Are you planning on pushing both together ? Approved. regards, Sean. On 23/09/2016 07:59, Ramanand Patil wrote: > Hi, > Please approve the backport of 8155049 to 8u-dev. > Bug: https://bugs.openjdk.java.net/browse/JDK-8155049 > JDK9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ee022b8f5e2d > JDK9 Review Thread: http://mail.openjdk.java.net/pipermail/security-dev/2016-May/013904.html > > Changes apply cleanly to jdk8u-dev. > > Regards, > Ramanand. From li.jiang at oracle.com Fri Sep 23 08:21:06 2016 From: li.jiang at oracle.com (Leo Jiang) Date: Fri, 23 Sep 2016 16:21:06 +0800 Subject: [8u-dev] Request for approval: 8159408: duplicated data in rmic's javac.properties In-Reply-To: <3619de32-671d-29fc-1ea8-37b104892820@oracle.com> References: <3619de32-671d-29fc-1ea8-37b104892820@oracle.com> Message-ID: <1761f0c6-c219-dfa3-1eb4-510fccb6bb30@oracle.com> Thank you Sean. Had added the noreg-trivial label on the JDK9 bugs. Regards, Leo On 09/23/2016 03:39 PM, Sean Coffey wrote: > Please add a suitable noreg label to the master bug report. > > Approved for jdk8u-dev. > > Regards, > Sean. > > > On 23/09/2016 07:08, Leo Jiang wrote: >> Hi, >> >> JDK9 Bug: https://bugs.openjdk.java.net/browse/JDK-8159408 >> Webrev: http://cr.openjdk.java.net/~ljiang/8159408/webrev/ >> Webrev thread: http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-September/004788.html >> >> >> JDK9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/23f1f1cf47da >> >> This fix cleanup the duplicated entry in properties file. >> >> Thanks, >> Leo >> > From ramanand.patil at oracle.com Fri Sep 23 09:49:45 2016 From: ramanand.patil at oracle.com (Ramanand Patil) Date: Fri, 23 Sep 2016 02:49:45 -0700 (PDT) Subject: [8u-dev] Request for Approval: Backport of 8155049: New tests from 8144566 fail with "No expected Server Name Indication" In-Reply-To: References: Message-ID: <5ba7320d-fe98-44e1-a79b-ec8a7813afd6@default> Hi Sean, I am planning to push both fixes consecutively. Thank you for the approval. -----Original Message----- From: Sean Coffey Sent: Friday, September 23, 2016 1:29 PM To: Ramanand Patil ; jdk8u-dev at openjdk.java.net Subject: Re: [8u-dev] Request for Approval: Backport of 8155049: New tests from 8144566 fail with "No expected Server Name Indication" Ramanand, I don't see 8144566 in the jdk8u-dev forest yet. Are you planning on pushing both together ? Approved. regards, Sean. On 23/09/2016 07:59, Ramanand Patil wrote: > Hi, > Please approve the backport of 8155049 to 8u-dev. > Bug: https://bugs.openjdk.java.net/browse/JDK-8155049 > JDK9 Changeset: > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ee022b8f5e2d > JDK9 Review Thread: > http://mail.openjdk.java.net/pipermail/security-dev/2016-May/013904.ht > ml > > Changes apply cleanly to jdk8u-dev. > > Regards, > Ramanand. From rob.mckenna at oracle.com Fri Sep 23 14:43:28 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 23 Sep 2016 15:43:28 +0100 Subject: [8u-dev] Request for approval - 8159410: InetAddress.isReachable returns true for non existing IP addresses Message-ID: <20160923144328.GA5104@vimes> Hi folks, Looking for approval for this direct backport: https://bugs.openjdk.java.net/browse/JDK-8159410 http://mail.openjdk.java.net/pipermail/net-dev/2016-September/010310.html http://hg.openjdk.java.net/jdk9/dev/jdk/rev/11a17f2b759d -Rob From sean.coffey at oracle.com Fri Sep 23 15:30:37 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 23 Sep 2016 16:30:37 +0100 Subject: [8u-dev] Request for approval - 8159410: InetAddress.isReachable returns true for non existing IP addresses In-Reply-To: <20160923144328.GA5104@vimes> References: <20160923144328.GA5104@vimes> Message-ID: <57E54A9D.5020201@oracle.com> Approved. Regards, Sean. On 23/09/16 15:43, Rob McKenna wrote: > Hi folks, > > Looking for approval for this direct backport: > > https://bugs.openjdk.java.net/browse/JDK-8159410 > http://mail.openjdk.java.net/pipermail/net-dev/2016-September/010310.html > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/11a17f2b759d > > -Rob From mark at talios.com Mon Sep 26 02:45:25 2016 From: mark at talios.com (Mark Derricutt) Date: Mon, 26 Sep 2016 15:45:25 +1300 Subject: Regular Java Crashes under macOs Sierra Message-ID: HI all, I'm noticing a bunch of core JDK crashes using the 8u112 dev builds when running IntelliJ IDEA under the new macOs Sierra: ``` Exception Name: JavaNativeException Description: java.lang.NullPointerException at sun.lwawt.macosx.CAccessibility.getAccessibleIndexInParent(CAccessibility.java:289) User Info: (null) 0 CoreFoundation 0x00007fff819ef52b __exceptionPreprocess + 171 1 libobjc.A.dylib 0x00007fff960c7cad objc_exception_throw + 48 2 CoreFoundation 0x00007fff819ef479 -[NSException raise] + 9 3 JavaNativeFoundation 0x000000011504464d JNFCallStaticIntMethod + 236 4 libawt_lwawt.dylib 0x000000011605751a +[JavaComponentAccessibility createWithAccessible:withEnv:withView:] + 76 5 libawt_lwawt.dylib 0x0000000116057aa1 -[JavaComponentAccessibility accessibilityFocusedUIElement] + 198 6 libawt_lwawt.dylib 0x000000011602c472 -[AWTView accessibilityFocusedUIElement] + 156 7 AppKit 0x00007fff7fe35417 -[NSWindow(NSWindowAccessibility) accessibilityFocusedUIElement] + 124 8 libawt_lwawt.dylib 0x00000001160577fb +[JavaComponentAccessibility postFocusChanged:] + 96 9 Foundation 0x00007fff833b1f2a __NSThreadPerformPerform + 326 10 CoreFoundation 0x00007fff81985551 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 11 CoreFoundation 0x00007fff819666bd __CFRunLoopDoSources0 + 557 12 CoreFoundation 0x00007fff81965bb6 __CFRunLoopRun + 934 13 CoreFoundation 0x00007fff819655b4 CFRunLoopRunSpecific + 420 14 HIToolbox 0x00007fff80f06f6c RunCurrentEventLoopInMode + 240 15 HIToolbox 0x00007fff80f06da1 ReceiveNextEventCommon + 432 16 HIToolbox 0x00007fff80f06bd6 _BlockUntilNextEventMatchingListInModeWithFilter + 71 17 AppKit 0x00007fff7f5fd5f5 _DPSNextEvent + 1093 18 AppKit 0x00007fff7fd0d8eb -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1637 19 libosxapp.dylib 0x00000001160df3aa -[NSApplicationAWT nextEventMatchingMask:untilDate:inMode:dequeue:] + 124 20 AppKit 0x00007fff7f5f1fbd -[NSApplication run] + 926 21 libosxapp.dylib 0x00000001160df14d +[NSApplicationAWT runAWTLoopWithApp:] + 156 22 libawt_lwawt.dylib 0x000000011606c15f -[AWTStarter starter:] + 905 23 Foundation 0x00007fff833b1f2a __NSThreadPerformPerform + 326 24 CoreFoundation 0x00007fff81985551 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 25 CoreFoundation 0x00007fff819666bd __CFRunLoopDoSources0 + 557 26 CoreFoundation 0x00007fff81965bb6 __CFRunLoopRun + 934 27 CoreFoundation 0x00007fff819655b4 CFRunLoopRunSpecific + 420 28 idea 0x0000000108b07643 parkRunLoop + 131 29 idea 0x0000000108b074f9 main + 153 30 libdyld.dylib 0x00007fff969a5255 start + 1 ``` Is this an appropriate place to post about this? Known issue? -- Mark Derricutt http://www.theoryinpractice.net http://www.chaliceofblood.net http://plus.google.com/+MarkDerricutt http://twitter.com/talios http://facebook.com/mderricutt From dalibor.topic at oracle.com Mon Sep 26 07:02:58 2016 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Mon, 26 Sep 2016 09:02:58 +0200 Subject: Regular Java Crashes under macOs Sierra In-Reply-To: References: Message-ID: Hi Mark, Generally speaking, the best place to report issues with early access builds is bugs.java.com. More specifically, if you discover an issue with a third party provided build, please report it to the provider of the build directly, as such builds may contain additional changes. In order to find out which issues have been reported you can query JBS, for example https://bugs.openjdk.java.net/browse/JDK-8165867?jql=text%20~%20%22Macos%20Sierra%22 may be a fair start. Cheers, Dalibor topic -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment > On 26.09.2016, at 04:45, Mark Derricutt wrote: > > HI all, > > I'm noticing a bunch of core JDK crashes using the 8u112 dev builds when running IntelliJ IDEA under the new macOs Sierra: > > ``` > Exception Name: JavaNativeException > Description: java.lang.NullPointerException > at sun.lwawt.macosx.CAccessibility.getAccessibleIndexInParent(CAccessibility.java:289) > > User Info: (null) > > 0 CoreFoundation 0x00007fff819ef52b __exceptionPreprocess + 171 > 1 libobjc.A.dylib 0x00007fff960c7cad objc_exception_throw + 48 > 2 CoreFoundation 0x00007fff819ef479 -[NSException raise] + 9 > 3 JavaNativeFoundation 0x000000011504464d JNFCallStaticIntMethod + 236 > 4 libawt_lwawt.dylib 0x000000011605751a +[JavaComponentAccessibility createWithAccessible:withEnv:withView:] + 76 > 5 libawt_lwawt.dylib 0x0000000116057aa1 -[JavaComponentAccessibility accessibilityFocusedUIElement] + 198 > 6 libawt_lwawt.dylib 0x000000011602c472 -[AWTView accessibilityFocusedUIElement] + 156 > 7 AppKit 0x00007fff7fe35417 -[NSWindow(NSWindowAccessibility) accessibilityFocusedUIElement] + 124 > 8 libawt_lwawt.dylib 0x00000001160577fb +[JavaComponentAccessibility postFocusChanged:] + 96 > 9 Foundation 0x00007fff833b1f2a __NSThreadPerformPerform + 326 > 10 CoreFoundation 0x00007fff81985551 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 > 11 CoreFoundation 0x00007fff819666bd __CFRunLoopDoSources0 + 557 > 12 CoreFoundation 0x00007fff81965bb6 __CFRunLoopRun + 934 > 13 CoreFoundation 0x00007fff819655b4 CFRunLoopRunSpecific + 420 > 14 HIToolbox 0x00007fff80f06f6c RunCurrentEventLoopInMode + 240 > 15 HIToolbox 0x00007fff80f06da1 ReceiveNextEventCommon + 432 > 16 HIToolbox 0x00007fff80f06bd6 _BlockUntilNextEventMatchingListInModeWithFilter + 71 > 17 AppKit 0x00007fff7f5fd5f5 _DPSNextEvent + 1093 > 18 AppKit 0x00007fff7fd0d8eb -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1637 > 19 libosxapp.dylib 0x00000001160df3aa -[NSApplicationAWT nextEventMatchingMask:untilDate:inMode:dequeue:] + 124 > 20 AppKit 0x00007fff7f5f1fbd -[NSApplication run] + 926 > 21 libosxapp.dylib 0x00000001160df14d +[NSApplicationAWT runAWTLoopWithApp:] + 156 > 22 libawt_lwawt.dylib 0x000000011606c15f -[AWTStarter starter:] + 905 > 23 Foundation 0x00007fff833b1f2a __NSThreadPerformPerform + 326 > 24 CoreFoundation 0x00007fff81985551 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 > 25 CoreFoundation 0x00007fff819666bd __CFRunLoopDoSources0 + 557 > 26 CoreFoundation 0x00007fff81965bb6 __CFRunLoopRun + 934 > 27 CoreFoundation 0x00007fff819655b4 CFRunLoopRunSpecific + 420 > 28 idea 0x0000000108b07643 parkRunLoop + 131 > 29 idea 0x0000000108b074f9 main + 153 > 30 libdyld.dylib 0x00007fff969a5255 start + 1 > ``` > > Is this an appropriate place to post about this? Known issue? > > > -- > Mark Derricutt > http://www.theoryinpractice.net > http://www.chaliceofblood.net > http://plus.google.com/+MarkDerricutt > http://twitter.com/talios > http://facebook.com/mderricutt From mark at talios.com Mon Sep 26 09:34:35 2016 From: mark at talios.com (Mark Derricutt) Date: Mon, 26 Sep 2016 22:34:35 +1300 Subject: Regular Java Crashes under macOs Sierra In-Reply-To: References: Message-ID: <44DD5B21-14EF-43FA-9B80-5F2C99C7EED4@talios.com> On 26 Sep 2016, at 20:02, Dalibor Topic wrote: > More specifically, if you discover an issue with a third party provided build, please report it to the provider of the build directly, as such builds may contain additional changes. Will do - if the website ever emails me a password reset link :( It says it sent one, but since there's no signup form, I'm not even sure I -have- an account on that JIRA instance... This isn't a third party build no, this is official Oracle JDK 8u102, and the jdk8.dev 8u102 builds. -- Mark Derricutt http://www.theoryinpractice.net http://www.chaliceofblood.net http://plus.google.com/+MarkDerricutt http://twitter.com/talios http://facebook.com/mderricutt From dalibor.topic at oracle.com Mon Sep 26 11:22:42 2016 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Mon, 26 Sep 2016 13:22:42 +0200 Subject: Regular Java Crashes under macOs Sierra In-Reply-To: <44DD5B21-14EF-43FA-9B80-5F2C99C7EED4@talios.com> References: <44DD5B21-14EF-43FA-9B80-5F2C99C7EED4@talios.com> Message-ID: <2C3F1A61-FD20-45F1-BC1F-6FC67D48CB18@oracle.com> Hi Mark, If you are wondering about whether you ought to be able to write to JBS, then please check the OpenJDK census to see if you are listed there. If that's not the case, then you will need to use bugs.java.com to report an issue. Cheers, Dalibor -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment > On 26.09.2016, at 11:34, Mark Derricutt wrote: > >> On 26 Sep 2016, at 20:02, Dalibor Topic wrote: >> >> More specifically, if you discover an issue with a third party provided build, please report it to the provider of the build directly, as such builds may contain additional changes. > > Will do - if the website ever emails me a password reset link :( It says it sent one, but since there's no signup form, I'm not even sure I -have- an account on that JIRA instance... > > This isn't a third party build no, this is official Oracle JDK 8u102, and the jdk8.dev 8u102 builds. > > -- > Mark Derricutt > http://www.theoryinpractice.net > http://www.chaliceofblood.net > http://plus.google.com/+MarkDerricutt > http://twitter.com/talios > http://facebook.com/mderricutt From daniel.daugherty at oracle.com Mon Sep 26 14:25:39 2016 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Mon, 26 Sep 2016 08:25:39 -0600 Subject: Regular Java Crashes under macOs Sierra In-Reply-To: <44DD5B21-14EF-43FA-9B80-5F2C99C7EED4@talios.com> References: <44DD5B21-14EF-43FA-9B80-5F2C99C7EED4@talios.com> Message-ID: <9b68a60e-d7fe-5d26-0241-66fb9ccbd2b3@oracle.com> In this message: > Oracle JDK 8u102, and the jdk8.dev 8u102 builds In the original message: > using the 8u112 dev builds when running IntelliJ IDEA We have two different JDK8u version numbers here. Please include the output of 'java -version' when you file the new bug report. Dan On 9/26/16 3:34 AM, Mark Derricutt wrote: > On 26 Sep 2016, at 20:02, Dalibor Topic wrote: > >> More specifically, if you discover an issue with a third party provided build, please report it to the provider of the build directly, as such builds may contain additional changes. > Will do - if the website ever emails me a password reset link :( It says it sent one, but since there's no signup form, I'm not even sure I -have- an account on that JIRA instance... > > This isn't a third party build no, this is official Oracle JDK 8u102, and the jdk8.dev 8u102 builds. > From volker.simonis at gmail.com Mon Sep 26 15:00:20 2016 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 26 Sep 2016 17:00:20 +0200 Subject: [8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() doesn't return true on ppc In-Reply-To: References: <13e66bbd-d896-673f-23ce-ea2eef45b230@oracle.com> <962ae958-5897-6e9b-eec3-33680358ad0b@oracle.com> Message-ID: Hi, I've been a little busy with JavaOne but now I've finally pushed this change. Thanks to everybody, Volker On Thu, Sep 15, 2016 at 8:08 AM, Hiroshi H Horii wrote: > Hi Volker, and Sean, > > Thank you for your comments and suggestion. > > I and Gustavo created a webrev that includes Bits and ByteArrayAccess. > > http://cr.openjdk.java.net/~gromero/8165231/02/ > > I believe there is no other similar methods in jdk. > > Regards, > Hiroshi > ----------------------- > Hiroshi Horii, Ph.D. > IBM Research - Tokyo > > > > > From: Sean Coffey > To: Volker Simonis > Cc: "jdk8u-dev at openjdk.java.net" , Java > Core Libs , Hiroshi H Horii/Japan/IBM at IBMJP, > "ppc-aix-port-dev at openjdk.java.net" , > Gustavo Bueno Romero , "Doerr, Martin" > > Date: 09/13/2016 21:46 > Subject: Re: [8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() > doesn't return true on ppc > ________________________________ > > > > Sounds good Volker. Good catch. > > regards, > Sean. > > On 13/09/2016 13:09, Volker Simonis wrote: >> Hi Sean, >> >> thanks a lot for the fast response. I've updated the bug entry as >> requested and will push the change - maybe with the following >> potential improvement: >> >> @Hiroshi: also maybe not that performance relevant, I think we should >> we also fix sun/security/provider/ByteArrayAccess.java which contains >> the same construct: >> >> // Return whether this platform supports full speed int/long memory >> access >> // at unaligned addresses. >> // This code was copied from java.nio.Bits because there is no >> equivalent >> // public API. >> private static boolean unaligned() { >> String arch = java.security.AccessController.doPrivileged >> (new sun.security.action.GetPropertyAction("os.arch", "")); >> return arch.equals("i386") || arch.equals("x86") || >> arch.equals("amd64") >> || arch.equals("x86_64"); >> } >> >> Regards, >> Volker > > > > From peter.brunet at oracle.com Mon Sep 26 20:12:19 2016 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 26 Sep 2016 15:12:19 -0500 Subject: Regular Java Crashes under macOs Sierra In-Reply-To: References: Message-ID: <7cf9f0bd-cd05-7f68-ed99-59799849a0a7@oracle.com> Hi Mark, Is VoiceOver on when you encounter the errors? Pete p.s. Can I assume this is when running under 8u102? On 9/25/16 9:45 PM, Mark Derricutt wrote: > HI all, > > I'm noticing a bunch of core JDK crashes using the 8u112 dev builds when running IntelliJ IDEA under the new macOs Sierra: > > ``` > Exception Name: JavaNativeException > Description: java.lang.NullPointerException > at sun.lwawt.macosx.CAccessibility.getAccessibleIndexInParent(CAccessibility.java:289) > > User Info: (null) > > 0 CoreFoundation 0x00007fff819ef52b __exceptionPreprocess + 171 > 1 libobjc.A.dylib 0x00007fff960c7cad objc_exception_throw + 48 > 2 CoreFoundation 0x00007fff819ef479 -[NSException raise] + 9 > 3 JavaNativeFoundation 0x000000011504464d JNFCallStaticIntMethod + 236 > 4 libawt_lwawt.dylib 0x000000011605751a +[JavaComponentAccessibility createWithAccessible:withEnv:withView:] + 76 > 5 libawt_lwawt.dylib 0x0000000116057aa1 -[JavaComponentAccessibility accessibilityFocusedUIElement] + 198 > 6 libawt_lwawt.dylib 0x000000011602c472 -[AWTView accessibilityFocusedUIElement] + 156 > 7 AppKit 0x00007fff7fe35417 -[NSWindow(NSWindowAccessibility) accessibilityFocusedUIElement] + 124 > 8 libawt_lwawt.dylib 0x00000001160577fb +[JavaComponentAccessibility postFocusChanged:] + 96 > 9 Foundation 0x00007fff833b1f2a __NSThreadPerformPerform + 326 > 10 CoreFoundation 0x00007fff81985551 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 > 11 CoreFoundation 0x00007fff819666bd __CFRunLoopDoSources0 + 557 > 12 CoreFoundation 0x00007fff81965bb6 __CFRunLoopRun + 934 > 13 CoreFoundation 0x00007fff819655b4 CFRunLoopRunSpecific + 420 > 14 HIToolbox 0x00007fff80f06f6c RunCurrentEventLoopInMode + 240 > 15 HIToolbox 0x00007fff80f06da1 ReceiveNextEventCommon + 432 > 16 HIToolbox 0x00007fff80f06bd6 _BlockUntilNextEventMatchingListInModeWithFilter + 71 > 17 AppKit 0x00007fff7f5fd5f5 _DPSNextEvent + 1093 > 18 AppKit 0x00007fff7fd0d8eb -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1637 > 19 libosxapp.dylib 0x00000001160df3aa -[NSApplicationAWT nextEventMatchingMask:untilDate:inMode:dequeue:] + 124 > 20 AppKit 0x00007fff7f5f1fbd -[NSApplication run] + 926 > 21 libosxapp.dylib 0x00000001160df14d +[NSApplicationAWT runAWTLoopWithApp:] + 156 > 22 libawt_lwawt.dylib 0x000000011606c15f -[AWTStarter starter:] + 905 > 23 Foundation 0x00007fff833b1f2a __NSThreadPerformPerform + 326 > 24 CoreFoundation 0x00007fff81985551 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 > 25 CoreFoundation 0x00007fff819666bd __CFRunLoopDoSources0 + 557 > 26 CoreFoundation 0x00007fff81965bb6 __CFRunLoopRun + 934 > 27 CoreFoundation 0x00007fff819655b4 CFRunLoopRunSpecific + 420 > 28 idea 0x0000000108b07643 parkRunLoop + 131 > 29 idea 0x0000000108b074f9 main + 153 > 30 libdyld.dylib 0x00007fff969a5255 start + 1 > ``` > > Is this an appropriate place to post about this? Known issue? > > From mark at talios.com Mon Sep 26 21:05:07 2016 From: mark at talios.com (Mark Derricutt) Date: Tue, 27 Sep 2016 10:05:07 +1300 Subject: Regular Java Crashes under macOs Sierra In-Reply-To: <7cf9f0bd-cd05-7f68-ed99-59799849a0a7@oracle.com> References: <7cf9f0bd-cd05-7f68-ed99-59799849a0a7@oracle.com> Message-ID: <3F860747-EB17-4770-A8AE-B6AF230013E6@talios.com> On 27 Sep 2016, at 9:12, Pete Brunet wrote: > Hi Mark, Is VoiceOver on when you encounter the errors? > p.s. Can I assume this is when running under 8u102? I don't believe VoiceOver is on, I've never used that before, tho I do have several accessibility options enabled for things like Keyboard mappers. This occurs under both 8u102 and 8u112dev. Mark -- Mark Derricutt http://www.theoryinpractice.net http://www.chaliceofblood.net http://plus.google.com/+MarkDerricutt http://twitter.com/talios http://facebook.com/mderricutt From peter.brunet at oracle.com Mon Sep 26 21:11:45 2016 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 26 Sep 2016 16:11:45 -0500 Subject: Regular Java Crashes under macOs Sierra In-Reply-To: <3F860747-EB17-4770-A8AE-B6AF230013E6@talios.com> References: <7cf9f0bd-cd05-7f68-ed99-59799849a0a7@oracle.com> <3F860747-EB17-4770-A8AE-B6AF230013E6@talios.com> Message-ID: On 9/26/16 4:05 PM, Mark Derricutt wrote: > On 27 Sep 2016, at 9:12, Pete Brunet wrote: > >> Hi Mark, Is VoiceOver on when you encounter the errors? >> p.s. Can I assume this is when running under 8u102? > > I don't believe VoiceOver is on, I've never used that before, tho I do have several accessibility options enabled for > things like Keyboard mappers. Thanks Mark, I'd like to know more about the non-VO options. Anton, Do you know if those options will cause activation of the NSAccessibility interface? I assume so because that's what is happening but wanted to check to make sure that makes sense. Pete > > This occurs under both 8u102 and 8u112dev. > > Mark > From anton.tarasov at jetbrains.com Tue Sep 27 07:57:21 2016 From: anton.tarasov at jetbrains.com (Anton Tarasov) Date: Tue, 27 Sep 2016 10:57:21 +0300 Subject: Regular Java Crashes under macOs Sierra In-Reply-To: References: <7cf9f0bd-cd05-7f68-ed99-59799849a0a7@oracle.com> <3F860747-EB17-4770-A8AE-B6AF230013E6@talios.com> Message-ID: Hi Pete, Mark, The fix for the NPE has recently been posted to awt-dev mailing list, targeting JDK-8165829 (please disregard it's closed, it should be reopened). On 9/27/2016 12:11 AM, Pete Brunet wrote: > > On 9/26/16 4:05 PM, Mark Derricutt wrote: >> On 27 Sep 2016, at 9:12, Pete Brunet wrote: >> >>> Hi Mark, Is VoiceOver on when you encounter the errors? >>> p.s. Can I assume this is when running under 8u102? >> I don't believe VoiceOver is on, I've never used that before, tho I do have several accessibility options enabled for >> things like Keyboard mappers. > Thanks Mark, I'd like to know more about the non-VO options. > > Anton, Do you know if those options will cause activation of the > NSAccessibility interface? I assume so because that's what is happening > but wanted to check to make sure that makes sense. That's the question I'd like to know the answer to as well... Regards, Anton. > > Pete >> This occurs under both 8u102 and 8u112dev. >> >> Mark >> From rob.mckenna at oracle.com Tue Sep 27 11:16:14 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 27 Sep 2016 12:16:14 +0100 Subject: [jdk8u-dev] Request for approval - 8166747: Add invalid network / computer name cases to isReachable known failure switch Message-ID: <20160927111614.GB4167@tecra> Hi folks, Looking for approval for this simple, clean backport: https://bugs.openjdk.java.net/browse/JDK-8166747 http://hg.openjdk.java.net/jdk9/dev/jdk/rev/665096863382 http://mail.openjdk.java.net/pipermail/net-dev/2016-September/010325.html -Rob From sean.coffey at oracle.com Tue Sep 27 13:01:04 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Tue, 27 Sep 2016 14:01:04 +0100 Subject: [jdk8u-dev] Request for approval - 8166747: Add invalid network / computer name cases to isReachable known failure switch In-Reply-To: <20160927111614.GB4167@tecra> References: <20160927111614.GB4167@tecra> Message-ID: <5b5775be-98ed-7f5e-510a-c65406208309@oracle.com> Approved. regards, Sean. On 27/09/2016 12:16, Rob McKenna wrote: > Hi folks, > > Looking for approval for this simple, clean backport: > > https://bugs.openjdk.java.net/browse/JDK-8166747 > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/665096863382 > http://mail.openjdk.java.net/pipermail/net-dev/2016-September/010325.html > > -Rob From anton.tarasov at jetbrains.com Tue Sep 27 14:58:55 2016 From: anton.tarasov at jetbrains.com (Anton Tarasov) Date: Tue, 27 Sep 2016 17:58:55 +0300 Subject: [8u-dev] Request for approval 8165829: Android Studio 2.x crashes with NPE at sun.lwawt.macosx.CAccessibility.getAccessibleIndexInParent Message-ID: <8C73D305-CD03-4C02-835B-05CA806408BA@jetbrains.com> Hello, Could you please approve a direct back-port to 8u-dev? bug: https://bugs.openjdk.java.net/browse/JDK-8165829 webrev: http://cr.openjdk.java.net/~ant/JDK-8165829/jdk8u/webrev.0 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2016-September/012002.html jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/b997573395a0 Thanks, Anton. From rob.mckenna at oracle.com Tue Sep 27 16:19:29 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 27 Sep 2016 17:19:29 +0100 Subject: [8u-dev] Request for approval 8165829: Android Studio 2.x crashes with NPE at sun.lwawt.macosx.CAccessibility.getAccessibleIndexInParent In-Reply-To: <8C73D305-CD03-4C02-835B-05CA806408BA@jetbrains.com> References: <8C73D305-CD03-4C02-835B-05CA806408BA@jetbrains.com> Message-ID: <20160927161929.GB2652@vimes> Approved -Rob On 27/09/16 05:58, Anton Tarasov wrote: > Hello, > > Could you please approve a direct back-port to 8u-dev? > > bug: https://bugs.openjdk.java.net/browse/JDK-8165829 > > webrev: http://cr.openjdk.java.net/~ant/JDK-8165829/jdk8u/webrev.0 > > review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2016-September/012002.html > > jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/b997573395a0 > > Thanks, > Anton. From david.holmes at oracle.com Wed Sep 28 01:11:06 2016 From: david.holmes at oracle.com (David Holmes) Date: Wed, 28 Sep 2016 11:11:06 +1000 Subject: [8u] Request for approval for CR 8152000: Java FlightRecorder does not run on Java 8 compact 3 profile since u65 Message-ID: <70e1b2b1-2d31-45f2-154c-8295b78e9237@oracle.com> Bug: https://bugs.openjdk.java.net/browse/JDK-8152000 webrev: http://cr.openjdk.java.net/~dholmes/8152000/webrev/ Review-thread: http://mail.openjdk.java.net/pipermail/build-dev/2016-September/017729.html Please approve this small adjustment to compact 3 rt.jar contents. This pertains only to 8u and as per the bug report re-enables an (unsupported) configuration to continue to operate (unsupported) as it did prior to 8u65. Thanks, David From mark at talios.com Wed Sep 28 03:08:43 2016 From: mark at talios.com (Mark Derricutt) Date: Wed, 28 Sep 2016 16:08:43 +1300 Subject: Regular Java Crashes under macOs Sierra In-Reply-To: References: <7cf9f0bd-cd05-7f68-ed99-59799849a0a7@oracle.com> <3F860747-EB17-4770-A8AE-B6AF230013E6@talios.com> Message-ID: On 27 Sep 2016, at 20:57, Anton Tarasov wrote: > Hi Pete, Mark, The fix for the NPE has recently been posted to awt-dev mailing list, targeting ? JDK-8165829 ? (please disregard it's closed, it should be reopened). Excellent, I see its fixed in the Jetbrains Runtime so have switched back to that in the meantime. Cheers. -- Mark Derricutt http://www.theoryinpractice.net http://www.chaliceofblood.net http://plus.google.com/+MarkDerricutt http://twitter.com/talios http://facebook.com/mderricutt From anton.tarasov at jetbrains.com Wed Sep 28 07:41:56 2016 From: anton.tarasov at jetbrains.com (Anton Tarasov) Date: Wed, 28 Sep 2016 10:41:56 +0300 Subject: Regular Java Crashes under macOs Sierra In-Reply-To: References: <7cf9f0bd-cd05-7f68-ed99-59799849a0a7@oracle.com> <3F860747-EB17-4770-A8AE-B6AF230013E6@talios.com> Message-ID: On 9/28/2016 6:08 AM, Mark Derricutt wrote: > On 27 Sep 2016, at 20:57, Anton Tarasov wrote: > >> Hi Pete, Mark, The fix for the NPE has recently been posted to awt-dev mailing list, targeting JDK-8165829 (please disregard it's closed, it should be reopened). > Excellent, I see its fixed in the Jetbrains Runtime so have switched back to that in the meantime. Right, it's there for quite a long. Regards, Anton. > > Cheers. > > From sean.coffey at oracle.com Wed Sep 28 07:47:25 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Wed, 28 Sep 2016 08:47:25 +0100 Subject: [8u] Request for approval for CR 8152000: Java FlightRecorder does not run on Java 8 compact 3 profile since u65 In-Reply-To: <70e1b2b1-2d31-45f2-154c-8295b78e9237@oracle.com> References: <70e1b2b1-2d31-45f2-154c-8295b78e9237@oracle.com> Message-ID: <9245e90b-8808-9719-44c5-0c7a334f2d2d@oracle.com> Approved. Regards, Sean. On 28/09/2016 02:11, David Holmes wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8152000 > > webrev: http://cr.openjdk.java.net/~dholmes/8152000/webrev/ > > Review-thread: > http://mail.openjdk.java.net/pipermail/build-dev/2016-September/017729.html > > Please approve this small adjustment to compact 3 rt.jar contents. > This pertains only to 8u and as per the bug report re-enables an > (unsupported) configuration to continue to operate (unsupported) as it > did prior to 8u65. > > Thanks, > David From ivan.gerasimov at oracle.com Thu Sep 29 07:41:33 2016 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Thu, 29 Sep 2016 10:41:33 +0300 Subject: [8u-dev] Request for approval to backport: 8166840: Synthetic bridge constructor in ArrayList$Itr blocks inlining Message-ID: <5f1fc9dc-b981-dcf7-7907-173bca4b3851@oracle.com> Hello! I'd like to get an approval to backport this fix to jdk8u. The unshuffled patch applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8166840 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/73816d6b57ba Jdk9 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-September/043808.html Would you please approve? With kind regards, Ivan From rob.mckenna at oracle.com Thu Sep 29 09:43:28 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 29 Sep 2016 10:43:28 +0100 Subject: [8u-dev] Request for approval: 8141370, 8132455, 8135124, 8046768 Message-ID: <20160929094328.GA3349@vimes> Hi folks, Looking to backport these test fixes as is: 8141370: com/sun/jndi/ldap/LdapTimeoutTest.java failed intermittently http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/c7fe870b2414 http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-December/037446.html 8132455: com/sun/jndi/ldap/LdapTimeoutTest.java fails at handleNamingException http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/2a49e593ad60 http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-November/036486.html 8135124: com/sun/jndi/ldap/LdapTimeoutTest.java failed intermittently http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/0e0cb50613bb http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035407.html 8046768: com/sun/jndi/ldap/LdapTimeoutTest.java fails intermittently http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/5060d0951803 -Rob From rob.mckenna at oracle.com Thu Sep 29 09:44:21 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 29 Sep 2016 10:44:21 +0100 Subject: [8u-dev] Request for approval to backport: 8166840: Synthetic bridge constructor in ArrayList$Itr blocks inlining In-Reply-To: <5f1fc9dc-b981-dcf7-7907-173bca4b3851@oracle.com> References: <5f1fc9dc-b981-dcf7-7907-173bca4b3851@oracle.com> Message-ID: <20160929094421.GB3349@vimes> Approved -Rob On 29/09/16 10:41, Ivan Gerasimov wrote: > Hello! > > I'd like to get an approval to backport this fix to jdk8u. > The unshuffled patch applies cleanly. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8166840 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/73816d6b57ba > Jdk9 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-September/043808.html > > Would you please approve? > > With kind regards, > Ivan > From sean.coffey at oracle.com Thu Sep 29 09:47:32 2016 From: sean.coffey at oracle.com (Sean Coffey) Date: Thu, 29 Sep 2016 10:47:32 +0100 Subject: [8u-dev] Request for approval: 8141370, 8132455, 8135124, 8046768 In-Reply-To: <20160929094328.GA3349@vimes> References: <20160929094328.GA3349@vimes> Message-ID: <8d669283-5c71-5837-0d7b-2707649dda9f@oracle.com> Approved. regards, Sean. On 29/09/2016 10:43, Rob McKenna wrote: > Hi folks, > > Looking to backport these test fixes as is: > > 8141370: com/sun/jndi/ldap/LdapTimeoutTest.java failed intermittently > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/c7fe870b2414 > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-December/037446.html > > 8132455: com/sun/jndi/ldap/LdapTimeoutTest.java fails at handleNamingException > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/2a49e593ad60 > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-November/036486.html > > 8135124: com/sun/jndi/ldap/LdapTimeoutTest.java failed intermittently > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/0e0cb50613bb > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035407.html > > 8046768: com/sun/jndi/ldap/LdapTimeoutTest.java fails intermittently > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/5060d0951803 > > -Rob From ivan.gerasimov at oracle.com Fri Sep 30 17:14:16 2016 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 30 Sep 2016 20:14:16 +0300 Subject: [8u-dev] Request for approval to backport: 8153146, 8087144, 8077670 -- test fixes Message-ID: <8f42bb1a-55fb-2305-924d-84092579c50d@oracle.com> Hello! I'd like to backport these test fixes to jdk8u. The patches apply cleanly. Would you please approve? Bug: https://bugs.openjdk.java.net/browse/JDK-8077670 (sun/security/krb5/auto/MaxRetries.java may fail with BindException) Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ee8b1bc2f534 Jdk9 review: http://mail.openjdk.java.net/pipermail/security-dev/2015-August/012711.html Bug: https://bugs.openjdk.java.net/browse/JDK-8153146 (sun/security/krb5/auto/MaxRetries.java failed with timeout) Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/551f7617b2c0 Jdk9 review: http://mail.openjdk.java.net/pipermail/security-dev/2016-August/014625.html With kind regards, Ivan From rob.mckenna at oracle.com Fri Sep 30 17:25:40 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 30 Sep 2016 18:25:40 +0100 Subject: [8u-dev] Request for approval to backport: 8153146, 8087144, 8077670 -- test fixes In-Reply-To: <8f42bb1a-55fb-2305-924d-84092579c50d@oracle.com> References: <8f42bb1a-55fb-2305-924d-84092579c50d@oracle.com> Message-ID: <20160930172540.GC11587@vimes> Approved -Rob On 30/09/16 08:14, Ivan Gerasimov wrote: > Hello! > > I'd like to backport these test fixes to jdk8u. The patches apply cleanly. > > Would you please approve? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8077670 > (sun/security/krb5/auto/MaxRetries.java may fail with BindException) > Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ee8b1bc2f534 > Jdk9 review: > http://mail.openjdk.java.net/pipermail/security-dev/2015-August/012711.html > > Bug: https://bugs.openjdk.java.net/browse/JDK-8153146 > (sun/security/krb5/auto/MaxRetries.java failed with timeout) > Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/551f7617b2c0 > Jdk9 review: > http://mail.openjdk.java.net/pipermail/security-dev/2016-August/014625.html > > With kind regards, > Ivan >