[8u-dev] Request for review: JDK-8151295: runtime/ErrorHandling fails when using jtreg 4.1 b13

[Martin Buchholz]

Jonathan Gibbons will know what to do.

On Wed, Aug 31, 2016 at 8:12 AM, Alexander Vorobyev <
alexander.vorobyev at oracle.com> wrote:

> Please review this fix for JDK 8.
>
> I explained in my previous comment, why current code works in JDK 9 but
> does not work in JDK 8.
>
>
>
> On 22.04.2016 14:44, Alexander Vorobyev wrote:
>
>> JDK 9 does contain jdk.test.lib.* in hotspot/test/testlibrary so there is
>> no problem.
>> But we are talking about JDK 8 here. There is no jdk.test.lib.* in
>> hotspot/test/teslibray. Instead, it contains com.oracle.java.testlibrary.*
>> So the main point of this fix is to use libraries which are available in
>> the hotspot testsuite.
>>
>> In the future, I guess,  com.oracle.java.testlibrary.* should be renamed
>> to jdk.test.lib.* (like in JDK 9 https://bugs.openjdk.java.net/
>> browse/JDK-8067013)
>>
>> On 21.04.2016 19:14, Martin Buchholz wrote:
>>
>>> How does jdk9 work then?
>>> Answering my own question, I think it's:
>>>
>>> # Path to libraries in the topmost test directory. This is needed so
>>> @library
>>> # does not need ../../ notation to reach them
>>> external.lib.roots = ../../
>>>
>>> On Thu, Apr 21, 2016 at 6:58 AM, Alexander Vorobyev
>>> <alexander.vorobyev at oracle.com> wrote:
>>>
>>>> Hi All,
>>>>
>>>> I'd like review for JDK-8151295
>>>> (https://bugs.openjdk.java.net/browse/JDK-8151295)
>>>>
>>>> Looks like new version of jtreg by default does not allow to use
>>>> libraries
>>>> from the outside of test suite. So I guess jdk.test.lib.* in affected
>>>> tests
>>>> should be changed to com.oracle.java.testlibrary.* which is available
>>>> in the
>>>> hotspot/test testsuite. At least until it renamed to jdk.testlibrary
>>>> (like
>>>> here https://bugs.openjdk.java.net/browse/JDK-8067013).
>>>>
>>>>
>>>>
>>>> Here is webrev:
>>>> http://cr.openjdk.java.net/~avorobye/8151295/
>>>>
>>>>
>>>> Thanks,
>>>> Alexander
>>>>
>>>>
>>>>
>>>>
>>
>