Request for review and approval: 8162598: XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace

Langer, Christoph christoph.langer at sap.com
Tue Sep 6 05:51:02 UTC 2016


Thanks Joe for reviewing. Then I request approval now...

Best regards
Christoph

From: Joe Wang [mailto:huizhe.wang at oracle.com]
Sent: Dienstag, 6. September 2016 07:50
To: Langer, Christoph <christoph.langer at sap.com>
Cc: jdk8u-dev at openjdk.java.net; Daniel Fuchs <daniel.fuchs at oracle.com>
Subject: Re: Request for review and approval: 8162598: XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace

Hi Langer,

The backport looks good to me. But you'll need approval from either Sean or Rob in order to put back into JDK 8.

Best,
Joe

On 9/1/16, 3:34 AM, Langer, Christoph wrote:
Hi,

can you please approve the backport of this fix:
Bug: https://bugs.openjdk.java.net/browse/JDK-8162598
JDK9 Change: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/e66cdc2de6b0
Discussion thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-July/042635.html

The actual changes and the test have to be split between jdk and jaxp repos:
JAXP change: http://cr.openjdk.java.net/~clanger/webrevs/8162598_jaxp.8udev/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8162598_jaxp.8udev/>
Test change in jdk repo: http://cr.openjdk.java.net/~clanger/webrevs/8162598_jdk.8udev/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8162598_jdk.8udev/>

Unfortunately, the patch does not apply after unshuffling. I also had to transport some of the cleanups that were made in other changes to resolve. But now everything builds and tests run cleanly. The test had to be extracted into an own test as the test structure differs between jdk9 and 8.

@Joe: Please review the jdk8 changes in order to get approval.

Thanks & Best regards
Christoph



More information about the jdk8u-dev mailing list