[8u-dev] Request for approval for CR: 8165482: java in ldoms, with cpu-arch=generic has problems

[Kevin Walls]

Thanks Rob, Sean - and Poonam who also looked over these changes.

Thanks
Kevin


On 03/04/2017 14:17, Seán Coffey wrote:
> Looks good to me.
>
> Regards,
> Sean.
>
> On 31/03/17 18:50, Rob McKenna wrote:
>> Hi Kevin,
>>
>> These changes will need codereview.
>>
>>      -Rob
>>
>> On 31/03/17 03:32, Kevin Walls wrote:
>>> Hi,
>>>
>>> This is an approval request to backport into 8u:
>>>
>>> 8165482: java in ldoms, with cpu-arch=generic has problems
>>> 9 changeset: 
>>> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/dfff5edc66df
>>>
>>> With a few routine changes this backports OK:
>>>
>>> src/cpu/sparc/vm/vm_version_sparc.cpp: has a different initial 
>>> number of %s
>>> in a call to jio_snprintf(), so it's not automatic, but the backport 
>>> adds
>>> one %s.
>>>
>>> src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp: in 8u we 
>>> have an
>>> #ifndef PRODUCT which isn't in 9, not part of the change, but means 
>>> the diff
>>> won't apply automatically.
>>>
>>> 9 uses log(), logging in 8u uses tty->print_cr, and needs err_msg() 
>>> to form
>>> a message rather than having printf-style formatting built-in.  8u 
>>> also uses
>>> #ifndef PRODUCT also, and in some places if (PrintMiscellaneous && 
>>> Verbose)
>>>
>>> Webrev in 8u of these changes:
>>> http://cr.openjdk.java.net/~kevinw/8165482.8u/webrev.00/
>>>
>>> Thanks
>>> Kevin
>>>
>>>
>>>
>>>
>