[8u] RFR 8176329 - jdeps to detect MR jar file and output a warning

Mandy Chung mandy.chung at oracle.com
Wed Apr 26 21:56:48 UTC 2017


> On Apr 26, 2017, at 2:27 PM, Brent Christian <brent.christian at oracle.com> wrote:
> 
> Hi,
> 
> Please review the following change to 8u.
> 
> If the 8u version of jdeps encounters a Multi-Release jar, the user should be warned that the JDK 9 version of jdeps should be used instead.
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8176329
> 
> Webrev:
> http://cr.openjdk.java.net/~bchristi/8176329/webrev.04/

 303                 if ("true".equalsIgnoreCase(atts.getValue("Multi-Release"))) {
 304                     return true;
 305                 }

This can be simplified to
   return "true".equalsIgnoreCase(atts.getValue("Multi-Release”));

MRJarWarning.java test
  66         defaultAttributes.putValue("Created-By", "1.8.0-internal (Oracle Corporation)");  

I suggest to drop “(Oracle…)”

  82         // jdeps still recognizes a mult-release jar.

typo: s/mult/multi

Otherwise looks good.

Mandy


More information about the jdk8u-dev mailing list