[8u] RFA for 8185628: Backport jdk/test/lib/testlibrary/CompilerUtils.java to jdk8u which is helpful in test development

[Seán Coffey]

This would need a review given that it's a different changeset to that 
done for JDK 9. The changes look fine to me. Reviewed.

You can consider this approved for jdk8u-dev.

Regards,
Sean.

On 02/08/17 07:55, Bhanu Prakash Gopularam wrote:
> Hi Rob,
>
> The 8u changes are present in webrev link in my earlier email. I am posting it again for your convenience:
>
> http://cr.openjdk.java.net/~bgopularam/8185628/webrev.00/
>
> Please let me know if you need more information.
>
> Thank you,
> Bhanu
>
> -----Original Message-----
> From: Rob McKenna
> Sent: Tuesday, August 01, 2017 6:22 PM
> To: Bhanu Prakash Gopularam
> Cc: jdk8u-dev at openjdk.java.net
> Subject: Re: [8u] RFA for 8185628: Backport jdk/test/lib/testlibrary/CompilerUtils.java to jdk8u which is helpful in test development
>
> Do you have a codereview for the changes in 8?
>
>      -Rob
>
> On 01/08/17 03:32, Bhanu Prakash Gopularam wrote:
>> Hi all,
>>
>> May I get the approval for following utility test class backport 'JDK-8185628: Backport jdk/test/lib/testlibrary/CompilerUtils.java to jdk8u'. This class is quite useful for new test development in jdk8u.
>> Webrev link: http://cr.openjdk.java.net/~bgopularam/8185628/webrev.00/
>>
>> New changes in 8u:
>> For compiling java source file I have used ProcessTools.executeCommand(..) instead of JavaCompiler.CompilationTask as some of the related API (for example: JavaFileManager.setLocationFromPaths(..)) are not available in 8u.
>>
>> JDK-9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/b2a69d66dc65/test/lib/testlibrary/CompilerUtils.java
>> JDK-9 review thread: I could not find specific email thread in mailer as this utility class was pushed along with module implementation in JDK-9.
>>
>> Thanks,
>> Bhanu