[8u] RFA for 8185164: GetOwnedMonitorInfo() returns incorrect owned monitor

[David Buck]

Hi Yasumasa!

I have pushed your fix into 8u-dev:

http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/b55756ea22d8

Unfortunately, I forgot to use your OpenJDK ID when I pushed, so I am 
showing up as the author of the push. When you are eventually nominated 
for committer status for JDK 8 Updates, please remember to include this 
fix in the list of jdk8 fixes. I am very sorry for the mistake.

Cheers,
-Buck

On 2017/08/12 12:32, Yasumasa Suenaga wrote:
> Hi David,
> 
> 8185164 for 8u has been reviewed by Dan.
> Could you push to 8u?
> 
> 
>    JBS:
>      https://bugs.openjdk.java.net/browse/JDK-8185164
> 
>    Review thread for 8u:
>      
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-August/021683.html 
> 
> 
>    webrev for 8u:
>      http://cr.openjdk.java.net/~ysuenaga/JDK-8185164/jdk8u/webrev.00/
> 
> 
> Thanks,
> 
> Yasumasa
> 
> 
> On 2017/08/11 6:29, Daniel D. Daugherty wrote:
>> I will review it when Yasumasa posts the JDK8u webrev...
>>
>> Dan
>>
>>
>>
>> On 8/10/17 8:27 AM, David Buck wrote:
>>> Hi Dan!
>>>
>>> I that case, it sounds perfectly reasonable to me that the JDK 8 
>>> backport just drop the testcases. Unfortunately, he will still need 
>>> to get a Reviewer to sign off on the backport webrev as it is 
>>> technically no longer a "trivial" backport. Maybe you can do that for 
>>> him?
>>>
>>> Cheers,
>>> -Buck
>>>
>>> On 2017/08/10 22:54, Daniel D. Daugherty wrote:
>>>> Hi Buck!
>>>>
>>>> Serguei and I helped Yasumasa port his reproducer program into a native
>>>> JTREG test which was included in the push to JDK10/hs. I believe that
>>>> infrastructure is only available in JDK9 and JDK10. He does have a
>>>> standalone version of his reproducer.
>>>>
>>>> Dan
>>>>
>>>>
>>>> On 8/10/17 12:40 AM, David Buck wrote:
>>>>> Hi Yasumasa!
>>>>>
>>>>> You will need to provide a new webrev based on the jdk8u-dev forest 
>>>>> and get that reviewed on the relevant public alias (in this case, 
>>>>> serviceability-dev). It at all possible, test cases should be 
>>>>> modified as needed to work on JDK 8. Of course, you should also 
>>>>> build and and test the JDK 8 version of the fix before requesting a 
>>>>> review.
>>>>>
>>>>> Once the JDK 8 version of your fix passes code review, please send 
>>>>> a new request for approval [0] this alias, jdk8u-dev. (It would 
>>>>> probably be best to just reply to this thread.)
>>>>>
>>>>> Once both of the above are done correctly, I will be happy to push 
>>>>> this change for you.
>>>>>
>>>>> Cheers,
>>>>> -Buck
>>>>>
>>>>> [0] http://openjdk.java.net/projects/jdk8u/approval-template.html
>>>>>
>>>>> On 2017/08/10 15:29, Yasumasa Suenaga wrote:
>>>>>> Hi David, (CC'ed to original reviewers)
>>>>>>
>>>>>>> This doesn't look like a strictly trivial backport. Have you made 
>>>>>>> and tested
>>>>>>> a diff against the the jdk8u-dev forest [0]?
>>>>>>
>>>>>> I could not import all of the change to jdk8u/hotspot because I could
>>>>>> not apply the changes for testcase.
>>>>>> However, essence of this change is for objectMonitor.cpp. It can 
>>>>>> apply.
>>>>>>
>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8185164/webrev.05/src/share/vm/runtime/objectMonitor.cpp.udiff.html 
>>>>>>
>>>>>>
>>>>>> Cannot I request backport?
>>>>>> I use this JVMTI API and event callback in my application. So I want
>>>>>> to fix it in current Java releases.
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Yasumasa
>>>>>>
>>>>>>
>>>>>> P.S.
>>>>>>    I'm also requesting it to the IcedTea 7. It seems to be accepted.
>>>>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=3433
>>>>>>
>>>>>>
>>>>>> 2017-08-10 14:51 GMT+09:00 David Buck <david.buck at oracle.com>:
>>>>>>> Hi Yasumasa!
>>>>>>>
>>>>>>> Thank you for your submission.
>>>>>>>
>>>>>>> This doesn't look like a strictly trivial backport. Have you made 
>>>>>>> and tested
>>>>>>> a diff against the the jdk8u-dev forest [0]? Please see our 
>>>>>>> homepage [1] for
>>>>>>> details on how to work on the JDK 8 Updates Project.
>>>>>>>
>>>>>>> Cheers,
>>>>>>> -Buck
>>>>>>>
>>>>>>> [0] http://hg.openjdk.java.net/jdk8u/jdk8u-dev
>>>>>>> [1] http://openjdk.java.net/projects/jdk8u/
>>>>>>>
>>>>>>>
>>>>>>> On 2017/08/10 13:12, Yasumasa Suenaga wrote:
>>>>>>>>
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> Please approve the backport of the following fixe to JDK 8u:
>>>>>>>>
>>>>>>>> JBS:
>>>>>>>>     https://bugs.openjdk.java.net/browse/JDK-8185164
>>>>>>>>
>>>>>>>> Review thread:
>>>>>>>>
>>>>>>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-August/021591.html 
>>>>>>>>
>>>>>>>>
>>>>>>>> Webrev:
>>>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8185164/webrev.05/
>>>>>>>>
>>>>>>>>
>>>>>>>> I'm not a jdk8u committer. So I need a sponsor.
>>>>>>>>
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> Yasumasa
>>>>>>>>
>>>>>>>
>>>>>
>>>>
>>>
>>