Request for Approval: Backport of 8181419: Race in jdwp invoker handling may lead to crashes or invalid results

[Andrew Hughes]

On 9 August 2017 at 17:39, Rob McKenna <rob.mckenna at oracle.com> wrote:
> Approved
>
>     -Rob
>
> On 09/08/17 05:41, Severin Gehwolf wrote:
>> Hi,
>>
>> Please approve this backport for JDK-8181419, which is a stabilization
>> patch for JDK-8153711 a JDWP memory leak which is already in 8u152.
>>
>> I've created a JDK 9 backport tracker bug since it's too late to get it
>> included now for JDK 9:
>> https://bugs.openjdk.java.net/browse/JDK-8186031
>>
>> The patch is the same as for JDK 10 (post unshuffelling):
>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8181419/JDK-8181419.jdk8.export.patch
>>
>> Original bug, review-request and webrev:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8181419
>> Review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-June/021355.html
>> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8181419-Race-in-jdwp-invoker-handling-may-lead-to-crashes-or-invalid-results/webrev.00/webrev/
>>
>> The fix got pushed to JDK 10 and there have been no issues found so
>> far. The JDK 8 patch builds fine for me and JDI tests do not show any
>> regressions.
>>
>> Thanks,
>> Severin

Pushed: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/0a54c59b882b
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222