From sreeprakash.s at oracle.com Fri Dec 1 06:39:56 2017 From: sreeprakash.s at oracle.com (Sreeprakash Sreedharan) Date: Thu, 30 Nov 2017 22:39:56 -0800 (PST) Subject: [8u-dev] RFA for backport of JDK-8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup In-Reply-To: <20171130164233.GA3916@vimes> References: <073d946e-d46e-418b-9ddd-96190e135490@default> <79943791-6828-4661-b818-6923d12f1f81@default> <20171130164233.GA3916@vimes> Message-ID: <09a7a3ee-f1f4-4562-8aaf-ea18a4273586@default> Thank you Rob. Regards, Sreeprakash -----Original Message----- From: Rob McKenna Sent: Thursday, November 30, 2017 10:13 PM To: Sreeprakash Sreedharan Cc: jdk8u-dev at openjdk.java.net Subject: Re: [8u-dev] RFA for backport of JDK-8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup Approved -Rob On 30/11/17 04:24, Sreeprakash Sreedharan wrote: > Gentle reminder. Still waiting for backport approval. > > Regards, > Sreeprakash > > -----Original Message----- > From: Sreeprakash Sreedharan > Sent: Wednesday, November 29, 2017 4:07 PM > To: jdk8u-dev at openjdk.java.net > Subject: [8u-dev] RFA for backport of JDK-8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup > > Hi, > > > > May I get the approval for backport of 'JDK-8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup' to jdk8u-dev. > > > > Main Bug: https://bugs.openjdk.java.net/browse/JDK-8183504 > > JDK10 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2017-October/013155.html > > JDK10 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/fd3c961a89ec > > > > > > Changes were not applied cleanly and jdk8u-dev review has been done in a separate thread. > > Jdk8u webrev: http://cr.openjdk.java.net/~ssreedharan/8183504/jdk8u-dev/webrev.01/ > > Jdk8u review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2017-November/013391.html > > > > I have tested out all the relevant Swing and AWT JTREG tests. > > Also, ensured that there are no failures related to this on JPRT (both west and Stockholm) Queues. > > > > Regards, > > Sreeprakash From sreeprakash.s at oracle.com Fri Dec 1 11:10:02 2017 From: sreeprakash.s at oracle.com (Sreeprakash Sreedharan) Date: Fri, 1 Dec 2017 03:10:02 -0800 (PST) Subject: [8u-dev] RFA for backport of JDK-8176072: READING attributes are not available on TSF Message-ID: <7e056ba9-d48b-41ee-8f90-525560d5acc9@default> Hi, May I get the approval for backport of 'JDK-8176072: READING attributes are not available on TSF' to jdk8u-dev. The unshuffled patch from JDK-10 was applied cleanly. Main Bug: https://bugs.openjdk.java.net/browse/JDK-8176072 JDK10 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/9ec74010cadf JDK10 review thread : http://mail.openjdk.java.net/pipermail/swing-dev/2017-November/007994.html Ensured that there are no failures related to this on JPRT (both west and Stockholm) Queues. I have tested out all the relevant Swing and AWT JTREG tests. Regards, Sreeprakash From aleksej.efimov at oracle.com Fri Dec 1 13:22:23 2017 From: aleksej.efimov at oracle.com (Aleks Efimov) Date: Fri, 1 Dec 2017 13:22:23 +0000 Subject: Request for approval: 8186441: Change of behavior in the getMessage () method of the SOAPMessageContextImpl class Message-ID: <2530d99b-d317-dbb4-2dc4-17bb8283f43c@oracle.com> Hi, Please, approve JDK-8186441 backport to JDK8u-dev. The backport is almost identical to JDK10 fix, except the path changes and the fact that JDK8 has only one copy of SaajStaxWriter class. Code changes are identical to JDK10. Testing shows no JAX* related failures. JBS: https://bugs.openjdk.java.net/browse/JDK-8186441 JDK10 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-November/050220.html JDK10 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/b8a119027122 JDK8 changes: http://cr.openjdk.java.net/~aefimov/8186441/8/00/ Best Regards, Aleksei From rob.mckenna at oracle.com Fri Dec 1 16:06:02 2017 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 1 Dec 2017 16:06:02 +0000 Subject: [8u-dev] RFA for backport of JDK-8176072: READING attributes are not available on TSF In-Reply-To: <7e056ba9-d48b-41ee-8f90-525560d5acc9@default> References: <7e056ba9-d48b-41ee-8f90-525560d5acc9@default> Message-ID: <20171201160602.GB8302@vimes> Approved -Rob On 01/12/17 03:10, Sreeprakash Sreedharan wrote: > Hi, > > May I get the approval for backport of 'JDK-8176072: READING attributes are not available on TSF' to jdk8u-dev. > The unshuffled patch from JDK-10 was applied cleanly. > > Main Bug: https://bugs.openjdk.java.net/browse/JDK-8176072 > JDK10 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/9ec74010cadf > JDK10 review thread : http://mail.openjdk.java.net/pipermail/swing-dev/2017-November/007994.html > > Ensured that there are no failures related to this on JPRT (both west and Stockholm) Queues. > I have tested out all the relevant Swing and AWT JTREG tests. > > Regards, > Sreeprakash From rob.mckenna at oracle.com Fri Dec 1 16:14:48 2017 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 1 Dec 2017 16:14:48 +0000 Subject: Request for approval: 8186441: Change of behavior in the getMessage () method of the SOAPMessageContextImpl class In-Reply-To: <2530d99b-d317-dbb4-2dc4-17bb8283f43c@oracle.com> References: <2530d99b-d317-dbb4-2dc4-17bb8283f43c@oracle.com> Message-ID: <20171201161448.GC8302@vimes> Approved -Rob On 01/12/17 13:22, Aleks Efimov wrote: > Hi, > > Please, approve JDK-8186441 backport to JDK8u-dev. The backport is almost > identical to JDK10 fix, except the path changes and the fact that JDK8 has > only one copy of SaajStaxWriter class. Code changes are identical to JDK10. > Testing shows no JAX* related failures. > > JBS: > https://bugs.openjdk.java.net/browse/JDK-8186441 > > JDK10 review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-November/050220.html > > JDK10 changeset: > http://hg.openjdk.java.net/jdk/jdk/rev/b8a119027122 > > JDK8 changes: > http://cr.openjdk.java.net/~aefimov/8186441/8/00/ > > Best Regards, > Aleksei From aleksej.efimov at oracle.com Fri Dec 1 16:16:20 2017 From: aleksej.efimov at oracle.com (Aleks Efimov) Date: Fri, 1 Dec 2017 16:16:20 +0000 Subject: Request for approval: 8186441: Change of behavior in the getMessage () method of the SOAPMessageContextImpl class In-Reply-To: <20171201161448.GC8302@vimes> References: <2530d99b-d317-dbb4-2dc4-17bb8283f43c@oracle.com> <20171201161448.GC8302@vimes> Message-ID: Thank you Rob! Best, Aleksei On 12/01/2017 04:14 PM, Rob McKenna wrote: > Approved > > -Rob > > On 01/12/17 13:22, Aleks Efimov wrote: >> Hi, >> >> Please, approve JDK-8186441 backport to JDK8u-dev. The backport is almost >> identical to JDK10 fix, except the path changes and the fact that JDK8 has >> only one copy of SaajStaxWriter class. Code changes are identical to JDK10. >> Testing shows no JAX* related failures. >> >> JBS: >> https://bugs.openjdk.java.net/browse/JDK-8186441 >> >> JDK10 review: >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-November/050220.html >> >> JDK10 changeset: >> http://hg.openjdk.java.net/jdk/jdk/rev/b8a119027122 >> >> JDK8 changes: >> http://cr.openjdk.java.net/~aefimov/8186441/8/00/ >> >> Best Regards, >> Aleksei From srikanth.adayapalam at oracle.com Mon Dec 4 06:38:59 2017 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Mon, 4 Dec 2017 12:08:59 +0530 Subject: Request for Approval to backport fix for JDK-8144185 Message-ID: <744954d7-8254-7a5c-55c4-0c85fe460bd5@oracle.com> Hello, We have a request from ASM maintainers and also from the sustenance team to have the fix made for JDK-8144185 to 8u stream. Please approve the backport *and* also help push the fix (as I am not a 8u committer). JDK10 defect: https://bugs.openjdk.java.net/browse/JDK-8144185 JDK8 backport ticket: https://bugs.openjdk.java.net/browse/JDK-8191969 The same fix for JDK10 was applied to 8u with no additional changes. All relevant tests have been run and are all green. jdk8u webrev: http://cr.openjdk.java.net/~sadayapalam/JDK-8191969/webrev.00/ 8u specific reviewer approval here: http://mail.openjdk.java.net/pipermail/compiler-dev/2017-December/011389.html TIA, Srikanth From rob.mckenna at oracle.com Mon Dec 4 14:34:15 2017 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 4 Dec 2017 14:34:15 +0000 Subject: Request for Approval to backport fix for JDK-8144185 In-Reply-To: <744954d7-8254-7a5c-55c4-0c85fe460bd5@oracle.com> References: <744954d7-8254-7a5c-55c4-0c85fe460bd5@oracle.com> Message-ID: <20171204143415.GB3035@vimes> Approved. > Please approve the backport *and* also help push the fix While maintainers may help with pushes (time permitting) it should not be assumed. (and unfortunately I don't have the bandwidth this week) You may have better luck approaching a colleague or someone on the review thread. -Rob On 04/12/17 12:08, Srikanth wrote: > Hello, > > We have a request from ASM maintainers and also from the sustenance team to > have the fix made for JDK-8144185 to 8u stream. > > Please approve the backport *and* also help push the fix (as I am not a 8u > committer). > > JDK10 defect: https://bugs.openjdk.java.net/browse/JDK-8144185 > JDK8 backport ticket: https://bugs.openjdk.java.net/browse/JDK-8191969 > > The same fix for JDK10 was applied to 8u with no additional changes. All > relevant tests have been run and are all green. > > jdk8u webrev: > > http://cr.openjdk.java.net/~sadayapalam/JDK-8191969/webrev.00/ > > 8u specific reviewer approval here: > > http://mail.openjdk.java.net/pipermail/compiler-dev/2017-December/011389.html > > > TIA, > Srikanth > From srikanth.adayapalam at oracle.com Mon Dec 4 14:36:09 2017 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Mon, 4 Dec 2017 20:06:09 +0530 Subject: Request for Approval to backport fix for JDK-8144185 In-Reply-To: <20171204143415.GB3035@vimes> References: <744954d7-8254-7a5c-55c4-0c85fe460bd5@oracle.com> <20171204143415.GB3035@vimes> Message-ID: <1095095f-466a-d36f-8e0a-8e9fce58b016@oracle.com> Thanks! Srikanth On Monday 04 December 2017 08:04 PM, Rob McKenna wrote: > Approved. > >> Please approve the backport *and* also help push the fix > While maintainers may help with pushes (time permitting) it should not > be assumed. (and unfortunately I don't have the bandwidth this week) > > You may have better luck approaching a colleague or someone on the > review thread. > > -Rob > > On 04/12/17 12:08, Srikanth wrote: >> Hello, >> >> We have a request from ASM maintainers and also from the sustenance team to >> have the fix made for JDK-8144185 to 8u stream. >> >> Please approve the backport *and* also help push the fix (as I am not a 8u >> committer). >> >> JDK10 defect: https://bugs.openjdk.java.net/browse/JDK-8144185 >> JDK8 backport ticket: https://bugs.openjdk.java.net/browse/JDK-8191969 >> >> The same fix for JDK10 was applied to 8u with no additional changes. All >> relevant tests have been run and are all green. >> >> jdk8u webrev: >> >> http://cr.openjdk.java.net/~sadayapalam/JDK-8191969/webrev.00/ >> >> 8u specific reviewer approval here: >> >> http://mail.openjdk.java.net/pipermail/compiler-dev/2017-December/011389.html >> >> >> TIA, >> Srikanth >> From anton.litvinov at oracle.com Mon Dec 4 15:41:34 2017 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Mon, 4 Dec 2017 15:41:34 +0000 Subject: [8u-dev] Request for approval for CR 8181659: Create an alternative fix for JDK-8167102, whose fix was backed out Message-ID: Hello, I would like to request for approval to push a straight backport of the fix from JDK 10 to JDK 8. The changeset from JDK 10 applies to JDK 8 after correction of file paths. Bug: https://bugs.openjdk.java.net/browse/JDK-8181659 JDK 10 changeset: http://hg.openjdk.java.net/jdk/client/rev/baad9dc0eab1 JDK 10 review thread: Approval 1 - http://mail.openjdk.java.net/pipermail/2d-dev/2017-November/008733.html Approval 2 - http://mail.openjdk.java.net/pipermail/2d-dev/2017-December/008745.html Reviewers: prr, serb Thank you, Anton From sean.coffey at oracle.com Mon Dec 4 17:33:12 2017 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Mon, 4 Dec 2017 17:33:12 +0000 Subject: [8u-dev] Request for approval for CR 8181659: Create an alternative fix for JDK-8167102, whose fix was backed out In-Reply-To: References: Message-ID: Approved. Regards, Sean. On 04/12/17 15:41, Anton Litvinov wrote: > Hello, > > I would like to request for approval to push a straight backport of > the fix from JDK 10 to JDK 8. The changeset from JDK 10 applies to JDK > 8 after correction of file paths. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8181659 > JDK 10 changeset: http://hg.openjdk.java.net/jdk/client/rev/baad9dc0eab1 > JDK 10 review thread: > Approval 1 - > http://mail.openjdk.java.net/pipermail/2d-dev/2017-November/008733.html > Approval 2 - > http://mail.openjdk.java.net/pipermail/2d-dev/2017-December/008745.html > Reviewers: prr, serb > > Thank you, > Anton From alexey.ivanov at oracle.com Mon Dec 4 19:17:53 2017 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Mon, 4 Dec 2017 19:17:53 +0000 Subject: [8u-dev] Request for approval and review for 8179665: [Windows] java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location Message-ID: <046d8088-a070-b8e6-ce61-7eba03cec6f1@oracle.com> Hello, Could you please approve the following backport of the fix to 8u-dev? The patch from JDK9 applies cleanly except for copyright year updates; all code hunks apply cleanly. Semyon, Could you please review the changes? Webrev: http://cr.openjdk.java.net/~aivanov/8179665/jdk8/webrev.0/ JBS: https://bugs.openjdk.java.net/browse/JDK-8179665 Code review: http://mail.openjdk.java.net/pipermail/awt-dev/2017-May/012867.html JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/046ac3fa2792 Thanks, Alexey From rob.mckenna at oracle.com Mon Dec 4 21:33:45 2017 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 4 Dec 2017 21:33:45 +0000 Subject: [8u-dev] Request for approval and review for 8179665: [Windows] java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location In-Reply-To: <046d8088-a070-b8e6-ce61-7eba03cec6f1@oracle.com> References: <046d8088-a070-b8e6-ce61-7eba03cec6f1@oracle.com> Message-ID: <20171204213345.GG3035@vimes> Approved -Rob On 04/12/17 19:17, Alexey Ivanov wrote: > Hello, > > Could you please approve the following backport of the fix to 8u-dev? > > The patch from JDK9 applies cleanly except for copyright year updates; > all code hunks apply cleanly. > > Semyon, > > Could you please review the changes? > > Webrev: http://cr.openjdk.java.net/~aivanov/8179665/jdk8/webrev.0/ > JBS: https://bugs.openjdk.java.net/browse/JDK-8179665 > > Code review: > http://mail.openjdk.java.net/pipermail/awt-dev/2017-May/012867.html > > JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/046ac3fa2792 > > > Thanks, > Alexey > From rob.mckenna at oracle.com Mon Dec 4 21:34:08 2017 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 4 Dec 2017 21:34:08 +0000 Subject: [8u-dev] Request for approval and review for 8179665: [Windows] java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location In-Reply-To: <20171204213345.GG3035@vimes> References: <046d8088-a070-b8e6-ce61-7eba03cec6f1@oracle.com> <20171204213345.GG3035@vimes> Message-ID: <20171204213408.GH3035@vimes> ..pending review! -Rob On 04/12/17 21:33, Rob McKenna wrote: > Approved > > -Rob > > On 04/12/17 19:17, Alexey Ivanov wrote: > > Hello, > > > > Could you please approve the following backport of the fix to 8u-dev? > > > > The patch from JDK9 applies cleanly except for copyright year updates; > > all code hunks apply cleanly. > > > > Semyon, > > > > Could you please review the changes? > > > > Webrev: http://cr.openjdk.java.net/~aivanov/8179665/jdk8/webrev.0/ > > JBS: https://bugs.openjdk.java.net/browse/JDK-8179665 > > > > Code review: > > http://mail.openjdk.java.net/pipermail/awt-dev/2017-May/012867.html > > > > JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/046ac3fa2792 > > > > > > Thanks, > > Alexey > > From VicWang at zhaoxin.com Tue Dec 5 08:44:20 2017 From: VicWang at zhaoxin.com (Vic Wang(BJ-RD)) Date: Tue, 5 Dec 2017 08:44:20 +0000 Subject: inquiry how to submit a change Message-ID: Dear, It?s my first time to join in this community. I am from ShangHai Zhaoxin Semiconductor Co., Ltd, an X86 CPU product development company. Now I want to contribute optimized code to fit our platform, and my target project is jdk8u, should I contribute code to Project jdk10 first? In addition, how to submit a change? Should I submit it directly in the mail? Best Regards! VicWang | R&D Telephone:+86-01082695388-892477 ????? ????????????????????????????????????????????????????? CONFIDENTIAL NOTE: This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. From volker.simonis at gmail.com Tue Dec 5 09:03:40 2017 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 5 Dec 2017 10:03:40 +0100 Subject: inquiry how to submit a change In-Reply-To: References: Message-ID: Hi VicWang, [1] contains a high-level description on how to contribute to the OpenJDK. The most important points are: - you have to sign the Oracle Contribution Agreement [2] - changes usually go into the latest development repository (jdk/jdk [3] (for core libraries), jdk/client [4] (for Sound/AWT/Swing), jdk/hs [5] (for Hotspot)) - small changes can be sent directly to the corresponding mailing list - you need to find a sponsor (on the mailing list) who opens a bug in the Java Bug System and reviews/pushes your change. Regards, Volker PS: your confidentiality signature makes no sense when posting to a public mailing list [1] http://openjdk.java.net/contribute/ [2] http://www.oracle.com/technetwork/oca-405177.pdf [3] http://hg.openjdk.java.net/jdk/jdk [4] http://hg.openjdk.java.net/jdk/client [5] http://hg.openjdk.java.net/jdk/hs On Tue, Dec 5, 2017 at 9:44 AM, Vic Wang(BJ-RD) wrote: > Dear, > It?s my first time to join in this community. I am from ShangHai Zhaoxin Semiconductor Co., Ltd, an X86 CPU product development company. > Now I want to contribute optimized code to fit our platform, and my target project is jdk8u, should I contribute code to Project jdk10 first? > In addition, how to submit a change? Should I submit it directly in the mail? > > Best Regards! > VicWang | R&D > Telephone:+86-01082695388-892477 > > > ????? > ????????????????????????????????????????????????????? > CONFIDENTIAL NOTE: > This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. From semyon.sadetsky at oracle.com Tue Dec 5 20:19:53 2017 From: semyon.sadetsky at oracle.com (Semyon Sadetsky) Date: Tue, 5 Dec 2017 12:19:53 -0800 Subject: [8u-dev] Request for approval and review for 8179665: [Windows] java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location In-Reply-To: <046d8088-a070-b8e6-ce61-7eba03cec6f1@oracle.com> References: <046d8088-a070-b8e6-ce61-7eba03cec6f1@oracle.com> Message-ID: +1 --Semyon On 12/04/2017 11:17 AM, Alexey Ivanov wrote: > Hello, > > Could you please approve the following backport of the fix to 8u-dev? > > The patch from JDK9 applies cleanly except for copyright year updates; > all code hunks apply cleanly. > > Semyon, > > Could you please review the changes? > > Webrev: http://cr.openjdk.java.net/~aivanov/8179665/jdk8/webrev.0/ > JBS: https://bugs.openjdk.java.net/browse/JDK-8179665 > > Code review: > http://mail.openjdk.java.net/pipermail/awt-dev/2017-May/012867.html > > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/046ac3fa2792 > > > Thanks, > Alexey > From VicWang at zhaoxin.com Wed Dec 6 08:14:15 2017 From: VicWang at zhaoxin.com (Vic Wang(BJ-RD)) Date: Wed, 6 Dec 2017 08:14:15 +0000 Subject: =?utf-8?B?562U5aSNOiBpbnF1aXJ5IGhvdyB0byBzdWJtaXQgYSBjaGFuZ2U=?= In-Reply-To: References: Message-ID: Dear Volker? Sorry to disturb you! I have signed the OCA on benefit of my company already. When I download [1][2][3] using the command such as hg clone http://hg.openjdk.java.net/jdk/jdk jdk , it occurs the following abort. requesting all changes adding changesets transaction abort! rollback completed abort: stream ended unexpectedly (got 6 bytes, expected 80) I find it need a username which is configured in ~/.bashrc. Is the username is necessary? How to assign a username? Thanks very much. [1] http://hg.openjdk.java.net/jdk/jdk [2] http://hg.openjdk.java.net/jdk/client [3] http://hg.openjdk.java.net/jdk/hs Best Regards! VicWang | R&D Telephone:+86-01082695388-892477 -----????----- ???: Volker Simonis [mailto:volker.simonis at gmail.com] ????: 2017?12?5? 17:04 ???: Vic Wang(BJ-RD) ??: jdk8u-dev at openjdk.java.net; Se?n Coffey; dalibor topic; Cobe Chen(BJ-RD) ??: Re: inquiry how to submit a change Hi VicWang, [1] contains a high-level description on how to contribute to the OpenJDK. The most important points are: - you have to sign the Oracle Contribution Agreement [2] - changes usually go into the latest development repository (jdk/jdk [3] (for core libraries), jdk/client [4] (for Sound/AWT/Swing), jdk/hs [5] (for Hotspot)) - small changes can be sent directly to the corresponding mailing list - you need to find a sponsor (on the mailing list) who opens a bug in the Java Bug System and reviews/pushes your change. Regards, Volker PS: your confidentiality signature makes no sense when posting to a public mailing list [1] http://openjdk.java.net/contribute/ [2] http://www.oracle.com/technetwork/oca-405177.pdf [3] http://hg.openjdk.java.net/jdk/jdk [4] http://hg.openjdk.java.net/jdk/client [5] http://hg.openjdk.java.net/jdk/hs On Tue, Dec 5, 2017 at 9:44 AM, Vic Wang(BJ-RD) wrote: > Dear, > It?s my first time to join in this community. I am from ShangHai Zhaoxin Semiconductor Co., Ltd, an X86 CPU product development company. > Now I want to contribute optimized code to fit our platform, and my target project is jdk8u, should I contribute code to Project jdk10 first? > In addition, how to submit a change? Should I submit it directly in the mail? > > Best Regards! > VicWang | R&D > Telephone:+86-01082695388-892477 > > > ????? > ????????????????????????????????????????????????????? > CONFIDENTIAL NOTE: > This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. ????? ????????????????????????????????????????????????????? CONFIDENTIAL NOTE: This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. From weijun.wang at oracle.com Wed Dec 6 09:10:16 2017 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 6 Dec 2017 17:10:16 +0800 Subject: inquiry how to submit a change In-Reply-To: References: Message-ID: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> > On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) wrote: > > requesting all changes > adding changesets > transaction abort! > rollback completed > abort: stream ended unexpectedly (got 6 bytes, expected 80) Looks like a network problem, I've seen this before. Please try again. > > I find it need a username which is configured in ~/.bashrc. Is the username is necessary? How to assign a username? I don't think a username is needed to pull the repository. --Max From volker.simonis at gmail.com Wed Dec 6 09:29:38 2017 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 6 Dec 2017 01:29:38 -0800 Subject: inquiry how to submit a change In-Reply-To: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> Message-ID: On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang wrote: > > >> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) wrote: >> >> requesting all changes >> adding changesets >> transaction abort! >> rollback completed >> abort: stream ended unexpectedly (got 6 bytes, expected 80) > > Looks like a network problem, I've seen this before. Please try again. > Yes, that's usually because of slow network. You can try to add: [ui] ssh = ssh -C to your .hgrc. Somtimes it helps :) >> >> I find it need a username which is configured in ~/.bashrc. Is the username is necessary? How to assign a username? > > I don't think a username is needed to pull the repository. > > --Max > > > From alexey.ivanov at oracle.com Thu Dec 7 13:14:14 2017 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Thu, 7 Dec 2017 13:14:14 +0000 Subject: [8u-dev] Request for approval and review for 8179665: [Windows] java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location In-Reply-To: References: <046d8088-a070-b8e6-ce61-7eba03cec6f1@oracle.com> Message-ID: <892de623-4848-7e26-08c8-07ca3ec09597@oracle.com> Semyon, Rob, Thank you very much for your quick replies! Regards, Alexey On 05/12/2017 20:19, Semyon Sadetsky wrote: > +1 > > --Semyon > > > On 12/04/2017 11:17 AM, Alexey Ivanov wrote: >> Hello, >> >> Could you please approve the following backport of the fix to 8u-dev? >> >> The patch from JDK9 applies cleanly except for copyright year updates; >> all code hunks apply cleanly. >> >> Semyon, >> >> Could you please review the changes? >> >> Webrev: http://cr.openjdk.java.net/~aivanov/8179665/jdk8/webrev.0/ >> JBS: https://bugs.openjdk.java.net/browse/JDK-8179665 >> >> Code review: >> http://mail.openjdk.java.net/pipermail/awt-dev/2017-May/012867.html >> >> JDK9 changeset: >> http://hg.openjdk.java.net/jdk9/client/jdk/rev/046ac3fa2792 >> >> >> Thanks, >> Alexey >> > From muthusamy.chinnathambi at oracle.com Fri Dec 8 09:34:16 2017 From: muthusamy.chinnathambi at oracle.com (Muthusamy Chinnathambi) Date: Fri, 8 Dec 2017 01:34:16 -0800 (PST) Subject: [8u] RFA for JDK-8170395: Metaspace initialization queries the wrong chunk freelist Message-ID: Hi, May I get the approval of backport of JDK-8170395: 'Metaspace initialization queries the wrong chunk freelist' to jdk8u. JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8170395 Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-November/025345.html Jdk8 review threads: http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-November/028937.html http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-December/029518.html Webrev link: http://cr.openjdk.java.net/~mchinnathamb/8170395/webrev.02/ Regards, Muthusamy C From muthusamy.chinnathambi at oracle.com Mon Dec 11 10:09:05 2017 From: muthusamy.chinnathambi at oracle.com (Muthusamy Chinnathambi) Date: Mon, 11 Dec 2017 02:09:05 -0800 (PST) Subject: [8u] RFA for JDK-8170395: Metaspace initialization queries the wrong chunk freelist In-Reply-To: <20171211095423.GA3859@tecra> References: <20171211095423.GA3859@tecra> Message-ID: Thank you Rob. Regards, Muthusamy C -----Original Message----- From: Rob McKenna Sent: Monday, December 11, 2017 3:24 PM To: Muthusamy Chinnathambi Cc: jdk8u-dev at openjdk.java.net Subject: Re: [8u] RFA for JDK-8170395: Metaspace initialization queries the wrong chunk freelist Approved -Rob On 08/12/17 01:34, Muthusamy Chinnathambi wrote: > Hi, > > May I get the approval of backport of JDK-8170395: 'Metaspace initialization queries the wrong chunk freelist' to jdk8u. > > > JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8170395 > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-November/025345.html > Jdk8 review threads: http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-November/028937.html > http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-December/029518.html > Webrev link: http://cr.openjdk.java.net/~mchinnathamb/8170395/webrev.02/ > > Regards, > Muthusamy C From rob.mckenna at oracle.com Mon Dec 11 09:54:23 2017 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 11 Dec 2017 09:54:23 +0000 Subject: [8u] RFA for JDK-8170395: Metaspace initialization queries the wrong chunk freelist In-Reply-To: References: Message-ID: <20171211095423.GA3859@tecra> Approved -Rob On 08/12/17 01:34, Muthusamy Chinnathambi wrote: > Hi, > > May I get the approval of backport of JDK-8170395: 'Metaspace initialization queries the wrong chunk freelist' to jdk8u. > > > JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8170395 > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-November/025345.html > Jdk8 review threads: http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-November/028937.html > http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-December/029518.html > Webrev link: http://cr.openjdk.java.net/~mchinnathamb/8170395/webrev.02/ > > Regards, > Muthusamy C From ramanand.patil at oracle.com Mon Dec 11 10:45:25 2017 From: ramanand.patil at oracle.com (Ramanand Patil) Date: Mon, 11 Dec 2017 02:45:25 -0800 (PST) Subject: [8u-dev] Request for Approval: Backport of 8165466: DecimalFormat percentage format can contain unexpected % Message-ID: <38d6d420-e5fc-452e-85e7-4b7d6ea0d322@default> Hi, Please approve the backport of 8165466 to 8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8165466 JDK9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f4463c138103 JDK9 Review Thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2016-October/002143.html Changes apply cleanly to jdk8u-dev after path reshuffling. Regards, Ramanand. From david.buck at oracle.com Mon Dec 11 10:58:26 2017 From: david.buck at oracle.com (David Buck) Date: Mon, 11 Dec 2017 19:58:26 +0900 Subject: [8u-dev] Request for Approval: Backport of 8165466: DecimalFormat percentage format can contain unexpected % In-Reply-To: <38d6d420-e5fc-452e-85e7-4b7d6ea0d322@default> References: <38d6d420-e5fc-452e-85e7-4b7d6ea0d322@default> Message-ID: approved for backport to 8u-dev Cheers, -Buck On 2017/12/11 19:45, Ramanand Patil wrote: > Hi, > > Please approve the backport of 8165466 to 8u-dev. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8165466 > > JDK9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f4463c138103 > > JDK9 Review Thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2016-October/002143.html > > > > Changes apply cleanly to jdk8u-dev after path reshuffling. > > > > Regards, > > Ramanand. > > > > > From ivan.gerasimov at oracle.com Mon Dec 11 17:30:07 2017 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Mon, 11 Dec 2017 09:30:07 -0800 Subject: [8u-dev] Request to Review and for Approval to Backport : 8193156: Need to backout fixes for JDK-8058547, JDK-8055753, JDK-8085903 Message-ID: <4db02c41-81bb-30fd-cce7-a13788cf071e@oracle.com> Hello! I'm seeking an approval to backport this combined backing-out of the mentioned fixes. The anti-delta is different from what we had in JDK 10, thus a request to review. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8193156 WEBREV: http://cr.openjdk.java.net/~igerasim/8193156/01/webrev/ Thanks in advance! -- With kind regards, Ivan Gerasimov From ivan.gerasimov at oracle.com Wed Dec 13 18:02:40 2017 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 13 Dec 2017 10:02:40 -0800 Subject: [8u-dev] Request to Review and for Approval to Backport : 8193156: Need to backout fixes for JDK-8058547, JDK-8055753, JDK-8085903 In-Reply-To: <4db02c41-81bb-30fd-cce7-a13788cf071e@oracle.com> References: <4db02c41-81bb-30fd-cce7-a13788cf071e@oracle.com> Message-ID: <117d4976-28be-1089-13fe-0a295682731e@oracle.com> Ping! The patch is the anti-delta of the fixes, so we're just reverting to what we used to have prior these fixes. Would you please help review this and approve the backport? With kind regards, Ivan On 12/11/17 9:30 AM, Ivan Gerasimov wrote: > Hello! > > I'm seeking an approval to backport this combined backing-out of the > mentioned fixes. > > The anti-delta is different from what we had in JDK 10, thus a request > to review. > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8193156 > WEBREV: http://cr.openjdk.java.net/~igerasim/8193156/01/webrev/ > > Thanks in advance! > -- With kind regards, Ivan Gerasimov From sean.mullan at oracle.com Wed Dec 13 19:00:12 2017 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 13 Dec 2017 14:00:12 -0500 Subject: [8u-dev] Request to Review and for Approval to Backport : 8193156: Need to backout fixes for JDK-8058547, JDK-8055753, JDK-8085903 In-Reply-To: <117d4976-28be-1089-13fe-0a295682731e@oracle.com> References: <4db02c41-81bb-30fd-cce7-a13788cf071e@oracle.com> <117d4976-28be-1089-13fe-0a295682731e@oracle.com> Message-ID: <39debc69-6143-79fc-c176-24efed5bc3d4@oracle.com> Looks fine to me. --Sean On 12/13/17 1:02 PM, Ivan Gerasimov wrote: > Ping! > > The patch is the anti-delta of the fixes, so we're just reverting to > what we used to have prior these fixes. > > Would you please help review this and approve the backport? > > With kind regards, > > Ivan > > > On 12/11/17 9:30 AM, Ivan Gerasimov wrote: >> Hello! >> >> I'm seeking an approval to backport this combined backing-out of the >> mentioned fixes. >> >> The anti-delta is different from what we had in JDK 10, thus a request >> to review. >> >> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8193156 >> WEBREV: http://cr.openjdk.java.net/~igerasim/8193156/01/webrev/ >> >> Thanks in advance! >> > From ivan.gerasimov at oracle.com Wed Dec 13 19:02:30 2017 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 13 Dec 2017 11:02:30 -0800 Subject: [8u-dev] Request to Review and for Approval to Backport : 8193156: Need to backout fixes for JDK-8058547, JDK-8055753, JDK-8085903 In-Reply-To: <39debc69-6143-79fc-c176-24efed5bc3d4@oracle.com> References: <4db02c41-81bb-30fd-cce7-a13788cf071e@oracle.com> <117d4976-28be-1089-13fe-0a295682731e@oracle.com> <39debc69-6143-79fc-c176-24efed5bc3d4@oracle.com> Message-ID: Thank you Sean for review! On 12/13/17 11:00 AM, Sean Mullan wrote: > Looks fine to me. > > --Sean > > On 12/13/17 1:02 PM, Ivan Gerasimov wrote: >> Ping! >> >> The patch is the anti-delta of the fixes, so we're just reverting to >> what we used to have prior these fixes. >> >> Would you please help review this and approve the backport? >> >> With kind regards, >> >> Ivan >> >> >> On 12/11/17 9:30 AM, Ivan Gerasimov wrote: >>> Hello! >>> >>> I'm seeking an approval to backport this combined backing-out of the >>> mentioned fixes. >>> >>> The anti-delta is different from what we had in JDK 10, thus a >>> request to review. >>> >>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8193156 >>> WEBREV: http://cr.openjdk.java.net/~igerasim/8193156/01/webrev/ >>> >>> Thanks in advance! >>> >> > -- With kind regards, Ivan Gerasimov From rob.mckenna at oracle.com Wed Dec 13 20:27:15 2017 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 13 Dec 2017 20:27:15 +0000 Subject: [8u-dev] Request to Review and for Approval to Backport : 8193156: Need to backout fixes for JDK-8058547, JDK-8055753, JDK-8085903 In-Reply-To: References: <4db02c41-81bb-30fd-cce7-a13788cf071e@oracle.com> <117d4976-28be-1089-13fe-0a295682731e@oracle.com> <39debc69-6143-79fc-c176-24efed5bc3d4@oracle.com> Message-ID: <20171213202715.GA3405@tecra> Approved -Rob On 13/12/17 11:02, Ivan Gerasimov wrote: > Thank you Sean for review! > > > On 12/13/17 11:00 AM, Sean Mullan wrote: > >Looks fine to me. > > > >--Sean > > > >On 12/13/17 1:02 PM, Ivan Gerasimov wrote: > >>Ping! > >> > >>The patch is the anti-delta of the fixes, so we're just reverting to > >>what we used to have prior these fixes. > >> > >>Would you please help review this and approve the backport? > >> > >>With kind regards, > >> > >>Ivan > >> > >> > >>On 12/11/17 9:30 AM, Ivan Gerasimov wrote: > >>>Hello! > >>> > >>>I'm seeking an approval to backport this combined backing-out of the > >>>mentioned fixes. > >>> > >>>The anti-delta is different from what we had in JDK 10, thus a request > >>>to review. > >>> > >>>BUGURL: https://bugs.openjdk.java.net/browse/JDK-8193156 > >>>WEBREV: http://cr.openjdk.java.net/~igerasim/8193156/01/webrev/ > >>> > >>>Thanks in advance! > >>> > >> > > > > -- > With kind regards, > Ivan Gerasimov > From dalibor.topic at oracle.com Thu Dec 14 13:44:45 2017 From: dalibor.topic at oracle.com (dalibor topic) Date: Thu, 14 Dec 2017 14:44:45 +0100 Subject: Can you give a tentative date for jdk8u152 release? In-Reply-To: References: <0C593F4D11D3814E821017CC036E31CA3BA314C9@AZ-FFEXMB03.global.avaya.com> Message-ID: <74fd2d5f-9451-80ed-973a-fcf931e9a4a6@oracle.com> On 28.11.2017 22:23, Heffron, Jim wrote: > on the main site http://openjdk.java.net/projects/jdk8u/ > the JDK 8 Update Releases don?t list the [Release] indicator next to the 8u152 Timeline link. > > Also under the Source code section the latest sentence says: > > In addition, the source code for the last release, 8u102, is available by cloning the 8u master forest : http://hg.openjdk.java.net/jdk8u/jdk8u and using the 'jdk8u102-b14' mercurial tag. > > Can this be updated with the correct tag? I think it's jdk8u152-b16 but is there a final GA tag to use? Thanks for reporting these issues. I believe both have been addressed meanwhile. cheers, dalibor topic -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment From VicWang at zhaoxin.com Fri Dec 15 03:01:37 2017 From: VicWang at zhaoxin.com (Vic Wang(BJ-RD)) Date: Fri, 15 Dec 2017 03:01:37 +0000 Subject: =?utf-8?B?562U5aSNOiBpbnF1aXJ5IGhvdyB0byBzdWJtaXQgYSBjaGFuZ2U=?= In-Reply-To: References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> Message-ID: <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> Dear Volker/Weijun: Thanks for your help. I've already clone the jdk ,hs ,client repository. Now I've built jdk success by executing the following command: First, I configure JDK9 environment path, Then, bash configure make images when running basic tests by ` make run-test-tier1`, it occurs the following error: 1>. ----------configuration:(0/0)---------- ----------rerun:(4/539)*---------- cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/scratch/2 && \\ /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ -classpath \\ org.openjdk.asmtools.jasm.Main -d /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/classes/1/jdk/internal/reflect/constantPool/ConstantPoolTest.d /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTestDummy.jasm result: Error. can't find jasm test result: Error. can't find jasm 2>. can't find jcoder tools/javac/T6435291/T6435291.java: javac shouldn't throw NPE while compiling invalid RuntimeInvisibleParameterAnnotations 3>. Execution failed: `main' threw exception: java.lang.reflect.InvocationTargetException jdk/javadoc/doclet/testIOException/TestIOException.java: test IOException handling 4>.============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk:tier1 1657 1656 0 1 << >> jtreg:test/langtools:tier1 3826 3814 1 11 << jtreg:test/nashorn:tier1 0 0 0 0 jtreg:test/jaxp:tier1 0 0 0 0 ============================== TEST FAILURE ps: I've configured the jtreg[1] by seting JT_HOME and jtharness[2] by seting JTHARNESS_HOME. I've found the asm lib ,but how to configure it ? Is there any configuration or dependencies to be set? [1] https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild/artifact/ [2] https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/ Best Regards! VicWang | R&D Telephone:+86-01082695388-892477 -----????----- ???: Volker Simonis [mailto:volker.simonis at gmail.com] ????: 2017?12?6? 17:30 ???: Weijun Wang ??: Vic Wang(BJ-RD); jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) ??: Re: inquiry how to submit a change On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang wrote: > > >> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) wrote: >> >> requesting all changes >> adding changesets >> transaction abort! >> rollback completed >> abort: stream ended unexpectedly (got 6 bytes, expected 80) > > Looks like a network problem, I've seen this before. Please try again. > Yes, that's usually because of slow network. You can try to add: [ui] ssh = ssh -C to your .hgrc. Somtimes it helps :) >> >> I find it need a username which is configured in ~/.bashrc. Is the username is necessary? How to assign a username? > > I don't think a username is needed to pull the repository. > > --Max > > > ????? ????????????????????????????????????????????????????? CONFIDENTIAL NOTE: This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. From weijun.wang at oracle.com Fri Dec 15 03:42:15 2017 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 15 Dec 2017 11:42:15 +0800 Subject: inquiry how to submit a change In-Reply-To: <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> Message-ID: <79E88FFE-20EF-4799-B4E9-97D3D383C0C1@oracle.com> Hi Vic I do not run test this way (I either run a single one with jtreg directly or use our internal CI to run a tier) so I am not sure where the problem is. As for jasm, There is a asmtools.jar in jtreg/lib. Do you have it? Thanks Max > On Dec 15, 2017, at 11:01 AM, Vic Wang(BJ-RD) wrote: > > Dear Volker/Weijun: > Thanks for your help. > I've already clone the jdk ,hs ,client repository. > > Now I've built jdk success by executing the following command: > First, I configure JDK9 environment path, > Then, > bash configure > make images > > when running basic tests by ` make run-test-tier1`, it occurs the following error: > 1>. > ----------configuration:(0/0)---------- > ----------rerun:(4/539)*---------- > cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/scratch/2 && \\ > /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ > -classpath \\ > org.openjdk.asmtools.jasm.Main -d /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/classes/1/jdk/internal/reflect/constantPool/ConstantPoolTest.d /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTestDummy.jasm > result: Error. can't find jasm > test result: Error. can't find jasm > > 2>. can't find jcoder > tools/javac/T6435291/T6435291.java: javac shouldn't throw NPE while compiling invalid RuntimeInvisibleParameterAnnotations > 3>. Execution failed: `main' threw exception: java.lang.reflect.InvocationTargetException > jdk/javadoc/doclet/testIOException/TestIOException.java: test IOException handling > > 4>.============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR >>> jtreg:test/jdk:tier1 1657 1656 0 1 << >>> jtreg:test/langtools:tier1 3826 3814 1 11 << > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST FAILURE > > ps: I've configured the jtreg[1] by seting JT_HOME and jtharness[2] by seting JTHARNESS_HOME. > I've found the asm lib ,but how to configure it ? > > Is there any configuration or dependencies to be set? > > [1] https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild/artifact/ > [2] https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBuild/artifact/ > > Best Regards! > VicWang | R&D > Telephone:+86-01082695388-892477 > > > -----????----- > ???: Volker Simonis [mailto:volker.simonis at gmail.com] > ????: 2017?12?6? 17:30 > ???: Weijun Wang > ??: Vic Wang(BJ-RD); jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) > ??: Re: inquiry how to submit a change > > On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang wrote: >> >> >>> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) wrote: >>> >>> requesting all changes >>> adding changesets >>> transaction abort! >>> rollback completed >>> abort: stream ended unexpectedly (got 6 bytes, expected 80) >> >> Looks like a network problem, I've seen this before. Please try again. >> > > Yes, that's usually because of slow network. > > You can try to add: > > [ui] > ssh = ssh -C > > to your .hgrc. Somtimes it helps :) > >>> >>> I find it need a username which is configured in ~/.bashrc. Is the username is necessary? How to assign a username? >> >> I don't think a username is needed to pull the repository. >> >> --Max >> >> >> > > > ????? > ????????????????????????????????????????????????????? > CONFIDENTIAL NOTE: > This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. From VicWang at zhaoxin.com Fri Dec 15 04:34:01 2017 From: VicWang at zhaoxin.com (Vic Wang(BJ-RD)) Date: Fri, 15 Dec 2017 04:34:01 +0000 Subject: =?utf-8?B?562U5aSNOiBpbnF1aXJ5IGhvdyB0byBzdWJtaXQgYSBjaGFuZ2U=?= In-Reply-To: <79E88FFE-20EF-4799-B4E9-97D3D383C0C1@oracle.com> References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> <79E88FFE-20EF-4799-B4E9-97D3D383C0C1@oracle.com> Message-ID: Hi Weijun : There is not a asmtools.jar in jtreg/lib. How can I get it? The web < http://openjdk.java.net/code-tools/asmtools> can't access (it return `404 Not Found`). Thanks very much. Best Regards! VicWang | R&D Telephone:+86-01082695388-892477 -----????----- ???: Weijun Wang [mailto:weijun.wang at oracle.com] ????: 2017?12?15? 11:42 ???: Vic Wang(BJ-RD) ??: Volker Simonis ; jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) ??: Re: inquiry how to submit a change Hi Vic I do not run test this way (I either run a single one with jtreg directly or use our internal CI to run a tier) so I am not sure where the problem is. As for jasm, There is a asmtools.jar in jtreg/lib. Do you have it? Thanks Max > On Dec 15, 2017, at 11:01 AM, Vic Wang(BJ-RD) wrote: > > Dear Volker/Weijun: > Thanks for your help. > I've already clone the jdk ,hs ,client repository. > > Now I've built jdk success by executing the following command: > First, I configure JDK9 environment path, Then, bash configure make > images > > when running basic tests by ` make run-test-tier1`, it occurs the following error: > 1>. > ----------configuration:(0/0)---------- > ----------rerun:(4/539)*---------- > cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/scratch/2 && \\ > /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ > -classpath \\ > org.openjdk.asmtools.jasm.Main -d > /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal- > server-release/test-support/jtreg_test_jdk_tier1/classes/1/jdk/interna > l/reflect/constantPool/ConstantPoolTest.d > /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/refl > ect/constantPool/ConstantPoolTestDummy.jasm > result: Error. can't find jasm > test result: Error. can't find jasm > > 2>. can't find jcoder > tools/javac/T6435291/T6435291.java: javac shouldn't throw NPE while > compiling invalid RuntimeInvisibleParameterAnnotations > 3>. Execution failed: `main' threw exception: > 3>java.lang.reflect.InvocationTargetException > jdk/javadoc/doclet/testIOException/TestIOException.java: test > IOException handling > > 4>.============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR >>> jtreg:test/jdk:tier1 1657 1656 0 1 << >>> jtreg:test/langtools:tier1 3826 3814 1 11 << > jtreg:test/nashorn:tier1 0 0 0 0 > jtreg:test/jaxp:tier1 0 0 0 0 > ============================== > TEST FAILURE > > ps: I've configured the jtreg[1] by seting JT_HOME and jtharness[2] by seting JTHARNESS_HOME. > I've found the asm lib ,but how to configure it ? > > Is there any configuration or dependencies to be set? > > [1] > https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild/a > rtifact/ [2] > https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBui > ld/artifact/ > > Best Regards! > VicWang | R&D > Telephone:+86-01082695388-892477 > > > -----????----- > ???: Volker Simonis [mailto:volker.simonis at gmail.com] > ????: 2017?12?6? 17:30 > ???: Weijun Wang > ??: Vic Wang(BJ-RD); jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) > ??: Re: inquiry how to submit a change > > On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang wrote: >> >> >>> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) wrote: >>> >>> requesting all changes >>> adding changesets >>> transaction abort! >>> rollback completed >>> abort: stream ended unexpectedly (got 6 bytes, >>> expected 80) >> >> Looks like a network problem, I've seen this before. Please try again. >> > > Yes, that's usually because of slow network. > > You can try to add: > > [ui] > ssh = ssh -C > > to your .hgrc. Somtimes it helps :) > >>> >>> I find it need a username which is configured in ~/.bashrc. Is the username is necessary? How to assign a username? >> >> I don't think a username is needed to pull the repository. >> >> --Max >> >> >> > > > ????? > ????????????????????????????????????????????????????? > CONFIDENTIAL NOTE: > This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. ????? ????????????????????????????????????????????????????? CONFIDENTIAL NOTE: This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. From aoqi at loongson.cn Fri Dec 15 04:46:14 2017 From: aoqi at loongson.cn (Ao Qi) Date: Fri, 15 Dec 2017 12:46:14 +0800 Subject: =?UTF-8?B?UmU6IOetlOWkjTogaW5xdWlyeSBob3cgdG8gc3VibWl0IGEgY2hhbmdl?= In-Reply-To: References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> <79E88FFE-20EF-4799-B4E9-97D3D383C0C1@oracle.com> Message-ID: Hi Vic, Hoping this helps: https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK/job/asmtools/ Ao Qi 12.15 2017-12-15 12:34 GMT+08:00 Vic Wang(BJ-RD) : > Hi Weijun : > There is not a asmtools.jar in jtreg/lib. How can I get it? > The web < http://openjdk.java.net/code-tools/asmtools> can't access (it > return `404 Not Found`). > Thanks very much. > > > Best Regards! > VicWang | R&D > Telephone:+86-01082695388-892477 > > -----????----- > ???: Weijun Wang [mailto:weijun.wang at oracle.com] > ????: 2017?12?15? 11:42 > ???: Vic Wang(BJ-RD) > ??: Volker Simonis ; jdk8u-dev at openjdk.java.net; > Cobe Chen(BJ-RD) > ??: Re: inquiry how to submit a change > > Hi Vic > > I do not run test this way (I either run a single one with jtreg directly > or use our internal CI to run a tier) so I am not sure where the problem is. > > As for jasm, There is a asmtools.jar in jtreg/lib. Do you have it? > > Thanks > Max > > > On Dec 15, 2017, at 11:01 AM, Vic Wang(BJ-RD) > wrote: > > > > Dear Volker/Weijun: > > Thanks for your help. > > I've already clone the jdk ,hs ,client repository. > > > > Now I've built jdk success by executing the following command: > > First, I configure JDK9 environment path, Then, bash configure make > > images > > > > when running basic tests by ` make run-test-tier1`, it occurs the > following error: > > 1>. > > ----------configuration:(0/0)---------- > > ----------rerun:(4/539)*---------- > > cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/ > linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/scratch/2 > && \\ > > /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ > > -classpath \\ > > org.openjdk.asmtools.jasm.Main -d > > /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal- > > server-release/test-support/jtreg_test_jdk_tier1/classes/1/jdk/interna > > l/reflect/constantPool/ConstantPoolTest.d > > /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/refl > > ect/constantPool/ConstantPoolTestDummy.jasm > > result: Error. can't find jasm > > test result: Error. can't find jasm > > > > 2>. can't find jcoder > > tools/javac/T6435291/T6435291.java: javac shouldn't throw NPE while > > compiling invalid RuntimeInvisibleParameterAnnotations > > 3>. Execution failed: `main' threw exception: > > 3>java.lang.reflect.InvocationTargetException > > jdk/javadoc/doclet/testIOException/TestIOException.java: test > > IOException handling > > > > 4>.============================== > > Test summary > > ============================== > > TEST TOTAL PASS FAIL > ERROR > >>> jtreg:test/jdk:tier1 1657 1656 0 > 1 << > >>> jtreg:test/langtools:tier1 3826 3814 1 > 11 << > > jtreg:test/nashorn:tier1 0 0 0 > 0 > > jtreg:test/jaxp:tier1 0 0 0 > 0 > > ============================== > > TEST FAILURE > > > > ps: I've configured the jtreg[1] by seting JT_HOME and jtharness[2] by > seting JTHARNESS_HOME. > > I've found the asm lib ,but how to > configure it ? > > > > Is there any configuration or dependencies to be set? > > > > [1] > > https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild/a > > rtifact/ [2] > > https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBui > > ld/artifact/ > > > > Best Regards! > > VicWang | R&D > > Telephone:+86-01082695388-892477 > > > > > > -----????----- > > ???: Volker Simonis [mailto:volker.simonis at gmail.com] > > ????: 2017?12?6? 17:30 > > ???: Weijun Wang > > ??: Vic Wang(BJ-RD); jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) > > ??: Re: inquiry how to submit a change > > > > On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang > wrote: > >> > >> > >>> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) > wrote: > >>> > >>> requesting all changes > >>> adding changesets > >>> transaction abort! > >>> rollback completed > >>> abort: stream ended unexpectedly (got 6 bytes, > >>> expected 80) > >> > >> Looks like a network problem, I've seen this before. Please try again. > >> > > > > Yes, that's usually because of slow network. > > > > You can try to add: > > > > [ui] > > ssh = ssh -C > > > > to your .hgrc. Somtimes it helps :) > > > >>> > >>> I find it need a username which is configured in ~/.bashrc. Is > the username is necessary? How to assign a username? > >> > >> I don't think a username is needed to pull the repository. > >> > >> --Max > >> > >> > >> > > > > > > ????? > > ????????????????????????????????????????????????????? > > CONFIDENTIAL NOTE: > > This email contains confidential or legally privileged information and > is for the sole use of its intended recipient. Any unauthorized review, > use, copying or forwarding of this email or the content of this email is > strictly prohibited. > > > > ????? > ????????????????????????????????????????????????????? > CONFIDENTIAL NOTE: > This email contains confidential or legally privileged information and is > for the sole use of its intended recipient. Any unauthorized review, use, > copying or forwarding of this email or the content of this email is > strictly prohibited. > From david.holmes at oracle.com Fri Dec 15 07:51:57 2017 From: david.holmes at oracle.com (David Holmes) Date: Fri, 15 Dec 2017 17:51:57 +1000 Subject: =?UTF-8?Q?Re:_=e7=ad=94=e5=a4=8d:_inquiry_how_to_submit_a_change?= In-Reply-To: References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> <79E88FFE-20EF-4799-B4E9-97D3D383C0C1@oracle.com> Message-ID: See: http://hg.openjdk.java.net/code-tools/ for all projects. David On 15/12/2017 2:46 PM, Ao Qi wrote: > Hi Vic, > > Hoping this helps: > https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK/job/asmtools/ > > Ao Qi > 12.15 > > 2017-12-15 12:34 GMT+08:00 Vic Wang(BJ-RD) : > >> Hi Weijun : >> There is not a asmtools.jar in jtreg/lib. How can I get it? >> The web < http://openjdk.java.net/code-tools/asmtools> can't access (it >> return `404 Not Found`). >> Thanks very much. >> >> >> Best Regards! >> VicWang | R&D >> Telephone:+86-01082695388-892477 >> >> -----????----- >> ???: Weijun Wang [mailto:weijun.wang at oracle.com] >> ????: 2017?12?15? 11:42 >> ???: Vic Wang(BJ-RD) >> ??: Volker Simonis ; jdk8u-dev at openjdk.java.net; >> Cobe Chen(BJ-RD) >> ??: Re: inquiry how to submit a change >> >> Hi Vic >> >> I do not run test this way (I either run a single one with jtreg directly >> or use our internal CI to run a tier) so I am not sure where the problem is. >> >> As for jasm, There is a asmtools.jar in jtreg/lib. Do you have it? >> >> Thanks >> Max >> >>> On Dec 15, 2017, at 11:01 AM, Vic Wang(BJ-RD) >> wrote: >>> >>> Dear Volker/Weijun: >>> Thanks for your help. >>> I've already clone the jdk ,hs ,client repository. >>> >>> Now I've built jdk success by executing the following command: >>> First, I configure JDK9 environment path, Then, bash configure make >>> images >>> >>> when running basic tests by ` make run-test-tier1`, it occurs the >> following error: >>> 1>. >>> ----------configuration:(0/0)---------- >>> ----------rerun:(4/539)*---------- >>> cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/ >> linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/scratch/2 >> && \\ >>> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >>> -classpath \\ >>> org.openjdk.asmtools.jasm.Main -d >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal- >>> server-release/test-support/jtreg_test_jdk_tier1/classes/1/jdk/interna >>> l/reflect/constantPool/ConstantPoolTest.d >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/refl >>> ect/constantPool/ConstantPoolTestDummy.jasm >>> result: Error. can't find jasm >>> test result: Error. can't find jasm >>> >>> 2>. can't find jcoder >>> tools/javac/T6435291/T6435291.java: javac shouldn't throw NPE while >>> compiling invalid RuntimeInvisibleParameterAnnotations >>> 3>. Execution failed: `main' threw exception: >>> 3>java.lang.reflect.InvocationTargetException >>> jdk/javadoc/doclet/testIOException/TestIOException.java: test >>> IOException handling >>> >>> 4>.============================== >>> Test summary >>> ============================== >>> TEST TOTAL PASS FAIL >> ERROR >>>>> jtreg:test/jdk:tier1 1657 1656 0 >> 1 << >>>>> jtreg:test/langtools:tier1 3826 3814 1 >> 11 << >>> jtreg:test/nashorn:tier1 0 0 0 >> 0 >>> jtreg:test/jaxp:tier1 0 0 0 >> 0 >>> ============================== >>> TEST FAILURE >>> >>> ps: I've configured the jtreg[1] by seting JT_HOME and jtharness[2] by >> seting JTHARNESS_HOME. >>> I've found the asm lib ,but how to >> configure it ? >>> >>> Is there any configuration or dependencies to be set? >>> >>> [1] >>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild/a >>> rtifact/ [2] >>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulBui >>> ld/artifact/ >>> >>> Best Regards! >>> VicWang | R&D >>> Telephone:+86-01082695388-892477 >>> >>> >>> -----????----- >>> ???: Volker Simonis [mailto:volker.simonis at gmail.com] >>> ????: 2017?12?6? 17:30 >>> ???: Weijun Wang >>> ??: Vic Wang(BJ-RD); jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>> ??: Re: inquiry how to submit a change >>> >>> On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang >> wrote: >>>> >>>> >>>>> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) >> wrote: >>>>> >>>>> requesting all changes >>>>> adding changesets >>>>> transaction abort! >>>>> rollback completed >>>>> abort: stream ended unexpectedly (got 6 bytes, >>>>> expected 80) >>>> >>>> Looks like a network problem, I've seen this before. Please try again. >>>> >>> >>> Yes, that's usually because of slow network. >>> >>> You can try to add: >>> >>> [ui] >>> ssh = ssh -C >>> >>> to your .hgrc. Somtimes it helps :) >>> >>>>> >>>>> I find it need a username which is configured in ~/.bashrc. Is >> the username is necessary? How to assign a username? >>>> >>>> I don't think a username is needed to pull the repository. >>>> >>>> --Max >>>> >>>> >>>> >>> >>> >>> ????? >>> ????????????????????????????????????????????????????? >>> CONFIDENTIAL NOTE: >>> This email contains confidential or legally privileged information and >> is for the sole use of its intended recipient. Any unauthorized review, >> use, copying or forwarding of this email or the content of this email is >> strictly prohibited. >> >> >> >> ????? >> ????????????????????????????????????????????????????? >> CONFIDENTIAL NOTE: >> This email contains confidential or legally privileged information and is >> for the sole use of its intended recipient. Any unauthorized review, use, >> copying or forwarding of this email or the content of this email is >> strictly prohibited. >> From ivan.gerasimov at oracle.com Mon Dec 18 20:45:30 2017 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Mon, 18 Dec 2017 12:45:30 -0800 Subject: [8u-dev] Request for Approval to Backport 8187985 : Broken certificate number in debug output Message-ID: <9b977492-7aae-8591-304a-d51698ec84e0@oracle.com> Hello! I'd like to backport this fix to JDK 8u-dev. The unshuffled patch applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8187985 JDK 10 change: http://hg.openjdk.java.net/jdk/jdk/rev/b1993e334da1 JDK 10 review: http://mail.openjdk.java.net/pipermail/security-dev/2017-December/016575.html Thanks in advance! -- With kind regards, Ivan Gerasimov From rob.mckenna at oracle.com Mon Dec 18 22:18:37 2017 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 18 Dec 2017 22:18:37 +0000 Subject: [8u-dev] Request for Approval to Backport 8187985 : Broken certificate number in debug output In-Reply-To: <9b977492-7aae-8591-304a-d51698ec84e0@oracle.com> References: <9b977492-7aae-8591-304a-d51698ec84e0@oracle.com> Message-ID: <20171218221837.GF3312@vimes> Approved -Rob On 18/12/17 12:45, Ivan Gerasimov wrote: > Hello! > > I'd like to backport this fix to JDK 8u-dev. > > The unshuffled patch applies cleanly. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8187985 > > JDK 10 change: http://hg.openjdk.java.net/jdk/jdk/rev/b1993e334da1 > > JDK 10 review: > http://mail.openjdk.java.net/pipermail/security-dev/2017-December/016575.html > > Thanks in advance! > > -- > With kind regards, > Ivan Gerasimov > From david.buck at oracle.com Tue Dec 19 00:31:04 2017 From: david.buck at oracle.com (David Buck) Date: Tue, 19 Dec 2017 09:31:04 +0900 Subject: [8u-dev] RFA: 8059036: Implement Diagnostic Commands for heap and finalizerinfo Message-ID: Hi! Please approve this serviceability backport to 8u-dev: bug report: https://bugs.openjdk.java.net/browse/JDK-8059036 JDK 9 changesets: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/56a527afc34a http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/9b17d0a2720f JDK 9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033169.html http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-June/033835.html JDK 8 backport review thread: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2017-December/021035.html JDK 8 backport webrevs (already reviewed): http://cr.openjdk.java.net/~dbuck/8059036.0_jdk8/ Cheers, -Buck From rob.mckenna at oracle.com Tue Dec 19 01:38:01 2017 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 19 Dec 2017 01:38:01 +0000 Subject: [8u-dev] RFA: 8059036: Implement Diagnostic Commands for heap and finalizerinfo In-Reply-To: References: Message-ID: <20171219013801.GA3296@vimes> Approved -Rob On 19/12/17 09:31, David Buck wrote: > Hi! > > Please approve this serviceability backport to 8u-dev: > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8059036 > > JDK 9 changesets: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/56a527afc34a > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/9b17d0a2720f > > JDK 9 review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033169.html > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-June/033835.html > > JDK 8 backport review thread: > http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2017-December/021035.html > > JDK 8 backport webrevs (already reviewed): > http://cr.openjdk.java.net/~dbuck/8059036.0_jdk8/ > > Cheers, > -Buck From VicWang at zhaoxin.com Tue Dec 19 11:08:34 2017 From: VicWang at zhaoxin.com (Vic Wang(BJ-RD)) Date: Tue, 19 Dec 2017 11:08:34 +0000 Subject: =?utf-8?B?562U5aSNOiDnrZTlpI06IGlucXVpcnkgaG93IHRvIHN1Ym1pdCBhIGNoYW5n?= =?utf-8?Q?e?= In-Reply-To: References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> <79E88FFE-20EF-4799-B4E9-97D3D383C0C1@oracle.com> Message-ID: Hi David, Ao Qi & Weijun: I've downloaded the asmtools.jar and put it in jtreg/lib dir. And set the following environment variables. export JT_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg export JTHARNESS_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtharness export ASMTOOLSHOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/asmtools-6.0/lib however, when running the test command, it still occurred "can't find jasm" error. The test command is : make run-test TEST="jtreg:test/jdk:tier1". Additional, as I want to submit a change for jdk repository, should I pass the basic run test firstly ? The following is the detailed results for the error. Thanks very much. <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< #-----testresult----- description=file\:/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTest.java elapsed=1333 0\:00\:01.333 end=Tue Dec 19 17\:57\:20 CST 2017 environment=regtest execStatus=Error. can't find jasm harnessLoaderMode=Classpath Loader harnessVariety=Full Bundle hostname=vic-os javatestOS=Linux 3.16.4 (amd64) javatestVersion=5.0 jtregVersion=jtreg 4.2 dev b09 modules=java.base/jdk.internal.misc java.base/jdk.internal.reflect script=com.sun.javatest.regtest.exec.RegressionScript sections=script_messages compile start=Tue Dec 19 17\:57\:18 CST 2017 test=jdk/internal/reflect/constantPool/ConstantPoolTest.java testJDK=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/images/jdk totalTime=1370 user.name=root work=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/jdk/internal/reflect/constantPool #section:script_messages ----------messages:(7/577)---------- JDK under test: /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/images/jdk openjdk version "10-internal" OpenJDK Runtime Environment (build 10-internal+0-adhoc.root.jdk) OpenJDK 64-Bit Server VM (build 10-internal+0-adhoc.root.jdk, mixed mode) Library /lib/testlibrary; kind: packages source directory: /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/lib/testlibrary class directory: /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/classes/2/lib/testlibrary #section:compile ----------messages:(3/232)---------- command: compile /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTestDummy.jasm reason: User specified action: run compile ConstantPoolTestDummy.jasm elapsed time (seconds): 1.097 ----------configuration:(0/0)---------- ----------rerun:(4/607)*---------- cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/scratch/0 && \\ /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ -classpath /home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg/lib/asmtools.jar \\ org.openjdk.asmtools.jasm.Main -d /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/classes/2/jdk/internal/reflect/constantPool/ConstantPoolTest.d /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTestDummy.jasm result: Error. can't find jasm test result: Error. can't find jasm <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< Best Regards! VicWang | R&D Telephone:+86-01082695388-892477 -----????----- ???: David Holmes [mailto:david.holmes at oracle.com] ????: 2017?12?15? 15:52 ???: Ao Qi ; Vic Wang(BJ-RD) ??: jdk8u-dev at openjdk.java.net ??: Re: ??: inquiry how to submit a change See: http://hg.openjdk.java.net/code-tools/ for all projects. David On 15/12/2017 2:46 PM, Ao Qi wrote: > Hi Vic, > > Hoping this helps: > https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK/job/asmtools/ > > Ao Qi > 12.15 > > 2017-12-15 12:34 GMT+08:00 Vic Wang(BJ-RD) : > >> Hi Weijun : >> There is not a asmtools.jar in jtreg/lib. How can I get it? >> The web < http://openjdk.java.net/code-tools/asmtools> can't access >> (it return `404 Not Found`). >> Thanks very much. >> >> >> Best Regards! >> VicWang | R&D >> Telephone:+86-01082695388-892477 >> >> -----????----- >> ???: Weijun Wang [mailto:weijun.wang at oracle.com] >> ????: 2017?12?15? 11:42 >> ???: Vic Wang(BJ-RD) >> ??: Volker Simonis ; >> jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >> ??: Re: inquiry how to submit a change >> >> Hi Vic >> >> I do not run test this way (I either run a single one with jtreg >> directly or use our internal CI to run a tier) so I am not sure where the problem is. >> >> As for jasm, There is a asmtools.jar in jtreg/lib. Do you have it? >> >> Thanks >> Max >> >>> On Dec 15, 2017, at 11:01 AM, Vic Wang(BJ-RD) >> wrote: >>> >>> Dear Volker/Weijun: >>> Thanks for your help. >>> I've already clone the jdk ,hs ,client repository. >>> >>> Now I've built jdk success by executing the following command: >>> First, I configure JDK9 environment path, Then, bash configure make >>> images >>> >>> when running basic tests by ` make run-test-tier1`, it occurs the >> following error: >>> 1>. >>> ----------configuration:(0/0)---------- >>> ----------rerun:(4/539)*---------- >>> cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/ >> linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/ >> scratch/2 >> && \\ >>> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >>> -classpath \\ >>> org.openjdk.asmtools.jasm.Main -d >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-norma >>> l- >>> server-release/test-support/jtreg_test_jdk_tier1/classes/1/jdk/inter >>> na l/reflect/constantPool/ConstantPoolTest.d >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/re >>> fl ect/constantPool/ConstantPoolTestDummy.jasm >>> result: Error. can't find jasm >>> test result: Error. can't find jasm >>> >>> 2>. can't find jcoder >>> tools/javac/T6435291/T6435291.java: javac shouldn't throw NPE while >>> compiling invalid RuntimeInvisibleParameterAnnotations >>> 3>. Execution failed: `main' threw exception: >>> 3>java.lang.reflect.InvocationTargetException >>> jdk/javadoc/doclet/testIOException/TestIOException.java: test >>> IOException handling >>> >>> 4>.============================== >>> Test summary >>> ============================== >>> TEST TOTAL PASS FAIL >> ERROR >>>>> jtreg:test/jdk:tier1 1657 1656 0 >> 1 << >>>>> jtreg:test/langtools:tier1 3826 3814 1 >> 11 << >>> jtreg:test/nashorn:tier1 0 0 0 >> 0 >>> jtreg:test/jaxp:tier1 0 0 0 >> 0 >>> ============================== >>> TEST FAILURE >>> >>> ps: I've configured the jtreg[1] by seting JT_HOME and jtharness[2] >>> by >> seting JTHARNESS_HOME. >>> I've found the asm lib ,but how >>> to >> configure it ? >>> >>> Is there any configuration or dependencies to be set? >>> >>> [1] >>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild >>> /a >>> rtifact/ [2] >>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulB >>> ui >>> ld/artifact/ >>> >>> Best Regards! >>> VicWang | R&D >>> Telephone:+86-01082695388-892477 >>> >>> >>> -----????----- >>> ???: Volker Simonis [mailto:volker.simonis at gmail.com] >>> ????: 2017?12?6? 17:30 >>> ???: Weijun Wang >>> ??: Vic Wang(BJ-RD); jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>> ??: Re: inquiry how to submit a change >>> >>> On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang >> wrote: >>>> >>>> >>>>> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) >> wrote: >>>>> >>>>> requesting all changes >>>>> adding changesets >>>>> transaction abort! >>>>> rollback completed >>>>> abort: stream ended unexpectedly (got 6 bytes, >>>>> expected 80) >>>> >>>> Looks like a network problem, I've seen this before. Please try again. >>>> >>> >>> Yes, that's usually because of slow network. >>> >>> You can try to add: >>> >>> [ui] >>> ssh = ssh -C >>> >>> to your .hgrc. Somtimes it helps :) >>> >>>>> >>>>> I find it need a username which is configured in ~/.bashrc. >>>>> Is >> the username is necessary? How to assign a username? >>>> >>>> I don't think a username is needed to pull the repository. >>>> >>>> --Max >>>> >>>> >>>> >>> >>> >>> ????? >>> ????????????????????????????????????????????????????? >>> CONFIDENTIAL NOTE: >>> This email contains confidential or legally privileged information >>> and >> is for the sole use of its intended recipient. Any unauthorized >> review, use, copying or forwarding of this email or the content of >> this email is strictly prohibited. >> >> >> >> ????? >> ????????????????????????????????????????????????????? >> CONFIDENTIAL NOTE: >> This email contains confidential or legally privileged information >> and is for the sole use of its intended recipient. Any unauthorized >> review, use, copying or forwarding of this email or the content of >> this email is strictly prohibited. >> ????? ????????????????????????????????????????????????????? CONFIDENTIAL NOTE: This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. From david.holmes at oracle.com Tue Dec 19 11:42:45 2017 From: david.holmes at oracle.com (David Holmes) Date: Tue, 19 Dec 2017 21:42:45 +1000 Subject: =?UTF-8?B?UmU6IOetlOWkjTog562U5aSNOiBpbnF1aXJ5IGhvdyB0byBzdWJtaXQg?= =?UTF-8?Q?a_change?= In-Reply-To: References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> <79E88FFE-20EF-4799-B4E9-97D3D383C0C1@oracle.com> Message-ID: cc'ing jtreg-use. Sorry I've no idea how to put these tools together externally. David On 19/12/2017 9:08 PM, Vic Wang(BJ-RD) wrote: > Hi David, Ao Qi & Weijun: > I've downloaded the asmtools.jar and put it in jtreg/lib dir. And set the following environment variables. > export JT_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg > export JTHARNESS_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtharness > export ASMTOOLSHOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/asmtools-6.0/lib > > however, when running the test command, it still occurred "can't find jasm" error. > The test command is : make run-test TEST="jtreg:test/jdk:tier1". > > Additional, as I want to submit a change for jdk repository, should I pass the basic run test firstly ? > The following is the detailed results for the error. Thanks very much. > <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< > #-----testresult----- > description=file\:/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTest.java > elapsed=1333 0\:00\:01.333 > end=Tue Dec 19 17\:57\:20 CST 2017 > environment=regtest > execStatus=Error. can't find jasm > harnessLoaderMode=Classpath Loader > harnessVariety=Full Bundle > hostname=vic-os > javatestOS=Linux 3.16.4 (amd64) > javatestVersion=5.0 > jtregVersion=jtreg 4.2 dev b09 > modules=java.base/jdk.internal.misc java.base/jdk.internal.reflect > script=com.sun.javatest.regtest.exec.RegressionScript > sections=script_messages compile > start=Tue Dec 19 17\:57\:18 CST 2017 > test=jdk/internal/reflect/constantPool/ConstantPoolTest.java > testJDK=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/images/jdk > totalTime=1370 > user.name=root > work=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/jdk/internal/reflect/constantPool > > #section:script_messages > ----------messages:(7/577)---------- > JDK under test: /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/images/jdk > openjdk version "10-internal" > OpenJDK Runtime Environment (build 10-internal+0-adhoc.root.jdk) > OpenJDK 64-Bit Server VM (build 10-internal+0-adhoc.root.jdk, mixed mode) > Library /lib/testlibrary; kind: packages > source directory: /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/lib/testlibrary > class directory: /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/classes/2/lib/testlibrary > > #section:compile > ----------messages:(3/232)---------- > command: compile /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTestDummy.jasm > reason: User specified action: run compile ConstantPoolTestDummy.jasm > elapsed time (seconds): 1.097 > ----------configuration:(0/0)---------- > ----------rerun:(4/607)*---------- > cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/scratch/0 && \\ > /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ > -classpath /home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg/lib/asmtools.jar \\ > org.openjdk.asmtools.jasm.Main -d /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/classes/2/jdk/internal/reflect/constantPool/ConstantPoolTest.d /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTestDummy.jasm > result: Error. can't find jasm > > > test result: Error. can't find jasm > <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< > > Best Regards! > VicWang | R&D > Telephone:+86-01082695388-892477 > > > -----????----- > ???: David Holmes [mailto:david.holmes at oracle.com] > ????: 2017?12?15? 15:52 > ???: Ao Qi ; Vic Wang(BJ-RD) > ??: jdk8u-dev at openjdk.java.net > ??: Re: ??: inquiry how to submit a change > > See: > > http://hg.openjdk.java.net/code-tools/ > > for all projects. > > David > > On 15/12/2017 2:46 PM, Ao Qi wrote: >> Hi Vic, >> >> Hoping this helps: >> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK/job/asmtools/ >> >> Ao Qi >> 12.15 >> >> 2017-12-15 12:34 GMT+08:00 Vic Wang(BJ-RD) : >> >>> Hi Weijun : >>> There is not a asmtools.jar in jtreg/lib. How can I get it? >>> The web < http://openjdk.java.net/code-tools/asmtools> can't access >>> (it return `404 Not Found`). >>> Thanks very much. >>> >>> >>> Best Regards! >>> VicWang | R&D >>> Telephone:+86-01082695388-892477 >>> >>> -----????----- >>> ???: Weijun Wang [mailto:weijun.wang at oracle.com] >>> ????: 2017?12?15? 11:42 >>> ???: Vic Wang(BJ-RD) >>> ??: Volker Simonis ; >>> jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>> ??: Re: inquiry how to submit a change >>> >>> Hi Vic >>> >>> I do not run test this way (I either run a single one with jtreg >>> directly or use our internal CI to run a tier) so I am not sure where the problem is. >>> >>> As for jasm, There is a asmtools.jar in jtreg/lib. Do you have it? >>> >>> Thanks >>> Max >>> >>>> On Dec 15, 2017, at 11:01 AM, Vic Wang(BJ-RD) >>> wrote: >>>> >>>> Dear Volker/Weijun: >>>> Thanks for your help. >>>> I've already clone the jdk ,hs ,client repository. >>>> >>>> Now I've built jdk success by executing the following command: >>>> First, I configure JDK9 environment path, Then, bash configure make >>>> images >>>> >>>> when running basic tests by ` make run-test-tier1`, it occurs the >>> following error: >>>> 1>. >>>> ----------configuration:(0/0)---------- >>>> ----------rerun:(4/539)*---------- >>>> cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/ >>> linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/ >>> scratch/2 >>> && \\ >>>> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >>>> -classpath \\ >>>> org.openjdk.asmtools.jasm.Main -d >>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-norma >>>> l- >>>> server-release/test-support/jtreg_test_jdk_tier1/classes/1/jdk/inter >>>> na l/reflect/constantPool/ConstantPoolTest.d >>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/re >>>> fl ect/constantPool/ConstantPoolTestDummy.jasm >>>> result: Error. can't find jasm >>>> test result: Error. can't find jasm >>>> >>>> 2>. can't find jcoder >>>> tools/javac/T6435291/T6435291.java: javac shouldn't throw NPE while >>>> compiling invalid RuntimeInvisibleParameterAnnotations >>>> 3>. Execution failed: `main' threw exception: >>>> 3>java.lang.reflect.InvocationTargetException >>>> jdk/javadoc/doclet/testIOException/TestIOException.java: test >>>> IOException handling >>>> >>>> 4>.============================== >>>> Test summary >>>> ============================== >>>> TEST TOTAL PASS FAIL >>> ERROR >>>>>> jtreg:test/jdk:tier1 1657 1656 0 >>> 1 << >>>>>> jtreg:test/langtools:tier1 3826 3814 1 >>> 11 << >>>> jtreg:test/nashorn:tier1 0 0 0 >>> 0 >>>> jtreg:test/jaxp:tier1 0 0 0 >>> 0 >>>> ============================== >>>> TEST FAILURE >>>> >>>> ps: I've configured the jtreg[1] by seting JT_HOME and jtharness[2] >>>> by >>> seting JTHARNESS_HOME. >>>> I've found the asm lib ,but how >>>> to >>> configure it ? >>>> >>>> Is there any configuration or dependencies to be set? >>>> >>>> [1] >>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild >>>> /a >>>> rtifact/ [2] >>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulB >>>> ui >>>> ld/artifact/ >>>> >>>> Best Regards! >>>> VicWang | R&D >>>> Telephone:+86-01082695388-892477 >>>> >>>> >>>> -----????----- >>>> ???: Volker Simonis [mailto:volker.simonis at gmail.com] >>>> ????: 2017?12?6? 17:30 >>>> ???: Weijun Wang >>>> ??: Vic Wang(BJ-RD); jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>>> ??: Re: inquiry how to submit a change >>>> >>>> On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang >>> wrote: >>>>> >>>>> >>>>>> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) >>> wrote: >>>>>> >>>>>> requesting all changes >>>>>> adding changesets >>>>>> transaction abort! >>>>>> rollback completed >>>>>> abort: stream ended unexpectedly (got 6 bytes, >>>>>> expected 80) >>>>> >>>>> Looks like a network problem, I've seen this before. Please try again. >>>>> >>>> >>>> Yes, that's usually because of slow network. >>>> >>>> You can try to add: >>>> >>>> [ui] >>>> ssh = ssh -C >>>> >>>> to your .hgrc. Somtimes it helps :) >>>> >>>>>> >>>>>> I find it need a username which is configured in ~/.bashrc. >>>>>> Is >>> the username is necessary? How to assign a username? >>>>> >>>>> I don't think a username is needed to pull the repository. >>>>> >>>>> --Max >>>>> >>>>> >>>>> >>>> >>>> >>>> ????? >>>> ????????????????????????????????????????????????????? >>>> CONFIDENTIAL NOTE: >>>> This email contains confidential or legally privileged information >>>> and >>> is for the sole use of its intended recipient. Any unauthorized >>> review, use, copying or forwarding of this email or the content of >>> this email is strictly prohibited. >>> >>> >>> >>> ????? >>> ????????????????????????????????????????????????????? >>> CONFIDENTIAL NOTE: >>> This email contains confidential or legally privileged information >>> and is for the sole use of its intended recipient. Any unauthorized >>> review, use, copying or forwarding of this email or the content of >>> this email is strictly prohibited. >>> > > > ????? > ????????????????????????????????????????????????????? > CONFIDENTIAL NOTE: > This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. > From david.buck at oracle.com Tue Dec 19 13:19:31 2017 From: david.buck at oracle.com (David Buck) Date: Tue, 19 Dec 2017 22:19:31 +0900 Subject: [8u-dev] RFA 8055755: Information about loaded dynamic libraries is wrong on MacOSX. Message-ID: Hi! Please approve this backport to JDK 8: bug report: https://bugs.openjdk.java.net/browse/JDK-8055755 JDK 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/fe13911efa5b JDK 9 review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-August/015455.html The JDK 9 changeset applies to the 8u-dev forest as-is. JPRT testing (hotspot testset) and manual confirmation of fix done. Cheers, -Buck From ramanand.patil at oracle.com Tue Dec 19 14:44:56 2017 From: ramanand.patil at oracle.com (Ramanand Patil) Date: Tue, 19 Dec 2017 06:44:56 -0800 (PST) Subject: [8u-dev] Request for Approval: Backport of 8136356: Add time zone mappings on Windows Message-ID: <4b9bcde2-1514-4696-88d3-37aff64a5ffd@default> Hi, Please approve the backport of 8136356 to 8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8136356 JDK9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/6fda66a5bdf2 JDK9 Review Thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2016-July/002052.html Changes apply cleanly to jdk8u-dev after path reshuffling. Regards, Ramanand. From rob.mckenna at oracle.com Tue Dec 19 14:57:49 2017 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 19 Dec 2017 14:57:49 +0000 Subject: [8u-dev] RFA 8055755: Information about loaded dynamic libraries is wrong on MacOSX. In-Reply-To: References: Message-ID: <20171219145749.GA3406@tecra> Approved -Rob On 19/12/17 22:19, David Buck wrote: > Hi! > > Please approve this backport to JDK 8: > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8055755 > > JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/fe13911efa5b > > JDK 9 review thread: > http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-August/015455.html > > The JDK 9 changeset applies to the 8u-dev forest as-is. JPRT testing (hotspot testset) and manual confirmation of fix done. > > Cheers, > -Buck From rob.mckenna at oracle.com Tue Dec 19 14:58:12 2017 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 19 Dec 2017 14:58:12 +0000 Subject: [8u-dev] Request for Approval: Backport of 8136356: Add time zone mappings on Windows In-Reply-To: <4b9bcde2-1514-4696-88d3-37aff64a5ffd@default> References: <4b9bcde2-1514-4696-88d3-37aff64a5ffd@default> Message-ID: <20171219145812.GB3406@tecra> Approved -Rob On 19/12/17 06:44, Ramanand Patil wrote: > Hi, > Please approve the backport of 8136356 to 8u-dev. > Bug: https://bugs.openjdk.java.net/browse/JDK-8136356 > JDK9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/6fda66a5bdf2 > JDK9 Review Thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2016-July/002052.html > Changes apply cleanly to jdk8u-dev after path reshuffling. > > Regards, > Ramanand. From mbalao at redhat.com Tue Dec 19 19:00:49 2017 From: mbalao at redhat.com (Martin Balao) Date: Tue, 19 Dec 2017 16:00:49 -0300 Subject: [RFR - backport]: JDK-8193520 - NSS and Sqlite DB Message-ID: Hi, I'd like to request a review for the jdk8u backport of JDK-8165996 (PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite) [1]. Backport ticket is JDK-8193520 [2]. Webrev 01: * http://cr.openjdk.java.net/~akasko/mbalao/jdk_8165996_nssdb_sqlite/backports/8/2017_12_14/8165996.webrev.01/ (online) * http://cr.openjdk.java.net/~akasko/mbalao/jdk_8165996_nssdb_sqlite/backports/8/2017_12_14/8165996.webrev.01.zip (download) Kind regards, Martin.- -- [1] - https://bugs.openjdk.java.net/browse/JDK-8165996 [2] - https://bugs.openjdk.java.net/browse/JDK-8193520 From jonathan.gibbons at oracle.com Wed Dec 20 00:20:47 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 19 Dec 2017 16:20:47 -0800 Subject: =?UTF-8?B?562U5aSNOiDnrZTlpI06IGlucXVpcnkgaG93IHRvIHN1Ym1pdCA=?= =?UTF-8?B?YSBjaGFuZ2U=?= In-Reply-To: References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> <79E88FFE-20EF-4799-B4E9-97D3D383C0C1@oracle.com> Message-ID: <5A39ACDF.3050009@oracle.com> Vic, Ao Qi, et al, The recommended place to get the latest builds of jtreg is from the Adopt OpenJDK group, here: https://ci.adoptopenjdk.net/view/Dependencies/job/jtreg/ Of the two builds there, I recommend jtreg-4.2-b10.tar.gz. This build contains all the necessary components, including asmtools.jar. (The other build is a build of the development "tip", and is not recommended for general use.) -- Jon On 12/19/2017 03:42 AM, David Holmes wrote: > cc'ing jtreg-use. Sorry I've no idea how to put these tools together > externally. > > David > > On 19/12/2017 9:08 PM, Vic Wang(BJ-RD) wrote: >> Hi David, Ao Qi & Weijun: >> I've downloaded the asmtools.jar and put it in jtreg/lib dir. And set >> the following environment variables. >> export JT_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg >> export >> JTHARNESS_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtharness >> export >> ASMTOOLSHOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/asmtools-6.0/lib >> >> however, when running the test command, it still occurred "can't find >> jasm" error. >> The test command is : make run-test TEST="jtreg:test/jdk:tier1". >> >> Additional, as I want to submit a change for jdk repository, should I >> pass the basic run test firstly ? >> The following is the detailed results for the error. Thanks very much. >> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< >> #-----testresult----- >> description=file\:/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTest.java >> >> elapsed=1333 0\:00\:01.333 >> end=Tue Dec 19 17\:57\:20 CST 2017 >> environment=regtest >> execStatus=Error. can't find jasm >> harnessLoaderMode=Classpath Loader >> harnessVariety=Full Bundle >> hostname=vic-os >> javatestOS=Linux 3.16.4 (amd64) >> javatestVersion=5.0 >> jtregVersion=jtreg 4.2 dev b09 >> modules=java.base/jdk.internal.misc java.base/jdk.internal.reflect >> script=com.sun.javatest.regtest.exec.RegressionScript >> sections=script_messages compile >> start=Tue Dec 19 17\:57\:18 CST 2017 >> test=jdk/internal/reflect/constantPool/ConstantPoolTest.java >> testJDK=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/images/jdk >> >> totalTime=1370 >> user.name=root >> work=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/jdk/internal/reflect/constantPool >> >> >> #section:script_messages >> ----------messages:(7/577)---------- >> JDK under test: >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/images/jdk >> openjdk version "10-internal" >> OpenJDK Runtime Environment (build 10-internal+0-adhoc.root.jdk) >> OpenJDK 64-Bit Server VM (build 10-internal+0-adhoc.root.jdk, mixed >> mode) >> Library /lib/testlibrary; kind: packages >> source directory: >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/lib/testlibrary >> class directory: >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/classes/2/lib/testlibrary >> >> #section:compile >> ----------messages:(3/232)---------- >> command: compile >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTestDummy.jasm >> reason: User specified action: run compile ConstantPoolTestDummy.jasm >> elapsed time (seconds): 1.097 >> ----------configuration:(0/0)---------- >> ----------rerun:(4/607)*---------- >> cd >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/scratch/0 >> && \\ >> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >> -classpath >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg/lib/asmtools.jar \\ >> org.openjdk.asmtools.jasm.Main -d >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/classes/2/jdk/internal/reflect/constantPool/ConstantPoolTest.d >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTestDummy.jasm >> >> result: Error. can't find jasm >> >> >> test result: Error. can't find jasm >> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< >> >> Best Regards! >> VicWang | R&D >> Telephone:+86-01082695388-892477 >> >> >> -----????----- >> ???: David Holmes [mailto:david.holmes at oracle.com] >> ????: 2017?12?15? 15:52 >> ???: Ao Qi ; Vic Wang(BJ-RD) >> ??: jdk8u-dev at openjdk.java.net >> ??: Re: ??: inquiry how to submit a change >> >> See: >> >> http://hg.openjdk.java.net/code-tools/ >> >> for all projects. >> >> David >> >> On 15/12/2017 2:46 PM, Ao Qi wrote: >>> Hi Vic, >>> >>> Hoping this helps: >>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK/job/asmtools/ >>> >>> Ao Qi >>> 12.15 >>> >>> 2017-12-15 12:34 GMT+08:00 Vic Wang(BJ-RD) : >>> >>>> Hi Weijun : >>>> There is not a asmtools.jar in jtreg/lib. How can I get it? >>>> The web < http://openjdk.java.net/code-tools/asmtools> can't access >>>> (it return `404 Not Found`). >>>> Thanks very much. >>>> >>>> >>>> Best Regards! >>>> VicWang | R&D >>>> Telephone:+86-01082695388-892477 >>>> >>>> -----????----- >>>> ???: Weijun Wang [mailto:weijun.wang at oracle.com] >>>> ????: 2017?12?15? 11:42 >>>> ???: Vic Wang(BJ-RD) >>>> ??: Volker Simonis ; >>>> jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>>> ??: Re: inquiry how to submit a change >>>> >>>> Hi Vic >>>> >>>> I do not run test this way (I either run a single one with jtreg >>>> directly or use our internal CI to run a tier) so I am not sure >>>> where the problem is. >>>> >>>> As for jasm, There is a asmtools.jar in jtreg/lib. Do you have it? >>>> >>>> Thanks >>>> Max >>>> >>>>> On Dec 15, 2017, at 11:01 AM, Vic Wang(BJ-RD) >>>> wrote: >>>>> >>>>> Dear Volker/Weijun: >>>>> Thanks for your help. >>>>> I've already clone the jdk ,hs ,client repository. >>>>> >>>>> Now I've built jdk success by executing the following command: >>>>> First, I configure JDK9 environment path, Then, bash configure make >>>>> images >>>>> >>>>> when running basic tests by ` make run-test-tier1`, it occurs the >>>> following error: >>>>> 1>. >>>>> ----------configuration:(0/0)---------- >>>>> ----------rerun:(4/539)*---------- >>>>> cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/ >>>> linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier1/ >>>> scratch/2 >>>> && \\ >>>>> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >>>>> -classpath \\ >>>>> org.openjdk.asmtools.jasm.Main -d >>>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-norma >>>>> l- >>>>> server-release/test-support/jtreg_test_jdk_tier1/classes/1/jdk/inter >>>>> na l/reflect/constantPool/ConstantPoolTest.d >>>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/re >>>>> fl ect/constantPool/ConstantPoolTestDummy.jasm >>>>> result: Error. can't find jasm >>>>> test result: Error. can't find jasm >>>>> >>>>> 2>. can't find jcoder >>>>> tools/javac/T6435291/T6435291.java: javac shouldn't throw NPE while >>>>> compiling invalid RuntimeInvisibleParameterAnnotations >>>>> 3>. Execution failed: `main' threw exception: >>>>> 3>java.lang.reflect.InvocationTargetException >>>>> jdk/javadoc/doclet/testIOException/TestIOException.java: test >>>>> IOException handling >>>>> >>>>> 4>.============================== >>>>> Test summary >>>>> ============================== >>>>> TEST TOTAL PASS FAIL >>>> ERROR >>>>>>> jtreg:test/jdk:tier1 1657 1656 0 >>>> 1 << >>>>>>> jtreg:test/langtools:tier1 3826 3814 1 >>>> 11 << >>>>> jtreg:test/nashorn:tier1 0 0 0 >>>> 0 >>>>> jtreg:test/jaxp:tier1 0 0 0 >>>> 0 >>>>> ============================== >>>>> TEST FAILURE >>>>> >>>>> ps: I've configured the jtreg[1] by seting JT_HOME and jtharness[2] >>>>> by >>>> seting JTHARNESS_HOME. >>>>> I've found the asm lib ,but how >>>>> to >>>> configure it ? >>>>> >>>>> Is there any configuration or dependencies to be set? >>>>> >>>>> [1] >>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBuild >>>>> /a >>>>> rtifact/ [2] >>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfulB >>>>> ui >>>>> ld/artifact/ >>>>> >>>>> Best Regards! >>>>> VicWang | R&D >>>>> Telephone:+86-01082695388-892477 >>>>> >>>>> >>>>> -----????----- >>>>> ???: Volker Simonis [mailto:volker.simonis at gmail.com] >>>>> ????: 2017?12?6? 17:30 >>>>> ???: Weijun Wang >>>>> ??: Vic Wang(BJ-RD); jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>>>> ??: Re: inquiry how to submit a change >>>>> >>>>> On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang >>>> wrote: >>>>>> >>>>>> >>>>>>> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) >>>> wrote: >>>>>>> >>>>>>> requesting all changes >>>>>>> adding changesets >>>>>>> transaction abort! >>>>>>> rollback completed >>>>>>> abort: stream ended unexpectedly (got 6 bytes, >>>>>>> expected 80) >>>>>> >>>>>> Looks like a network problem, I've seen this before. Please try >>>>>> again. >>>>>> >>>>> >>>>> Yes, that's usually because of slow network. >>>>> >>>>> You can try to add: >>>>> >>>>> [ui] >>>>> ssh = ssh -C >>>>> >>>>> to your .hgrc. Somtimes it helps :) >>>>> >>>>>>> >>>>>>> I find it need a username which is configured in ~/.bashrc. >>>>>>> Is >>>> the username is necessary? How to assign a username? >>>>>> >>>>>> I don't think a username is needed to pull the repository. >>>>>> >>>>>> --Max >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> ????? >>>>> ????????????????????????????????? >>>>> ???????????????????? >>>>> CONFIDENTIAL NOTE: >>>>> This email contains confidential or legally privileged information >>>>> and >>>> is for the sole use of its intended recipient. Any unauthorized >>>> review, use, copying or forwarding of this email or the content of >>>> this email is strictly prohibited. >>>> >>>> >>>> >>>> ????? >>>> ????????????????????????????????? >>>> ???????????????????? >>>> CONFIDENTIAL NOTE: >>>> This email contains confidential or legally privileged information >>>> and is for the sole use of its intended recipient. Any unauthorized >>>> review, use, copying or forwarding of this email or the content of >>>> this email is strictly prohibited. >>>> >> >> >> ????? >> ?????????????????????????????????? >> ??????????????????? >> CONFIDENTIAL NOTE: >> This email contains confidential or legally privileged information >> and is for the sole use of its intended recipient. Any unauthorized >> review, use, copying or forwarding of this email or the content of >> this email is strictly prohibited. >> From VicWang at zhaoxin.com Wed Dec 20 06:37:12 2017 From: VicWang at zhaoxin.com (Vic Wang(BJ-RD)) Date: Wed, 20 Dec 2017 06:37:12 +0000 Subject: =?utf-8?B?562U5aSNOiDnrZTlpI06IOetlOWkjTogaW5xdWlyeSBob3cgdG8gc3VibWl0?= =?utf-8?Q?_a_change?= In-Reply-To: <5A39ACDF.3050009@oracle.com> References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> <79E88FFE-20EF-4799-B4E9-97D3D383C0C1@oracle.com> <5A39ACDF.3050009@oracle.com> Message-ID: Dear Jonathan: I've downloaded jtreg-4.2-b10.tar.gz, it still occurred "can't find jasm" error. Can you help me try this? Just run TEST=" test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTest.java ". First, you have already built jdk images. Then, $cd the jdk repository dir. $bash configure --with-jtreg=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg --with-boot-jdk=/home/vic/Desktop/JVM/jdk-9.0.1 #please change your jtreg home dir and boot-jdk dir. $ make run-test TEST="test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTest.java" Then , it occurs " can't find jasm" error. Thanks very much. Best Regards! VicWang | R&D Telephone:+86-01082695388-892477 -----????----- ???: Jonathan Gibbons [mailto:jonathan.gibbons at oracle.com] ????: 2017?12?20? 8:21 ???: David Holmes ; Vic Wang(BJ-RD) ; Ao Qi ; Weijun Wang ??: jdk8u-dev at openjdk.java.net; jtreg-use at openjdk.java.net ??: Re: ??: ??: inquiry how to submit a change Vic, Ao Qi, et al, The recommended place to get the latest builds of jtreg is from the Adopt OpenJDK group, here: https://ci.adoptopenjdk.net/view/Dependencies/job/jtreg/ Of the two builds there, I recommend jtreg-4.2-b10.tar.gz. This build contains all the necessary components, including asmtools.jar. (The other build is a build of the development "tip", and is not recommended for general use.) -- Jon On 12/19/2017 03:42 AM, David Holmes wrote: > cc'ing jtreg-use. Sorry I've no idea how to put these tools together > externally. > > David > > On 19/12/2017 9:08 PM, Vic Wang(BJ-RD) wrote: >> Hi David, Ao Qi & Weijun: >> I've downloaded the asmtools.jar and put it in jtreg/lib dir. And set >> the following environment variables. >> export JT_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg >> export >> JTHARNESS_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtharnes >> s >> export >> ASMTOOLSHOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/asmtools-6 >> .0/lib >> >> however, when running the test command, it still occurred "can't find >> jasm" error. >> The test command is : make run-test TEST="jtreg:test/jdk:tier1". >> >> Additional, as I want to submit a change for jdk repository, should I >> pass the basic run test firstly ? >> The following is the detailed results for the error. Thanks very much. >> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< >> #-----testresult----- >> description=file\:/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jd >> k/jdk/internal/reflect/constantPool/ConstantPoolTest.java >> >> elapsed=1333 0\:00\:01.333 >> end=Tue Dec 19 17\:57\:20 CST 2017 >> environment=regtest >> execStatus=Error. can't find jasm >> harnessLoaderMode=Classpath Loader >> harnessVariety=Full Bundle >> hostname=vic-os >> javatestOS=Linux 3.16.4 (amd64) >> javatestVersion=5.0 >> jtregVersion=jtreg 4.2 dev b09 >> modules=java.base/jdk.internal.misc java.base/jdk.internal.reflect >> script=com.sun.javatest.regtest.exec.RegressionScript >> sections=script_messages compile >> start=Tue Dec 19 17\:57\:18 CST 2017 >> test=jdk/internal/reflect/constantPool/ConstantPoolTest.java >> testJDK=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_6 >> 4-normal-server-release/images/jdk >> >> totalTime=1370 >> user.name=root >> work=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-n >> ormal-server-release/test-support/jtreg_test_jdk_tier1/jdk/internal/r >> eflect/constantPool >> >> >> #section:script_messages >> ----------messages:(7/577)---------- >> JDK under test: >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >> -server-release/images/jdk >> openjdk version "10-internal" >> OpenJDK Runtime Environment (build 10-internal+0-adhoc.root.jdk) >> OpenJDK 64-Bit Server VM (build 10-internal+0-adhoc.root.jdk, mixed >> mode) >> Library /lib/testlibrary; kind: packages >> source directory: >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/lib/testlibrary >> class directory: >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >> -server-release/test-support/jtreg_test_jdk_tier1/classes/2/lib/testl >> ibrary >> >> #section:compile >> ----------messages:(3/232)---------- >> command: compile >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/ref >> lect/constantPool/ConstantPoolTestDummy.jasm >> reason: User specified action: run compile ConstantPoolTestDummy.jasm >> elapsed time (seconds): 1.097 >> ----------configuration:(0/0)---------- >> ----------rerun:(4/607)*---------- >> cd >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >> -server-release/test-support/jtreg_test_jdk_tier1/scratch/0 >> && \\ >> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >> -classpath >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg/lib/asmtools.jar \\ >> org.openjdk.asmtools.jasm.Main -d >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >> -server-release/test-support/jtreg_test_jdk_tier1/classes/2/jdk/inter >> nal/reflect/constantPool/ConstantPoolTest.d >> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/ref >> lect/constantPool/ConstantPoolTestDummy.jasm >> >> result: Error. can't find jasm >> >> >> test result: Error. can't find jasm >> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< >> >> Best Regards! >> VicWang | R&D >> Telephone:+86-01082695388-892477 >> >> >> -----????----- >> ???: David Holmes [mailto:david.holmes at oracle.com] >> ????: 2017?12?15? 15:52 >> ???: Ao Qi ; Vic Wang(BJ-RD) >> ??: jdk8u-dev at openjdk.java.net >> ??: Re: ??: inquiry how to submit a change >> >> See: >> >> http://hg.openjdk.java.net/code-tools/ >> >> for all projects. >> >> David >> >> On 15/12/2017 2:46 PM, Ao Qi wrote: >>> Hi Vic, >>> >>> Hoping this helps: >>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK/job/asmtools/ >>> >>> Ao Qi >>> 12.15 >>> >>> 2017-12-15 12:34 GMT+08:00 Vic Wang(BJ-RD) : >>> >>>> Hi Weijun : >>>> There is not a asmtools.jar in jtreg/lib. How can I get it? >>>> The web < http://openjdk.java.net/code-tools/asmtools> can't access >>>> (it return `404 Not Found`). >>>> Thanks very much. >>>> >>>> >>>> Best Regards! >>>> VicWang | R&D >>>> Telephone:+86-01082695388-892477 >>>> >>>> -----????----- >>>> ???: Weijun Wang [mailto:weijun.wang at oracle.com] >>>> ????: 2017?12?15? 11:42 >>>> ???: Vic Wang(BJ-RD) >>>> ??: Volker Simonis ; >>>> jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>>> ??: Re: inquiry how to submit a change >>>> >>>> Hi Vic >>>> >>>> I do not run test this way (I either run a single one with jtreg >>>> directly or use our internal CI to run a tier) so I am not sure >>>> where the problem is. >>>> >>>> As for jasm, There is a asmtools.jar in jtreg/lib. Do you have it? >>>> >>>> Thanks >>>> Max >>>> >>>>> On Dec 15, 2017, at 11:01 AM, Vic Wang(BJ-RD) >>>>> >>>> wrote: >>>>> >>>>> Dear Volker/Weijun: >>>>> Thanks for your help. >>>>> I've already clone the jdk ,hs ,client repository. >>>>> >>>>> Now I've built jdk success by executing the following command: >>>>> First, I configure JDK9 environment path, Then, bash configure >>>>> make images >>>>> >>>>> when running basic tests by ` make run-test-tier1`, it occurs the >>>> following error: >>>>> 1>. >>>>> ----------configuration:(0/0)---------- >>>>> ----------rerun:(4/539)*---------- >>>>> cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/ >>>> linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier >>>> 1/ >>>> scratch/2 >>>> && \\ >>>>> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >>>>> -classpath \\ >>>>> org.openjdk.asmtools.jasm.Main -d >>>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-nor >>>>> ma >>>>> l- >>>>> server-release/test-support/jtreg_test_jdk_tier1/classes/1/jdk/int >>>>> er na l/reflect/constantPool/ConstantPoolTest.d >>>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/ >>>>> re fl ect/constantPool/ConstantPoolTestDummy.jasm >>>>> result: Error. can't find jasm >>>>> test result: Error. can't find jasm >>>>> >>>>> 2>. can't find jcoder >>>>> tools/javac/T6435291/T6435291.java: javac shouldn't throw NPE >>>>> while compiling invalid RuntimeInvisibleParameterAnnotations >>>>> 3>. Execution failed: `main' threw exception: >>>>> 3>java.lang.reflect.InvocationTargetException >>>>> jdk/javadoc/doclet/testIOException/TestIOException.java: test >>>>> IOException handling >>>>> >>>>> 4>.============================== >>>>> Test summary >>>>> ============================== >>>>> TEST TOTAL PASS FAIL >>>> ERROR >>>>>>> jtreg:test/jdk:tier1 1657 1656 0 >>>> 1 << >>>>>>> jtreg:test/langtools:tier1 3826 3814 1 >>>> 11 << >>>>> jtreg:test/nashorn:tier1 0 0 0 >>>> 0 >>>>> jtreg:test/jaxp:tier1 0 0 0 >>>> 0 >>>>> ============================== >>>>> TEST FAILURE >>>>> >>>>> ps: I've configured the jtreg[1] by seting JT_HOME and >>>>> jtharness[2] by >>>> seting JTHARNESS_HOME. >>>>> I've found the asm lib ,but >>>>> how to >>>> configure it ? >>>>> >>>>> Is there any configuration or dependencies to be set? >>>>> >>>>> [1] >>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBui >>>>> ld >>>>> /a >>>>> rtifact/ [2] >>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfu >>>>> lB >>>>> ui >>>>> ld/artifact/ >>>>> >>>>> Best Regards! >>>>> VicWang | R&D >>>>> Telephone:+86-01082695388-892477 >>>>> >>>>> >>>>> -----????----- >>>>> ???: Volker Simonis [mailto:volker.simonis at gmail.com] >>>>> ????: 2017?12?6? 17:30 >>>>> ???: Weijun Wang >>>>> ??: Vic Wang(BJ-RD); jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>>>> ??: Re: inquiry how to submit a change >>>>> >>>>> On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang >>>>> >>>> wrote: >>>>>> >>>>>> >>>>>>> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) >>>>>>> >>>> wrote: >>>>>>> >>>>>>> requesting all changes >>>>>>> adding changesets >>>>>>> transaction abort! >>>>>>> rollback completed >>>>>>> abort: stream ended unexpectedly (got 6 bytes, >>>>>>> expected 80) >>>>>> >>>>>> Looks like a network problem, I've seen this before. Please try >>>>>> again. >>>>>> >>>>> >>>>> Yes, that's usually because of slow network. >>>>> >>>>> You can try to add: >>>>> >>>>> [ui] >>>>> ssh = ssh -C >>>>> >>>>> to your .hgrc. Somtimes it helps :) >>>>> >>>>>>> >>>>>>> I find it need a username which is configured in ~/.bashrc. >>>>>>> Is >>>> the username is necessary? How to assign a username? >>>>>> >>>>>> I don't think a username is needed to pull the repository. >>>>>> >>>>>> --Max >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> ????? >>>>> ????????????????????????????????? >>>>> ???????????????????? >>>>> CONFIDENTIAL NOTE: >>>>> This email contains confidential or legally privileged information >>>>> and >>>> is for the sole use of its intended recipient. Any unauthorized >>>> review, use, copying or forwarding of this email or the content of >>>> this email is strictly prohibited. >>>> >>>> >>>> >>>> ????? >>>> ????????????????????????????????? >>>> ???????????????????? >>>> CONFIDENTIAL NOTE: >>>> This email contains confidential or legally privileged information >>>> and is for the sole use of its intended recipient. Any unauthorized >>>> review, use, copying or forwarding of this email or the content of >>>> this email is strictly prohibited. >>>> >> >> >> ????? >> ?????????????????????????????????? >> ??????????????????? >> CONFIDENTIAL NOTE: >> This email contains confidential or legally privileged information >> and is for the sole use of its intended recipient. Any unauthorized >> review, use, copying or forwarding of this email or the content of >> this email is strictly prohibited. >> ????? ????????????????????????????????????????????????????? CONFIDENTIAL NOTE: This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. From ramanand.patil at oracle.com Wed Dec 20 14:28:14 2017 From: ramanand.patil at oracle.com (Ramanand Patil) Date: Wed, 20 Dec 2017 06:28:14 -0800 (PST) Subject: [8u-dev] Request for Approval: Backport of 8153955: increase java.util.logging.FileHandler MAX_LOCKS limit Message-ID: <0f2907ac-c66a-45fb-bbe4-edeb7029216d@default> Hi, Please approve the backport of HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8153955"8153955 to 8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8153955 JDK8 Review Thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-December/050659.html JDK8u fix was completely different, hence a separate review was carried out for this fix on the above provided thread. Regards, Ramanand. From sean.coffey at oracle.com Wed Dec 20 14:50:39 2017 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 20 Dec 2017 14:50:39 +0000 Subject: [8u-dev] Request for Approval: Backport of 8153955: increase java.util.logging.FileHandler MAX_LOCKS limit In-Reply-To: <0f2907ac-c66a-45fb-bbe4-edeb7029216d@default> References: <0f2907ac-c66a-45fb-bbe4-edeb7029216d@default> Message-ID: <05a84cde-7d74-ff31-7d06-7c55d2825a9e@oracle.com> Approved. Regards, Sean. On 20/12/17 14:28, Ramanand Patil wrote: > Hi, > > Please approve the backport of HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8153955"8153955 to 8u-dev. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8153955 > > JDK8 Review Thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-December/050659.html > > > > JDK8u fix was completely different, hence a separate review was carried out for this fix on the above provided thread. > > > > Regards, > > Ramanand. > > From david.buck at oracle.com Wed Dec 20 22:21:46 2017 From: david.buck at oracle.com (David Buck) Date: Thu, 21 Dec 2017 07:21:46 +0900 Subject: [8u] RFA 8031304 : Add dcmd to print all loaded dynamic libraries Message-ID: Hi! Please approve this serviceability backport to 8u-dev: bug report: https://bugs.openjdk.java.net/browse/JDK-8031304 JDK 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/afa21611f918 JDK 9 review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-January/013778.html JDK 8 backport review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-December/022677.html JDK 8 backport webrev (already reviewed): http://cr.openjdk.java.net/~dbuck/8031304_jdk8_ver00/ Cheers, -Buck From jonathan.gibbons at oracle.com Wed Dec 20 22:40:16 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 20 Dec 2017 14:40:16 -0800 Subject: =?UTF-8?B?562U5aSNOiDnrZTlpI06IOetlOWkjTogaW5xdWlyeSBob3cgdG8=?= =?UTF-8?B?IHN1Ym1pdCBhIGNoYW5nZQ==?= In-Reply-To: References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> <79E88FFE-20EF-4799-B4E9-97D3D383C0C1@oracle.com> <5A39ACDF.3050009@oracle.com> Message-ID: <5A3AE6D0.6050606@oracle.com> Vic, Thank you for your specific instructions on how to reproduce the issue. I now see the failure for myself, and will investigate further. -- Jon On 12/19/2017 10:37 PM, Vic Wang(BJ-RD) wrote: > Dear Jonathan: > > I've downloaded jtreg-4.2-b10.tar.gz, it still occurred "can't find jasm" error. > > Can you help me try this? Just run TEST=" test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTest.java ". > > First, you have already built jdk images. Then, > $cd the jdk repository dir. > $bash configure --with-jtreg=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg --with-boot-jdk=/home/vic/Desktop/JVM/jdk-9.0.1 #please change your jtreg home dir and boot-jdk dir. > $ make run-test TEST="test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTest.java" > > Then , it occurs " can't find jasm" error. > Thanks very much. > > Best Regards! > VicWang | R&D > Telephone:+86-01082695388-892477 > > > -----????----- > ???: Jonathan Gibbons [mailto:jonathan.gibbons at oracle.com] > ????: 2017?12?20? 8:21 > ???: David Holmes ; Vic Wang(BJ-RD) ; Ao Qi ; Weijun Wang > ??: jdk8u-dev at openjdk.java.net; jtreg-use at openjdk.java.net > ??: Re: ??: ??: inquiry how to submit a change > > Vic, Ao Qi, et al, > > The recommended place to get the latest builds of jtreg is from the Adopt OpenJDK group, here: > > https://ci.adoptopenjdk.net/view/Dependencies/job/jtreg/ > > Of the two builds there, I recommend jtreg-4.2-b10.tar.gz. This build contains all the necessary components, including asmtools.jar. > > (The other build is a build of the development "tip", and is not recommended for general use.) > > -- Jon > > > On 12/19/2017 03:42 AM, David Holmes wrote: >> cc'ing jtreg-use. Sorry I've no idea how to put these tools together >> externally. >> >> David >> >> On 19/12/2017 9:08 PM, Vic Wang(BJ-RD) wrote: >>> Hi David, Ao Qi & Weijun: >>> I've downloaded the asmtools.jar and put it in jtreg/lib dir. And set >>> the following environment variables. >>> export JT_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg >>> export >>> JTHARNESS_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtharnes >>> s >>> export >>> ASMTOOLSHOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/asmtools-6 >>> .0/lib >>> >>> however, when running the test command, it still occurred "can't find >>> jasm" error. >>> The test command is : make run-test TEST="jtreg:test/jdk:tier1". >>> >>> Additional, as I want to submit a change for jdk repository, should I >>> pass the basic run test firstly ? >>> The following is the detailed results for the error. Thanks very much. >>> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< >>> #-----testresult----- >>> description=file\:/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jd >>> k/jdk/internal/reflect/constantPool/ConstantPoolTest.java >>> >>> elapsed=1333 0\:00\:01.333 >>> end=Tue Dec 19 17\:57\:20 CST 2017 >>> environment=regtest >>> execStatus=Error. can't find jasm >>> harnessLoaderMode=Classpath Loader >>> harnessVariety=Full Bundle >>> hostname=vic-os >>> javatestOS=Linux 3.16.4 (amd64) >>> javatestVersion=5.0 >>> jtregVersion=jtreg 4.2 dev b09 >>> modules=java.base/jdk.internal.misc java.base/jdk.internal.reflect >>> script=com.sun.javatest.regtest.exec.RegressionScript >>> sections=script_messages compile >>> start=Tue Dec 19 17\:57\:18 CST 2017 >>> test=jdk/internal/reflect/constantPool/ConstantPoolTest.java >>> testJDK=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_6 >>> 4-normal-server-release/images/jdk >>> >>> totalTime=1370 >>> user.name=root >>> work=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-n >>> ormal-server-release/test-support/jtreg_test_jdk_tier1/jdk/internal/r >>> eflect/constantPool >>> >>> >>> #section:script_messages >>> ----------messages:(7/577)---------- >>> JDK under test: >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >>> -server-release/images/jdk >>> openjdk version "10-internal" >>> OpenJDK Runtime Environment (build 10-internal+0-adhoc.root.jdk) >>> OpenJDK 64-Bit Server VM (build 10-internal+0-adhoc.root.jdk, mixed >>> mode) >>> Library /lib/testlibrary; kind: packages >>> source directory: >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/lib/testlibrary >>> class directory: >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >>> -server-release/test-support/jtreg_test_jdk_tier1/classes/2/lib/testl >>> ibrary >>> >>> #section:compile >>> ----------messages:(3/232)---------- >>> command: compile >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/ref >>> lect/constantPool/ConstantPoolTestDummy.jasm >>> reason: User specified action: run compile ConstantPoolTestDummy.jasm >>> elapsed time (seconds): 1.097 >>> ----------configuration:(0/0)---------- >>> ----------rerun:(4/607)*---------- >>> cd >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >>> -server-release/test-support/jtreg_test_jdk_tier1/scratch/0 >>> && \\ >>> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >>> -classpath >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg/lib/asmtools.jar \\ >>> org.openjdk.asmtools.jasm.Main -d >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >>> -server-release/test-support/jtreg_test_jdk_tier1/classes/2/jdk/inter >>> nal/reflect/constantPool/ConstantPoolTest.d >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/ref >>> lect/constantPool/ConstantPoolTestDummy.jasm >>> >>> result: Error. can't find jasm >>> >>> >>> test result: Error. can't find jasm >>> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< >>> >>> Best Regards! >>> VicWang | R&D >>> Telephone:+86-01082695388-892477 >>> >>> >>> -----????----- >>> ???: David Holmes [mailto:david.holmes at oracle.com] >>> ????: 2017?12?15? 15:52 >>> ???: Ao Qi ; Vic Wang(BJ-RD) >>> ??: jdk8u-dev at openjdk.java.net >>> ??: Re: ??: inquiry how to submit a change >>> >>> See: >>> >>> http://hg.openjdk.java.net/code-tools/ >>> >>> for all projects. >>> >>> David >>> >>> On 15/12/2017 2:46 PM, Ao Qi wrote: >>>> Hi Vic, >>>> >>>> Hoping this helps: >>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK/job/asmtools/ >>>> >>>> Ao Qi >>>> 12.15 >>>> >>>> 2017-12-15 12:34 GMT+08:00 Vic Wang(BJ-RD) : >>>> >>>>> Hi Weijun : >>>>> There is not a asmtools.jar in jtreg/lib. How can I get it? >>>>> The web < http://openjdk.java.net/code-tools/asmtools> can't access >>>>> (it return `404 Not Found`). >>>>> Thanks very much. >>>>> >>>>> >>>>> Best Regards! >>>>> VicWang | R&D >>>>> Telephone:+86-01082695388-892477 >>>>> >>>>> -----????----- >>>>> ???: Weijun Wang [mailto:weijun.wang at oracle.com] >>>>> ????: 2017?12?15? 11:42 >>>>> ???: Vic Wang(BJ-RD) >>>>> ??: Volker Simonis ; >>>>> jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>>>> ??: Re: inquiry how to submit a change >>>>> >>>>> Hi Vic >>>>> >>>>> I do not run test this way (I either run a single one with jtreg >>>>> directly or use our internal CI to run a tier) so I am not sure >>>>> where the problem is. >>>>> >>>>> As for jasm, There is a asmtools.jar in jtreg/lib. Do you have it? >>>>> >>>>> Thanks >>>>> Max >>>>> >>>>>> On Dec 15, 2017, at 11:01 AM, Vic Wang(BJ-RD) >>>>>> >>>>> wrote: >>>>>> Dear Volker/Weijun: >>>>>> Thanks for your help. >>>>>> I've already clone the jdk ,hs ,client repository. >>>>>> >>>>>> Now I've built jdk success by executing the following command: >>>>>> First, I configure JDK9 environment path, Then, bash configure >>>>>> make images >>>>>> >>>>>> when running basic tests by ` make run-test-tier1`, it occurs the >>>>> following error: >>>>>> 1>. >>>>>> ----------configuration:(0/0)---------- >>>>>> ----------rerun:(4/539)*---------- >>>>>> cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/ >>>>> linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier >>>>> 1/ >>>>> scratch/2 >>>>> && \\ >>>>>> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >>>>>> -classpath \\ >>>>>> org.openjdk.asmtools.jasm.Main -d >>>>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-nor >>>>>> ma >>>>>> l- >>>>>> server-release/test-support/jtreg_test_jdk_tier1/classes/1/jdk/int >>>>>> er na l/reflect/constantPool/ConstantPoolTest.d >>>>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/ >>>>>> re fl ect/constantPool/ConstantPoolTestDummy.jasm >>>>>> result: Error. can't find jasm >>>>>> test result: Error. can't find jasm >>>>>> >>>>>> 2>. can't find jcoder >>>>>> tools/javac/T6435291/T6435291.java: javac shouldn't throw NPE >>>>>> while compiling invalid RuntimeInvisibleParameterAnnotations >>>>>> 3>. Execution failed: `main' threw exception: >>>>>> 3>java.lang.reflect.InvocationTargetException >>>>>> jdk/javadoc/doclet/testIOException/TestIOException.java: test >>>>>> IOException handling >>>>>> >>>>>> 4>.============================== >>>>>> Test summary >>>>>> ============================== >>>>>> TEST TOTAL PASS FAIL >>>>> ERROR >>>>>>>> jtreg:test/jdk:tier1 1657 1656 0 >>>>> 1 << >>>>>>>> jtreg:test/langtools:tier1 3826 3814 1 >>>>> 11 << >>>>>> jtreg:test/nashorn:tier1 0 0 0 >>>>> 0 >>>>>> jtreg:test/jaxp:tier1 0 0 0 >>>>> 0 >>>>>> ============================== >>>>>> TEST FAILURE >>>>>> >>>>>> ps: I've configured the jtreg[1] by seting JT_HOME and >>>>>> jtharness[2] by >>>>> seting JTHARNESS_HOME. >>>>>> I've found the asm lib ,but >>>>>> how to >>>>> configure it ? >>>>>> Is there any configuration or dependencies to be set? >>>>>> >>>>>> [1] >>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBui >>>>>> ld >>>>>> /a >>>>>> rtifact/ [2] >>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfu >>>>>> lB >>>>>> ui >>>>>> ld/artifact/ >>>>>> >>>>>> Best Regards! >>>>>> VicWang | R&D >>>>>> Telephone:+86-01082695388-892477 >>>>>> >>>>>> >>>>>> -----????----- >>>>>> ???: Volker Simonis [mailto:volker.simonis at gmail.com] >>>>>> ????: 2017?12?6? 17:30 >>>>>> ???: Weijun Wang >>>>>> ??: Vic Wang(BJ-RD); jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>>>>> ??: Re: inquiry how to submit a change >>>>>> >>>>>> On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang >>>>>> >>>>> wrote: >>>>>>> >>>>>>>> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) >>>>>>>> >>>>> wrote: >>>>>>>> requesting all changes >>>>>>>> adding changesets >>>>>>>> transaction abort! >>>>>>>> rollback completed >>>>>>>> abort: stream ended unexpectedly (got 6 bytes, >>>>>>>> expected 80) >>>>>>> Looks like a network problem, I've seen this before. Please try >>>>>>> again. >>>>>>> >>>>>> Yes, that's usually because of slow network. >>>>>> >>>>>> You can try to add: >>>>>> >>>>>> [ui] >>>>>> ssh = ssh -C >>>>>> >>>>>> to your .hgrc. Somtimes it helps :) >>>>>> >>>>>>>> I find it need a username which is configured in ~/.bashrc. >>>>>>>> Is >>>>> the username is necessary? How to assign a username? >>>>>>> I don't think a username is needed to pull the repository. >>>>>>> >>>>>>> --Max >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> ????? >>>>>> ????????????????????????????????? >>>>>> ???????????????????? >>>>>> CONFIDENTIAL NOTE: >>>>>> This email contains confidential or legally privileged information >>>>>> and >>>>> is for the sole use of its intended recipient. Any unauthorized >>>>> review, use, copying or forwarding of this email or the content of >>>>> this email is strictly prohibited. >>>>> >>>>> >>>>> >>>>> ????? >>>>> ????????????????????????????????? >>>>> ???????????????????? >>>>> CONFIDENTIAL NOTE: >>>>> This email contains confidential or legally privileged information >>>>> and is for the sole use of its intended recipient. Any unauthorized >>>>> review, use, copying or forwarding of this email or the content of >>>>> this email is strictly prohibited. >>>>> >>> >>> ????? >>> ?????????????????????????????????? >>> ??????????????????? >>> CONFIDENTIAL NOTE: >>> This email contains confidential or legally privileged information >>> and is for the sole use of its intended recipient. Any unauthorized >>> review, use, copying or forwarding of this email or the content of >>> this email is strictly prohibited. >>> > > > ????? > ????????????????????????????????????????????????????? > CONFIDENTIAL NOTE: > This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. From jonathan.gibbons at oracle.com Wed Dec 20 23:27:20 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 20 Dec 2017 15:27:20 -0800 Subject: =?UTF-8?B?562U5aSNOiDnrZTlpI06IOetlOWkjTogaW5xdWlyeSBob3cgdG8=?= =?UTF-8?B?IHN1Ym1pdCBhIGNoYW5nZQ==?= In-Reply-To: <5A3AE6D0.6050606@oracle.com> References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> <79E88FFE-20EF-4799-B4E9-97D3D383C0C1@oracle.com> <5A39ACDF.3050009@oracle.com> <5A3AE6D0.6050606@oracle.com> Message-ID: <5A3AF1D8.2020508@oracle.com> Vic, A notable difference between the build of asmtools tools that we are using here in the JDK organization is that it is AsmTools 6.0. (Dec 19, 2014) The version of asmtools in the AdoptOpenJDK build of jtreg is AsmTools 7.0 beta (Dec 18, 2017). I will investigate why the difference causes a problem. -- Jon On 12/20/2017 02:40 PM, Jonathan Gibbons wrote: > Vic, > > Thank you for your specific instructions on how to reproduce the > issue. I now see the failure for myself, and will investigate further. > > -- Jon > > On 12/19/2017 10:37 PM, Vic Wang(BJ-RD) wrote: >> Dear Jonathan: >> >> I've downloaded jtreg-4.2-b10.tar.gz, it still occurred "can't find >> jasm" error. >> >> Can you help me try this? Just run TEST=" >> test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTest.java ". >> >> First, you have already built jdk images. Then, >> $cd the jdk repository dir. >> $bash configure >> --with-jtreg=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg >> --with-boot-jdk=/home/vic/Desktop/JVM/jdk-9.0.1 #please change your >> jtreg home dir and boot-jdk dir. >> $ make run-test >> TEST="test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTest.java" >> >> Then , it occurs " can't find jasm" error. >> Thanks very much. >> >> Best Regards! >> VicWang | R&D >> Telephone:+86-01082695388-892477 >> >> >> -----????----- >> ???: Jonathan Gibbons [mailto:jonathan.gibbons at oracle.com] >> ????: 2017?12?20? 8:21 >> ???: David Holmes ; Vic Wang(BJ-RD) >> ; Ao Qi ; Weijun Wang >> >> ??: jdk8u-dev at openjdk.java.net; jtreg-use at openjdk.java.net >> ??: Re: ??: ??: inquiry how to submit a change >> >> Vic, Ao Qi, et al, >> >> The recommended place to get the latest builds of jtreg is from the >> Adopt OpenJDK group, here: >> >> https://ci.adoptopenjdk.net/view/Dependencies/job/jtreg/ >> >> Of the two builds there, I recommend jtreg-4.2-b10.tar.gz. This >> build contains all the necessary components, including asmtools.jar. >> >> (The other build is a build of the development "tip", and is not >> recommended for general use.) >> >> -- Jon >> >> >> On 12/19/2017 03:42 AM, David Holmes wrote: >>> cc'ing jtreg-use. Sorry I've no idea how to put these tools together >>> externally. >>> >>> David >>> >>> On 19/12/2017 9:08 PM, Vic Wang(BJ-RD) wrote: >>>> Hi David, Ao Qi & Weijun: >>>> I've downloaded the asmtools.jar and put it in jtreg/lib dir. And set >>>> the following environment variables. >>>> export JT_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg >>>> export >>>> JTHARNESS_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtharnes >>>> s >>>> export >>>> ASMTOOLSHOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/asmtools-6 >>>> .0/lib >>>> >>>> however, when running the test command, it still occurred "can't find >>>> jasm" error. >>>> The test command is : make run-test TEST="jtreg:test/jdk:tier1". >>>> >>>> Additional, as I want to submit a change for jdk repository, should I >>>> pass the basic run test firstly ? >>>> The following is the detailed results for the error. Thanks very much. >>>> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< >>>> #-----testresult----- >>>> description=file\:/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jd >>>> k/jdk/internal/reflect/constantPool/ConstantPoolTest.java >>>> >>>> elapsed=1333 0\:00\:01.333 >>>> end=Tue Dec 19 17\:57\:20 CST 2017 >>>> environment=regtest >>>> execStatus=Error. can't find jasm >>>> harnessLoaderMode=Classpath Loader >>>> harnessVariety=Full Bundle >>>> hostname=vic-os >>>> javatestOS=Linux 3.16.4 (amd64) >>>> javatestVersion=5.0 >>>> jtregVersion=jtreg 4.2 dev b09 >>>> modules=java.base/jdk.internal.misc java.base/jdk.internal.reflect >>>> script=com.sun.javatest.regtest.exec.RegressionScript >>>> sections=script_messages compile >>>> start=Tue Dec 19 17\:57\:18 CST 2017 >>>> test=jdk/internal/reflect/constantPool/ConstantPoolTest.java >>>> testJDK=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_6 >>>> 4-normal-server-release/images/jdk >>>> >>>> totalTime=1370 >>>> user.name=root >>>> work=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-n >>>> ormal-server-release/test-support/jtreg_test_jdk_tier1/jdk/internal/r >>>> eflect/constantPool >>>> >>>> >>>> #section:script_messages >>>> ----------messages:(7/577)---------- >>>> JDK under test: >>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >>>> -server-release/images/jdk >>>> openjdk version "10-internal" >>>> OpenJDK Runtime Environment (build 10-internal+0-adhoc.root.jdk) >>>> OpenJDK 64-Bit Server VM (build 10-internal+0-adhoc.root.jdk, mixed >>>> mode) >>>> Library /lib/testlibrary; kind: packages >>>> source directory: >>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/lib/testlibrary >>>> class directory: >>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >>>> -server-release/test-support/jtreg_test_jdk_tier1/classes/2/lib/testl >>>> ibrary >>>> >>>> #section:compile >>>> ----------messages:(3/232)---------- >>>> command: compile >>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/ref >>>> lect/constantPool/ConstantPoolTestDummy.jasm >>>> reason: User specified action: run compile ConstantPoolTestDummy.jasm >>>> elapsed time (seconds): 1.097 >>>> ----------configuration:(0/0)---------- >>>> ----------rerun:(4/607)*---------- >>>> cd >>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >>>> -server-release/test-support/jtreg_test_jdk_tier1/scratch/0 >>>> && \\ >>>> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >>>> -classpath >>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg/lib/asmtools.jar \\ >>>> >>>> org.openjdk.asmtools.jasm.Main -d >>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >>>> -server-release/test-support/jtreg_test_jdk_tier1/classes/2/jdk/inter >>>> nal/reflect/constantPool/ConstantPoolTest.d >>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/ref >>>> lect/constantPool/ConstantPoolTestDummy.jasm >>>> >>>> result: Error. can't find jasm >>>> >>>> >>>> test result: Error. can't find jasm >>>> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< >>>> >>>> Best Regards! >>>> VicWang | R&D >>>> Telephone:+86-01082695388-892477 >>>> >>>> >>>> -----????----- >>>> ???: David Holmes [mailto:david.holmes at oracle.com] >>>> ????: 2017?12?15? 15:52 >>>> ???: Ao Qi ; Vic Wang(BJ-RD) >>>> >>>> ??: jdk8u-dev at openjdk.java.net >>>> ??: Re: ??: inquiry how to submit a change >>>> >>>> See: >>>> >>>> http://hg.openjdk.java.net/code-tools/ >>>> >>>> for all projects. >>>> >>>> David >>>> >>>> On 15/12/2017 2:46 PM, Ao Qi wrote: >>>>> Hi Vic, >>>>> >>>>> Hoping this helps: >>>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK/job/asmtools/ >>>>> >>>>> Ao Qi >>>>> 12.15 >>>>> >>>>> 2017-12-15 12:34 GMT+08:00 Vic Wang(BJ-RD) : >>>>> >>>>>> Hi Weijun : >>>>>> There is not a asmtools.jar in jtreg/lib. How can I get it? >>>>>> The web < http://openjdk.java.net/code-tools/asmtools> can't access >>>>>> (it return `404 Not Found`). >>>>>> Thanks very much. >>>>>> >>>>>> >>>>>> Best Regards! >>>>>> VicWang | R&D >>>>>> Telephone:+86-01082695388-892477 >>>>>> >>>>>> -----????----- >>>>>> ???: Weijun Wang [mailto:weijun.wang at oracle.com] >>>>>> ????: 2017?12?15? 11:42 >>>>>> ???: Vic Wang(BJ-RD) >>>>>> ??: Volker Simonis ; >>>>>> jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>>>>> ??: Re: inquiry how to submit a change >>>>>> >>>>>> Hi Vic >>>>>> >>>>>> I do not run test this way (I either run a single one with jtreg >>>>>> directly or use our internal CI to run a tier) so I am not sure >>>>>> where the problem is. >>>>>> >>>>>> As for jasm, There is a asmtools.jar in jtreg/lib. Do you have it? >>>>>> >>>>>> Thanks >>>>>> Max >>>>>> >>>>>>> On Dec 15, 2017, at 11:01 AM, Vic Wang(BJ-RD) >>>>>>> >>>>>> wrote: >>>>>>> Dear Volker/Weijun: >>>>>>> Thanks for your help. >>>>>>> I've already clone the jdk ,hs ,client repository. >>>>>>> >>>>>>> Now I've built jdk success by executing the following command: >>>>>>> First, I configure JDK9 environment path, Then, bash configure >>>>>>> make images >>>>>>> >>>>>>> when running basic tests by ` make run-test-tier1`, it occurs the >>>>>> following error: >>>>>>> 1>. >>>>>>> ----------configuration:(0/0)---------- >>>>>>> ----------rerun:(4/539)*---------- >>>>>>> cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/ >>>>>> linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier >>>>>> 1/ >>>>>> scratch/2 >>>>>> && \\ >>>>>>> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >>>>>>> -classpath \\ >>>>>>> org.openjdk.asmtools.jasm.Main -d >>>>>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-nor >>>>>>> ma >>>>>>> l- >>>>>>> server-release/test-support/jtreg_test_jdk_tier1/classes/1/jdk/int >>>>>>> er na l/reflect/constantPool/ConstantPoolTest.d >>>>>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/ >>>>>>> re fl ect/constantPool/ConstantPoolTestDummy.jasm >>>>>>> result: Error. can't find jasm >>>>>>> test result: Error. can't find jasm >>>>>>> >>>>>>> 2>. can't find jcoder >>>>>>> tools/javac/T6435291/T6435291.java: javac shouldn't throw NPE >>>>>>> while compiling invalid RuntimeInvisibleParameterAnnotations >>>>>>> 3>. Execution failed: `main' threw exception: >>>>>>> 3>java.lang.reflect.InvocationTargetException >>>>>>> jdk/javadoc/doclet/testIOException/TestIOException.java: test >>>>>>> IOException handling >>>>>>> >>>>>>> 4>.============================== >>>>>>> Test summary >>>>>>> ============================== >>>>>>> TEST TOTAL PASS FAIL >>>>>> ERROR >>>>>>>>> jtreg:test/jdk:tier1 1657 1656 0 >>>>>> 1 << >>>>>>>>> jtreg:test/langtools:tier1 3826 3814 1 >>>>>> 11 << >>>>>>> jtreg:test/nashorn:tier1 0 0 0 >>>>>> 0 >>>>>>> jtreg:test/jaxp:tier1 0 0 0 >>>>>> 0 >>>>>>> ============================== >>>>>>> TEST FAILURE >>>>>>> >>>>>>> ps: I've configured the jtreg[1] by seting JT_HOME and >>>>>>> jtharness[2] by >>>>>> seting JTHARNESS_HOME. >>>>>>> I've found the asm lib ,but >>>>>>> how to >>>>>> configure it ? >>>>>>> Is there any configuration or dependencies to be set? >>>>>>> >>>>>>> [1] >>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBui >>>>>>> ld >>>>>>> /a >>>>>>> rtifact/ [2] >>>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfu >>>>>>> lB >>>>>>> ui >>>>>>> ld/artifact/ >>>>>>> >>>>>>> Best Regards! >>>>>>> VicWang | R&D >>>>>>> Telephone:+86-01082695388-892477 >>>>>>> >>>>>>> >>>>>>> -----????----- >>>>>>> ???: Volker Simonis [mailto:volker.simonis at gmail.com] >>>>>>> ????: 2017?12?6? 17:30 >>>>>>> ???: Weijun Wang >>>>>>> ??: Vic Wang(BJ-RD); jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>>>>>> ??: Re: inquiry how to submit a change >>>>>>> >>>>>>> On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang >>>>>>> >>>>>> wrote: >>>>>>>> >>>>>>>>> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) >>>>>>>>> >>>>>> wrote: >>>>>>>>> requesting all changes >>>>>>>>> adding changesets >>>>>>>>> transaction abort! >>>>>>>>> rollback completed >>>>>>>>> abort: stream ended unexpectedly (got 6 bytes, >>>>>>>>> expected 80) >>>>>>>> Looks like a network problem, I've seen this before. Please try >>>>>>>> again. >>>>>>>> >>>>>>> Yes, that's usually because of slow network. >>>>>>> >>>>>>> You can try to add: >>>>>>> >>>>>>> [ui] >>>>>>> ssh = ssh -C >>>>>>> >>>>>>> to your .hgrc. Somtimes it helps :) >>>>>>> >>>>>>>>> I find it need a username which is configured in >>>>>>>>> ~/.bashrc. >>>>>>>>> Is >>>>>> the username is necessary? How to assign a username? >>>>>>>> I don't think a username is needed to pull the repository. >>>>>>>> >>>>>>>> --Max >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> ????? >>>>>>> ????????????????????????????????? >>>>>>> ???????????????????? >>>>>>> CONFIDENTIAL NOTE: >>>>>>> This email contains confidential or legally privileged information >>>>>>> and >>>>>> is for the sole use of its intended recipient. Any unauthorized >>>>>> review, use, copying or forwarding of this email or the content of >>>>>> this email is strictly prohibited. >>>>>> >>>>>> >>>>>> >>>>>> ????? >>>>>> ????????????????????????????????? >>>>>> ???????????????????? >>>>>> CONFIDENTIAL NOTE: >>>>>> This email contains confidential or legally privileged information >>>>>> and is for the sole use of its intended recipient. Any unauthorized >>>>>> review, use, copying or forwarding of this email or the content of >>>>>> this email is strictly prohibited. >>>>>> >>>> >>>> ????? >>>> ?????????????????????????????????? >>>> ??????????????????? >>>> CONFIDENTIAL NOTE: >>>> This email contains confidential or legally privileged information >>>> and is for the sole use of its intended recipient. Any unauthorized >>>> review, use, copying or forwarding of this email or the content of >>>> this email is strictly prohibited. >>>> >> >> >> ????? >> ?????????????????????????????????? >> ??????????????????? >> CONFIDENTIAL NOTE: >> This email contains confidential or legally privileged information >> and is for the sole use of its intended recipient. Any unauthorized >> review, use, copying or forwarding of this email or the content of >> this email is strictly prohibited. > From jonathan.gibbons at oracle.com Thu Dec 21 00:54:59 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 20 Dec 2017 16:54:59 -0800 Subject: =?UTF-8?B?562U5aSNOiDnrZTlpI06IOetlOWkjTogaW5xdWlyeSBob3cgdG8=?= =?UTF-8?B?IHN1Ym1pdCBhIGNoYW5nZQ==?= In-Reply-To: References: <53CB4C39-F0BE-4474-9549-F94B12600A60@oracle.com> <67a8fbed1c1b468ebc52f9a40a958ca3@zhaoxin.com> <79E88FFE-20EF-4799-B4E9-97D3D383C0C1@oracle.com> <5A39ACDF.3050009@oracle.com> Message-ID: <5A3B0663.5070608@oracle.com> Vic, I have found the root case of the problem. The hint was in your earlier message, when you said: > Hi Weijun : > There is not a asmtools.jar in jtreg/lib. How can I get it? > The web< http://openjdk.java.net/code-tools/asmtools> can't access (it return `404 Not Found`). > Thanks very much. The issue is that the Adopt OpenJDK build of jtreg does not include asmtools.jar for some reason. It is not enough to fix this by just putting a copy of asmtools.jar in the jtreg/lib directory. It also needs to be added to the Class-Path entry in the MANIFEST.MF entry in the jtreg.jar file. This will happen automatically if jtreg is built with ASMTOOLS_HOME defined appropriately. While you can patch this up manually, it would be better to work with the Adopt OpenJDK group to get their binaries fixed. And, somewhat by coincidence, we've just promoted a new version of jtreg, so that should soon trigger a new build of jtreg (jtreg 4.2 b11) on their CI system. You can also now try building jtreg yourself, using the latest easy build instructions. The short form instructions are: 1. Download the jtreg source from http://hg.openjdk.java.net/code-tools/jtreg 2. Make sure you have a recent version of Ant, and a recent version of JDK (such as JDK 7 or JDK 8) on your execution path 3. `cd` to the root directory of the jtreg source you downloaded 4. `sh make/build-all.sh JDK_HOME` where JDK_HOME is the install directory for a recent version of JDK 5. The jtreg build will be in build/images/jtreg See http://openjdk.java.net/jtreg/build.html for more details. -- Jon On 12/19/2017 10:37 PM, Vic Wang(BJ-RD) wrote: > Dear Jonathan: > > I've downloaded jtreg-4.2-b10.tar.gz, it still occurred "can't find jasm" error. > > Can you help me try this? Just run TEST=" test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTest.java ". > > First, you have already built jdk images. Then, > $cd the jdk repository dir. > $bash configure --with-jtreg=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg --with-boot-jdk=/home/vic/Desktop/JVM/jdk-9.0.1 #please change your jtreg home dir and boot-jdk dir. > $ make run-test TEST="test/jdk/jdk/internal/reflect/constantPool/ConstantPoolTest.java" > > Then , it occurs " can't find jasm" error. > Thanks very much. > > Best Regards! > VicWang | R&D > Telephone:+86-01082695388-892477 > > > -----????----- > ???: Jonathan Gibbons [mailto:jonathan.gibbons at oracle.com] > ????: 2017?12?20? 8:21 > ???: David Holmes ; Vic Wang(BJ-RD) ; Ao Qi ; Weijun Wang > ??: jdk8u-dev at openjdk.java.net; jtreg-use at openjdk.java.net > ??: Re: ??: ??: inquiry how to submit a change > > Vic, Ao Qi, et al, > > The recommended place to get the latest builds of jtreg is from the Adopt OpenJDK group, here: > > https://ci.adoptopenjdk.net/view/Dependencies/job/jtreg/ > > Of the two builds there, I recommend jtreg-4.2-b10.tar.gz. This build contains all the necessary components, including asmtools.jar. > > (The other build is a build of the development "tip", and is not recommended for general use.) > > -- Jon > > > On 12/19/2017 03:42 AM, David Holmes wrote: >> cc'ing jtreg-use. Sorry I've no idea how to put these tools together >> externally. >> >> David >> >> On 19/12/2017 9:08 PM, Vic Wang(BJ-RD) wrote: >>> Hi David, Ao Qi & Weijun: >>> I've downloaded the asmtools.jar and put it in jtreg/lib dir. And set >>> the following environment variables. >>> export JT_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg >>> export >>> JTHARNESS_HOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtharnes >>> s >>> export >>> ASMTOOLSHOME=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/asmtools-6 >>> .0/lib >>> >>> however, when running the test command, it still occurred "can't find >>> jasm" error. >>> The test command is : make run-test TEST="jtreg:test/jdk:tier1". >>> >>> Additional, as I want to submit a change for jdk repository, should I >>> pass the basic run test firstly ? >>> The following is the detailed results for the error. Thanks very much. >>> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< >>> #-----testresult----- >>> description=file\:/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jd >>> k/jdk/internal/reflect/constantPool/ConstantPoolTest.java >>> >>> elapsed=1333 0\:00\:01.333 >>> end=Tue Dec 19 17\:57\:20 CST 2017 >>> environment=regtest >>> execStatus=Error. can't find jasm >>> harnessLoaderMode=Classpath Loader >>> harnessVariety=Full Bundle >>> hostname=vic-os >>> javatestOS=Linux 3.16.4 (amd64) >>> javatestVersion=5.0 >>> jtregVersion=jtreg 4.2 dev b09 >>> modules=java.base/jdk.internal.misc java.base/jdk.internal.reflect >>> script=com.sun.javatest.regtest.exec.RegressionScript >>> sections=script_messages compile >>> start=Tue Dec 19 17\:57\:18 CST 2017 >>> test=jdk/internal/reflect/constantPool/ConstantPoolTest.java >>> testJDK=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_6 >>> 4-normal-server-release/images/jdk >>> >>> totalTime=1370 >>> user.name=root >>> work=/home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-n >>> ormal-server-release/test-support/jtreg_test_jdk_tier1/jdk/internal/r >>> eflect/constantPool >>> >>> >>> #section:script_messages >>> ----------messages:(7/577)---------- >>> JDK under test: >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >>> -server-release/images/jdk >>> openjdk version "10-internal" >>> OpenJDK Runtime Environment (build 10-internal+0-adhoc.root.jdk) >>> OpenJDK 64-Bit Server VM (build 10-internal+0-adhoc.root.jdk, mixed >>> mode) >>> Library /lib/testlibrary; kind: packages >>> source directory: >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/lib/testlibrary >>> class directory: >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >>> -server-release/test-support/jtreg_test_jdk_tier1/classes/2/lib/testl >>> ibrary >>> >>> #section:compile >>> ----------messages:(3/232)---------- >>> command: compile >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/ref >>> lect/constantPool/ConstantPoolTestDummy.jasm >>> reason: User specified action: run compile ConstantPoolTestDummy.jasm >>> elapsed time (seconds): 1.097 >>> ----------configuration:(0/0)---------- >>> ----------rerun:(4/607)*---------- >>> cd >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >>> -server-release/test-support/jtreg_test_jdk_tier1/scratch/0 >>> && \\ >>> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >>> -classpath >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jtreg/jtreg/lib/asmtools.jar \\ >>> org.openjdk.asmtools.jasm.Main -d >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-normal >>> -server-release/test-support/jtreg_test_jdk_tier1/classes/2/jdk/inter >>> nal/reflect/constantPool/ConstantPoolTest.d >>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/ref >>> lect/constantPool/ConstantPoolTestDummy.jasm >>> >>> result: Error. can't find jasm >>> >>> >>> test result: Error. can't find jasm >>> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< >>> >>> Best Regards! >>> VicWang | R&D >>> Telephone:+86-01082695388-892477 >>> >>> >>> -----????----- >>> ???: David Holmes [mailto:david.holmes at oracle.com] >>> ????: 2017?12?15? 15:52 >>> ???: Ao Qi ; Vic Wang(BJ-RD) >>> ??: jdk8u-dev at openjdk.java.net >>> ??: Re: ??: inquiry how to submit a change >>> >>> See: >>> >>> http://hg.openjdk.java.net/code-tools/ >>> >>> for all projects. >>> >>> David >>> >>> On 15/12/2017 2:46 PM, Ao Qi wrote: >>>> Hi Vic, >>>> >>>> Hoping this helps: >>>> https://adopt-openjdk.ci.cloudbees.com/view/OpenJDK/job/asmtools/ >>>> >>>> Ao Qi >>>> 12.15 >>>> >>>> 2017-12-15 12:34 GMT+08:00 Vic Wang(BJ-RD) : >>>> >>>>> Hi Weijun : >>>>> There is not a asmtools.jar in jtreg/lib. How can I get it? >>>>> The web < http://openjdk.java.net/code-tools/asmtools> can't access >>>>> (it return `404 Not Found`). >>>>> Thanks very much. >>>>> >>>>> >>>>> Best Regards! >>>>> VicWang | R&D >>>>> Telephone:+86-01082695388-892477 >>>>> >>>>> -----????----- >>>>> ???: Weijun Wang [mailto:weijun.wang at oracle.com] >>>>> ????: 2017?12?15? 11:42 >>>>> ???: Vic Wang(BJ-RD) >>>>> ??: Volker Simonis ; >>>>> jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>>>> ??: Re: inquiry how to submit a change >>>>> >>>>> Hi Vic >>>>> >>>>> I do not run test this way (I either run a single one with jtreg >>>>> directly or use our internal CI to run a tier) so I am not sure >>>>> where the problem is. >>>>> >>>>> As for jasm, There is a asmtools.jar in jtreg/lib. Do you have it? >>>>> >>>>> Thanks >>>>> Max >>>>> >>>>>> On Dec 15, 2017, at 11:01 AM, Vic Wang(BJ-RD) >>>>>> >>>>> wrote: >>>>>> Dear Volker/Weijun: >>>>>> Thanks for your help. >>>>>> I've already clone the jdk ,hs ,client repository. >>>>>> >>>>>> Now I've built jdk success by executing the following command: >>>>>> First, I configure JDK9 environment path, Then, bash configure >>>>>> make images >>>>>> >>>>>> when running basic tests by ` make run-test-tier1`, it occurs the >>>>> following error: >>>>>> 1>. >>>>>> ----------configuration:(0/0)---------- >>>>>> ----------rerun:(4/539)*---------- >>>>>> cd /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/ >>>>> linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_tier >>>>> 1/ >>>>> scratch/2 >>>>> && \\ >>>>>> /home/vic/Desktop/JVM/jdk-9.0.1/bin/java \\ >>>>>> -classpath \\ >>>>>> org.openjdk.asmtools.jasm.Main -d >>>>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/build/linux-x86_64-nor >>>>>> ma >>>>>> l- >>>>>> server-release/test-support/jtreg_test_jdk_tier1/classes/1/jdk/int >>>>>> er na l/reflect/constantPool/ConstantPoolTest.d >>>>>> /home/vic/Desktop/JVM/sourcecode/tmp/hg/jdk/test/jdk/jdk/internal/ >>>>>> re fl ect/constantPool/ConstantPoolTestDummy.jasm >>>>>> result: Error. can't find jasm >>>>>> test result: Error. can't find jasm >>>>>> >>>>>> 2>. can't find jcoder >>>>>> tools/javac/T6435291/T6435291.java: javac shouldn't throw NPE >>>>>> while compiling invalid RuntimeInvisibleParameterAnnotations >>>>>> 3>. Execution failed: `main' threw exception: >>>>>> 3>java.lang.reflect.InvocationTargetException >>>>>> jdk/javadoc/doclet/testIOException/TestIOException.java: test >>>>>> IOException handling >>>>>> >>>>>> 4>.============================== >>>>>> Test summary >>>>>> ============================== >>>>>> TEST TOTAL PASS FAIL >>>>> ERROR >>>>>>>> jtreg:test/jdk:tier1 1657 1656 0 >>>>> 1 << >>>>>>>> jtreg:test/langtools:tier1 3826 3814 1 >>>>> 11 << >>>>>> jtreg:test/nashorn:tier1 0 0 0 >>>>> 0 >>>>>> jtreg:test/jaxp:tier1 0 0 0 >>>>> 0 >>>>>> ============================== >>>>>> TEST FAILURE >>>>>> >>>>>> ps: I've configured the jtreg[1] by seting JT_HOME and >>>>>> jtharness[2] by >>>>> seting JTHARNESS_HOME. >>>>>> I've found the asm lib ,but >>>>>> how to >>>>> configure it ? >>>>>> Is there any configuration or dependencies to be set? >>>>>> >>>>>> [1] >>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/lastSuccessfulBui >>>>>> ld >>>>>> /a >>>>>> rtifact/ [2] >>>>>> https://adopt-openjdk.ci.cloudbees.com/job/jtharness/lastSuccessfu >>>>>> lB >>>>>> ui >>>>>> ld/artifact/ >>>>>> >>>>>> Best Regards! >>>>>> VicWang | R&D >>>>>> Telephone:+86-01082695388-892477 >>>>>> >>>>>> >>>>>> -----????----- >>>>>> ???: Volker Simonis [mailto:volker.simonis at gmail.com] >>>>>> ????: 2017?12?6? 17:30 >>>>>> ???: Weijun Wang >>>>>> ??: Vic Wang(BJ-RD); jdk8u-dev at openjdk.java.net; Cobe Chen(BJ-RD) >>>>>> ??: Re: inquiry how to submit a change >>>>>> >>>>>> On Wed, Dec 6, 2017 at 1:10 AM, Weijun Wang >>>>>> >>>>> wrote: >>>>>>> >>>>>>>> On Dec 6, 2017, at 4:14 PM, Vic Wang(BJ-RD) >>>>>>>> >>>>> wrote: >>>>>>>> requesting all changes >>>>>>>> adding changesets >>>>>>>> transaction abort! >>>>>>>> rollback completed >>>>>>>> abort: stream ended unexpectedly (got 6 bytes, >>>>>>>> expected 80) >>>>>>> Looks like a network problem, I've seen this before. Please try >>>>>>> again. >>>>>>> >>>>>> Yes, that's usually because of slow network. >>>>>> >>>>>> You can try to add: >>>>>> >>>>>> [ui] >>>>>> ssh = ssh -C >>>>>> >>>>>> to your .hgrc. Somtimes it helps :) >>>>>> >>>>>>>> I find it need a username which is configured in ~/.bashrc. >>>>>>>> Is >>>>> the username is necessary? How to assign a username? >>>>>>> I don't think a username is needed to pull the repository. >>>>>>> >>>>>>> --Max >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> ????? >>>>>> ????????????????????????????????? >>>>>> ???????????????????? >>>>>> CONFIDENTIAL NOTE: >>>>>> This email contains confidential or legally privileged information >>>>>> and >>>>> is for the sole use of its intended recipient. Any unauthorized >>>>> review, use, copying or forwarding of this email or the content of >>>>> this email is strictly prohibited. >>>>> >>>>> >>>>> >>>>> ????? >>>>> ????????????????????????????????? >>>>> ???????????????????? >>>>> CONFIDENTIAL NOTE: >>>>> This email contains confidential or legally privileged information >>>>> and is for the sole use of its intended recipient. Any unauthorized >>>>> review, use, copying or forwarding of this email or the content of >>>>> this email is strictly prohibited. >>>>> >>> >>> ????? >>> ?????????????????????????????????? >>> ??????????????????? >>> CONFIDENTIAL NOTE: >>> This email contains confidential or legally privileged information >>> and is for the sole use of its intended recipient. Any unauthorized >>> review, use, copying or forwarding of this email or the content of >>> this email is strictly prohibited. >>> > > > ????? > ????????????????????????????????????????????????????? > CONFIDENTIAL NOTE: > This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. From david.buck at oracle.com Thu Dec 21 11:32:39 2017 From: david.buck at oracle.com (David Buck) Date: Thu, 21 Dec 2017 20:32:39 +0900 Subject: [8u-dev] Request for enhancement backport approval for CR 8031304 -Add dcmd to print all loaded dynamic libraries Message-ID: <9420a6f2-1d59-6b54-8a33-7c4cb76a2850@oracle.com> Hi! Sean Coffey has explained in an off-channel conversation that this change will require an enhancement backport approval. Please consider the following enhancement for approval: bug report: https://bugs.openjdk.java.net/browse/JDK-8031304 This is an important serviceability improvement. Without this backport, there is no officially supported tool included in the JDK that allows the user to collect library information from the command line. I have run all the standard JPRT hotspot tests, run the testcase included in the changeset, and manually confirmed that the new diagnostic command works as expected. Cheers, -Buck From sean.coffey at oracle.com Thu Dec 21 11:36:10 2017 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 21 Dec 2017 11:36:10 +0000 Subject: [8u-dev] Request for enhancement backport approval for CR 8031304 -Add dcmd to print all loaded dynamic libraries In-Reply-To: <9420a6f2-1d59-6b54-8a33-7c4cb76a2850@oracle.com> References: <9420a6f2-1d59-6b54-8a33-7c4cb76a2850@oracle.com> Message-ID: Thanks Buck. I'll get back to you on this one shortly. regards, Sean. On 21/12/2017 11:32, David Buck wrote: > Hi! > > Sean Coffey has explained in an off-channel conversation that this > change will require an enhancement backport approval. Please consider > the following enhancement for approval: > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8031304 > > This is an important serviceability improvement. Without this > backport, there is no officially supported tool included in the JDK > that allows the user to collect library information from the command > line. I have run all the standard JPRT hotspot tests, run the testcase > included in the changeset, and manually confirmed that the new > diagnostic command works as expected. > > Cheers, > -Buck > From david.buck at oracle.com Thu Dec 21 12:13:00 2017 From: david.buck at oracle.com (David Buck) Date: Thu, 21 Dec 2017 21:13:00 +0900 Subject: [8u-dev] Request for enhancement backport approval for CR 8044107 - Add Diagnostic Command to list all ClassLoaders Message-ID: <011ad46a-8e9c-1bb4-33f3-6bdbbc1bd1e9@oracle.com> Hi! Please consider the following enhancement for approval: bug report: https://bugs.openjdk.java.net/browse/JDK-8044107 This is an important serviceability improvement. Without this backport, there is no officially supported tool included in the JDK that allows the user to collect classloader information from the command line. I have run all the standard JPRT hotspot tests, run the testcase included in the changeset, and manually confirmed that the new diagnostic command works as expected. The change itself is extremely small and safe. I believe any risk posed by including this in JDK 8 is negligible. Cheers, -Buck From sean.coffey at oracle.com Thu Dec 21 23:43:26 2017 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 21 Dec 2017 23:43:26 +0000 Subject: [8u-dev] Request for enhancement backport approval for CR 8031304 -Add dcmd to print all loaded dynamic libraries In-Reply-To: References: <9420a6f2-1d59-6b54-8a33-7c4cb76a2850@oracle.com> Message-ID: <5765f46a-19a0-6e44-547a-d6b762280558@oracle.com> Approved for backporting to JDK 8u. regards, Sean. On 21/12/2017 11:36, Se?n Coffey wrote: > Thanks Buck. I'll get back to you on this one shortly. > > regards, > Sean. > > On 21/12/2017 11:32, David Buck wrote: >> Hi! >> >> Sean Coffey has explained in an off-channel conversation that this >> change will require an enhancement backport approval. Please consider >> the following enhancement for approval: >> >> bug report: >> https://bugs.openjdk.java.net/browse/JDK-8031304 >> >> This is an important serviceability improvement. Without this >> backport, there is no officially supported tool included in the JDK >> that allows the user to collect library information from the command >> line. I have run all the standard JPRT hotspot tests, run the >> testcase included in the changeset, and manually confirmed that the >> new diagnostic command works as expected. >> >> Cheers, >> -Buck >> > From sean.coffey at oracle.com Thu Dec 21 23:43:42 2017 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 21 Dec 2017 23:43:42 +0000 Subject: [8u] RFA 8031304 : Add dcmd to print all loaded dynamic libraries In-Reply-To: References: Message-ID: Approved. regards, Sean. On 20/12/2017 22:21, David Buck wrote: > Hi! > > Please approve this serviceability backport to 8u-dev: > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8031304 > > JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/afa21611f918 > > JDK 9 review thread: > http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-January/013778.html > > > JDK 8 backport review thread: > http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-December/022677.html > > > JDK 8 backport webrev (already reviewed): > http://cr.openjdk.java.net/~dbuck/8031304_jdk8_ver00/ > > Cheers, > -Buck From sean.coffey at oracle.com Thu Dec 21 23:44:13 2017 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 21 Dec 2017 23:44:13 +0000 Subject: [8u-dev] Request for enhancement backport approval for CR 8044107 - Add Diagnostic Command to list all ClassLoaders In-Reply-To: <011ad46a-8e9c-1bb4-33f3-6bdbbc1bd1e9@oracle.com> References: <011ad46a-8e9c-1bb4-33f3-6bdbbc1bd1e9@oracle.com> Message-ID: Approved for porting. regards, Sean. On 21/12/2017 12:13, David Buck wrote: > Hi! > > Please consider the following enhancement for approval: > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8044107 > > This is an important serviceability improvement. Without this > backport, there is no officially supported tool included in the JDK > that allows the user to collect classloader information from the > command line. I have run all the standard JPRT hotspot tests, run the > testcase included in the changeset, and manually confirmed that the > new diagnostic command works as expected. The change itself is > extremely small and safe. I believe any risk posed by including this > in JDK 8 is negligible. > > Cheers, > -Buck From christoph.langer at sap.com Fri Dec 22 10:39:27 2017 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 22 Dec 2017 10:39:27 +0000 Subject: Request for approval 8193807: avoid UnsatisfiedLinkError by providing empty basic implementations of getSystemCpuLoad and getProcessCpuLoad Message-ID: Hi, please approve this fix for jdk8u: Change: http://cr.openjdk.java.net/~mbaesken/webrevs/8193807/ Bug: https://bugs.openjdk.java.net/browse/JDK-8193807 It has been reviewed in this thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-December/050694.html Thanks & Best regards Christoph From sean.coffey at oracle.com Fri Dec 22 11:18:45 2017 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 22 Dec 2017 11:18:45 +0000 Subject: [8u-dev] Request for approval : 8054213 :Class name repeated in output of Type.toString() Message-ID: <9f0dcf71-578c-a4a3-6121-fba374ec297e@oracle.com> I'd like to fix the following in JDK 8 Updates. The 9 patch backports cleanly post path unshuffling. https://bugs.openjdk.java.net/browse/JDK-8054213 http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/74e3d247a5f2 -- Regards, Sean. From sean.coffey at oracle.com Fri Dec 22 11:15:02 2017 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 22 Dec 2017 11:15:02 +0000 Subject: Request for approval 8193807: avoid UnsatisfiedLinkError by providing empty basic implementations of getSystemCpuLoad and getProcessCpuLoad In-Reply-To: References: Message-ID: Christoph, * can you link this bug to JDK-8079510 ? I believe they're related. * can you add a suitable noreg- label to the bug report * can you add 9-na to the bug report. In some respect, this may have been better done by backporting JDK-8079510 but I think your current approach is ok also. Approved for jdk8u-dev once the above is done. Regards, Sean. On 22/12/17 10:39, Langer, Christoph wrote: > Hi, > > please approve this fix for jdk8u: > > Change: http://cr.openjdk.java.net/~mbaesken/webrevs/8193807/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8193807 > > It has been reviewed in this thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-December/050694.html > > Thanks & Best regards > Christoph > From david.buck at oracle.com Fri Dec 22 13:10:30 2017 From: david.buck at oracle.com (David Buck) Date: Fri, 22 Dec 2017 22:10:30 +0900 Subject: [8u] RFA 8044107 : Add Diagnostic Command to list all ClassLoaders Message-ID: <996e6bf2-101f-94fc-7400-0f2c6a5e63c3@oracle.com> Hi! Please approve the push of this backport to 8u-dev. The change has been reviewed and the necessary enhancement approval has been obtained. bug report: https://bugs.openjdk.java.net/browse/JDK-8044107 JDK 8 backport code review: http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-December/029655.html enhancement backport approval: http://mail.openjdk.java.net/pipermail/jdk8u-dev/2017-December/007145.html Cheers, -Buck From christoph.langer at sap.com Fri Dec 22 13:34:10 2017 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 22 Dec 2017 13:34:10 +0000 Subject: Request for approval 8193807: avoid UnsatisfiedLinkError by providing empty basic implementations of getSystemCpuLoad and getProcessCpuLoad In-Reply-To: References: Message-ID: <30bcc40f9dd9411bb249d2d555a3251a@sap.com> Thanks, Sean. I added the labels and also linked to 8079510. The colleagues wanted to keep it separate as it differs quite significantly to 8079510 due to the different JDK8 repo structure. @Volker: please push it. Best regards Christoph -----Original Message----- From: Se?n Coffey [mailto:sean.coffey at oracle.com] Sent: Freitag, 22. Dezember 2017 12:15 To: Langer, Christoph ; jdk8u-dev at openjdk.java.net; Baesken, Matthias Subject: Re: Request for approval 8193807: avoid UnsatisfiedLinkError by providing empty basic implementations of getSystemCpuLoad and getProcessCpuLoad Christoph, * can you link this bug to JDK-8079510 ? I believe they're related. * can you add a suitable noreg- label to the bug report * can you add 9-na to the bug report. In some respect, this may have been better done by backporting JDK-8079510 but I think your current approach is ok also. Approved for jdk8u-dev once the above is done. Regards, Sean. On 22/12/17 10:39, Langer, Christoph wrote: > Hi, > > please approve this fix for jdk8u: > > Change: http://cr.openjdk.java.net/~mbaesken/webrevs/8193807/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8193807 > > It has been reviewed in this thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-December/050694.html > > Thanks & Best regards > Christoph > From david.buck at oracle.com Fri Dec 22 12:56:20 2017 From: david.buck at oracle.com (David Buck) Date: Fri, 22 Dec 2017 21:56:20 +0900 Subject: [8u-dev] Request for approval : 8054213 :Class name repeated in output of Type.toString() In-Reply-To: <9f0dcf71-578c-a4a3-6121-fba374ec297e@oracle.com> References: <9f0dcf71-578c-a4a3-6121-fba374ec297e@oracle.com> Message-ID: <25399883-bfaa-a324-90a7-285262c1cac0@oracle.com> approved for backport to 8u-dev Cheers, -Buck On 2017/12/22 20:18, Se?n Coffey wrote: > I'd like to fix the following in JDK 8 Updates. The 9 patch backports > cleanly post path unshuffling. > > https://bugs.openjdk.java.net/browse/JDK-8054213 > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/74e3d247a5f2 > From sean.coffey at oracle.com Fri Dec 22 13:53:43 2017 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 22 Dec 2017 13:53:43 +0000 Subject: [8u] RFA 8044107 : Add Diagnostic Command to list all ClassLoaders In-Reply-To: <996e6bf2-101f-94fc-7400-0f2c6a5e63c3@oracle.com> References: <996e6bf2-101f-94fc-7400-0f2c6a5e63c3@oracle.com> Message-ID: Approved. Regards, Sean. On 22/12/17 13:10, David Buck wrote: > Hi! > > Please approve the push of this backport to 8u-dev. The change has > been reviewed and the necessary enhancement approval has been obtained. > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8044107 > > JDK 8 backport code review: > http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-December/029655.html > > > enhancement backport approval: > http://mail.openjdk.java.net/pipermail/jdk8u-dev/2017-December/007145.html > > > Cheers, > -Buck From VicWang at zhaoxin.com Wed Dec 27 08:31:28 2017 From: VicWang at zhaoxin.com (Vic Wang(BJ-RD)) Date: Wed, 27 Dec 2017 08:31:28 +0000 Subject: [patch] support zhaoxin x86 cpu vendor ids CentaulHauls and Shanghai Message-ID: Hi, Here is a patch for supporting zhaoxin x86 cpu vendor ids (CentaurHauls id and Shanghai id). The original repository is http://hg.openjdk.java.net/jdk/jdk. Please help me to submit the changes . If there is anything incorrectly, please let me know. Thank you very much. The following is the changeset by the diff command. diff -Nur org/jdk/src/hotspot/cpu/x86/assembler_x86.cpp zx/jdk/src/hotspot/cpu/x86/assembler_x86.cpp --- org/jdk/src/hotspot/cpu/x86/assembler_x86.cpp2017-12-07 09:48:50.000000000 +0800 +++ zx/jdk/src/hotspot/cpu/x86/assembler_x86.cpp2017-12-27 15:03:43.000000000 +0800 @@ -3167,6 +3167,89 @@ return; } + if (UseAddressNop && VM_Version::is_zx()) { + // + // Using multi-bytes nops "0x0F 0x1F [address]" for ZX + // 1: 0x90 + // 2: 0x66 0x90 + // 3: 0x66 0x66 0x90 (don't use "0x0F 0x1F 0x00" - need patching safe padding) + // 4: 0x0F 0x1F 0x40 0x00 + // 5: 0x0F 0x1F 0x44 0x00 0x00 + // 6: 0x66 0x0F 0x1F 0x44 0x00 0x00 + // 7: 0x0F 0x1F 0x80 0x00 0x00 0x00 0x00 + // 8: 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 + // 9: 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 + // 10: 0x66 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 + // 11: 0x66 0x66 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 + + // The rest coding is ZX specific - don't use consecutive address nops + + // 12: 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 0x66 0x66 0x66 0x90 + // 13: 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 0x66 0x66 0x66 0x90 + // 14: 0x66 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 0x66 0x66 0x66 0x90 + // 15: 0x66 0x66 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 0x66 0x66 0x66 0x90 + + while(i >= 15) { + // For ZX don't generate consecutive addess nops (mix with regular nops) + i -= 15; + emit_int8(0x66); // size prefix + emit_int8(0x66); // size prefix + emit_int8(0x66); // size prefix + addr_nop_8(); + emit_int8(0x66); // size prefix + emit_int8(0x66); // size prefix + emit_int8(0x66); // size prefix + emit_int8((unsigned char)0x90); + // nop + } + switch (i) { + case 14: + emit_int8(0x66); // size prefix + case 13: + emit_int8(0x66); // size prefix + case 12: + addr_nop_8(); + emit_int8(0x66); // size prefix + emit_int8(0x66); // size prefix + emit_int8(0x66); // size prefix + emit_int8((unsigned char)0x90); + // nop + break; + case 11: + emit_int8(0x66); // size prefix + case 10: + emit_int8(0x66); // size prefix + case 9: + emit_int8(0x66); // size prefix + case 8: + addr_nop_8(); + break; + case 7: + addr_nop_7(); + break; + case 6: + emit_int8(0x66); // size prefix + case 5: + addr_nop_5(); + break; + case 4: + addr_nop_4(); + break; + case 3: + // Don't use "0x0F 0x1F 0x00" - need patching safe padding + emit_int8(0x66); // size prefix + case 2: + emit_int8(0x66); // size prefix + case 1: + emit_int8((unsigned char)0x90); + // nop + break; + default: + assert(i == 0, " "); + } + return; + } + // Using nops with size prefixes "0x66 0x90". // From AMD Optimization Guide: // 1: 0x90 diff -Nur org/jdk/src/hotspot/cpu/x86/vm_version_x86.cpp zx/jdk/src/hotspot/cpu/x86/vm_version_x86.cpp --- org/jdk/src/hotspot/cpu/x86/vm_version_x86.cpp2017-12-22 19:59:09.000000000 +0800 +++ zx/jdk/src/hotspot/cpu/x86/vm_version_x86.cpp2017-12-26 13:28:57.000000000 +0800 @@ -628,6 +628,11 @@ if (UseSSE < 1) _features &= ~CPU_SSE; + //since AVX instructions is slower than SSE in some ZX cpus, force USEAVX=0. + if(is_zx() && ((cpu_family()==6)||(cpu_family()==7))){ +UseAVX = 0; + } + // first try initial setting and detect what we can support if (UseAVX > 0) { if (UseAVX > 2 && supports_evex()) { @@ -1057,6 +1062,66 @@ // UseXmmRegToRegMoveAll == true --> movaps(xmm, xmm), movapd(xmm, xmm). // UseXmmRegToRegMoveAll == false --> movss(xmm, xmm), movsd(xmm, xmm). + + if( is_zx() ) { // ZX cpus specific settings + if( FLAG_IS_DEFAULT(UseStoreImmI16) ) { + UseStoreImmI16 = false; // don't use it on ZX cpus + } + if( (cpu_family() == 6)|| (cpu_family() == 7) ) { + if( FLAG_IS_DEFAULT(UseAddressNop) ) { + // Use it on all ZX cpus + UseAddressNop = true; + } + } + if( FLAG_IS_DEFAULT(UseXmmLoadAndClearUpper) ) { + UseXmmLoadAndClearUpper = true; // use movsd on all ZX cpus + } + if( FLAG_IS_DEFAULT(UseXmmRegToRegMoveAll) ) { + if( supports_sse3() ) { + UseXmmRegToRegMoveAll = true; // use movaps, movapd on new ZX cpus + } else { + UseXmmRegToRegMoveAll = false; + } + } + if( ((cpu_family() == 6)||(cpu_family() == 7)) && supports_sse3() ) { // new ZX cpus +#ifdef COMPILER2 + if( FLAG_IS_DEFAULT(MaxLoopPad) ) { + // For new ZX cpus do the next optimization: + // don't align the beginning of a loop if there are enough instructions + // left (NumberOfLoopInstrToAlign defined in c2_globals.hpp) + // in current fetch line (OptoLoopAlignment) or the padding + // is big (> MaxLoopPad). + // Set MaxLoopPad to 11 for new ZX cpus to reduce number of + // generated NOP instructions. 11 is the largest size of one + // address NOP instruction '0F 1F' (see Assembler::nop(i)). + MaxLoopPad = 11; + } +#endif // COMPILER2 + if (FLAG_IS_DEFAULT(UseXMMForArrayCopy)) { + UseXMMForArrayCopy = true; // use SSE2 movq on new ZX cpus + } + if (supports_sse4_2()) { // new ZX cpus + if (FLAG_IS_DEFAULT(UseUnalignedLoadStores)) { + UseUnalignedLoadStores = true; // use movdqu on newest ZX cpus + } + } + if (supports_sse4_2()) { + if (FLAG_IS_DEFAULT(UseSSE42Intrinsics)) { + FLAG_SET_DEFAULT(UseSSE42Intrinsics, true); + } + } else { + if (UseSSE42Intrinsics && !FLAG_IS_DEFAULT(UseAESIntrinsics)) { + warning("SSE4.2 intrinsics require SSE4.2 instructions or higher. Intrinsics will be disabled."); + } + FLAG_SET_DEFAULT(UseSSE42Intrinsics, false); + } + } + + if(FLAG_IS_DEFAULT(AllocatePrefetchInstr) && supports_3dnow_prefetch()) { + FLAG_SET_DEFAULT(AllocatePrefetchInstr, 3); + } + } + if( is_amd() ) { // AMD cpus specific settings if( supports_sse2() && FLAG_IS_DEFAULT(UseAddressNop) ) { // Use it on new AMD cpus starting from Opteron. @@ -1349,6 +1414,14 @@ #ifdef COMPILER2 if (FLAG_IS_DEFAULT(UseFPUForSpilling) && supports_sse4_2()) { FLAG_SET_DEFAULT(UseFPUForSpilling, true); + } +#endif + } + + if (is_zx() && ((cpu_family() == 6)||(cpu_family() == 7)) && supports_sse3()) { +#ifdef COMPILER2 + if (FLAG_IS_DEFAULT(UseFPUForSpilling) && supports_sse4_2()) { + FLAG_SET_DEFAULT(UseFPUForSpilling, true); } #endif } diff -Nur org/jdk/src/hotspot/cpu/x86/vm_version_x86.hpp zx/jdk/src/hotspot/cpu/x86/vm_version_x86.hpp --- org/jdk/src/hotspot/cpu/x86/vm_version_x86.hpp2017-12-07 09:48:50.000000000 +0800 +++ zx/jdk/src/hotspot/cpu/x86/vm_version_x86.hpp2017-12-21 15:37:33.000000000 +0800 @@ -305,6 +305,9 @@ enum Extended_Family { // AMD CPU_FAMILY_AMD_11H = 0x11, + // ZX + CPU_FAMILY_ZX_CORE_F6 = 6, +CPU_FAMILY_ZX_CORE_F7 = 7, // Intel CPU_FAMILY_INTEL_CORE = 6, CPU_MODEL_NEHALEM = 0x1e, @@ -549,6 +552,16 @@ } } +// ZX features. + if(is_zx()) { + if(_cpuid_info.ext_cpuid1_ecx.bits.lzcnt_intel != 0) + result |= CPU_LZCNT; + // for ZX, ecx.bits.misalignsse bit (bit 8) indicates support for prefetchw + if (_cpuid_info.ext_cpuid1_ecx.bits.misalignsse != 0) { + result |= CPU_3DNOW_PREFETCH; + } + } + return result; } @@ -657,6 +670,7 @@ static bool is_P6() { return cpu_family() >= 6; } static bool is_amd() { assert_is_initialized(); return _cpuid_info.std_vendor_name_0 == 0x68747541; } // 'htuA' static bool is_intel() { assert_is_initialized(); return _cpuid_info.std_vendor_name_0 == 0x756e6547; } // 'uneG' + static bool is_zx() { assert_is_initialized(); return (_cpuid_info.std_vendor_name_0 == 0x746e6543)||(_cpuid_info.std_vendor_name_0 == 0x68532020); } // 'tneC'||'hS ' static bool is_atom_family() { return ((cpu_family() == 0x06) && ((extended_cpu_model() == 0x36) || (extended_cpu_model() == 0x37) || (extended_cpu_model() == 0x4D))); } //Silvermont and Centerton static bool is_knights_family() { return ((cpu_family() == 0x06) && ((extended_cpu_model() == 0x57) || (extended_cpu_model() == 0x85))); } // Xeon Phi 3200/5200/7200 and Future Xeon Phi @@ -680,7 +694,16 @@ } } else if (is_amd()) { result = (_cpuid_info.ext_cpuid8_ecx.bits.cores_per_cpu + 1); - } + } else if (is_zx()) { + bool supports_topology = supports_processor_topology(); + if (supports_topology) { + result = _cpuid_info.tpl_cpuidB1_ebx.bits.logical_cpus / + _cpuid_info.tpl_cpuidB0_ebx.bits.logical_cpus; + } + if (!supports_topology || result == 0) { + result = (_cpuid_info.dcp_cpuid4_eax.bits.cores_per_cpu + 1); + } +} return result; } @@ -688,7 +711,9 @@ uint result = 1; if (is_intel() && supports_processor_topology()) { result = _cpuid_info.tpl_cpuidB0_ebx.bits.logical_cpus; - } else if (_cpuid_info.std_cpuid1_edx.bits.ht != 0) { + } else if (is_zx() && supports_processor_topology()) { + result = _cpuid_info.tpl_cpuidB0_ebx.bits.logical_cpus; +} else if (_cpuid_info.std_cpuid1_edx.bits.ht != 0) { if (cpu_family() >= 0x17) { result = _cpuid_info.ext_cpuid1E_ebx.bits.threads_per_core + 1; } else { @@ -705,7 +730,9 @@ result = (_cpuid_info.dcp_cpuid4_ebx.bits.L1_line_size + 1); } else if (is_amd()) { result = _cpuid_info.ext_cpuid5_ecx.bits.L1_line_size; - } + } else if (is_zx()) { + result = (_cpuid_info.dcp_cpuid4_ebx.bits.L1_line_size + 1); +} if (result < 32) // not defined ? result = 32; // 32 bytes by default on x86 and other x64 return result; Finally, running the jtreg test. I run 2 jtreg tests(jtreg:test/jdk:tier1 and jtreg:test/langtools:tier1) and both of them are pass. Best Regards! VicWang | R&D Telephone:+86-01082695388-892477 ????? ????????????????????????????????????????????????????? CONFIDENTIAL NOTE: This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. From david.holmes at oracle.com Thu Dec 28 00:12:06 2017 From: david.holmes at oracle.com (David Holmes) Date: Thu, 28 Dec 2017 10:12:06 +1000 Subject: [patch] support zhaoxin x86 cpu vendor ids CentaulHauls and Shanghai In-Reply-To: References: Message-ID: <7353ec44-667f-3520-df6b-32b60ff9a550@oracle.com> Hi, These are hotspot changes so should be done using http://hg.openjdk.java.net/jdk/hs and reviewed on hotspot-dev at openjdk.java.net, for pushing into JDK 11 (possibly JDK 10 if the case can be made for that). If a backport to 8u is desired then that would have to be taken up on the jdk8u-dev mailing list. Thanks, David On 27/12/2017 6:31 PM, Vic Wang(BJ-RD) wrote: > Hi, > Here is a patch for supporting zhaoxin x86 cpu vendor ids (CentaurHauls id and Shanghai id). The original repository is http://hg.openjdk.java.net/jdk/jdk. > Please help me to submit the changes . If there is anything incorrectly, please let me know. Thank you very much. > > The following is the changeset by the diff command. > > diff -Nur org/jdk/src/hotspot/cpu/x86/assembler_x86.cpp zx/jdk/src/hotspot/cpu/x86/assembler_x86.cpp > --- org/jdk/src/hotspot/cpu/x86/assembler_x86.cpp2017-12-07 09:48:50.000000000 +0800 > +++ zx/jdk/src/hotspot/cpu/x86/assembler_x86.cpp2017-12-27 15:03:43.000000000 +0800 > @@ -3167,6 +3167,89 @@ > return; > } > > + if (UseAddressNop && VM_Version::is_zx()) { > + // > + // Using multi-bytes nops "0x0F 0x1F [address]" for ZX > + // 1: 0x90 > + // 2: 0x66 0x90 > + // 3: 0x66 0x66 0x90 (don't use "0x0F 0x1F 0x00" - need patching safe padding) > + // 4: 0x0F 0x1F 0x40 0x00 > + // 5: 0x0F 0x1F 0x44 0x00 0x00 > + // 6: 0x66 0x0F 0x1F 0x44 0x00 0x00 > + // 7: 0x0F 0x1F 0x80 0x00 0x00 0x00 0x00 > + // 8: 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 > + // 9: 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 > + // 10: 0x66 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 > + // 11: 0x66 0x66 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 > + > + // The rest coding is ZX specific - don't use consecutive address nops > + > + // 12: 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 0x66 0x66 0x66 0x90 > + // 13: 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 0x66 0x66 0x66 0x90 > + // 14: 0x66 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 0x66 0x66 0x66 0x90 > + // 15: 0x66 0x66 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 0x66 0x66 0x66 0x90 > + > + while(i >= 15) { > + // For ZX don't generate consecutive addess nops (mix with regular nops) > + i -= 15; > + emit_int8(0x66); // size prefix > + emit_int8(0x66); // size prefix > + emit_int8(0x66); // size prefix > + addr_nop_8(); > + emit_int8(0x66); // size prefix > + emit_int8(0x66); // size prefix > + emit_int8(0x66); // size prefix > + emit_int8((unsigned char)0x90); > + // nop > + } > + switch (i) { > + case 14: > + emit_int8(0x66); // size prefix > + case 13: > + emit_int8(0x66); // size prefix > + case 12: > + addr_nop_8(); > + emit_int8(0x66); // size prefix > + emit_int8(0x66); // size prefix > + emit_int8(0x66); // size prefix > + emit_int8((unsigned char)0x90); > + // nop > + break; > + case 11: > + emit_int8(0x66); // size prefix > + case 10: > + emit_int8(0x66); // size prefix > + case 9: > + emit_int8(0x66); // size prefix > + case 8: > + addr_nop_8(); > + break; > + case 7: > + addr_nop_7(); > + break; > + case 6: > + emit_int8(0x66); // size prefix > + case 5: > + addr_nop_5(); > + break; > + case 4: > + addr_nop_4(); > + break; > + case 3: > + // Don't use "0x0F 0x1F 0x00" - need patching safe padding > + emit_int8(0x66); // size prefix > + case 2: > + emit_int8(0x66); // size prefix > + case 1: > + emit_int8((unsigned char)0x90); > + // nop > + break; > + default: > + assert(i == 0, " "); > + } > + return; > + } > + > // Using nops with size prefixes "0x66 0x90". > // From AMD Optimization Guide: > // 1: 0x90 > diff -Nur org/jdk/src/hotspot/cpu/x86/vm_version_x86.cpp zx/jdk/src/hotspot/cpu/x86/vm_version_x86.cpp > --- org/jdk/src/hotspot/cpu/x86/vm_version_x86.cpp2017-12-22 19:59:09.000000000 +0800 > +++ zx/jdk/src/hotspot/cpu/x86/vm_version_x86.cpp2017-12-26 13:28:57.000000000 +0800 > @@ -628,6 +628,11 @@ > if (UseSSE < 1) > _features &= ~CPU_SSE; > > + //since AVX instructions is slower than SSE in some ZX cpus, force USEAVX=0. > + if(is_zx() && ((cpu_family()==6)||(cpu_family()==7))){ > +UseAVX = 0; > + } > + > // first try initial setting and detect what we can support > if (UseAVX > 0) { > if (UseAVX > 2 && supports_evex()) { > @@ -1057,6 +1062,66 @@ > // UseXmmRegToRegMoveAll == true --> movaps(xmm, xmm), movapd(xmm, xmm). > // UseXmmRegToRegMoveAll == false --> movss(xmm, xmm), movsd(xmm, xmm). > > + > + if( is_zx() ) { // ZX cpus specific settings > + if( FLAG_IS_DEFAULT(UseStoreImmI16) ) { > + UseStoreImmI16 = false; // don't use it on ZX cpus > + } > + if( (cpu_family() == 6)|| (cpu_family() == 7) ) { > + if( FLAG_IS_DEFAULT(UseAddressNop) ) { > + // Use it on all ZX cpus > + UseAddressNop = true; > + } > + } > + if( FLAG_IS_DEFAULT(UseXmmLoadAndClearUpper) ) { > + UseXmmLoadAndClearUpper = true; // use movsd on all ZX cpus > + } > + if( FLAG_IS_DEFAULT(UseXmmRegToRegMoveAll) ) { > + if( supports_sse3() ) { > + UseXmmRegToRegMoveAll = true; // use movaps, movapd on new ZX cpus > + } else { > + UseXmmRegToRegMoveAll = false; > + } > + } > + if( ((cpu_family() == 6)||(cpu_family() == 7)) && supports_sse3() ) { // new ZX cpus > +#ifdef COMPILER2 > + if( FLAG_IS_DEFAULT(MaxLoopPad) ) { > + // For new ZX cpus do the next optimization: > + // don't align the beginning of a loop if there are enough instructions > + // left (NumberOfLoopInstrToAlign defined in c2_globals.hpp) > + // in current fetch line (OptoLoopAlignment) or the padding > + // is big (> MaxLoopPad). > + // Set MaxLoopPad to 11 for new ZX cpus to reduce number of > + // generated NOP instructions. 11 is the largest size of one > + // address NOP instruction '0F 1F' (see Assembler::nop(i)). > + MaxLoopPad = 11; > + } > +#endif // COMPILER2 > + if (FLAG_IS_DEFAULT(UseXMMForArrayCopy)) { > + UseXMMForArrayCopy = true; // use SSE2 movq on new ZX cpus > + } > + if (supports_sse4_2()) { // new ZX cpus > + if (FLAG_IS_DEFAULT(UseUnalignedLoadStores)) { > + UseUnalignedLoadStores = true; // use movdqu on newest ZX cpus > + } > + } > + if (supports_sse4_2()) { > + if (FLAG_IS_DEFAULT(UseSSE42Intrinsics)) { > + FLAG_SET_DEFAULT(UseSSE42Intrinsics, true); > + } > + } else { > + if (UseSSE42Intrinsics && !FLAG_IS_DEFAULT(UseAESIntrinsics)) { > + warning("SSE4.2 intrinsics require SSE4.2 instructions or higher. Intrinsics will be disabled."); > + } > + FLAG_SET_DEFAULT(UseSSE42Intrinsics, false); > + } > + } > + > + if(FLAG_IS_DEFAULT(AllocatePrefetchInstr) && supports_3dnow_prefetch()) { > + FLAG_SET_DEFAULT(AllocatePrefetchInstr, 3); > + } > + } > + > if( is_amd() ) { // AMD cpus specific settings > if( supports_sse2() && FLAG_IS_DEFAULT(UseAddressNop) ) { > // Use it on new AMD cpus starting from Opteron. > @@ -1349,6 +1414,14 @@ > #ifdef COMPILER2 > if (FLAG_IS_DEFAULT(UseFPUForSpilling) && supports_sse4_2()) { > FLAG_SET_DEFAULT(UseFPUForSpilling, true); > + } > +#endif > + } > + > + if (is_zx() && ((cpu_family() == 6)||(cpu_family() == 7)) && supports_sse3()) { > +#ifdef COMPILER2 > + if (FLAG_IS_DEFAULT(UseFPUForSpilling) && supports_sse4_2()) { > + FLAG_SET_DEFAULT(UseFPUForSpilling, true); > } > #endif > } > diff -Nur org/jdk/src/hotspot/cpu/x86/vm_version_x86.hpp zx/jdk/src/hotspot/cpu/x86/vm_version_x86.hpp > --- org/jdk/src/hotspot/cpu/x86/vm_version_x86.hpp2017-12-07 09:48:50.000000000 +0800 > +++ zx/jdk/src/hotspot/cpu/x86/vm_version_x86.hpp2017-12-21 15:37:33.000000000 +0800 > @@ -305,6 +305,9 @@ > enum Extended_Family { > // AMD > CPU_FAMILY_AMD_11H = 0x11, > + // ZX > + CPU_FAMILY_ZX_CORE_F6 = 6, > +CPU_FAMILY_ZX_CORE_F7 = 7, > // Intel > CPU_FAMILY_INTEL_CORE = 6, > CPU_MODEL_NEHALEM = 0x1e, > @@ -549,6 +552,16 @@ > } > } > > +// ZX features. > + if(is_zx()) { > + if(_cpuid_info.ext_cpuid1_ecx.bits.lzcnt_intel != 0) > + result |= CPU_LZCNT; > + // for ZX, ecx.bits.misalignsse bit (bit 8) indicates support for prefetchw > + if (_cpuid_info.ext_cpuid1_ecx.bits.misalignsse != 0) { > + result |= CPU_3DNOW_PREFETCH; > + } > + } > + > return result; > } > > @@ -657,6 +670,7 @@ > static bool is_P6() { return cpu_family() >= 6; } > static bool is_amd() { assert_is_initialized(); return _cpuid_info.std_vendor_name_0 == 0x68747541; } // 'htuA' > static bool is_intel() { assert_is_initialized(); return _cpuid_info.std_vendor_name_0 == 0x756e6547; } // 'uneG' > + static bool is_zx() { assert_is_initialized(); return (_cpuid_info.std_vendor_name_0 == 0x746e6543)||(_cpuid_info.std_vendor_name_0 == 0x68532020); } // 'tneC'||'hS ' > static bool is_atom_family() { return ((cpu_family() == 0x06) && ((extended_cpu_model() == 0x36) || (extended_cpu_model() == 0x37) || (extended_cpu_model() == 0x4D))); } //Silvermont and Centerton > static bool is_knights_family() { return ((cpu_family() == 0x06) && ((extended_cpu_model() == 0x57) || (extended_cpu_model() == 0x85))); } // Xeon Phi 3200/5200/7200 and Future Xeon Phi > > @@ -680,7 +694,16 @@ > } > } else if (is_amd()) { > result = (_cpuid_info.ext_cpuid8_ecx.bits.cores_per_cpu + 1); > - } > + } else if (is_zx()) { > + bool supports_topology = supports_processor_topology(); > + if (supports_topology) { > + result = _cpuid_info.tpl_cpuidB1_ebx.bits.logical_cpus / > + _cpuid_info.tpl_cpuidB0_ebx.bits.logical_cpus; > + } > + if (!supports_topology || result == 0) { > + result = (_cpuid_info.dcp_cpuid4_eax.bits.cores_per_cpu + 1); > + } > +} > return result; > } > > @@ -688,7 +711,9 @@ > uint result = 1; > if (is_intel() && supports_processor_topology()) { > result = _cpuid_info.tpl_cpuidB0_ebx.bits.logical_cpus; > - } else if (_cpuid_info.std_cpuid1_edx.bits.ht != 0) { > + } else if (is_zx() && supports_processor_topology()) { > + result = _cpuid_info.tpl_cpuidB0_ebx.bits.logical_cpus; > +} else if (_cpuid_info.std_cpuid1_edx.bits.ht != 0) { > if (cpu_family() >= 0x17) { > result = _cpuid_info.ext_cpuid1E_ebx.bits.threads_per_core + 1; > } else { > @@ -705,7 +730,9 @@ > result = (_cpuid_info.dcp_cpuid4_ebx.bits.L1_line_size + 1); > } else if (is_amd()) { > result = _cpuid_info.ext_cpuid5_ecx.bits.L1_line_size; > - } > + } else if (is_zx()) { > + result = (_cpuid_info.dcp_cpuid4_ebx.bits.L1_line_size + 1); > +} > if (result < 32) // not defined ? > result = 32; // 32 bytes by default on x86 and other x64 > return result; > > > Finally, running the jtreg test. I run 2 jtreg tests(jtreg:test/jdk:tier1 and jtreg:test/langtools:tier1) and both of them are pass. > > Best Regards! > VicWang | R&D > Telephone:+86-01082695388-892477 > > > ????? > ????????????????????????????????????????????????????? > CONFIDENTIAL NOTE: > This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. > From VicWang at zhaoxin.com Thu Dec 28 06:23:46 2017 From: VicWang at zhaoxin.com (Vic Wang(BJ-RD)) Date: Thu, 28 Dec 2017 06:23:46 +0000 Subject: =?utf-8?B?562U5aSNOiBbcGF0Y2hdIHN1cHBvcnQgemhhb3hpbiB4ODYgY3B1IHZlbmRv?= =?utf-8?Q?r_ids_CentaulHauls_and_Shanghai?= In-Reply-To: <7353ec44-667f-3520-df6b-32b60ff9a550@oracle.com> References: <7353ec44-667f-3520-df6b-32b60ff9a550@oracle.com> Message-ID: <764a791e3330445c9d2bd63f64c9288f@zhaoxin.com> Hi David, I got it. Thanks very much. Best Regards! Vic -----????----- ???: David Holmes [mailto:david.holmes at oracle.com] ????: 2017?12?28? 8:12 ???: Vic Wang(BJ-RD) ; Se?n Coffey (sean.coffey at oracle.com) ; dalibor topic (dalibor.topic at oracle.com) ; jdk8u-dev at openjdk.java.net ??: Cobe Chen(BJ-RD) ??: Re: [patch] support zhaoxin x86 cpu vendor ids CentaulHauls and Shanghai Hi, These are hotspot changes so should be done using http://hg.openjdk.java.net/jdk/hs and reviewed on hotspot-dev at openjdk.java.net, for pushing into JDK 11 (possibly JDK 10 if the case can be made for that). If a backport to 8u is desired then that would have to be taken up on the jdk8u-dev mailing list. Thanks, David On 27/12/2017 6:31 PM, Vic Wang(BJ-RD) wrote: > Hi, > Here is a patch for supporting zhaoxin x86 cpu vendor ids (CentaurHauls id and Shanghai id). The original repository is http://hg.openjdk.java.net/jdk/jdk. > Please help me to submit the changes . If there is anything incorrectly, please let me know. Thank you very much. > > The following is the changeset by the diff command. > > diff -Nur org/jdk/src/hotspot/cpu/x86/assembler_x86.cpp > zx/jdk/src/hotspot/cpu/x86/assembler_x86.cpp > --- org/jdk/src/hotspot/cpu/x86/assembler_x86.cpp2017-12-07 > 09:48:50.000000000 +0800 > +++ zx/jdk/src/hotspot/cpu/x86/assembler_x86.cpp2017-12-27 > +++ 15:03:43.000000000 +0800 > @@ -3167,6 +3167,89 @@ > return; > } > > + if (UseAddressNop && VM_Version::is_zx()) { > + // > + // Using multi-bytes nops "0x0F 0x1F [address]" for ZX > + // 1: 0x90 > + // 2: 0x66 0x90 > + // 3: 0x66 0x66 0x90 (don't use "0x0F 0x1F 0x00" - need patching safe padding) > + // 4: 0x0F 0x1F 0x40 0x00 > + // 5: 0x0F 0x1F 0x44 0x00 0x00 > + // 6: 0x66 0x0F 0x1F 0x44 0x00 0x00 > + // 7: 0x0F 0x1F 0x80 0x00 0x00 0x00 0x00 > + // 8: 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 > + // 9: 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 > + // 10: 0x66 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 > + // 11: 0x66 0x66 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 > + > + // The rest coding is ZX specific - don't use consecutive address > + nops > + > + // 12: 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 0x66 0x66 0x66 0x90 > + // 13: 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 0x66 0x66 0x66 0x90 > + // 14: 0x66 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 0x66 0x66 0x66 0x90 > + // 15: 0x66 0x66 0x66 0x0F 0x1F 0x84 0x00 0x00 0x00 0x00 0x00 > + 0x66 0x66 0x66 0x90 > + > + while(i >= 15) { > + // For ZX don't generate consecutive addess nops (mix with regular nops) > + i -= 15; > + emit_int8(0x66); // size prefix > + emit_int8(0x66); // size prefix > + emit_int8(0x66); // size prefix > + addr_nop_8(); > + emit_int8(0x66); // size prefix > + emit_int8(0x66); // size prefix > + emit_int8(0x66); // size prefix > + emit_int8((unsigned char)0x90); > + // nop > + } > + switch (i) { > + case 14: > + emit_int8(0x66); // size prefix > + case 13: > + emit_int8(0x66); // size prefix > + case 12: > + addr_nop_8(); > + emit_int8(0x66); // size prefix > + emit_int8(0x66); // size prefix > + emit_int8(0x66); // size prefix > + emit_int8((unsigned char)0x90); > + // nop > + break; > + case 11: > + emit_int8(0x66); // size prefix > + case 10: > + emit_int8(0x66); // size prefix > + case 9: > + emit_int8(0x66); // size prefix > + case 8: > + addr_nop_8(); > + break; > + case 7: > + addr_nop_7(); > + break; > + case 6: > + emit_int8(0x66); // size prefix > + case 5: > + addr_nop_5(); > + break; > + case 4: > + addr_nop_4(); > + break; > + case 3: > + // Don't use "0x0F 0x1F 0x00" - need patching safe padding > + emit_int8(0x66); // size prefix > + case 2: > + emit_int8(0x66); // size prefix > + case 1: > + emit_int8((unsigned char)0x90); > + // nop > + break; > + default: > + assert(i == 0, " "); > + } > + return; > + } > + > // Using nops with size prefixes "0x66 0x90". > // From AMD Optimization Guide: > // 1: 0x90 > diff -Nur org/jdk/src/hotspot/cpu/x86/vm_version_x86.cpp > zx/jdk/src/hotspot/cpu/x86/vm_version_x86.cpp > --- org/jdk/src/hotspot/cpu/x86/vm_version_x86.cpp2017-12-22 > 19:59:09.000000000 +0800 > +++ zx/jdk/src/hotspot/cpu/x86/vm_version_x86.cpp2017-12-26 > +++ 13:28:57.000000000 +0800 > @@ -628,6 +628,11 @@ > if (UseSSE < 1) > _features &= ~CPU_SSE; > > + //since AVX instructions is slower than SSE in some ZX cpus, force USEAVX=0. > + if(is_zx() && ((cpu_family()==6)||(cpu_family()==7))){ > +UseAVX = 0; > + } > + > // first try initial setting and detect what we can support > if (UseAVX > 0) { > if (UseAVX > 2 && supports_evex()) { @@ -1057,6 +1062,66 @@ > // UseXmmRegToRegMoveAll == true --> movaps(xmm, xmm), movapd(xmm, xmm). > // UseXmmRegToRegMoveAll == false --> movss(xmm, xmm), movsd(xmm, xmm). > > + > + if( is_zx() ) { // ZX cpus specific settings > + if( FLAG_IS_DEFAULT(UseStoreImmI16) ) { > + UseStoreImmI16 = false; // don't use it on ZX cpus > + } > + if( (cpu_family() == 6)|| (cpu_family() == 7) ) { > + if( FLAG_IS_DEFAULT(UseAddressNop) ) { > + // Use it on all ZX cpus > + UseAddressNop = true; > + } > + } > + if( FLAG_IS_DEFAULT(UseXmmLoadAndClearUpper) ) { > + UseXmmLoadAndClearUpper = true; // use movsd on all ZX cpus > + } > + if( FLAG_IS_DEFAULT(UseXmmRegToRegMoveAll) ) { > + if( supports_sse3() ) { > + UseXmmRegToRegMoveAll = true; // use movaps, movapd on new ZX cpus > + } else { > + UseXmmRegToRegMoveAll = false; > + } > + } > + if( ((cpu_family() == 6)||(cpu_family() == 7)) && supports_sse3() > +) { // new ZX cpus #ifdef COMPILER2 > + if( FLAG_IS_DEFAULT(MaxLoopPad) ) { > + // For new ZX cpus do the next optimization: > + // don't align the beginning of a loop if there are enough instructions > + // left (NumberOfLoopInstrToAlign defined in c2_globals.hpp) > + // in current fetch line (OptoLoopAlignment) or the padding > + // is big (> MaxLoopPad). > + // Set MaxLoopPad to 11 for new ZX cpus to reduce number of > + // generated NOP instructions. 11 is the largest size of one > + // address NOP instruction '0F 1F' (see Assembler::nop(i)). > + MaxLoopPad = 11; > + } > +#endif // COMPILER2 > + if (FLAG_IS_DEFAULT(UseXMMForArrayCopy)) { > + UseXMMForArrayCopy = true; // use SSE2 movq on new ZX cpus > + } > + if (supports_sse4_2()) { // new ZX cpus > + if (FLAG_IS_DEFAULT(UseUnalignedLoadStores)) { > + UseUnalignedLoadStores = true; // use movdqu on newest ZX cpus > + } > + } > + if (supports_sse4_2()) { > + if (FLAG_IS_DEFAULT(UseSSE42Intrinsics)) { > + FLAG_SET_DEFAULT(UseSSE42Intrinsics, true); > + } > + } else { > + if (UseSSE42Intrinsics && !FLAG_IS_DEFAULT(UseAESIntrinsics)) { > + warning("SSE4.2 intrinsics require SSE4.2 instructions or higher. Intrinsics will be disabled."); > + } > + FLAG_SET_DEFAULT(UseSSE42Intrinsics, false); > + } > + } > + > + if(FLAG_IS_DEFAULT(AllocatePrefetchInstr) && supports_3dnow_prefetch()) { > + FLAG_SET_DEFAULT(AllocatePrefetchInstr, 3); > + } > + } > + > if( is_amd() ) { // AMD cpus specific settings > if( supports_sse2() && FLAG_IS_DEFAULT(UseAddressNop) ) { > // Use it on new AMD cpus starting from Opteron. > @@ -1349,6 +1414,14 @@ > #ifdef COMPILER2 > if (FLAG_IS_DEFAULT(UseFPUForSpilling) && supports_sse4_2()) { > FLAG_SET_DEFAULT(UseFPUForSpilling, true); > + } > +#endif > + } > + > + if (is_zx() && ((cpu_family() == 6)||(cpu_family() == 7)) && > +supports_sse3()) { #ifdef COMPILER2 > + if (FLAG_IS_DEFAULT(UseFPUForSpilling) && supports_sse4_2()) { > + FLAG_SET_DEFAULT(UseFPUForSpilling, true); > } > #endif > } > diff -Nur org/jdk/src/hotspot/cpu/x86/vm_version_x86.hpp > zx/jdk/src/hotspot/cpu/x86/vm_version_x86.hpp > --- org/jdk/src/hotspot/cpu/x86/vm_version_x86.hpp2017-12-07 > 09:48:50.000000000 +0800 > +++ zx/jdk/src/hotspot/cpu/x86/vm_version_x86.hpp2017-12-21 > +++ 15:37:33.000000000 +0800 > @@ -305,6 +305,9 @@ > enum Extended_Family { > // AMD > CPU_FAMILY_AMD_11H = 0x11, > + // ZX > + CPU_FAMILY_ZX_CORE_F6 = 6, > +CPU_FAMILY_ZX_CORE_F7 = 7, > // Intel > CPU_FAMILY_INTEL_CORE = 6, > CPU_MODEL_NEHALEM = 0x1e, > @@ -549,6 +552,16 @@ > } > } > > +// ZX features. > + if(is_zx()) { > + if(_cpuid_info.ext_cpuid1_ecx.bits.lzcnt_intel != 0) > + result |= CPU_LZCNT; > + // for ZX, ecx.bits.misalignsse bit (bit 8) indicates support for prefetchw > + if (_cpuid_info.ext_cpuid1_ecx.bits.misalignsse != 0) { > + result |= CPU_3DNOW_PREFETCH; > + } > + } > + > return result; > } > > @@ -657,6 +670,7 @@ > static bool is_P6() { return cpu_family() >= 6; } > static bool is_amd() { assert_is_initialized(); return _cpuid_info.std_vendor_name_0 == 0x68747541; } // 'htuA' > static bool is_intel() { assert_is_initialized(); return _cpuid_info.std_vendor_name_0 == 0x756e6547; } // 'uneG' > + static bool is_zx() { assert_is_initialized(); return (_cpuid_info.std_vendor_name_0 == 0x746e6543)||(_cpuid_info.std_vendor_name_0 == 0x68532020); } // 'tneC'||'hS ' > static bool is_atom_family() { return ((cpu_family() == 0x06) && ((extended_cpu_model() == 0x36) || (extended_cpu_model() == 0x37) || (extended_cpu_model() == 0x4D))); } //Silvermont and Centerton > static bool is_knights_family() { return ((cpu_family() == 0x06) > && ((extended_cpu_model() == 0x57) || (extended_cpu_model() == > 0x85))); } // Xeon Phi 3200/5200/7200 and Future Xeon Phi > > @@ -680,7 +694,16 @@ > } > } else if (is_amd()) { > result = (_cpuid_info.ext_cpuid8_ecx.bits.cores_per_cpu + 1); > - } > + } else if (is_zx()) { > + bool supports_topology = supports_processor_topology(); > + if (supports_topology) { > + result = _cpuid_info.tpl_cpuidB1_ebx.bits.logical_cpus / > + _cpuid_info.tpl_cpuidB0_ebx.bits.logical_cpus; > + } > + if (!supports_topology || result == 0) { > + result = (_cpuid_info.dcp_cpuid4_eax.bits.cores_per_cpu + 1); > + } > +} > return result; > } > > @@ -688,7 +711,9 @@ > uint result = 1; > if (is_intel() && supports_processor_topology()) { > result = _cpuid_info.tpl_cpuidB0_ebx.bits.logical_cpus; > - } else if (_cpuid_info.std_cpuid1_edx.bits.ht != 0) { > + } else if (is_zx() && supports_processor_topology()) { > + result = _cpuid_info.tpl_cpuidB0_ebx.bits.logical_cpus; > +} else if (_cpuid_info.std_cpuid1_edx.bits.ht != 0) { > if (cpu_family() >= 0x17) { > result = _cpuid_info.ext_cpuid1E_ebx.bits.threads_per_core + 1; > } else { > @@ -705,7 +730,9 @@ > result = (_cpuid_info.dcp_cpuid4_ebx.bits.L1_line_size + 1); > } else if (is_amd()) { > result = _cpuid_info.ext_cpuid5_ecx.bits.L1_line_size; > - } > + } else if (is_zx()) { > + result = (_cpuid_info.dcp_cpuid4_ebx.bits.L1_line_size + 1); } > if (result < 32) // not defined ? > result = 32; // 32 bytes by default on x86 and other x64 > return result; > > > Finally, running the jtreg test. I run 2 jtreg tests(jtreg:test/jdk:tier1 and jtreg:test/langtools:tier1) and both of them are pass. > > Best Regards! > VicWang | R&D > Telephone:+86-01082695388-892477 > > > ????? > ????????????????????????????????????????????????????? > CONFIDENTIAL NOTE: > This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. > ????? ????????????????????????????????????????????????????? CONFIDENTIAL NOTE: This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited.