RFR: JDK-8171151 - JDK8u ProblemList.txt Updation
Seán Coffey
sean.coffey at oracle.com
Mon Feb 6 09:06:41 UTC 2017
This looks ok Nikita.
You've opened some new bug IDs to record some of these failures. I think
it would have been better to either open backports of JDK 9 issues or
link them to older JBS issues where applicable.
e.g. you've logged JDK-8173182 even though other bugs with same issue
exist on sun/security/pkcs11/MessageDigest/TestCloning.java - In a
related bug we have a clear reason as to why the issue is not a JDK
issue [1]. Opening new bugs adds a tail to capturing bug history. We can
clean this up post your push. For now, the updated ProblemList looks ok.
regards,
Sean.
[1]
https://bugs.openjdk.java.net/browse/JDK-8043951?focusedCommentId=14037458&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14037458
On 02/02/2017 13:07, Nikita Jain wrote:
>
> Hi Sean,
>
> > -tools/pack200/Pack200Test.java solaris-all, macosx-all
>
> As suggested backport is done and waiting for push
>
> >+ sun/security/pkcs11/rsa/TestKeyPairGenerator.java solaris-sparcv9
>
> Done, modified as solaris-all
>
> >+ sun/security/tools/jarsigner/TsacertOptionTest.java linux-x64,
> macosx-x64 :
>
> As suggested backported the fix and hence now not adding into the
> ProblemList.txt
>
> Updated the webrev:
> http://cr.openjdk.java.net/~rpatil/8171151/webrev.02/
> <http://cr.openjdk.java.net/%7Erpatil/8171151/webrev.02/>
>
> Thanks,
>
> Nikita Jain
>
> *From:*Seán Coffey
> *Sent:* Monday, January 23, 2017 10:47 PM
> *To:* Ivan Gerasimov <ivan.gerasimov at oracle.com>; Nikita Jain
> <nikita.j.jain at oracle.com>; jdk8u-dev at openjdk.java.net
> *Subject:* Re: RFR: JDK-8171151 - JDK8u ProblemList.txt Updation
>
> Nikita,
>
> a few comments.
>
> The Pack200Test.java test was probably stabilized via the JDK-8166248
> test fix. It stipulates that the test run on a with max memory > 4g -
> That might be useful for JDK 8u also.
>
>
> *+ # 8129560*
>
> *+ sun/security/pkcs11/rsa/TestKeyPairGenerator.java
> solaris-sparcv9*
>
> This seems applicable to solaris x64 also, Should the arch be
> solaris-all ?
>
> Would it be better to port the 1 line fix rather than add this to the
> exclude list ?
>
>
> *+ # 8168374, 8130041*
>
> *+ sun/security/tools/jarsigner/TsacertOptionTest.java
> linux-x64, macosx-x64*
>
> 8168374 is a JDK 9 (only) modules issue. Please remove the id reference.
> 813004 [1] is a simple enough backport. I'd recommend porting that to
> 8u-dev.
>
> For new tests & bug IDs being added to the problem list, do you plan
> to open a backport reference for test fixes that should be ported ?
>
> [1] http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/78fcb2e094db
>
> Regards,
> Sean.
>
> On 23/01/17 10:44, Ivan Gerasimov wrote:
>
> Thanks Nikita!
>
> The fix now looks good to me.
> Please get another review from a jdk8u-dev Reviewer before pushing
> it.
>
> With kind regards,
> Ivan
>
> On 23.01.2017 11:19, Nikita Jain wrote:
>
>
> Hi All,
>
> Updated the webrev. May I have a reviewer to review this:
>
> http://cr.openjdk.java.net/~rpatil/8171151/webrev.01/
> <http://cr.openjdk.java.net/%7Erpatil/8171151/webrev.01/>
> <http://cr.openjdk.java.net/%7Erpatil/8171151/webrev.01/>
> <http://cr.openjdk.java.net/%7Erpatil/8171151/webrev.01/>
>
> Thank you Ivan for looking into this, created new bugs for the
> same.
>
>
> Thanks,
>
> Nikita Jain
>
> *From:*Ivan Gerasimov
> *Sent:* Sunday, January 22, 2017 3:43 AM
> *To:* Nikita Jain <nikita.j.jain at oracle.com>
> <mailto:nikita.j.jain at oracle.com>; jdk8u-dev at openjdk.java.net
> <mailto:jdk8u-dev at openjdk.java.net>
> *Subject:* Re: RFR: JDK-8171151 - JDK8u ProblemList.txt Updation
>
> Hi Nikita!
>
> Thanks for working on this!
> Reducing the noise from failing tests should greatly help to
> focus on the important failures.
>
> Your patch looks good in general.
>
> A couple of comments:
> 1)
> 223 # 8158274
> 224 java/nio/file/Files/probeContentType/Basic.java solaris-x64
>
> The bug JDK-8158274 was about Solaris Sparc and is now closed
> with "Won't fix" resolution.
> If the test is going to be fixed, then a new bug should be filed.
>
> 2)
> 283 # 8043951
> 284 sun/security/pkcs11/MessageDigest/TestCloning.java
> solaris-x64
>
> The bug JDK-8043951 was closed as "Won't fix".
> If we're going to fix the test, either the bug should be
> reopened, or a new bug should be filed.
>
>
> Please not that I'm not a Reviewer, so you'll need to get an
> approval from one.
>
> With kind regards,
> Ivan
>
> On 18.01.2017 16:47, Nikita Jain wrote:
>
> Hi All,
>
> Please review this fix for JDK-8171151 - JDK8u
> ProblemList.txt Updation
>
> Bug:https://bugs.openjdk.java.net/browse/JDK-8171151
>
> JDK8u
> Webrev:http://cr.openjdk.java.net/~rpatil/8171151/webrev.00/
> <http://cr.openjdk.java.net/%7Erpatil/8171151/webrev.00/>
> <http://cr.openjdk.java.net/%7Erpatil/8171151/webrev.00/>
> <http://cr.openjdk.java.net/%7Erpatil/8171151/webrev.00/>
>
> Testing: Passes JPRT.
>
>
> --------------
>
> Summary
>
> Test cases inserted
>
> -> New test failures for JDK8u-dev have been added in the
> list with their associated bug id.
>
> -> 8171208, The bug has been closed because of the Infra
> issue. However, its reference is used here just to track the
> INFRA bug id.
>
> java/net/CookieHandler/CookieManagerTest.java
>
> java/net/HttpURLConnection/UnmodifiableMaps.java
>
> sun/net/www/protocol/http/B6299712.java
>
> Test cases updated/deleted
>
> -> Removing the test as per the bug id 8027973 [bug is fixed]
>
> javax/xml/jaxp/transform/jdk8004476/XSLTExFuncTest.java
>
>
> -> Removing the test as per the bug id 7052625 [change is
> backported]
>
> com/sun/net/httpserver/bugs/6725892/Test.java
>
> -> Removing the test as per the bug id 7148829 [No more
> failure seen, reopen if seen again]
>
> sun/net/InetAddress/nameservice/simple/CacheTest.java
>
> sun/net/InetAddress/nameservice/simple/DefaultCaching.java
>
> -> The test was seen as failure in solaris_x64 and
> solaris_sparcv9 also. Platform, Bug id has also been added for
> the same.
>
> java/net/MulticastSocket/SetLoopbackMode.java
>
>
> -> The test was seen as failure in solaris_x64. Platform,
> Bug id has also been added for the same.
>
> java/net/MulticastSocket/Test.java
>
> -> Updating bug id from (JDK-7157786 to JDK-8026976), as
> '7157786' is closed as duplicate
>
> sun/security/pkcs11/ec/TestKeyFactory.java
>
> -> Removing the test as per the bug id 6988842 [bug is
> fixed but entry is not removed from the ProblemList.txt]
>
> sun/security/pkcs11/Secmod/AddPrivateKey.java
>
> sun/security/pkcs11/ec/ReadCertificates.java
>
> sun/security/pkcs11/ec/ReadPKCS12.java
>
> -> According to this bug id: 6988842, test is not falling
> on solaris-all. The test was seen as failure on linux_i586 and
> linux_x64. Hence, the bug id and affected platform has been
> updated.
>
> sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java
>
> -> Removing these tests as per the comment in Bug 7143279.
> [No failure reported since 2013/06. Reopen if seen again]
>
> tools/pack200/CommandLineTests.java
>
> tools/pack200/Pack200Test.java
>
> -> The test was seen as failure in windows _all. Platform,
> Bug id has also been added for the same.
>
> tools/launcher/FXLauncherTest.java
>
> Thanks,
>
> Nikita Jain
>
More information about the jdk8u-dev
mailing list