Request for approval: 7131356, 8160370, 8161039, 8174779, 8174736

[Naoto Sato]

Hi Brent,

I reviewed the extra changes for 8u and looks fine to me. Please 
consider this approved for 8u-dev backport.

Naoto

On 3/27/17 4:43 PM, Brent Christian wrote:
> Hi,
>
> I am seeking approval to backport JDK 9 fixes for these 5 related bugs:
>
> 7131356 : (props) "No Java runtime present, requesting install" when
> creating VM from JNI [macosx]
> JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/b88aa53f3dc6
>
> 8160370 : System.getProperty("os.version") returns "Unknown" on Mac
> JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/b72c37787a5e
>
> 8161039 : System.getProperty("os.version") returns incorrect version
> number on Mac
> JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/165e4d9c7afa
>
> 8174779 : Locale issues with Mac 10.12
> JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d014ae449563
>
> 8174736 : [JCP] [Mac]Cannot launch JCP on Mac os with language set to
> "Chinese, Simplified" while region is not China
> JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1c14d0ba40e0
>
>
> To summarize, 7131356 replaced use of Apple's JavaRuntimeSupport
> framework with CoreFoundation calls to setup the locale and os
> name/version.  The fix has had some time to bake in JDK 9 (since June),
> during which time four related bugs were found and fixed, mostly around
> specific MacOS versions (e.g. 8160370 - MacOS 10.8, 8161039 - MacOS
> 10.11.0, 8174779 - MacOS 10.12).
>
>
> Here's the jdk8u-dev webrev:
> http://cr.openjdk.java.net/~bchristi/7131356/8u/webrev.00/
>
> The JDK 9 patches apply to 8u-dev, with the following (trivial, IMO)
> caveats:
>
> 1. unshuffle_list.txt needs to be updated for java_props_macosx.[ch]
> (filed 8177556).
>
> 2. 'hg import' didn't like that the copyright year for the JDK 9
> changeset was 2015, but in 8u is 2013
>
> 3. The fix [1] for unrelated bug 8136556 [2] added an #ifdef [3] in the
> getJRSFramework() function.  This backport removes that function
> altogether, but 'hg import' didn't like that the #ifdef isn't there to
> remove.
>
> Original review threads, for reference: 7131356[4], 8160370[5],
> 8161039[6], 8174779[7], 8174736[8].
>
> Thanks,
> -Brent
>
> 1. http://hg.openjdk.java.net/jdk9/hs-rt/jdk/rev/55573c377d64
> 2. https://bugs.openjdk.java.net/browse/JDK-8136556
> 3.
> http://hg.openjdk.java.net/jdk9/hs-rt/jdk/file/55573c377d64/src/java.base/macosx/native/libjava/java_props_macosx.c#l41
>
> 4.
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-June/041771.html
> 5.
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-June/042096.html
> 6.
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-July/042499.html
> 7.
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-February/046406.html
>
> 8.
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-March/046610.html