[8u-dev] Request for approval: 8177817 (new small change for 8u), and 8134119 (backport)

[Seán Coffey]

Looks fine Kevin. Approved.

Regards,
Sean.

On 31/03/17 10:46, Kevin Walls wrote:
> Hi,
>
> This is an approval request for a backport to 8u of:
>
> 8134119: Use new API to get cache line sizes
> https://bugs.openjdk.java.net/browse/JDK-8134119
> 9 change: 
> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/raw-rev/be30670bbd35
>
> This will backport almost cleanly: must change os:strdup_check_oom() 
> to just os::strdup().
>
> However, I first need to push the following new CR to 8u, so this is 
> also a request for approval for:
>
> 8177817: Remove assertions in 8u that were removed by 8056124 in 9.
> https://bugs.openjdk.java.net/browse/JDK-8177817
> 9 change for 8056124: 
> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/63934ec778a2
>
> This is a new change to do some code removal exactly as 8056124 did in 
> 9, also explained in hotspot-compiler-dev: 
> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2017-March/025923.html
>
> I've been over this plan with the original author.  The new CR 8177817 
> lets other changes backport almost unchanged from their 9 changesets.
>
> In the bug comment for 8177817 I've put the diff, it's the removals 
> insrc/cpu/sparc/vm/vm_version_sparc.cpp from 8056124, which have not 
> yet been put back into 8u.  The diff is also in the above 
> hotspot-compiler-dev thread.
>
> This builds on 8049717 which we discussed yesterday.  I plan to push 
> these 3 together.
>
> Many thanks
> Kevin
>
>