[8u] Request for approval and review: 8180934 (XS): PutfieldError failed with UnsupportedClassVersionError

[Zoltán Majó]

Hi David,


On 05/29/2017 01:23 PM, David Holmes wrote:
> On 29/05/2017 7:08 PM, Zoltán Majó wrote:
>> [...]
>>
>> Here is the updated webrev:
>> http://cr.openjdk.java.net/~zmajo/8180934/webrev.01/
>
> Looks good.

Thank you for the review!
>
>>>
>>> Also as a point of order: a RFR and a RFA are distinct and should be 
>>> posted separately: the RFR on hotspot-xxx-dev (as appropriate) and 
>>> the RFA on jdk8u-dev.
>>
>> Thanks, I noted that. Should I re-send the RFA and RFR for this 
>> issue, or does it suffice if I do it the next time (and onwards)?
>
> That's up to Sean :)

OK, thank you.

Best regards,


Zoltan

>
> Thanks,
> David
>
>> Best regards,
>>
>>
>> Zoltan
>>
>>
>>>
>>> Thanks,
>>> David
>>>
>>>> Thanks, Harold
>>>>
>>>>
>>>> On 5/26/2017 10:17 AM, Zoltán Majó wrote:
>>>>> Hi,
>>>>>
>>>>>
>>>>> when backporting 8160551, I also backported a test that is 
>>>>> relevant only for class files with version >= 53. As JDK 8 
>>>>> supports only class files with version < 53, having the test in 
>>>>> the JDK 8u test base does not make sense. This changeset proposes 
>>>>> to remove the test.
>>>>>
>>>>> https://bugs.openjdk.java.net/browse/JDK-8180934
>>>>> http://cr.openjdk.java.net/~zmajo/8180934/webrev.00/
>>>>>
>>>>> I executed all hotspot/runtime tests with the changeset (using JDK 
>>>>> 8u122), no problems have shown up. JPRT testing is in progress.
>>>>>
>>>>> Please note that this fix is a JDK 8u-specific fix (not a backport 
>>>>> of some existing fix in JDK 9).
>>>>>
>>>>> Thank you!
>>>>>
>>>>> Best regards,
>>>>>
>>>>>
>>>>> Zoltan
>>>>>
>>>>
>>