RFA for backport of 8035496: G1 ARM: missing remset entry noticed by VerifyAfterGC for vm/gc/concurrent/lp50yp10rp70mr30st0

[David Holmes]

Hi Rob,

I had a look at this earlier and the patch does apply cleanly.

Thanks,
David

On 24/10/2017 7:49 PM, Rob McKenna wrote:
> Hi Ninsheng,
> 
> Unless the patch applies cleanly this will need a codereview from
> somoone on hotspot-dev.
> 
>      -Rob
> 
> On 24/10/17 10:03, Ningsheng Jian wrote:
>> OK. Thank you Andrew. Forwarding to jdk8u-dev.
>> ----
>> Hi,
>>
>> I found the following patch is missing in JDK8u:
>>
>> http://hg.openjdk.java.net/jdk9/dev/hotspot/rev/86b7a6d44894
>>
>> I cannot view JDK-8035496 bug details, but I think this fix is correct
>> for AArch64 (and probably other weak ordering architectures). It
>> should be backported to JDK8u.
>>
>> I found this fix when we were trying to figure out the root cause of a
>> random G1GC crash in one AArch64 platform.
>>
>> The backport webrev is:
>>
>> http://cr.openjdk.java.net/~njian/8035496-backport/webrev/
>>
>> Is it OK for jdk8u? If yes, could someone please help to push the changeset?
>>
>> Thanks,
>> Ningsheng
>>
>>
>>
>> On 23 October 2017 at 23:30, Andrew Hughes <gnu.andrew at redhat.com> wrote:
>>> On 23 October 2017 at 07:04, Ningsheng Jian <ningsheng.jian at linaro.org> wrote:
>>>> Hi,
>>>>
>>>> I found the following patch is missing in AArch64 JDK8u:
>>>>
>>>> http://hg.openjdk.java.net/jdk9/dev/hotspot/rev/86b7a6d44894
>>>>
>>>> I cannot view the bug details, but I think this fix is correct for
>>>> AArch64 and should be backported to JDK8u. I found this fix when we
>>>> were trying to figure out the root cause of a random G1GC crash in one
>>>> AArch64 platform.
>>>>
>>>> The backport webrev is:
>>>>
>>>> http://cr.openjdk.java.net/~njian/8035496-backport/webrev/
>>>>
>>>> Is it OK for aarch64-port/jdk8u?
>>>>
>>>> Thanks,
>>>> Ningsheng
>>>
>>>
>>> As this is a backport from 9, it should really be requested for the
>>> main 8u tree:
>>>
>>> http://openjdk.java.net/projects/jdk8u/codereview.html
>>> http://mail.openjdk.java.net/mailman/listinfo/jdk8u-dev
>>>
>>> aarch64/jdk8u would then pick it up on merge.
>>> --
>>> Andrew :)
>>>
>>> Senior Free Java Software Engineer
>>> Red Hat, Inc. (http://www.redhat.com)
>>>
>>> Web Site: http://fuseyism.com
>>> Twitter: https://twitter.com/gnu_andrew_java
>>> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
>>> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222