From shafi.s.ahmad at oracle.com Tue Apr 3 06:44:23 2018 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Mon, 2 Apr 2018 23:44:23 -0700 (PDT) Subject: [8u] RFA for backport of "JDK-8165736: Error message should be shown when JVMTI agent cannot be attached" to jdk8u-dev Message-ID: Hi, May I get the approval of backport of "JDK- 8165736: Error message should be shown when JVMTI agent cannot be attached" to jdk8u-dev. Webrev: http://cr.openjdk.java.net/~shshahma/8165736/ Jdk10 bug: https://bugs.openjdk.java.net/browse/JDK-8165736 Jdk10 review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-November/022172.html Jdk8 review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-March/023426.html http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-April/023436.html Testing: jprt -testset hotspot and -testset core Regards, Shafi From david.buck at oracle.com Tue Apr 3 07:13:13 2018 From: david.buck at oracle.com (David Buck) Date: Tue, 3 Apr 2018 16:13:13 +0900 Subject: [8u] RFA for backport of "JDK-8165736: Error message should be shown when JVMTI agent cannot be attached" to jdk8u-dev In-Reply-To: References: Message-ID: <31d160e0-c42e-25a7-b43d-757c504b89ad@oracle.com> approved Cheers, -Buck On 2018/04/03 15:44, Shafi Ahmad wrote: > Hi, > > May I get the approval of backport of "JDK- 8165736: Error message should be shown when JVMTI agent cannot be attached" to jdk8u-dev. > > Webrev: http://cr.openjdk.java.net/~shshahma/8165736/ > Jdk10 bug: https://bugs.openjdk.java.net/browse/JDK-8165736 > Jdk10 review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-November/022172.html > Jdk8 review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-March/023426.html > http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-April/023436.html > > Testing: jprt -testset hotspot and -testset core > > Regards, > Shafi > From shafi.s.ahmad at oracle.com Tue Apr 3 10:28:19 2018 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Tue, 3 Apr 2018 03:28:19 -0700 (PDT) Subject: [8u] RFA for backport of "JDK-8165736: Error message should be shown when JVMTI agent cannot be attached" to jdk8u-dev In-Reply-To: <31d160e0-c42e-25a7-b43d-757c504b89ad@oracle.com> References: <31d160e0-c42e-25a7-b43d-757c504b89ad@oracle.com> Message-ID: <37facf0f-385c-4ef4-9aa7-cdd39c283ee8@default> Thank you Buck. Regards, Shafi > -----Original Message----- > From: David Buck > Sent: Tuesday, April 03, 2018 12:43 PM > To: Shafi Ahmad ; jdk8u-dev at openjdk.java.net > Subject: Re: [8u] RFA for backport of "JDK-8165736: Error message should be > shown when JVMTI agent cannot be attached" to jdk8u-dev > > approved > > Cheers, > -Buck > > On 2018/04/03 15:44, Shafi Ahmad wrote: > > Hi, > > > > May I get the approval of backport of "JDK- 8165736: Error message should > be shown when JVMTI agent cannot be attached" to jdk8u-dev. > > > > Webrev: http://cr.openjdk.java.net/~shshahma/8165736/ > > Jdk10 bug: https://bugs.openjdk.java.net/browse/JDK-8165736 > > Jdk10 review thread: http://mail.openjdk.java.net/pipermail/serviceability- > dev/2017-November/022172.html > > Jdk8 review thread: http://mail.openjdk.java.net/pipermail/serviceability- > dev/2018-March/023426.html > > http://mail.openjdk.java.net/pipermail/serviceability- > dev/2018-April/023436.html > > > > Testing: jprt -testset hotspot and -testset core > > > > Regards, > > Shafi > > From dipak.kumar at oracle.com Thu Apr 5 04:29:08 2018 From: dipak.kumar at oracle.com (Dipak Kumar) Date: Wed, 4 Apr 2018 21:29:08 -0700 (PDT) Subject: [8u] RFA for backport of JDK-8195738 : scroll position in ScrollPane is reset after calling validate() Message-ID: <11e9b9ee-8ee5-4995-bfd3-07249402dda6@default> Hi, May I get the approval for backport of "JDK-8195738 : scroll position in ScrollPane is reset after calling validate()" to jdk8u-dev. JBS - https://bugs.openjdk.java.net/browse/JDK-8195738 JDK-11 review thread - http://mail.openjdk.java.net/pipermail/awt-dev/2018-February/013579.html JDK-11 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/96bebffe0be1 JDK-8u webrev - HYPERLINK "http://cr.openjdk.java.net/%7Edkumar/8195738/webrev.00/"http://cr.openjdk.java.net/~dkumar/8195738/webrev.00/ JDK-8u review thread - http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013720.html I have tested out all the relevant AWT JTREG tests. Also, ensured that there are no failures related to this on JPRT (Stockholm) queues. Thanks, Dipak From david.buck at oracle.com Thu Apr 5 04:53:41 2018 From: david.buck at oracle.com (David Buck) Date: Thu, 5 Apr 2018 13:53:41 +0900 Subject: [8u] RFA for backport of JDK-8195738 : scroll position in ScrollPane is reset after calling validate() In-Reply-To: <11e9b9ee-8ee5-4995-bfd3-07249402dda6@default> References: <11e9b9ee-8ee5-4995-bfd3-07249402dda6@default> Message-ID: <3BDC6195-7CA0-413F-BB76-48224EEEAEB1@oracle.com> Hi Dipak! When a code review spans multiple months, please include all of the links needed to view the entire thread from start to finish. I have included the missing links for this request: JDK 11 review thread (March): http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013668.html JDK 8 review thread (April): http://mail.openjdk.java.net/pipermail/awt-dev/2018-April/013816.html This backport is approved for jdk8u-dev. Cheers, -Buck > On Apr 5, 2018, at 13:29, Dipak Kumar wrote: > > Hi, > > > > May I get the approval for backport of "JDK-8195738 : scroll position in ScrollPane is reset after calling validate()" to jdk8u-dev. > > > > JBS - https://bugs.openjdk.java.net/browse/JDK-8195738 > > JDK-11 review thread - http://mail.openjdk.java.net/pipermail/awt-dev/2018-February/013579.html > > JDK-11 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/96bebffe0be1 > > > > JDK-8u webrev - HYPERLINK "http://cr.openjdk.java.net/%7Edkumar/8195738/webrev.00/"http://cr.openjdk.java.net/~dkumar/8195738/webrev.00/ > > JDK-8u review thread - http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013720.html > > > > I have tested out all the relevant AWT JTREG tests. > > Also, ensured that there are no failures related to this on JPRT (Stockholm) queues. > > > > Thanks, > > Dipak From dipak.kumar at oracle.com Thu Apr 5 05:04:52 2018 From: dipak.kumar at oracle.com (Dipak Kumar) Date: Wed, 4 Apr 2018 22:04:52 -0700 (PDT) Subject: [8u] RFA for backport of JDK-8195738 : scroll position in ScrollPane is reset after calling validate() In-Reply-To: <3BDC6195-7CA0-413F-BB76-48224EEEAEB1@oracle.com> References: <11e9b9ee-8ee5-4995-bfd3-07249402dda6@default> <3BDC6195-7CA0-413F-BB76-48224EEEAEB1@oracle.com> Message-ID: Thank you Buck for the approval and letting me know the part which I missed. -----Original Message----- From: David Buck Sent: 05 April 2018 10:24 To: Dipak Kumar Cc: jdk8u-dev at openjdk.java.net Subject: Re: [8u] RFA for backport of JDK-8195738 : scroll position in ScrollPane is reset after calling validate() Hi Dipak! When a code review spans multiple months, please include all of the links needed to view the entire thread from start to finish. I have included the missing links for this request: JDK 11 review thread (March): http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013668.html JDK 8 review thread (April): http://mail.openjdk.java.net/pipermail/awt-dev/2018-April/013816.html This backport is approved for jdk8u-dev. Cheers, -Buck > On Apr 5, 2018, at 13:29, Dipak Kumar wrote: > > Hi, > > > > May I get the approval for backport of "JDK-8195738 : scroll position in ScrollPane is reset after calling validate()" to jdk8u-dev. > > > > JBS - https://bugs.openjdk.java.net/browse/JDK-8195738 > > JDK-11 review thread - http://mail.openjdk.java.net/pipermail/awt-dev/2018-February/013579.html > > JDK-11 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/96bebffe0be1 > > > > JDK-8u webrev - HYPERLINK "http://cr.openjdk.java.net/%7Edkumar/8195738/webrev.00/"http://cr.openjdk.java.net/~dkumar/8195738/webrev.00/ > > JDK-8u review thread - http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013720.html > > > > I have tested out all the relevant AWT JTREG tests. > > Also, ensured that there are no failures related to this on JPRT (Stockholm) queues. > > > > Thanks, > > Dipak From kevin.walls at oracle.com Thu Apr 5 11:55:35 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Thu, 5 Apr 2018 12:55:35 +0100 Subject: [8u-dev] Request for approval: 8034788: Rewrite toolchain.m4 to support multiple toolchains per platform Message-ID: Hi, I'd like to get approval to backport to jdk8u: 8034788: Rewrite toolchain.m4 to support multiple toolchains per platform JBS: https://bugs.openjdk.java.net/browse/JDK-8034788 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/rev/b18872ff5379 8u webrev: http://cr.openjdk.java.net/~kevinw/8034788/webrev.00/ build-dev approval email thread for this backport: http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021520.html Thanks! Kevin From kevin.walls at oracle.com Thu Apr 5 12:50:30 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Thu, 5 Apr 2018 13:50:30 +0100 Subject: [8u-dev] Request for approval: 8035725: Must keep microsoft VS_PATH on PATH after toolchain detection Message-ID: <1864518a-84b9-bc56-a06b-143da7bab6b1@oracle.com> Hi, I'd like to get approval to backport to jdk8u: 8035725: Must keep microsoft VS_PATH on PATH after toolchain detection JBS: https://bugs.openjdk.java.net/browse/JDK-8035725 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/44a3384beedd This is a small change that imports almost cleanly into jdk8u-dev.? Of the 3 changes in? common/autoconf/toolchain.m4 the last one just removes some trailing whitespace, which is not needed in 8u (and we need to rebuild and commit generated-configure.sh). This follows on from changes for 8034788, see other email.? This only affects some Windows builds, although I was getting good results from Windows builds with my proposed 8034788 changes. I'll only proceed with this after that change (if approval is OK for both). Thanks! Kevin From rob.mckenna at oracle.com Thu Apr 5 13:55:42 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 5 Apr 2018 14:55:42 +0100 Subject: [8u-dev] Request for approval: 8034788: Rewrite toolchain.m4 to support multiple toolchains per platform In-Reply-To: References: Message-ID: <20180405135542.GA3725@vimes> Approved -Rob On 05/04/18 12:55, Kevin Walls wrote: > Hi, > > I'd like to get approval to backport to jdk8u: > > 8034788: Rewrite toolchain.m4 to support multiple toolchains per platform > JBS: https://bugs.openjdk.java.net/browse/JDK-8034788 > 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/rev/b18872ff5379 > > 8u webrev: http://cr.openjdk.java.net/~kevinw/8034788/webrev.00/ > > build-dev approval email thread for this backport: > http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021520.html > > Thanks! > Kevin > > From rob.mckenna at oracle.com Thu Apr 5 13:56:09 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 5 Apr 2018 14:56:09 +0100 Subject: [8u-dev] Request for approval: 8035725: Must keep microsoft VS_PATH on PATH after toolchain detection In-Reply-To: <1864518a-84b9-bc56-a06b-143da7bab6b1@oracle.com> References: <1864518a-84b9-bc56-a06b-143da7bab6b1@oracle.com> Message-ID: <20180405135609.GB3725@vimes> Approved -Rob On 05/04/18 13:50, Kevin Walls wrote: > Hi, > > I'd like to get approval to backport to jdk8u: > > 8035725: Must keep microsoft VS_PATH on PATH after toolchain detection > JBS: https://bugs.openjdk.java.net/browse/JDK-8035725 > > 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/44a3384beedd > > This is a small change that imports almost cleanly into jdk8u-dev.? Of the 3 > changes in? common/autoconf/toolchain.m4 the last one just removes some > trailing whitespace, which is not needed in 8u (and we need to rebuild and > commit generated-configure.sh). > > This follows on from changes for 8034788, see other email.? This only > affects some Windows builds, although I was getting good results from > Windows builds with my proposed 8034788 changes. I'll only proceed with this > after that change (if approval is OK for both). > > Thanks! > Kevin > > From kevin.walls at oracle.com Fri Apr 6 12:03:01 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Fri, 6 Apr 2018 13:03:01 +0100 Subject: [8u-dev] Request for approval: 8035751: Clean up Visual Studio detection logic AND 8039030: 9-dev windows-i586 build failed with mktemp: command not found Message-ID: Hi, I'd like to get approval to backport to jdk8u: 8035751: Clean up Visual Studio detection logic JBS: https://bugs.openjdk.java.net/browse/JDK-8035751 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/f16ec21040c5 This imports cleanly (and we need to rebuild and commit generated-configure.sh). 8035751 has a follow-on bug: 8039030: 9-dev windows-i586 build failed with mktemp: command not found JBS: https://bugs.openjdk.java.net/browse/JDK-8039030 9 changeset: http://hg.openjdk.java.net/jdk9/dev/raw-rev/f5cdb85738ca ..which was a build failure affecting some systems (with a hash in the path, e.g. for F#). This one also imports cleanly to 8u.? I will push these together if approved. Thanks! Kevin From rob.mckenna at oracle.com Fri Apr 6 13:51:05 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 6 Apr 2018 14:51:05 +0100 Subject: [8u-dev] Request for approval: 8035751: Clean up Visual Studio detection logic AND 8039030: 9-dev windows-i586 build failed with mktemp: command not found In-Reply-To: References: Message-ID: <20180406135105.GA5146@vimes> Approved -Rob On 06/04/18 13:03, Kevin Walls wrote: > Hi, > > I'd like to get approval to backport to jdk8u: > > 8035751: Clean up Visual Studio detection logic > JBS: https://bugs.openjdk.java.net/browse/JDK-8035751 > 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/f16ec21040c5 > > This imports cleanly (and we need to rebuild and commit > generated-configure.sh). > > 8035751 has a follow-on bug: > > 8039030: 9-dev windows-i586 build failed with mktemp: command not found > JBS: https://bugs.openjdk.java.net/browse/JDK-8039030 > 9 changeset: http://hg.openjdk.java.net/jdk9/dev/raw-rev/f5cdb85738ca > > ..which was a build failure affecting some systems (with a hash in the path, > e.g. for F#). > > This one also imports cleanly to 8u.? I will push these together if > approved. > > Thanks! > Kevin > > From kevin.walls at oracle.com Fri Apr 6 21:30:14 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Fri, 6 Apr 2018 22:30:14 +0100 Subject: [8u-dev] Request for approval: 8176033: New cygwin grep does not match \r as newline Message-ID: <7e17cec7-32e0-db65-0423-702b6343f54d@oracle.com> Hi, I'd like to request approval to backport to 8u: 8176033: New cygwin grep does not match \r as newline JBS: https://bugs.openjdk.java.net/browse/JDK-8176033 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/raw-rev/01d26dcf5eac This very small change was pointed out to me as worth doing, it's another trap waiting for people who vary the cygwin version in their Windows build environment. The 8u diff is pasted below.? The 9 changeset didn't "hg import" from, but the affected lines are the same, using TR to delete characters rather than relying on grep.? Plus rebuilding generated-configure.sh with the autogen script. Thanks Kevin bash-4.2$ hg diff common/autoconf/basics_windows.m4 diff -r cddffb220808 common/autoconf/basics_windows.m4 --- a/common/autoconf/basics_windows.m4 Fri Apr 06 04:20:26 2018 -0700 +++ b/common/autoconf/basics_windows.m4 Fri Apr 06 14:20:35 2018 -0700 @@ -321,8 +321,8 @@ ?????? AC_MSG_ERROR([Something is wrong with your cygwin installation since I cannot find cygpath.exe in your path]) ???? fi ???? AC_MSG_CHECKING([cygwin root directory as unix-style path]) -??? # The cmd output ends with Windows line endings (CR/LF), the grep command will strip that away -??? cygwin_winpath_root=`cd / ; cmd /c cd | grep ".*"` +??? # The cmd output ends with Windows line endings (CR/LF) +??? cygwin_winpath_root=`cd / ; cmd /c cd | $TR -d '\r\n'` ???? # Force cygpath to report the proper root by including a trailing space, and then stripping it off again. ???? CYGWIN_ROOT_PATH=`$CYGPATH -u "$cygwin_winpath_root " | $CUT -f 1 -d " "` ???? AC_MSG_RESULT([$CYGWIN_ROOT_PATH]) From david.buck at oracle.com Fri Apr 6 21:49:26 2018 From: david.buck at oracle.com (David Buck) Date: Sat, 7 Apr 2018 06:49:26 +0900 Subject: [8u-dev] Request for approval: 8176033: New cygwin grep does not match \r as newline In-Reply-To: <7e17cec7-32e0-db65-0423-702b6343f54d@oracle.com> References: <7e17cec7-32e0-db65-0423-702b6343f54d@oracle.com> Message-ID: <87179563-5493-5cb4-dea3-2b25df7a6527@oracle.com> Hi Kevin! Here is the code review thread for the JDK 9 push: http://mail.openjdk.java.net/pipermail/build-dev/2017-March/018751.html Please be sure to always include a link to the code review thread(s) in future backport requests [0]. Also, please be sure to add an appropriate noreg label [1] to the bug report for any changeset that does not include a new regression test (or expand the scope of a preexisting test). Please consider this request approved for push to 8u-dev once the noreg label has been added. Cheers, -Buck [0] http://openjdk.java.net/projects/jdk8u/approval-template.html [1] http://openjdk.java.net/guide/changePlanning.html#noreg On 2018/04/07 6:30, Kevin Walls wrote: > Hi, > > I'd like to request approval to backport to 8u: > > 8176033: New cygwin grep does not match \r as newline > > JBS: https://bugs.openjdk.java.net/browse/JDK-8176033 > 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/raw-rev/01d26dcf5eac > > This very small change was pointed out to me as worth doing, it's > another trap waiting for people who vary the cygwin version in their > Windows build environment. > > The 8u diff is pasted below.? The 9 changeset didn't "hg import" from, > but the affected lines are the same, using TR to delete characters > rather than relying on grep.? Plus rebuilding generated-configure.sh > with the autogen script. > > Thanks > Kevin > > > bash-4.2$ hg diff common/autoconf/basics_windows.m4 > diff -r cddffb220808 common/autoconf/basics_windows.m4 > --- a/common/autoconf/basics_windows.m4 Fri Apr 06 04:20:26 2018 -0700 > +++ b/common/autoconf/basics_windows.m4 Fri Apr 06 14:20:35 2018 -0700 > @@ -321,8 +321,8 @@ > ?????? AC_MSG_ERROR([Something is wrong with your cygwin installation > since I cannot find cygpath.exe in your path]) > ???? fi > ???? AC_MSG_CHECKING([cygwin root directory as unix-style path]) > -??? # The cmd output ends with Windows line endings (CR/LF), the grep > command will strip that away > -??? cygwin_winpath_root=`cd / ; cmd /c cd | grep ".*"` > +??? # The cmd output ends with Windows line endings (CR/LF) > +??? cygwin_winpath_root=`cd / ; cmd /c cd | $TR -d '\r\n'` > ???? # Force cygpath to report the proper root by including a trailing > space, and then stripping it off again. > ???? CYGWIN_ROOT_PATH=`$CYGPATH -u "$cygwin_winpath_root " | $CUT -f 1 > -d " "` > ???? AC_MSG_RESULT([$CYGWIN_ROOT_PATH]) > > > From kevin.walls at oracle.com Fri Apr 6 22:13:31 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Fri, 6 Apr 2018 23:13:31 +0100 Subject: [8u-dev] Request for approval: 8176033: New cygwin grep does not match \r as newline In-Reply-To: <87179563-5493-5cb4-dea3-2b25df7a6527@oracle.com> References: <7e17cec7-32e0-db65-0423-702b6343f54d@oracle.com> <87179563-5493-5cb4-dea3-2b25df7a6527@oracle.com> Message-ID: <3bda37b7-5af6-0c76-057b-e80d2f138540@oracle.com> Thanks Buck... Will and label before a push. Thanks Kevin On 06/04/2018 22:49, David Buck wrote: > Hi Kevin! > > Here is the code review thread for the JDK 9 push: > > http://mail.openjdk.java.net/pipermail/build-dev/2017-March/018751.html > > Please be sure to always include a link to the code review thread(s) > in future backport requests [0]. > > Also, please be sure to add an appropriate noreg label [1] to the bug > report for any changeset that does not include a new regression test > (or expand the scope of a preexisting test). > > Please consider this request approved for push to 8u-dev once the > noreg label has been added. > > Cheers, > -Buck > > [0] http://openjdk.java.net/projects/jdk8u/approval-template.html > > [1] http://openjdk.java.net/guide/changePlanning.html#noreg > > On 2018/04/07 6:30, Kevin Walls wrote: >> Hi, >> >> I'd like to request approval to backport to 8u: >> >> 8176033: New cygwin grep does not match \r as newline >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8176033 >> 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/raw-rev/01d26dcf5eac >> >> This very small change was pointed out to me as worth doing, it's >> another trap waiting for people who vary the cygwin version in their >> Windows build environment. >> >> The 8u diff is pasted below.? The 9 changeset didn't "hg import" >> from, but the affected lines are the same, using TR to delete >> characters rather than relying on grep.? Plus rebuilding >> generated-configure.sh with the autogen script. >> >> Thanks >> Kevin >> >> >> bash-4.2$ hg diff common/autoconf/basics_windows.m4 >> diff -r cddffb220808 common/autoconf/basics_windows.m4 >> --- a/common/autoconf/basics_windows.m4 Fri Apr 06 04:20:26 2018 -0700 >> +++ b/common/autoconf/basics_windows.m4 Fri Apr 06 14:20:35 2018 -0700 >> @@ -321,8 +321,8 @@ >> ??????? AC_MSG_ERROR([Something is wrong with your cygwin >> installation since I cannot find cygpath.exe in your path]) >> ????? fi >> ????? AC_MSG_CHECKING([cygwin root directory as unix-style path]) >> -??? # The cmd output ends with Windows line endings (CR/LF), the >> grep command will strip that away >> -??? cygwin_winpath_root=`cd / ; cmd /c cd | grep ".*"` >> +??? # The cmd output ends with Windows line endings (CR/LF) >> +??? cygwin_winpath_root=`cd / ; cmd /c cd | $TR -d '\r\n'` >> ????? # Force cygpath to report the proper root by including a >> trailing space, and then stripping it off again. >> ????? CYGWIN_ROOT_PATH=`$CYGPATH -u "$cygwin_winpath_root " | $CUT -f >> 1 -d " "` >> ????? AC_MSG_RESULT([$CYGWIN_ROOT_PATH]) >> >> >> From rob.mckenna at oracle.com Fri Apr 6 22:46:51 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 6 Apr 2018 23:46:51 +0100 Subject: [8u-dev] Request for approval: 8176033: New cygwin grep does not match \r as newline In-Reply-To: <7e17cec7-32e0-db65-0423-702b6343f54d@oracle.com> References: <7e17cec7-32e0-db65-0423-702b6343f54d@oracle.com> Message-ID: <20180406224651.GD5146@vimes> Approved -Rob On 06/04/18 22:30, Kevin Walls wrote: > Hi, > > I'd like to request approval to backport to 8u: > > 8176033: New cygwin grep does not match \r as newline > > JBS: https://bugs.openjdk.java.net/browse/JDK-8176033 > 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/raw-rev/01d26dcf5eac > > This very small change was pointed out to me as worth doing, it's another > trap waiting for people who vary the cygwin version in their Windows build > environment. > > The 8u diff is pasted below.? The 9 changeset didn't "hg import" from, but > the affected lines are the same, using TR to delete characters rather than > relying on grep.? Plus rebuilding generated-configure.sh with the autogen > script. > > Thanks > Kevin > > > bash-4.2$ hg diff common/autoconf/basics_windows.m4 > diff -r cddffb220808 common/autoconf/basics_windows.m4 > --- a/common/autoconf/basics_windows.m4 Fri Apr 06 04:20:26 2018 -0700 > +++ b/common/autoconf/basics_windows.m4 Fri Apr 06 14:20:35 2018 -0700 > @@ -321,8 +321,8 @@ > ?????? AC_MSG_ERROR([Something is wrong with your cygwin installation since > I cannot find cygpath.exe in your path]) > ???? fi > ???? AC_MSG_CHECKING([cygwin root directory as unix-style path]) > -??? # The cmd output ends with Windows line endings (CR/LF), the grep > command will strip that away > -??? cygwin_winpath_root=`cd / ; cmd /c cd | grep ".*"` > +??? # The cmd output ends with Windows line endings (CR/LF) > +??? cygwin_winpath_root=`cd / ; cmd /c cd | $TR -d '\r\n'` > ???? # Force cygpath to report the proper root by including a trailing > space, and then stripping it off again. > ???? CYGWIN_ROOT_PATH=`$CYGPATH -u "$cygwin_winpath_root " | $CUT -f 1 -d " > "` > ???? AC_MSG_RESULT([$CYGWIN_ROOT_PATH]) > > > From dipak.kumar at oracle.com Tue Apr 10 04:34:39 2018 From: dipak.kumar at oracle.com (Dipak Kumar) Date: Mon, 9 Apr 2018 21:34:39 -0700 (PDT) Subject: [8u] RFA for backport of JDK- 8152974 : AWT hang occurrs when sequenced events arrive out of sequence Message-ID: <4015d135-79fc-41eb-9202-8ed48b69884f@default> Hi, May I get the approval for backport of "JDK- 8152974 : AWT hang occurrs when sequenced events arrive out of sequence" to jdk8u-dev. JBS - https://bugs.openjdk.java.net/browse/JDK-8152974 JDK-11 review thread - http://mail.openjdk.java.net/pipermail/awt-dev/2018-February/013561.html http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013721.html JDK-11 changeset - http://hg.openjdk.java.net/jdk/client/rev/719064f540f3 JDK-8u webrev - http://cr.openjdk.java.net/~dkumar/8152974/8u-dev_Backport/webrev.00/ JDK-8u review thread - http://mail.openjdk.java.net/pipermail/awt-dev/2018-April/013818.html I have tested out all the relevant AWT JTREG tests. Also, ensured that there are no failures related to this on JPRT (Stockholm) queues. Thanks, Dipak From rob.mckenna at oracle.com Tue Apr 10 11:55:29 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 10 Apr 2018 12:55:29 +0100 Subject: [8u] RFA for backport of JDK- 8152974 : AWT hang occurrs when sequenced events arrive out of sequence In-Reply-To: <4015d135-79fc-41eb-9202-8ed48b69884f@default> References: <4015d135-79fc-41eb-9202-8ed48b69884f@default> Message-ID: <20180410115529.GA3924@tecra> Approved -Rob On 09/04/18 21:34, Dipak Kumar wrote: > Hi, > > > > May I get the approval for backport of "JDK- 8152974 : AWT hang occurrs when sequenced events arrive out of sequence" to jdk8u-dev. > > > > JBS - https://bugs.openjdk.java.net/browse/JDK-8152974 > > > JDK-11 review thread - http://mail.openjdk.java.net/pipermail/awt-dev/2018-February/013561.html > > http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013721.html > > > > JDK-11 changeset - http://hg.openjdk.java.net/jdk/client/rev/719064f540f3 > > > > JDK-8u webrev - http://cr.openjdk.java.net/~dkumar/8152974/8u-dev_Backport/webrev.00/ > > JDK-8u review thread - http://mail.openjdk.java.net/pipermail/awt-dev/2018-April/013818.html > > > > I have tested out all the relevant AWT JTREG tests. > > Also, ensured that there are no failures related to this on JPRT (Stockholm) queues. > > > > Thanks, > > Dipak > > From kevin.walls at oracle.com Tue Apr 10 15:05:59 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Tue, 10 Apr 2018 16:05:59 +0100 Subject: [8u-dev] Request for approval for CR 8034199: Add "reconfigure" target for re-creating a configuration AND 8035904 Message-ID: Hi, I'd like to request approval to backport from 9 to 8u: 8034199: Add "reconfigure" target for re-creating a configuration JBS: https://bugs.openjdk.java.net/browse/JDK-8034199 9 changeset: URL:?? http://hg.openjdk.java.net/jdk9/dev/rev/26ce5b43f3de User:? ihse Date:? 2014-02-13 22:38:21 +0000 9 review thread: https://marc.info/?l=openjdk-build-dev&m=139264595530270&w=2 This is a clean backport, plus regenerating common/autoconf/generated-configure.sh. 8034199 implies we need its follow-on bug 8035904: there was a build failure on machines with older bash versions, so a comparison with =~ was rewritten to use grep.? This problem still relevant for at least some of our Solaris builds. Hence this is also a request for approval for: 8035904: Solaris fastdebug builds are failing JBS: https://bugs.openjdk.java.net/browse/JDK-8035904 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/ee306f131815 9 review thread: http://mail.openjdk.java.net/pipermail/build-dev/2014-February/012008.html That is also a clean import to 8 with the 9 changeset. Thanks Kevin From rob.mckenna at oracle.com Tue Apr 10 16:18:35 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 10 Apr 2018 17:18:35 +0100 Subject: [8u-dev] Request for approval for CR 8034199: Add "reconfigure" target for re-creating a configuration AND 8035904 In-Reply-To: References: Message-ID: <20180410161835.GA3515@vimes> Approved -Rob On 10/04/18 16:05, Kevin Walls wrote: > Hi, > > I'd like to request approval to backport from 9 to 8u: > > 8034199: Add "reconfigure" target for re-creating a configuration > JBS: https://bugs.openjdk.java.net/browse/JDK-8034199 > > 9 changeset: > URL:?? http://hg.openjdk.java.net/jdk9/dev/rev/26ce5b43f3de > User:? ihse > Date:? 2014-02-13 22:38:21 +0000 > > > 9 review thread: > https://marc.info/?l=openjdk-build-dev&m=139264595530270&w=2 > > > This is a clean backport, plus regenerating > common/autoconf/generated-configure.sh. > > 8034199 implies we need its follow-on bug 8035904: there was a build failure > on machines with older bash versions, so a comparison with =~ was rewritten > to use grep.? This problem still relevant for at least some of our Solaris > builds. > > Hence this is also a request for approval for: > > 8035904: Solaris fastdebug builds are failing > JBS: https://bugs.openjdk.java.net/browse/JDK-8035904 > > 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/ee306f131815 > 9 review thread: > http://mail.openjdk.java.net/pipermail/build-dev/2014-February/012008.html > > That is also a clean import to 8 with the 9 changeset. > > Thanks > Kevin > > > From ivan.gerasimov at oracle.com Wed Apr 11 08:22:46 2018 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 11 Apr 2018 01:22:46 -0700 Subject: [8u-dev] 8178370 : [TEST_BUG] java/security/Signature/SignatureLength.java fails Message-ID: <476ca122-7ae4-84d2-b91c-a5f052da597d@oracle.com> Hello! I'd like to backport this test bug fix to jdk 8u-dev. The fix applies as is (modulo the file path change). The fixed test passes on all platforms. Bug: https://bugs.openjdk.java.net/browse/JDK-8178370 Jdk11 change: http://hg.openjdk.java.net/jdk/jdk/rev/f1a8ec1a6972 Jdk11 review: http://mail.openjdk.java.net/pipermail/security-dev/2018-March/016972.html Thanks in advance! -- With kind regards, Ivan Gerasimov From ramanand.patil at oracle.com Wed Apr 11 10:49:35 2018 From: ramanand.patil at oracle.com (Ramanand Patil) Date: Wed, 11 Apr 2018 03:49:35 -0700 (PDT) Subject: [8u-dev] Request for Approval: Backport of 8200359: (tz) Upgrade time-zone data to tzdata2018d Message-ID: Hi, Please approve the backport of 8200359 to 8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8200359 JDK Changeset: http://hg.openjdk.java.net/jdk/jdk/rev/dce997f9a93e JDK Review Thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2018-March/002488.html Changes apply cleanly to jdk8u-dev after path reshuffling. [Note: I am still waiting on jdk10u-fix-request for this bug]. Regards, Ramanand. From kevin.walls at oracle.com Wed Apr 11 10:50:09 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Wed, 11 Apr 2018 11:50:09 +0100 Subject: [8u-dev] Request for approval for CR 8034199: Add "reconfigure" target for re-creating a configuration AND 8035904 In-Reply-To: <20180410161835.GA3515@vimes> References: <20180410161835.GA3515@vimes> Message-ID: <899fea49-214d-9f84-cb80-b38eea562760@oracle.com> Thanks.? Actually I am retracting my approval request for 8035904. The 8034199 change is running fine in the systems I have tried. I was wrong in saying the =~ issue remains: the old bash version that caused problems (for that change in 2014, bash 3.00 was reported) is not in use on our build systems now. But I did now find a system that didn't like the -q and -E options to grep which 8035904 adds.? So I plan to push just 8034199 and note this in the bugs. Thanks Kevin On 10/04/2018 17:18, Rob McKenna wrote: > Approved > > -Rob > > On 10/04/18 16:05, Kevin Walls wrote: >> Hi, >> >> I'd like to request approval to backport from 9 to 8u: >> >> 8034199: Add "reconfigure" target for re-creating a configuration >> JBS: https://bugs.openjdk.java.net/browse/JDK-8034199 >> >> 9 changeset: >> URL:?? http://hg.openjdk.java.net/jdk9/dev/rev/26ce5b43f3de >> User:? ihse >> Date:? 2014-02-13 22:38:21 +0000 >> >> >> 9 review thread: >> https://marc.info/?l=openjdk-build-dev&m=139264595530270&w=2 >> >> >> This is a clean backport, plus regenerating >> common/autoconf/generated-configure.sh. >> >> 8034199 implies we need its follow-on bug 8035904: there was a build failure >> on machines with older bash versions, so a comparison with =~ was rewritten >> to use grep.? This problem still relevant for at least some of our Solaris >> builds. >> >> Hence this is also a request for approval for: >> >> 8035904: Solaris fastdebug builds are failing >> JBS: https://bugs.openjdk.java.net/browse/JDK-8035904 >> >> 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/ee306f131815 >> 9 review thread: >> http://mail.openjdk.java.net/pipermail/build-dev/2014-February/012008.html >> >> That is also a clean import to 8 with the 9 changeset. >> >> Thanks >> Kevin >> >> >> From david.buck at oracle.com Wed Apr 11 10:51:09 2018 From: david.buck at oracle.com (David Buck) Date: Wed, 11 Apr 2018 19:51:09 +0900 Subject: [8u-dev] Request for Approval: Backport of 8200359: (tz) Upgrade time-zone data to tzdata2018d In-Reply-To: References: Message-ID: approved for backport to 8u-dev Cheers, -Buck > On Apr 11, 2018, at 19:49, Ramanand Patil wrote: > > Hi, > Please approve the backport of 8200359 to 8u-dev. > Bug: https://bugs.openjdk.java.net/browse/JDK-8200359 > JDK Changeset: http://hg.openjdk.java.net/jdk/jdk/rev/dce997f9a93e > JDK Review Thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2018-March/002488.html > > Changes apply cleanly to jdk8u-dev after path reshuffling. > > [Note: I am still waiting on jdk10u-fix-request for this bug]. > > Regards, > Ramanand. From rob.mckenna at oracle.com Wed Apr 11 15:22:32 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 11 Apr 2018 16:22:32 +0100 Subject: [8u-dev] 8178370 : [TEST_BUG] java/security/Signature/SignatureLength.java fails In-Reply-To: <476ca122-7ae4-84d2-b91c-a5f052da597d@oracle.com> References: <476ca122-7ae4-84d2-b91c-a5f052da597d@oracle.com> Message-ID: <20180411152232.GA3390@vimes> Approved -Rob On 11/04/18 01:22, Ivan Gerasimov wrote: > Hello! > > I'd like to backport this test bug fix to jdk 8u-dev. > > The fix applies as is (modulo the file path change). > > The fixed test passes on all platforms. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8178370 > > Jdk11 change: http://hg.openjdk.java.net/jdk/jdk/rev/f1a8ec1a6972 > > Jdk11 review: > http://mail.openjdk.java.net/pipermail/security-dev/2018-March/016972.html > > Thanks in advance! > > -- > With kind regards, > Ivan Gerasimov > From kevin.walls at oracle.com Thu Apr 12 12:38:49 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Thu, 12 Apr 2018 13:38:49 +0100 Subject: [8u-dev] Request for approval: 8035495: Improvements in autoconf integration AND 8035825 Message-ID: <8988cc9d-39cd-b384-4d1d-ba27fbe91bae@oracle.com> Hi, I'd like to request approval of this backport from 9 to 8u: 8035495: Improvements in autoconf integration JBS: https://bugs.openjdk.java.net/browse/JDK-8035495 9 changeset: URL: http://hg.openjdk.java.net/jdk9/dev/rev/6e29cd9ac2b4 9 review: http://mail.openjdk.java.net/pipermail/build-dev/2014-February/011963.html There was a follow-on bug which I'll apply at the same time, which was: 8035825: Warn instead of fail when calling the configure wrapper directly JBS: https://bugs.openjdk.java.net/browse/JDK-8035825 9 changeset: URL: http://hg.openjdk.java.net/jdk9/dev/rev/e7872d8abd12 9 review: http://mail.openjdk.java.net/pipermail/build-dev/2014-February/011988.html This required some manual editing just for the change at the start of common/autoconf/configure. 8u webrev with them both: http://cr.openjdk.java.net/~kevinw/8035495/webrev.00/ build-dev review of the 8u backport: http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021665.html Many thanks! Kevin From kevin.walls at oracle.com Thu Apr 12 12:55:32 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Thu, 12 Apr 2018 13:55:32 +0100 Subject: [8u-dev] Request for approval for CR JDK-8035730: Configure fails in cygwin if current dir is in /home/user Message-ID: <670df559-79cc-d7ab-5cdf-11a84d593ca0@oracle.com> Hi, I'd like to request approval to backport from 9 to 8u: JDK-8035730: Configure fails in cygwin if current dir is in /home/user JBS: https://bugs.openjdk.java.net/browse/JDK-8035730 9 changeset: URL: http://hg.openjdk.java.net/jdk9/dev/rev/73d85b04c45c User: ihse Date: 2014-02-27 08:42:52 +0000 9 review thread: http://mail.openjdk.java.net/pipermail/build-dev/2014-February/011979.html This is a clean backport, after 8035495 and 8035825 are applied, so can go ahead if they are approved. Many thanks Kevin From aleksej.efimov at oracle.com Thu Apr 12 14:35:05 2018 From: aleksej.efimov at oracle.com (Aleks Efimov) Date: Thu, 12 Apr 2018 15:35:05 +0100 Subject: [8u-dev] RFR (XXS): 8067239: [TESTBUG] javax/xml/bind/marshal/8036981/Test.java failed Message-ID: Hi, javax/xml/bind/marshal/8036981/Test.java test is failing on all compact profiles. The full JRE is required to run this test. The proposed fix is to add the test to needs_jre test group: diff -r 2edaf51db818 test/TEST.groups --- a/test/TEST.groups +++ b/test/TEST.groups @@ -393,6 +393,7 @@ ?? javax/management/mxbean/LeakTest.java \ ?? javax/management/mxbean/MXBeanTest.java \ ?? javax/management/mxbean/PropertyNamesTest.java \ +? javax/xml/bind/marshal/8036981/Test.java \ ?? javax/xml/bind/marshal/8134111/UnmarshalTest.java \ ?? javax/xml/ws/8043129 \ ?? jdk/lambda/vm/InterfaceAccessFlagsTest.java \ This test is available in JDK8 only. Thank you and Best Regards, Aleksei From lance.andersen at oracle.com Thu Apr 12 14:36:13 2018 From: lance.andersen at oracle.com (Lance Andersen) Date: Thu, 12 Apr 2018 10:36:13 -0400 Subject: [8u-dev] RFR (XXS): 8067239: [TESTBUG] javax/xml/bind/marshal/8036981/Test.java failed In-Reply-To: References: Message-ID: +1 > On Apr 12, 2018, at 10:35 AM, Aleks Efimov wrote: > > Hi, > > javax/xml/bind/marshal/8036981/Test.java test is failing on all compact profiles. The full JRE is required to run this test. The proposed fix is to add the test to needs_jre test group: > diff -r 2edaf51db818 test/TEST.groups > --- a/test/TEST.groups > +++ b/test/TEST.groups > @@ -393,6 +393,7 @@ > javax/management/mxbean/LeakTest.java \ > javax/management/mxbean/MXBeanTest.java \ > javax/management/mxbean/PropertyNamesTest.java \ > + javax/xml/bind/marshal/8036981/Test.java \ > javax/xml/bind/marshal/8134111/UnmarshalTest.java \ > javax/xml/ws/8043129 \ > jdk/lambda/vm/InterfaceAccessFlagsTest.java \ > > This test is available in JDK8 only. > > Thank you and Best Regards, > Aleksei > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From sean.coffey at oracle.com Thu Apr 12 14:37:25 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 12 Apr 2018 15:37:25 +0100 Subject: [8u-dev] RFR (XXS): 8067239: [TESTBUG] javax/xml/bind/marshal/8036981/Test.java failed In-Reply-To: References: Message-ID: Looks fine. regards, Sean. On 12/04/2018 15:35, Aleks Efimov wrote: > Hi, > > javax/xml/bind/marshal/8036981/Test.java test is failing on all > compact profiles. The full JRE is required to run this test. The > proposed fix is to add the test to needs_jre test group: > diff -r 2edaf51db818 test/TEST.groups > --- a/test/TEST.groups > +++ b/test/TEST.groups > @@ -393,6 +393,7 @@ > ?? javax/management/mxbean/LeakTest.java \ > ?? javax/management/mxbean/MXBeanTest.java \ > ?? javax/management/mxbean/PropertyNamesTest.java \ > +? javax/xml/bind/marshal/8036981/Test.java \ > ?? javax/xml/bind/marshal/8134111/UnmarshalTest.java \ > ?? javax/xml/ws/8043129 \ > ?? jdk/lambda/vm/InterfaceAccessFlagsTest.java \ > > This test is available in JDK8 only. > > Thank you and Best Regards, > Aleksei > From aleksej.efimov at oracle.com Thu Apr 12 14:40:27 2018 From: aleksej.efimov at oracle.com (Aleks Efimov) Date: Thu, 12 Apr 2018 15:40:27 +0100 Subject: [8u-dev] RFR (XXS): 8067239: [TESTBUG] javax/xml/bind/marshal/8036981/Test.java failed In-Reply-To: References: Message-ID: Lance, Sean, Thank you for the super-fast review! With Best Regards, Aleksei On 04/12/2018 03:37 PM, Se?n Coffey wrote: > Looks fine. > > regards, > Sean. > > > On 12/04/2018 15:35, Aleks Efimov wrote: >> Hi, >> >> javax/xml/bind/marshal/8036981/Test.java test is failing on all >> compact profiles. The full JRE is required to run this test. The >> proposed fix is to add the test to needs_jre test group: >> diff -r 2edaf51db818 test/TEST.groups >> --- a/test/TEST.groups >> +++ b/test/TEST.groups >> @@ -393,6 +393,7 @@ >> ?? javax/management/mxbean/LeakTest.java \ >> ?? javax/management/mxbean/MXBeanTest.java \ >> ?? javax/management/mxbean/PropertyNamesTest.java \ >> +? javax/xml/bind/marshal/8036981/Test.java \ >> ?? javax/xml/bind/marshal/8134111/UnmarshalTest.java \ >> ?? javax/xml/ws/8043129 \ >> ?? jdk/lambda/vm/InterfaceAccessFlagsTest.java \ >> >> This test is available in JDK8 only. >> >> Thank you and Best Regards, >> Aleksei >> > From rob.mckenna at oracle.com Thu Apr 12 15:45:04 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 12 Apr 2018 16:45:04 +0100 Subject: [8u-dev] Request for approval: 8035495: Improvements in autoconf integration AND 8035825 In-Reply-To: <8988cc9d-39cd-b384-4d1d-ba27fbe91bae@oracle.com> References: <8988cc9d-39cd-b384-4d1d-ba27fbe91bae@oracle.com> Message-ID: <20180412154504.GB4640@vimes> Approved -Rob On 12/04/18 13:38, Kevin Walls wrote: > Hi, > > I'd like to request approval of this backport from 9 to 8u: > > 8035495: Improvements in autoconf integration > JBS: https://bugs.openjdk.java.net/browse/JDK-8035495 > 9 changeset: URL: http://hg.openjdk.java.net/jdk9/dev/rev/6e29cd9ac2b4 > 9 review: > http://mail.openjdk.java.net/pipermail/build-dev/2014-February/011963.html > > > There was a follow-on bug which I'll apply at the same time, which was: > > 8035825: Warn instead of fail when calling the configure wrapper directly > JBS: https://bugs.openjdk.java.net/browse/JDK-8035825 > 9 changeset: URL: http://hg.openjdk.java.net/jdk9/dev/rev/e7872d8abd12 > 9 review: > http://mail.openjdk.java.net/pipermail/build-dev/2014-February/011988.html > > This required some manual editing just for the change at the start of > common/autoconf/configure. > > > 8u webrev with them both: > http://cr.openjdk.java.net/~kevinw/8035495/webrev.00/ > > build-dev review of the 8u backport: > http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021665.html > > Many thanks! > Kevin > > > From rob.mckenna at oracle.com Thu Apr 12 15:45:16 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 12 Apr 2018 16:45:16 +0100 Subject: [8u-dev] Request for approval for CR JDK-8035730: Configure fails in cygwin if current dir is in /home/user In-Reply-To: <670df559-79cc-d7ab-5cdf-11a84d593ca0@oracle.com> References: <670df559-79cc-d7ab-5cdf-11a84d593ca0@oracle.com> Message-ID: <20180412154516.GC4640@vimes> Approved -Rob On 12/04/18 13:55, Kevin Walls wrote: > Hi, > > I'd like to request approval to backport from 9 to 8u: > > JDK-8035730: Configure fails in cygwin if current dir is in /home/user > JBS: https://bugs.openjdk.java.net/browse/JDK-8035730 > > 9 changeset: > URL: http://hg.openjdk.java.net/jdk9/dev/rev/73d85b04c45c > User: ihse > Date: 2014-02-27 08:42:52 +0000 > > > 9 review thread: http://mail.openjdk.java.net/pipermail/build-dev/2014-February/011979.html > > This is a clean backport, after 8035495 and 8035825 are applied, so can go ahead if they are approved. > > Many thanks > Kevin > From andreas.liebscher at mobilexag.de Thu Apr 12 17:49:45 2018 From: andreas.liebscher at mobilexag.de (Andreas Liebscher) Date: Thu, 12 Apr 2018 17:49:45 +0000 Subject: Where to find JRE Installer for Windows? Message-ID: <1d0a309aba4748e29871f5f5d710120a@mobilexag.de> Where can I find a installer downlaod for der latest released (161) OpenJDK JRE version for Windows? I searched on https://github.com/ojdkbuild/ojdkbuild but only found JDK Installer there. For the not yet relased 172 there I found an installer on http://jdk.java.net/8/ Andreas From shade at redhat.com Fri Apr 13 15:20:46 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 13 Apr 2018 17:20:46 +0200 Subject: [8u] Request for approval for JDK-8169201: Montgomery multiply intrinsic should use correct name In-Reply-To: References: Message-ID: <14d87da6-d826-1510-15ec-a627788e2fda@redhat.com> (realized this was never pushed) Ping? -Aleksey On 03/21/2018 04:54 PM, Aleksey Shipilev wrote: > It is a really trivial patch: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/110b1774a359 > > diff -r 96e9e479ff8a src/share/vm/opto/library_call.cpp > --- a/src/share/vm/opto/library_call.cpp Thu Aug 24 01:27:02 2017 -0400 > +++ b/src/share/vm/opto/library_call.cpp Wed Mar 21 16:49:39 2018 +0100 > @@ -6026,7 +6026,7 @@ > } > > assert(UseMontgomeryMultiplyIntrinsic, "not implemented on this platform"); > - const char* stubName = "montgomery_square"; > + const char* stubName = "montgomery_multiply"; > > assert(callee()->signature()->size() == 7, "montgomeryMultiply has 7 parameters"); > > > It applies with a bit of fuzz to jdk8-dev. > > JDK 9 bug: > https://bugs.openjdk.java.net/browse/JDK-8169201 > > JDK 9 RFR: > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-November/024899.html > > We need this to avoid weird bugs in code that relies on intrinsic names: > http://mail.openjdk.java.net/pipermail/aarch64-port-dev/2018-March/005424.html > > Thanks, > -Aleksey > From dalibor.topic at oracle.com Fri Apr 13 15:44:51 2018 From: dalibor.topic at oracle.com (dalibor topic) Date: Fri, 13 Apr 2018 17:44:51 +0200 Subject: Where to find JRE Installer for Windows? In-Reply-To: <1d0a309aba4748e29871f5f5d710120a@mobilexag.de> References: <1d0a309aba4748e29871f5f5d710120a@mobilexag.de> Message-ID: Hi Andreas, binary installers for OpenJDK binaries have started to be provided with JDK 9 and later. For earlier versions, you'll need to look for suitable third party builds for your Windows version. cheersm dalibor topic On 12.04.2018 19:49, Andreas Liebscher wrote: > Where can I find a installer downlaod for der latest released (161) OpenJDK JRE version for Windows? > I searched on https://github.com/ojdkbuild/ojdkbuild but only found JDK Installer there. > > For the not yet relased 172 there I found an installer on http://jdk.java.net/8/ > > Andreas > -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment From shade at redhat.com Fri Apr 13 16:22:25 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 13 Apr 2018 18:22:25 +0200 Subject: [8u-dev] Request for approval JDK-8173013: JVMTI tagged object access needs G1 pre-barrier Message-ID: <8105ca31-d8b5-f46b-a769-09e052751ae0@redhat.com> Hi, Please approve the backport of this fix to 8u. This theoretically makes G1 more stable in 8u, although I could not reproduce the failure with current G1 in 8u-dev (the reproducer is time-sensitive). The absence of this fix causes problems with Shenandoah JDK 8 backport, which is supposed to piggyback on G1 pre-barriers. JDK 9 bug: https://bugs.openjdk.java.net/browse/JDK-8173013 JDK 9 change: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/6c280bbde146 The patch needs to change include path to "gc_implementation", due to repository reshuffling: diff -r 7fae638af89d src/share/vm/prims/jvmtiTagMap.cpp --- a/src/share/vm/prims/jvmtiTagMap.cpp Thu Nov 10 23:26:56 2016 -0800 +++ b/src/share/vm/prims/jvmtiTagMap.cpp Fri Apr 13 17:25:08 2018 +0200 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -47,6 +47,7 @@ #include "services/serviceUtil.hpp" #include "utilities/macros.hpp" #if INCLUDE_ALL_GCS +#include "gc_implementation/g1/g1SATBCardTableModRefBS.hpp" #include "gc_implementation/parallelScavenge/parallelScavengeHeap.hpp" #endif // INCLUDE_ALL_GCS @@ -1519,6 +1520,14 @@ if (_tags[i] == entry->tag()) { oop o = entry->object(); assert(o != NULL && Universe::heap()->is_in_reserved(o), "sanity check"); +#if INCLUDE_ALL_GCS + if (UseG1GC) { + // The reference in this tag map could be the only (implicitly weak) + // reference to that object. If we hand it out, we need to keep it live wrt + // SATB marking similar to other j.l.ref.Reference referents. + G1SATBCardTableModRefBS::enqueue(o); + } +#endif jobject ref = JNIHandles::make_local(JavaThread::current(), o); _object_results->append(ref); _tag_results->append((uint64_t)entry->tag()); Testing: x86_64 build Thanks, -Aleksey From shade at redhat.com Fri Apr 13 16:45:54 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 13 Apr 2018 18:45:54 +0200 Subject: [8u-dev] Request for approval JDK-8165489: Missing G1 barrier in Unsafe_GetObjectVolatile Message-ID: <53443eaa-fbbd-1238-b4c5-6373e43535ca@redhat.com> Hi, Please approve this fix for 8u. This improves G1 stability in 8u, and provides the base for Shenandoah JDK 8 backport that piggybacks on G1 pre-barriers. The fix does not apply cleanly, because there is also Unsafe_GetObject140 that needs fixing too. JDK 9 bug: https://bugs.openjdk.java.net/browse/JDK-8165489 JDK 9 fix: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a696583f5ddb JDK 8u fix: http://cr.openjdk.java.net/~shade/8165489-8u/webrev.01/ Testing: x86_64 build, Shenandoah tests Thanks, -Aleksey From rob.mckenna at oracle.com Fri Apr 13 16:58:21 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 13 Apr 2018 17:58:21 +0100 Subject: [8u] Request for approval for JDK-8169201: Montgomery multiply intrinsic should use correct name In-Reply-To: <14d87da6-d826-1510-15ec-a627788e2fda@redhat.com> References: <14d87da6-d826-1510-15ec-a627788e2fda@redhat.com> Message-ID: <20180413165821.GA4943@vimes> Approved -Rob On 13/04/18 17:20, Aleksey Shipilev wrote: > (realized this was never pushed) > > Ping? > > -Aleksey > > On 03/21/2018 04:54 PM, Aleksey Shipilev wrote: > > It is a really trivial patch: > > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/110b1774a359 > > > > diff -r 96e9e479ff8a src/share/vm/opto/library_call.cpp > > --- a/src/share/vm/opto/library_call.cpp Thu Aug 24 01:27:02 2017 -0400 > > +++ b/src/share/vm/opto/library_call.cpp Wed Mar 21 16:49:39 2018 +0100 > > @@ -6026,7 +6026,7 @@ > > } > > > > assert(UseMontgomeryMultiplyIntrinsic, "not implemented on this platform"); > > - const char* stubName = "montgomery_square"; > > + const char* stubName = "montgomery_multiply"; > > > > assert(callee()->signature()->size() == 7, "montgomeryMultiply has 7 parameters"); > > > > > > It applies with a bit of fuzz to jdk8-dev. > > > > JDK 9 bug: > > https://bugs.openjdk.java.net/browse/JDK-8169201 > > > > JDK 9 RFR: > > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-November/024899.html > > > > We need this to avoid weird bugs in code that relies on intrinsic names: > > http://mail.openjdk.java.net/pipermail/aarch64-port-dev/2018-March/005424.html > > > > Thanks, > > -Aleksey > > > > From rob.mckenna at oracle.com Fri Apr 13 17:00:26 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 13 Apr 2018 18:00:26 +0100 Subject: [8u-dev] Request for approval JDK-8173013: JVMTI tagged object access needs G1 pre-barrier In-Reply-To: <8105ca31-d8b5-f46b-a769-09e052751ae0@redhat.com> References: <8105ca31-d8b5-f46b-a769-09e052751ae0@redhat.com> Message-ID: <20180413170026.GB4943@vimes> Approved. Please add a suitable noreg label. -Rob On 13/04/18 18:22, Aleksey Shipilev wrote: > Hi, > > Please approve the backport of this fix to 8u. This theoretically makes G1 more stable in 8u, > although I could not reproduce the failure with current G1 in 8u-dev (the reproducer is > time-sensitive). The absence of this fix causes problems with Shenandoah JDK 8 backport, which is > supposed to piggyback on G1 pre-barriers. > > JDK 9 bug: > https://bugs.openjdk.java.net/browse/JDK-8173013 > > JDK 9 change: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/6c280bbde146 > > The patch needs to change include path to "gc_implementation", due to repository reshuffling: > > diff -r 7fae638af89d src/share/vm/prims/jvmtiTagMap.cpp > --- a/src/share/vm/prims/jvmtiTagMap.cpp Thu Nov 10 23:26:56 2016 -0800 > +++ b/src/share/vm/prims/jvmtiTagMap.cpp Fri Apr 13 17:25:08 2018 +0200 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -47,6 +47,7 @@ > #include "services/serviceUtil.hpp" > #include "utilities/macros.hpp" > #if INCLUDE_ALL_GCS > +#include "gc_implementation/g1/g1SATBCardTableModRefBS.hpp" > #include "gc_implementation/parallelScavenge/parallelScavengeHeap.hpp" > #endif // INCLUDE_ALL_GCS > > @@ -1519,6 +1520,14 @@ > if (_tags[i] == entry->tag()) { > oop o = entry->object(); > assert(o != NULL && Universe::heap()->is_in_reserved(o), "sanity check"); > +#if INCLUDE_ALL_GCS > + if (UseG1GC) { > + // The reference in this tag map could be the only (implicitly weak) > + // reference to that object. If we hand it out, we need to keep it live wrt > + // SATB marking similar to other j.l.ref.Reference referents. > + G1SATBCardTableModRefBS::enqueue(o); > + } > +#endif > jobject ref = JNIHandles::make_local(JavaThread::current(), o); > _object_results->append(ref); > _tag_results->append((uint64_t)entry->tag()); > > > Testing: x86_64 build > > Thanks, > -Aleksey From shade at redhat.com Fri Apr 13 17:17:11 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 13 Apr 2018 19:17:11 +0200 Subject: [8u] Request for approval for JDK-8169201: Montgomery multiply intrinsic should use correct name In-Reply-To: <20180413165821.GA4943@vimes> References: <14d87da6-d826-1510-15ec-a627788e2fda@redhat.com> <20180413165821.GA4943@vimes> Message-ID: <07f24f0b-5bf1-e226-7a09-6a0b01ece701@redhat.com> Thanks! Please remind me, do I still need Oracle sponsor to push to 8u-dev? -Aleksey On 04/13/2018 06:58 PM, Rob McKenna wrote: > Approved > > -Rob > > On 13/04/18 17:20, Aleksey Shipilev wrote: >> (realized this was never pushed) >> >> Ping? >> >> -Aleksey >> >> On 03/21/2018 04:54 PM, Aleksey Shipilev wrote: >>> It is a really trivial patch: >>> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/110b1774a359 >>> >>> diff -r 96e9e479ff8a src/share/vm/opto/library_call.cpp >>> --- a/src/share/vm/opto/library_call.cpp Thu Aug 24 01:27:02 2017 -0400 >>> +++ b/src/share/vm/opto/library_call.cpp Wed Mar 21 16:49:39 2018 +0100 >>> @@ -6026,7 +6026,7 @@ >>> } >>> >>> assert(UseMontgomeryMultiplyIntrinsic, "not implemented on this platform"); >>> - const char* stubName = "montgomery_square"; >>> + const char* stubName = "montgomery_multiply"; >>> >>> assert(callee()->signature()->size() == 7, "montgomeryMultiply has 7 parameters"); >>> >>> >>> It applies with a bit of fuzz to jdk8-dev. >>> >>> JDK 9 bug: >>> https://bugs.openjdk.java.net/browse/JDK-8169201 >>> >>> JDK 9 RFR: >>> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-November/024899.html >>> >>> We need this to avoid weird bugs in code that relies on intrinsic names: >>> http://mail.openjdk.java.net/pipermail/aarch64-port-dev/2018-March/005424.html >>> >>> Thanks, >>> -Aleksey >>> >> >> From rob.mckenna at oracle.com Fri Apr 13 19:52:01 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 13 Apr 2018 20:52:01 +0100 Subject: [8u] Request for approval for JDK-8169201: Montgomery multiply intrinsic should use correct name In-Reply-To: <07f24f0b-5bf1-e226-7a09-6a0b01ece701@redhat.com> References: <14d87da6-d826-1510-15ec-a627788e2fda@redhat.com> <20180413165821.GA4943@vimes> <07f24f0b-5bf1-e226-7a09-6a0b01ece701@redhat.com> Message-ID: <20180413195201.GC4943@vimes> Not according to http://openjdk.java.net/census#shade -Rob On 13/04/18 10:17, Aleksey Shipilev wrote: > Thanks! > > Please remind me, do I still need Oracle sponsor to push to 8u-dev? > > -Aleksey > > On 04/13/2018 06:58 PM, Rob McKenna wrote: > > Approved > > > > -Rob > > > > On 13/04/18 17:20, Aleksey Shipilev wrote: > >> (realized this was never pushed) > >> > >> Ping? > >> > >> -Aleksey > >> > >> On 03/21/2018 04:54 PM, Aleksey Shipilev wrote: > >>> It is a really trivial patch: > >>> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/110b1774a359 > >>> > >>> diff -r 96e9e479ff8a src/share/vm/opto/library_call.cpp > >>> --- a/src/share/vm/opto/library_call.cpp Thu Aug 24 01:27:02 2017 -0400 > >>> +++ b/src/share/vm/opto/library_call.cpp Wed Mar 21 16:49:39 2018 +0100 > >>> @@ -6026,7 +6026,7 @@ > >>> } > >>> > >>> assert(UseMontgomeryMultiplyIntrinsic, "not implemented on this platform"); > >>> - const char* stubName = "montgomery_square"; > >>> + const char* stubName = "montgomery_multiply"; > >>> > >>> assert(callee()->signature()->size() == 7, "montgomeryMultiply has 7 parameters"); > >>> > >>> > >>> It applies with a bit of fuzz to jdk8-dev. > >>> > >>> JDK 9 bug: > >>> https://bugs.openjdk.java.net/browse/JDK-8169201 > >>> > >>> JDK 9 RFR: > >>> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-November/024899.html > >>> > >>> We need this to avoid weird bugs in code that relies on intrinsic names: > >>> http://mail.openjdk.java.net/pipermail/aarch64-port-dev/2018-March/005424.html > >>> > >>> Thanks, > >>> -Aleksey > >>> > >> > >> > From kevin.walls at oracle.com Fri Apr 13 20:48:34 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Fri, 13 Apr 2018 21:48:34 +0100 Subject: [8u-dev] Request for approval: 8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris Message-ID: Hi, I'd like to request approval for this backport from 9 to 8u: 8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris JBS: https://bugs.openjdk.java.net/browse/JDK-8038340 9 changesets: base repo: http://hg.openjdk.java.net/jdk9/dev/rev/9786ef8ca58c (requires some manual fixup for 8u) JDK: repo: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/fdeb6a8b0f3a (clean import to jdk8u-dev) 9 review thread: http://mail.openjdk.java.net/pipermail/2d-dev/2014-April/004361.html (thread starts in March, not that it's long, but I don't see a link there to the previous emails in the thread: http://mail.openjdk.java.net/pipermail/2d-dev/2014-March/004333.html ) 8u webrev: http://cr.openjdk.java.net/~kevinw/8038340/webrev.00/ build-dev review of this backport: http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021730.html Many thanks! Kevin From david.buck at oracle.com Sat Apr 14 00:06:07 2018 From: david.buck at oracle.com (David Buck) Date: Sat, 14 Apr 2018 09:06:07 +0900 Subject: [8u-dev] Request for approval: 8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris In-Reply-To: References: Message-ID: approved Cheers, -Buck On 2018/04/14 5:48, Kevin Walls wrote: > Hi, > > I'd like to request approval for this backport from 9 to 8u: > > 8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris > JBS: https://bugs.openjdk.java.net/browse/JDK-8038340 > > 9 changesets: > base repo: http://hg.openjdk.java.net/jdk9/dev/rev/9786ef8ca58c > (requires some manual fixup for 8u) > JDK: repo: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/fdeb6a8b0f3a > (clean import to jdk8u-dev) > > 9 review thread: > http://mail.openjdk.java.net/pipermail/2d-dev/2014-April/004361.html > (thread starts in March, not that it's long, but I don't see a link > there to the previous emails in the thread: > http://mail.openjdk.java.net/pipermail/2d-dev/2014-March/004333.html ) > > 8u webrev: http://cr.openjdk.java.net/~kevinw/8038340/webrev.00/ > > build-dev review of this backport: > http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021730.html > > Many thanks! > Kevin > From rob.mckenna at oracle.com Mon Apr 16 13:41:27 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 16 Apr 2018 14:41:27 +0100 Subject: [8u-dev] Request for approval JDK-8165489: Missing G1 barrier in Unsafe_GetObjectVolatile In-Reply-To: <53443eaa-fbbd-1238-b4c5-6373e43535ca@redhat.com> References: <53443eaa-fbbd-1238-b4c5-6373e43535ca@redhat.com> Message-ID: <20180416134127.GA2862@vimes> This change requires a codereview. As one hasn't been explicitly requested in the subject line, then HS reviewers may overlook this email. -Rob On 13/04/18 18:45, Aleksey Shipilev wrote: > Hi, > > Please approve this fix for 8u. This improves G1 stability in 8u, and provides the base for > Shenandoah JDK 8 backport that piggybacks on G1 pre-barriers. The fix does not apply cleanly, > because there is also Unsafe_GetObject140 that needs fixing too. > > JDK 9 bug: > https://bugs.openjdk.java.net/browse/JDK-8165489 > > JDK 9 fix: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a696583f5ddb > > JDK 8u fix: > http://cr.openjdk.java.net/~shade/8165489-8u/webrev.01/ > > Testing: x86_64 build, Shenandoah tests > > Thanks, > -Aleksey From sean.coffey at oracle.com Mon Apr 16 14:02:34 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Mon, 16 Apr 2018 15:02:34 +0100 Subject: [8u] Request for enhancement backport approval for CR JDK-8158012: Use SW prefetch instructions instead of BIS for allocation prefetches on SPARC Core C4 In-Reply-To: <5e15804c-203f-71b0-9825-929b732b7d0d@oracle.com> References: <5e15804c-203f-71b0-9825-929b732b7d0d@oracle.com> Message-ID: <6cb3d85d-4beb-58b6-588f-e4668dd20747@oracle.com> Muthusamy, Apologies for the long delay here. This enhancement request looks good for porting to jdk8u. Please proceed with push approval request. Regards, Sean. On 30/08/17 11:29, Se?n Coffey wrote: > Muthusamy, > > thanks for the mail. This will be evaluated and I hope to get back > with a decision shortly. > > Regards, > Sean. > > On 30/08/17 10:37, Muthusamy Chinnathambi wrote: >> Hi, >> >> May I get the approval of enhancement backport of 'JDK-8158012: Use >> SW prefetch instructions instead of BIS for allocation prefetches on >> SPARC Core C4' to jdk8u-dev. >> >> Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8158012 >> >> Rational: This change which adjusts the default prefetching mechanism >> only on Oracle SPARC Core C4 processor based systems can offer >> significant performance improvements. >> >> I have tested it with the jprt and jtreg tests. >> >> Regards, >> Muthusamy C > From shade at redhat.com Mon Apr 16 14:05:03 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 16 Apr 2018 16:05:03 +0200 Subject: [8u-dev] RFR (S) JDK-8165489: Missing G1 barrier in Unsafe_GetObjectVolatile In-Reply-To: <20180416134127.GA2862@vimes> References: <53443eaa-fbbd-1238-b4c5-6373e43535ca@redhat.com> <20180416134127.GA2862@vimes> Message-ID: Resending with better subject line, hopefully HS reviewers would see it. -Aleksey On 04/16/2018 03:41 PM, Rob McKenna wrote: > This change requires a codereview. As one hasn't been explicitly > requested in the subject line, then HS reviewers may overlook this > email. > > -Rob > > On 13/04/18 18:45, Aleksey Shipilev wrote: >> Hi, >> >> Please approve this fix for 8u. This improves G1 stability in 8u, and provides the base for >> Shenandoah JDK 8 backport that piggybacks on G1 pre-barriers. The fix does not apply cleanly, >> because there is also Unsafe_GetObject140 that needs fixing too. >> >> JDK 9 bug: >> https://bugs.openjdk.java.net/browse/JDK-8165489 >> >> JDK 9 fix: >> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a696583f5ddb >> >> JDK 8u fix: >> http://cr.openjdk.java.net/~shade/8165489-8u/webrev.01/ >> >> Testing: x86_64 build, Shenandoah tests >> >> Thanks, >> -Aleksey From david.holmes at oracle.com Mon Apr 16 21:55:31 2018 From: david.holmes at oracle.com (David Holmes) Date: Tue, 17 Apr 2018 07:55:31 +1000 Subject: [8u-dev] RFR (S) JDK-8165489: Missing G1 barrier in Unsafe_GetObjectVolatile In-Reply-To: References: <53443eaa-fbbd-1238-b4c5-6373e43535ca@redhat.com> <20180416134127.GA2862@vimes> Message-ID: On 17/04/2018 12:05 AM, Aleksey Shipilev wrote: > Resending with better subject line, hopefully HS reviewers would see it. You need to send to hotspot alias to get a code review. David > -Aleksey > > On 04/16/2018 03:41 PM, Rob McKenna wrote: >> This change requires a codereview. As one hasn't been explicitly >> requested in the subject line, then HS reviewers may overlook this >> email. >> >> -Rob >> >> On 13/04/18 18:45, Aleksey Shipilev wrote: >>> Hi, >>> >>> Please approve this fix for 8u. This improves G1 stability in 8u, and provides the base for >>> Shenandoah JDK 8 backport that piggybacks on G1 pre-barriers. The fix does not apply cleanly, >>> because there is also Unsafe_GetObject140 that needs fixing too. >>> >>> JDK 9 bug: >>> https://bugs.openjdk.java.net/browse/JDK-8165489 >>> >>> JDK 9 fix: >>> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a696583f5ddb >>> >>> JDK 8u fix: >>> http://cr.openjdk.java.net/~shade/8165489-8u/webrev.01/ >>> >>> Testing: x86_64 build, Shenandoah tests >>> >>> Thanks, >>> -Aleksey > > From kevin.walls at oracle.com Tue Apr 17 11:27:14 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Tue, 17 Apr 2018 12:27:14 +0100 Subject: [8u-dev] Request for approval for CR 8138692: libjsig compilation is missing EXTRA_CFLAGS on macosx Message-ID: <25021863-0fd3-8a75-f91d-8536f7e0e1a6@oracle.com> Hi, I'd like to request approval to backport from 9 to 8u: 8138692: libjsig compilation is missing EXTRA_CFLAGS on macosx JBS: https://bugs.openjdk.java.net/browse/JDK-8138692 9 changeset: URL: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/38bd261644c0 9 review thread http://mail.openjdk.java.net/pipermail/build-dev/2015-October/015650.html This is a clean backport in the hotspot repo, the addition of $(EXTRA_CFLAGS) in make/bsd/makefiles/jsig.make. Thanks Kevin From rob.mckenna at oracle.com Tue Apr 17 14:40:21 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 17 Apr 2018 15:40:21 +0100 Subject: [8u-dev] Request for approval for CR 8138692: libjsig compilation is missing EXTRA_CFLAGS on macosx In-Reply-To: <25021863-0fd3-8a75-f91d-8536f7e0e1a6@oracle.com> References: <25021863-0fd3-8a75-f91d-8536f7e0e1a6@oracle.com> Message-ID: <20180417144021.GB4017@vimes> Approved -Rob On 17/04/18 12:27, Kevin Walls wrote: > Hi, > > I'd like to request approval to backport from 9 to 8u: > > 8138692: libjsig compilation is missing EXTRA_CFLAGS on macosx > JBS: https://bugs.openjdk.java.net/browse/JDK-8138692 > > 9 changeset: > URL: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/38bd261644c0 > > 9 review thread > http://mail.openjdk.java.net/pipermail/build-dev/2015-October/015650.html > > This is a clean backport in the hotspot repo, the addition of > $(EXTRA_CFLAGS) in make/bsd/makefiles/jsig.make. > > Thanks > Kevin > > > From shade at redhat.com Tue Apr 17 16:04:18 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 17 Apr 2018 18:04:18 +0200 Subject: [8u-dev] RFR (S) JDK-8165489: Missing G1 barrier in Unsafe_GetObjectVolatile In-Reply-To: References: <53443eaa-fbbd-1238-b4c5-6373e43535ca@redhat.com> <20180416134127.GA2862@vimes> Message-ID: OK, trying again with copying hotspot-dev at . -Aleksey On 04/16/2018 11:55 PM, David Holmes wrote: > On 17/04/2018 12:05 AM, Aleksey Shipilev wrote: >> Resending with better subject line, hopefully HS reviewers would see it. > > You need to send to hotspot alias to get a code review. > > David > >> -Aleksey >> >> On 04/16/2018 03:41 PM, Rob McKenna wrote: >>> This change requires a codereview. As one hasn't been explicitly >>> requested in the subject line, then HS reviewers may overlook this >>> email. >>> >>> ???? -Rob >>> >>> On 13/04/18 18:45, Aleksey Shipilev wrote: >>>> Hi, >>>> >>>> Please approve this fix for 8u. This improves G1 stability in 8u, and provides the base for >>>> Shenandoah JDK 8 backport that piggybacks on G1 pre-barriers. The fix does not apply cleanly, >>>> because there is also Unsafe_GetObject140 that needs fixing too. >>>> >>>> JDK 9 bug: >>>> ?? https://bugs.openjdk.java.net/browse/JDK-8165489 >>>> >>>> JDK 9 fix: >>>> ?? http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a696583f5ddb >>>> >>>> JDK 8u fix: >>>> ?? http://cr.openjdk.java.net/~shade/8165489-8u/webrev.01/ >>>> >>>> Testing: x86_64 build, Shenandoah tests >>>> >>>> Thanks, >>>> -Aleksey >> >> From abhi.saha at oracle.com Tue Apr 17 17:57:43 2018 From: abhi.saha at oracle.com (Abhijit Saha) Date: Tue, 17 Apr 2018 10:57:43 -0700 Subject: [8u] Request for approval for bulk changes from 8u172 fixes into 8u Message-ID: <9642e188-896a-a9de-1be5-dd6759d1c845@oracle.com> 8u172 has been released earlier today [1]. Requesting approval to sync up the 8u172 changes into the jdk8u forest. Webrev: http://cr.openjdk.java.net/~asaha/openJDK.8u172-8u192.sync/webrev Thanks Abhijit [1] http://www.oracle.com/technetwork/java/javase/downloads/index.html -- Java Platform Group Oracle Corporation. (408)276-7564 From rob.mckenna at oracle.com Tue Apr 17 19:04:17 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 17 Apr 2018 20:04:17 +0100 Subject: [8u] Request for approval for bulk changes from 8u172 fixes into 8u In-Reply-To: <9642e188-896a-a9de-1be5-dd6759d1c845@oracle.com> References: <9642e188-896a-a9de-1be5-dd6759d1c845@oracle.com> Message-ID: <20180417190417.GC4017@vimes> Approved -Rob On 17/04/18 10:57, Abhijit Saha wrote: > 8u172 has been released earlier today [1]. Requesting approval to sync up > the 8u172 changes into the jdk8u forest. > > Webrev: http://cr.openjdk.java.net/~asaha/openJDK.8u172-8u192.sync/webrev > > > > Thanks > Abhijit > > > [1] http://www.oracle.com/technetwork/java/javase/downloads/index.html > > > -- > Java Platform Group > Oracle Corporation. > (408)276-7564 > From muthusamy.chinnathambi at oracle.com Wed Apr 18 08:22:25 2018 From: muthusamy.chinnathambi at oracle.com (Muthusamy Chinnathambi) Date: Wed, 18 Apr 2018 01:22:25 -0700 (PDT) Subject: [8u] Request for enhancement backport approval for CR JDK-8158012: Use SW prefetch instructions instead of BIS for allocation prefetches on SPARC Core C4 In-Reply-To: <6cb3d85d-4beb-58b6-588f-e4668dd20747@oracle.com> References: <5e15804c-203f-71b0-9825-929b732b7d0d@oracle.com> <6cb3d85d-4beb-58b6-588f-e4668dd20747@oracle.com> Message-ID: Thanks Sean. I will initiate push request soon. Regards, Muthusamy C -----Original Message----- From: Se?n Coffey Sent: Monday, April 16, 2018 7:33 PM To: Muthusamy Chinnathambi ; jdk8u-dev at openjdk.java.net Subject: Re: [8u] Request for enhancement backport approval for CR JDK-8158012: Use SW prefetch instructions instead of BIS for allocation prefetches on SPARC Core C4 Muthusamy, Apologies for the long delay here. This enhancement request looks good for porting to jdk8u. Please proceed with push approval request. Regards, Sean. On 30/08/17 11:29, Se?n Coffey wrote: > Muthusamy, > > thanks for the mail. This will be evaluated and I hope to get back > with a decision shortly. > > Regards, > Sean. > > On 30/08/17 10:37, Muthusamy Chinnathambi wrote: >> Hi, >> >> May I get the approval of enhancement backport of 'JDK-8158012: Use >> SW prefetch instructions instead of BIS for allocation prefetches on >> SPARC Core C4' to jdk8u-dev. >> >> Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8158012 >> >> Rational: This change which adjusts the default prefetching mechanism >> only on Oracle SPARC Core C4 processor based systems can offer >> significant performance improvements. >> >> I have tested it with the jprt and jtreg tests. >> >> Regards, >> Muthusamy C > From kevin.walls at oracle.com Wed Apr 18 15:30:08 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Wed, 18 Apr 2018 16:30:08 +0100 Subject: [8u-dev] Request for approval for CR 8179079: Incremental HotSpot builds broken on Windows Message-ID: Hi, I'd like to request approval to backport from jdk10 to 8u: 8179079: Incremental HotSpot builds broken on Windows JBS: https://bugs.openjdk.java.net/browse/JDK-8179079 10 changeset: http://hg.openjdk.java.net/jdk10/jdk10/rev/6426c94ee05f Original review thread: http://mail.openjdk.java.net/pipermail/build-dev/2017-April/019046.html It's not quite a clean backport, the same code is present but the sed pattern is in a variable in later JDKs. Proposed 8u change: pasted below. Thanks Kevin diff -r 7a73b8b4ac8a -r 310b1d9c5772 make/common/NativeCompilation.gmk --- a/make/common/NativeCompilation.gmk Mon Apr 16 00:48:00 2018 -0700 +++ b/make/common/NativeCompilation.gmk Wed Apr 18 03:57:40 2018 -0700 @@ -116,6 +116,7 @@ ????????? ($(ECHO) $$@: \\ \ ????????? && $(SED) -e '/^Note: including file:/!d' \ ????????????? -e 's|Note: including file: *||' \ +????????? -e 's|\r||g' \ ????????????? -e 's|\\|/|g' \ ????????????? -e 's|^\([a-zA-Z]\):|/cygdrive/\1|g' \ ????????????? -e '/$(subst /,\/,$(TOPDIR))/!d' \ From kevin.walls at oracle.com Wed Apr 18 15:34:37 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Wed, 18 Apr 2018 16:34:37 +0100 Subject: [8u-dev] Request for approval for CR 8022177: Windows/MSYS builds broken Message-ID: <555ac801-b755-6328-a780-f6f975c9e1d8@oracle.com> Hi, I'd like to request approval to backport from 9 to 8u: 8022177: Windows/MSYS builds broken JBS: https://bugs.openjdk.java.net/browse/JDK-8022177 9 changeset: URL: http://hg.openjdk.java.net/jdk9/dev/rev/13255d60e919 9 review thread: http://mail.openjdk.java.net/pipermail/build-dev/2014-August/012920.html We're not claiming any specific support for MinGW the minimalist GNU for Windows, this is more about getting the refactoring/naming changes which make further changes easier. This is a clean backport, except for the change in flags.m4: in later JDKs (since 8037825), we have warnings as errors, but we don't do that in 8u so I won't apply that line. Plus I regenerate generated-configure.sh. Thanks Kevin From kevin.walls at oracle.com Wed Apr 18 16:32:37 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Wed, 18 Apr 2018 17:32:37 +0100 Subject: [8u-dev] Request for approval for CR 8057538: Build the freetype library during configure on Windows Message-ID: <63d4ff74-3d50-e573-9d6d-69d0120eff1f@oracle.com> Hi, I'd like to request approval to backport from 9 to 8u: 8057538: Build the freetype library during configure on Windows JBS: https://bugs.openjdk.java.net/browse/JDK-8057538 9 changeset: URL: http://hg.openjdk.java.net/jdk9/dev/rev/5d7de212359d 9 review thread: http://mail.openjdk.java.net/pipermail/build-dev/2014-September/013240.html This request is not so much about freetype, but about backporting changes which make further changes easier. To clarify, bulding freetype from source is a new option, not compulsory. This imports cleanly to 8u, (in my clone where I've applied 8022177 already), except the generated file which we rebuild. Thanks Kevin From alexey.ivanov at oracle.com Wed Apr 18 17:13:34 2018 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Wed, 18 Apr 2018 18:13:34 +0100 Subject: [8u-dev] RFA for JDK-8179079: Incremental HotSpot builds broken on Windows In-Reply-To: References: <1841530b-5d3f-d3d8-1e0b-b2db5c6a2e34@oracle.com> Message-ID: <00101d99-f2c3-3746-5b23-d47ab4048088@oracle.com> Hi, Could you please approve this backport to 8u? Regards, Alexey On 18/04/2018 16:27, Erik Joelsson wrote: > Looks good. Thanks for taking care of this backport! > > /Erik > > > On 2018-04-18 05:06, Alexey Ivanov wrote: >> Hi, >> >> Could you please review the following backport of the build fix for >> Windows: >> >> jbs: https://bugs.openjdk.java.net/browse/JDK-8179079 >> review: >> http://mail.openjdk.java.net/pipermail/build-dev/2017-April/019045.html >> changeset: http://hg.openjdk.java.net/jdk10/jdk10/rev/6426c94ee05f >> >> The patch does not apply to 8u: >> webrev: http://cr.openjdk.java.net/~aivanov/8179079/jdk8/webrev.0/ >> >> >> This problem exists in 8u builds as well. If you try to rebuild 8u, >> you'll get errors: >> >> make[2]: *** No rule to make target >> '/cygdrive/c/ade/work/jdk8u/build/windows-x86-normal-server-release/jdk/include/jni.h >> ', needed by >> '/cygdrive/c/ade/work/jdk8u/build/windows-x86-normal-server-release/jdk/objs/libverify/check_code.obj'. >> Stop. >> >> It's because the generated dependency file contain CR (\r) character >> at the end of the file name and make interprets it as part of the >> file name. >> >> >> Thank you! >> >> Regards, >> Alexey > From alexey.ivanov at oracle.com Wed Apr 18 17:21:03 2018 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Wed, 18 Apr 2018 18:21:03 +0100 Subject: [8u-dev] RFA for JDK-8179079: Incremental HotSpot builds broken on Windows In-Reply-To: <00101d99-f2c3-3746-5b23-d47ab4048088@oracle.com> References: <1841530b-5d3f-d3d8-1e0b-b2db5c6a2e34@oracle.com> <00101d99-f2c3-3746-5b23-d47ab4048088@oracle.com> Message-ID: Sorry for duplicate request. Kevin proposes the same changeset, I'll let Kevin proceed as he has many other build tweaks. -- Regards, Alexey On 18/04/2018 18:13, Alexey Ivanov wrote: > Hi, > > Could you please approve this backport to 8u? > > > Regards, > Alexey > > On 18/04/2018 16:27, Erik Joelsson wrote: >> Looks good. Thanks for taking care of this backport! >> >> /Erik >> >> >> On 2018-04-18 05:06, Alexey Ivanov wrote: >>> Hi, >>> >>> Could you please review the following backport of the build fix for >>> Windows: >>> >>> jbs: https://bugs.openjdk.java.net/browse/JDK-8179079 >>> review: >>> http://mail.openjdk.java.net/pipermail/build-dev/2017-April/019045.html >>> changeset: http://hg.openjdk.java.net/jdk10/jdk10/rev/6426c94ee05f >>> >>> The patch does not apply to 8u: >>> webrev: http://cr.openjdk.java.net/~aivanov/8179079/jdk8/webrev.0/ >>> >>> >>> This problem exists in 8u builds as well. If you try to rebuild 8u, >>> you'll get errors: >>> >>> make[2]: *** No rule to make target >>> '/cygdrive/c/ade/work/jdk8u/build/windows-x86-normal-server-release/jdk/include/jni.h >>> ', needed by >>> '/cygdrive/c/ade/work/jdk8u/build/windows-x86-normal-server-release/jdk/objs/libverify/check_code.obj'. >>> Stop. >>> >>> It's because the generated dependency file contain CR (\r) character >>> at the end of the file name and make interprets it as part of the >>> file name. >>> >>> >>> Thank you! >>> >>> Regards, >>> Alexey >> > From david.buck at oracle.com Thu Apr 19 00:59:59 2018 From: david.buck at oracle.com (David Buck) Date: Thu, 19 Apr 2018 09:59:59 +0900 Subject: [8u-dev] Request for approval for CR 8022177: Windows/MSYS builds broken In-Reply-To: <555ac801-b755-6328-a780-f6f975c9e1d8@oracle.com> References: <555ac801-b755-6328-a780-f6f975c9e1d8@oracle.com> Message-ID: <17db15cd-ab97-1a92-a1b3-826d656c10a6@oracle.com> approved Cheers, -Buck On 2018/04/19 0:34, Kevin Walls wrote: > Hi, > > I'd like to request approval to backport from 9 to 8u: > > 8022177: Windows/MSYS builds broken > JBS: https://bugs.openjdk.java.net/browse/JDK-8022177 > > 9 changeset: > URL:?? http://hg.openjdk.java.net/jdk9/dev/rev/13255d60e919 > > 9 review thread: > http://mail.openjdk.java.net/pipermail/build-dev/2014-August/012920.html > > > We're not claiming any specific support for MinGW the minimalist GNU for > Windows, this is more about getting the refactoring/naming > changes which make further changes easier. > > This is a clean backport, except for the change in flags.m4: in later > JDKs (since 8037825), we have warnings as errors, > but we don't do that in 8u so I won't apply that line. > > Plus I regenerate generated-configure.sh. > > Thanks > Kevin > From david.buck at oracle.com Thu Apr 19 01:05:19 2018 From: david.buck at oracle.com (David Buck) Date: Thu, 19 Apr 2018 10:05:19 +0900 Subject: [8u-dev] Request for approval for CR 8057538: Build the freetype library during configure on Windows In-Reply-To: <63d4ff74-3d50-e573-9d6d-69d0120eff1f@oracle.com> References: <63d4ff74-3d50-e573-9d6d-69d0120eff1f@oracle.com> Message-ID: <3bc25fd2-ab26-62b8-e002-0ce3177aa757@oracle.com> approved Cheers, -Buck On 2018/04/19 1:32, Kevin Walls wrote: > > Hi, > > I'd like to request approval to backport from 9 to 8u: > > 8057538: Build the freetype library during configure on Windows > JBS: https://bugs.openjdk.java.net/browse/JDK-8057538 > > 9 changeset: > URL: http://hg.openjdk.java.net/jdk9/dev/rev/5d7de212359d > > 9 review thread: > http://mail.openjdk.java.net/pipermail/build-dev/2014-September/013240.html > > > This request is not so much about freetype, but about backporting > changes which make further changes easier. > > To clarify, bulding freetype from source is a new option, not compulsory. > > This imports cleanly to 8u, (in my clone where I've applied 8022177 > already), except the generated file which we rebuild. > > Thanks > Kevin > From david.buck at oracle.com Thu Apr 19 01:09:33 2018 From: david.buck at oracle.com (David Buck) Date: Thu, 19 Apr 2018 10:09:33 +0900 Subject: [8u-dev] Request for approval for CR 8057538: Build the freetype library during configure on Windows In-Reply-To: <63d4ff74-3d50-e573-9d6d-69d0120eff1f@oracle.com> References: <63d4ff74-3d50-e573-9d6d-69d0120eff1f@oracle.com> Message-ID: <80bf37ee-a06c-d6c8-3f93-06e7d32cbb25@oracle.com> approved Cheers, -Buck On 2018/04/19 1:32, Kevin Walls wrote: > > Hi, > > I'd like to request approval to backport from 9 to 8u: > > 8057538: Build the freetype library during configure on Windows > JBS: https://bugs.openjdk.java.net/browse/JDK-8057538 > > 9 changeset: > URL: http://hg.openjdk.java.net/jdk9/dev/rev/5d7de212359d > > 9 review thread: > http://mail.openjdk.java.net/pipermail/build-dev/2014-September/013240.html > > > This request is not so much about freetype, but about backporting > changes which make further changes easier. > > To clarify, bulding freetype from source is a new option, not compulsory. > > This imports cleanly to 8u, (in my clone where I've applied 8022177 > already), except the generated file which we rebuild. > > Thanks > Kevin > From david.buck at oracle.com Thu Apr 19 01:11:54 2018 From: david.buck at oracle.com (David Buck) Date: Thu, 19 Apr 2018 10:11:54 +0900 Subject: [8u-dev] Request for approval for CR 8179079: Incremental HotSpot builds broken on Windows In-Reply-To: References: Message-ID: <813174a3-1a56-f0b5-1ec5-bedb438f52c8@oracle.com> approved Cheers, -Buck On 2018/04/19 0:30, Kevin Walls wrote: > > Hi, > > I'd like to request approval to backport from jdk10 to 8u: > > 8179079: Incremental HotSpot builds broken on Windows > JBS: https://bugs.openjdk.java.net/browse/JDK-8179079 > > 10 changeset: > http://hg.openjdk.java.net/jdk10/jdk10/rev/6426c94ee05f > > Original review thread: > http://mail.openjdk.java.net/pipermail/build-dev/2017-April/019046.html > > It's not quite a clean backport, the same code is present but the sed > pattern is in a variable in later JDKs. > Proposed 8u change: pasted below. > > Thanks > Kevin > > > > diff -r 7a73b8b4ac8a -r 310b1d9c5772 make/common/NativeCompilation.gmk > --- a/make/common/NativeCompilation.gmk Mon Apr 16 00:48:00 2018 -0700 > +++ b/make/common/NativeCompilation.gmk Wed Apr 18 03:57:40 2018 -0700 > @@ -116,6 +116,7 @@ > ????????? ($(ECHO) $$@: \\ \ > ????????? && $(SED) -e '/^Note: including file:/!d' \ > ????????????? -e 's|Note: including file: *||' \ > +????????? -e 's|\r||g' \ > ????????????? -e 's|\\|/|g' \ > ????????????? -e 's|^\([a-zA-Z]\):|/cygdrive/\1|g' \ > ????????????? -e '/$(subst /,\/,$(TOPDIR))/!d' \ > From muthusamy.chinnathambi at oracle.com Fri Apr 20 11:15:28 2018 From: muthusamy.chinnathambi at oracle.com (Muthusamy Chinnathambi) Date: Fri, 20 Apr 2018 04:15:28 -0700 (PDT) Subject: [8u] RFA JDK-8158012: Use SW prefetch instructions instead of BIS for allocation prefetches on SPARC Core C4 Message-ID: <7f3b67b1-1e27-4034-a981-c08b8bc7a3da@default> Hi, May I get the approval of backport of 'JDK-8158012: Use SW prefetch instructions instead of BIS for allocation prefetches on SPARC Core C4' to jdk8u. Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8158012 Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-December/025089.html Jdk8 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-July/027561.html http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-August/028107.html Enhancement request approval thread: http://mail.openjdk.java.net/pipermail/jdk8u-dev/2017-August/006880.html http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-April/007392.html Regards, Muthusamy C From rob.mckenna at oracle.com Fri Apr 20 12:47:52 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 20 Apr 2018 13:47:52 +0100 Subject: [8u] RFA JDK-8158012: Use SW prefetch instructions instead of BIS for allocation prefetches on SPARC Core C4 In-Reply-To: <7f3b67b1-1e27-4034-a981-c08b8bc7a3da@default> References: <7f3b67b1-1e27-4034-a981-c08b8bc7a3da@default> Message-ID: <20180420124752.GA4333@vimes> Approved -Rob On 20/04/18 04:15, Muthusamy Chinnathambi wrote: > Hi, > > May I get the approval of backport of 'JDK-8158012: Use SW prefetch instructions instead of BIS for allocation prefetches on SPARC Core C4' to jdk8u. > > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8158012 > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-December/025089.html > Jdk8 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-July/027561.html > http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-August/028107.html > Enhancement request approval thread: http://mail.openjdk.java.net/pipermail/jdk8u-dev/2017-August/006880.html > http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-April/007392.html > > Regards, > Muthusamy C From aleksej.efimov at oracle.com Fri Apr 20 16:40:44 2018 From: aleksej.efimov at oracle.com (Aleks Efimov) Date: Fri, 20 Apr 2018 17:40:44 +0100 Subject: [jdk8u-dev] RFR: 8196491: Newlines in JAXB string values of SOAP-requests are escaped to " " Message-ID: <482f1e92-9734-8d31-b98f-37ac30b804c3@oracle.com> Hello, Would you, please, review the fix for JAXWS regression bug [1] that has been introduced by a fix that tried to preserve whitespaces in WS parameters [2]. The proposed fix addresses the reported UnsupportedOperationException and brings the JDK7 and JDK8 in-sync in terms of white-space processing: http://cr.openjdk.java.net/~aefimov/8196491/8/00 The fix has been integrated already into JAXWS/B-RI projects [3][4]. Regression and JCK tests showed no failures with the fix. With Best Regards, Aleksei [1] JBS bug: https://bugs.openjdk.java.net/browse/JDK-8196491 [2] Fix caused regression: https://bugs.openjdk.java.net/browse/JDK-8172297 [3] JAXWS-RI fix: https://github.com/javaee/metro-jax-ws/commit/5a06cb2d0b5ef884cc87ef431e7add458322aab8 [4] JAXB-RI fix: https://github.com/javaee/jaxb-v2/commit/8f1e74a7d3439d7f4c3f07689337c00d9e915628 From lance.andersen at oracle.com Fri Apr 20 17:15:24 2018 From: lance.andersen at oracle.com (Lance Andersen) Date: Fri, 20 Apr 2018 13:15:24 -0400 Subject: [jdk8u-dev] RFR: 8196491: Newlines in JAXB string values of SOAP-requests are escaped to " " In-Reply-To: <482f1e92-9734-8d31-b98f-37ac30b804c3@oracle.com> References: <482f1e92-9734-8d31-b98f-37ac30b804c3@oracle.com> Message-ID: <312A2EE0-1603-4C1A-9544-591365FE48F6@oracle.com> The changes look OK Aleks Best Lance > On Apr 20, 2018, at 12:40 PM, Aleks Efimov wrote: > > Hello, > > Would you, please, review the fix for JAXWS regression bug [1] that has been introduced by a fix that tried to preserve whitespaces in WS parameters [2]. > The proposed fix addresses the reported UnsupportedOperationException and brings the JDK7 and JDK8 in-sync in terms of white-space processing: > http://cr.openjdk.java.net/~aefimov/8196491/8/00 > > The fix has been integrated already into JAXWS/B-RI projects [3][4]. Regression and JCK tests showed no failures with the fix. > > With Best Regards, > Aleksei > > [1] JBS bug: https://bugs.openjdk.java.net/browse/JDK-8196491 > [2] Fix caused regression: https://bugs.openjdk.java.net/browse/JDK-8172297 > [3] JAXWS-RI fix: https://github.com/javaee/metro-jax-ws/commit/5a06cb2d0b5ef884cc87ef431e7add458322aab8 > [4] JAXB-RI fix: https://github.com/javaee/jaxb-v2/commit/8f1e74a7d3439d7f4c3f07689337c00d9e915628 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From jheffron at forcepoint.com Fri Apr 20 18:51:44 2018 From: jheffron at forcepoint.com (Heffron, Jim) Date: Fri, 20 Apr 2018 18:51:44 +0000 Subject: final release 8u172 Message-ID: Looking at http://hg.openjdk.java.net/jdk8u/jdk8u Is jdk8u172-b11 the final build for the release? Or are we anticipating another merge and tag? The main webpage: http://openjdk.java.net/projects/jdk8u/ marks 8u162 as the last released version Thanks, JIM HEFFRON FORCEPOINT From rob.mckenna at oracle.com Fri Apr 20 20:51:16 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 20 Apr 2018 21:51:16 +0100 Subject: final release 8u172 In-Reply-To: References: Message-ID: <20180420205116.GC4333@vimes> 8u172 is the final build. Our project page tends to lag reality by an indeterminate amount of time. Thanks for the reminder. -Rob On 20/04/18 18:51, Heffron, Jim wrote: > Looking at http://hg.openjdk.java.net/jdk8u/jdk8u > > Is jdk8u172-b11 the final build for the release? Or are we anticipating another merge and tag? > > The main webpage: http://openjdk.java.net/projects/jdk8u/ marks 8u162 as the last released version > > Thanks, > > JIM HEFFRON > FORCEPOINT > > From david.buck at oracle.com Mon Apr 23 08:35:38 2018 From: david.buck at oracle.com (David Buck) Date: Mon, 23 Apr 2018 17:35:38 +0900 Subject: [8u] RFA: 8134157: adlc fails to compile with SS12u4 Message-ID: <189b2320-5f96-bc8b-dd1e-ba2c67933b01@oracle.com> Hi! Please approve this small backport to 8u-dev: bug report: https://bugs.openjdk.java.net/browse/JDK-8134157 JDK 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/c64d134410a7 JDK 9 review thread: http://mail.openjdk.java.net/pipermail/build-dev/2015-August/015480.html JDK 9 fix applies as-is to JDK 8u source. JPRT hotspot testset run and passed. Manually verified efficacy of fix. Cheers, -Buck From roman.grigoriadi at oracle.com Mon Apr 23 04:18:51 2018 From: roman.grigoriadi at oracle.com (Roman Grigoriadi) Date: Mon, 23 Apr 2018 06:18:51 +0200 Subject: [jdk8u-dev] RFR: 8196491: Newlines in JAXB string values of SOAP-requests are escaped to " " In-Reply-To: <482f1e92-9734-8d31-b98f-37ac30b804c3@oracle.com> References: <482f1e92-9734-8d31-b98f-37ac30b804c3@oracle.com> Message-ID: <6E4D9DFD-0128-4EB2-A8EF-5E052CFC358D@oracle.com> Looks good to me. -Roman > On 20 Apr 2018, at 18:40, Aleks Efimov wrote: > > Hello, > > Would you, please, review the fix for JAXWS regression bug [1] that has been introduced by a fix that tried to preserve whitespaces in WS parameters [2]. > The proposed fix addresses the reported UnsupportedOperationException and brings the JDK7 and JDK8 in-sync in terms of white-space processing: > http://cr.openjdk.java.net/~aefimov/8196491/8/00 > > The fix has been integrated already into JAXWS/B-RI projects [3][4]. Regression and JCK tests showed no failures with the fix. > > With Best Regards, > Aleksei > > [1] JBS bug: https://bugs.openjdk.java.net/browse/JDK-8196491 > [2] Fix caused regression: https://bugs.openjdk.java.net/browse/JDK-8172297 > [3] JAXWS-RI fix: https://github.com/javaee/metro-jax-ws/commit/5a06cb2d0b5ef884cc87ef431e7add458322aab8 > [4] JAXB-RI fix: https://github.com/javaee/jaxb-v2/commit/8f1e74a7d3439d7f4c3f07689337c00d9e915628 From rob.mckenna at oracle.com Mon Apr 23 14:16:36 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 23 Apr 2018 15:16:36 +0100 Subject: [8u] RFA: 8134157: adlc fails to compile with SS12u4 In-Reply-To: <189b2320-5f96-bc8b-dd1e-ba2c67933b01@oracle.com> References: <189b2320-5f96-bc8b-dd1e-ba2c67933b01@oracle.com> Message-ID: <20180423141636.GA3341@vimes> Approved -Rob On 23/04/18 17:35, David Buck wrote: > Hi! > > Please approve this small backport to 8u-dev: > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8134157 > > JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/c64d134410a7 > > JDK 9 review thread: > http://mail.openjdk.java.net/pipermail/build-dev/2015-August/015480.html > > JDK 9 fix applies as-is to JDK 8u source. JPRT hotspot testset run and > passed. Manually verified efficacy of fix. > > Cheers, > -Buck From dipak.kumar at oracle.com Tue Apr 24 04:26:08 2018 From: dipak.kumar at oracle.com (Dipak Kumar) Date: Mon, 23 Apr 2018 21:26:08 -0700 (PDT) Subject: [8u] RFA for backport of JDK- 8195095 : Images are not scaled correctly in JEditorPane Message-ID: <2905d59d-5a09-4886-bcc0-701d4a01e7c0@default> Hi, May I get the approval for backport of " JDK- 8195095 : Images are not scaled correctly in JEditorPane" to jdk8u-dev. JBS - https://bugs.openjdk.java.net/browse/JDK-8195095 JDK-11 review thread - http://mail.openjdk.java.net/pipermail/swing-dev/2018-March/008389.html JDK-11 changeset - http://hg.openjdk.java.net/jdk/client/rev/8d8f74e84ff6 JDK-8u webrev - http://cr.openjdk.java.net/~dkumar/8195095/8u_backport/webrev.00/ JDK-8u review thread - http://mail.openjdk.java.net/pipermail/swing-dev/2018-April/008538.html I have tested out all the relevant AWT JTREG tests. Also, ensured that there are no failures related to this on JPRT (Stockholm) queues. Thanks, Dipak From fairoz.matte at oracle.com Tue Apr 24 08:56:01 2018 From: fairoz.matte at oracle.com (Fairoz Matte) Date: Tue, 24 Apr 2018 01:56:01 -0700 (PDT) Subject: [8u-dev] Request for Approval: Backport of 6730115 : Fastdebug VM crashes with "ExceptionMark destructor expects no pending exceptions" error Message-ID: Hi, Please approve the backport of 6730115 to 8u-dev Bug - https://bugs.openjdk.java.net/browse/JDK-6730115 JDK9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/23c27f9ae1e8 JDK9 Review Thread: http://mail.openjdk.java.net/pipermail/jdk9-hs-rt-changes/2013-December/000009.html Changes apply cleanly to jdk8u-dev. No issues found in JPRT Thanks, Fairoz From david.buck at oracle.com Tue Apr 24 09:26:43 2018 From: david.buck at oracle.com (David Buck) Date: Tue, 24 Apr 2018 18:26:43 +0900 Subject: [8u] RFA for backport of JDK- 8195095 : Images are not scaled correctly in JEditorPane In-Reply-To: <2905d59d-5a09-4886-bcc0-701d4a01e7c0@default> References: <2905d59d-5a09-4886-bcc0-701d4a01e7c0@default> Message-ID: approved Cheers, -Buck > On Apr 24, 2018, at 13:26, Dipak Kumar wrote: > > Hi, > > May I get the approval for backport of " JDK- 8195095 : Images are not scaled correctly in JEditorPane" to jdk8u-dev. > > JBS - https://bugs.openjdk.java.net/browse/JDK-8195095 > JDK-11 review thread - http://mail.openjdk.java.net/pipermail/swing-dev/2018-March/008389.html > JDK-11 changeset - http://hg.openjdk.java.net/jdk/client/rev/8d8f74e84ff6 > JDK-8u webrev - http://cr.openjdk.java.net/~dkumar/8195095/8u_backport/webrev.00/ > JDK-8u review thread - http://mail.openjdk.java.net/pipermail/swing-dev/2018-April/008538.html > > I have tested out all the relevant AWT JTREG tests. > Also, ensured that there are no failures related to this on JPRT (Stockholm) queues. > > Thanks, > Dipak From alexey.ivanov at oracle.com Tue Apr 24 09:32:52 2018 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Tue, 24 Apr 2018 10:32:52 +0100 Subject: [8u-dev] RFA for JDK-8201433: Fix potential crash in BufImg_SetupICM In-Reply-To: <8863f361-4335-5f46-e5ab-6295822fadcf@oracle.com> References: <67d364ee-8d47-c8a2-d9e1-3f734e8f399e@oracle.com> <8863f361-4335-5f46-e5ab-6295822fadcf@oracle.com> Message-ID: <6d520009-ca50-ca64-24eb-c72bb93bf16b@oracle.com> Hi, I'd like to request approval for this backport to 8u-dev. Backport review thread: http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009162.html Thank you in advance. On 24/04/2018 00:44, Sergey Bylokhov wrote: > Looks fine. > > On 23/04/2018 03:44, Alexey Ivanov wrote: >> Hi, >> >> Could you please review the following backport to 8u-dev? >> >> jbs: https://bugs.openjdk.java.net/browse/JDK-8201433 >> review: >> http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009129.html >> jdk11 changeset: http://hg.openjdk.java.net/jdk/client/rev/4ed714d1f90b >> >> >> The patch does not apply cleanly to 8u: >> webrev: http://cr.openjdk.java.net/~aivanov/8201433/jdk8/webrev.0/ >> >> Thank you! >> >> Regards, >> Alexey > -- Regards, Alexey From alexey.ivanov at oracle.com Tue Apr 24 09:34:35 2018 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Tue, 24 Apr 2018 10:34:35 +0100 Subject: [8u-dev] RFA for JDK-8201240: Improve releasing native resources of BufImgSurfaceData.ICMColorData In-Reply-To: References: Message-ID: <7c522e9c-3ecf-61ef-a515-919461954a25@oracle.com> Hi, I'd like to request approval for this backport to 8u-dev. Backport review thread: http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009163.html Thank you in advance. On 24/04/2018 00:46, Sergey Bylokhov wrote: > Looks fine. > > On 23/04/2018 03:49, Alexey Ivanov wrote: >> Hi, >> >> Could you please review the following backport to 8u-dev? >> >> jbs: https://bugs.openjdk.java.net/browse/JDK-8201240 >> review: >> http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009122.html >> jdk11 changeset: http://hg.openjdk.java.net/jdk/client/rev/69f7e3ed043c >> >> >> The patch does not apply cleanly to 8u and also requires changes to >> map files: >> webrev: http://cr.openjdk.java.net/~aivanov/8201240/jdk8/webrev.0/ >> >> Thank you! >> >> Regards, >> Alexey > -- Regards, Alexey From david.buck at oracle.com Tue Apr 24 09:34:21 2018 From: david.buck at oracle.com (David Buck) Date: Tue, 24 Apr 2018 18:34:21 +0900 Subject: [8u-dev] RFA for JDK-8201433: Fix potential crash in BufImg_SetupICM In-Reply-To: <6d520009-ca50-ca64-24eb-c72bb93bf16b@oracle.com> References: <67d364ee-8d47-c8a2-d9e1-3f734e8f399e@oracle.com> <8863f361-4335-5f46-e5ab-6295822fadcf@oracle.com> <6d520009-ca50-ca64-24eb-c72bb93bf16b@oracle.com> Message-ID: approved Cheers, -Buck > On Apr 24, 2018, at 18:32, Alexey Ivanov wrote: > > Hi, > > I'd like to request approval for this backport to 8u-dev. > > Backport review thread: > http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009162.html > > Thank you in advance. > > > On 24/04/2018 00:44, Sergey Bylokhov wrote: >> Looks fine. >> >> On 23/04/2018 03:44, Alexey Ivanov wrote: >>> Hi, >>> >>> Could you please review the following backport to 8u-dev? >>> >>> jbs: https://bugs.openjdk.java.net/browse/JDK-8201433 >>> review: http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009129.html >>> jdk11 changeset: http://hg.openjdk.java.net/jdk/client/rev/4ed714d1f90b >>> >>> >>> The patch does not apply cleanly to 8u: >>> webrev: http://cr.openjdk.java.net/~aivanov/8201433/jdk8/webrev.0/ >>> >>> Thank you! >>> >>> Regards, >>> Alexey >> > -- > Regards, > Alexey From david.buck at oracle.com Tue Apr 24 09:37:09 2018 From: david.buck at oracle.com (David Buck) Date: Tue, 24 Apr 2018 18:37:09 +0900 Subject: [8u-dev] RFA for JDK-8201240: Improve releasing native resources of BufImgSurfaceData.ICMColorData In-Reply-To: <7c522e9c-3ecf-61ef-a515-919461954a25@oracle.com> References: <7c522e9c-3ecf-61ef-a515-919461954a25@oracle.com> Message-ID: <643A3446-6C33-4F3B-8C0B-ADC9CD3F5F70@oracle.com> approved Cheers, -Buck > On Apr 24, 2018, at 18:34, Alexey Ivanov wrote: > > Hi, > > I'd like to request approval for this backport to 8u-dev. > > Backport review thread: > http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009163.html > > Thank you in advance. > > > On 24/04/2018 00:46, Sergey Bylokhov wrote: >> Looks fine. >> >> On 23/04/2018 03:49, Alexey Ivanov wrote: >>> Hi, >>> >>> Could you please review the following backport to 8u-dev? >>> >>> jbs: https://bugs.openjdk.java.net/browse/JDK-8201240 >>> review: http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009122.html >>> jdk11 changeset: http://hg.openjdk.java.net/jdk/client/rev/69f7e3ed043c >>> >>> >>> The patch does not apply cleanly to 8u and also requires changes to map files: >>> webrev: http://cr.openjdk.java.net/~aivanov/8201240/jdk8/webrev.0/ >>> >>> Thank you! >>> >>> Regards, >>> Alexey >> > -- > Regards, > Alexey From fairoz.matte at oracle.com Tue Apr 24 13:52:01 2018 From: fairoz.matte at oracle.com (Fairoz Matte) Date: Tue, 24 Apr 2018 06:52:01 -0700 (PDT) Subject: [8u-dev] Request for Approval: Backport of 6730115 : Fastdebug VM crashes with "ExceptionMark destructor expects no pending exceptions" error In-Reply-To: References: Message-ID: Hi, Sorry for sending wrong review thread link. Please find below is the right one. Bug - https://bugs.openjdk.java.net/browse/JDK-6730115 JDK9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/23c27f9ae1e8 JDK9 Review Thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2013-December/010452.html Note: Issue is updated with noreg label Thanks, Fairoz > -----Original Message----- > From: Fairoz Matte > Sent: Tuesday, April 24, 2018 2:26 PM > To: jdk8u-dev at openjdk.java.net > Subject: [8u-dev] Request for Approval: Backport of 6730115 : Fastdebug VM > crashes with "ExceptionMark destructor expects no pending exceptions" > error > > Hi, > > Please approve the backport of 6730115 to 8u-dev Bug - > https://bugs.openjdk.java.net/browse/JDK-6730115 > JDK9 Changeset: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/23c27f9ae1e8 > JDK9 Review Thread: http://mail.openjdk.java.net/pipermail/jdk9-hs-rt- > changes/2013-December/000009.html > > Changes apply cleanly to jdk8u-dev. > No issues found in JPRT > > Thanks, > Fairoz From anton.litvinov at oracle.com Tue Apr 24 16:07:19 2018 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Tue, 24 Apr 2018 17:07:19 +0100 Subject: [8u-dev] Request for approval for CR 8199748: Touch keyboard is not shown, if text component gets focus from other text component Message-ID: <008144c9-0d9c-782a-04bf-094cda7a1f3c@oracle.com> Hello, I would like to request for approval to push a straight backport of the fix from JDK 11 to JDK 8. The changeset from JDK 11 applies to JDK 8 after correction of a file path. Bug: https://bugs.openjdk.java.net/browse/JDK-8199748 JDK 11 changeset: http://hg.openjdk.java.net/jdk/client/rev/b6f4bd0bf173 JDK 11 review thread: ??? Approval 1 - http://mail.openjdk.java.net/pipermail/awt-dev/2018-April/013889.html ??? Approval 2 - http://mail.openjdk.java.net/pipermail/awt-dev/2018-April/013902.html Reviewers: serb, aivanov Thank you, Anton From sean.coffey at oracle.com Tue Apr 24 16:28:50 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Tue, 24 Apr 2018 17:28:50 +0100 Subject: [8u-dev] Request for Approval: Backport of 6730115 : Fastdebug VM crashes with "ExceptionMark destructor expects no pending exceptions" error In-Reply-To: References: Message-ID: Approved. regards, Sean. On 24/04/2018 14:52, Fairoz Matte wrote: > Hi, > > Sorry for sending wrong review thread link. > Please find below is the right one. > > Bug - https://bugs.openjdk.java.net/browse/JDK-6730115 > JDK9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/23c27f9ae1e8 > JDK9 Review Thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2013-December/010452.html > > Note: Issue is updated with noreg label > > Thanks, > Fairoz > >> -----Original Message----- >> From: Fairoz Matte >> Sent: Tuesday, April 24, 2018 2:26 PM >> To: jdk8u-dev at openjdk.java.net >> Subject: [8u-dev] Request for Approval: Backport of 6730115 : Fastdebug VM >> crashes with "ExceptionMark destructor expects no pending exceptions" >> error >> >> Hi, >> >> Please approve the backport of 6730115 to 8u-dev Bug - >> https://bugs.openjdk.java.net/browse/JDK-6730115 >> JDK9 Changeset: >> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/23c27f9ae1e8 >> JDK9 Review Thread: http://mail.openjdk.java.net/pipermail/jdk9-hs-rt- >> changes/2013-December/000009.html >> >> Changes apply cleanly to jdk8u-dev. >> No issues found in JPRT >> >> Thanks, >> Fairoz From sean.coffey at oracle.com Tue Apr 24 16:30:15 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Tue, 24 Apr 2018 17:30:15 +0100 Subject: [8u-dev] Request for approval for CR 8199748: Touch keyboard is not shown, if text component gets focus from other text component In-Reply-To: <008144c9-0d9c-782a-04bf-094cda7a1f3c@oracle.com> References: <008144c9-0d9c-782a-04bf-094cda7a1f3c@oracle.com> Message-ID: <9a8bcbd9-9ec3-c80e-2a85-48a0159ec904@oracle.com> Approved. regards, Sean. On 24/04/2018 17:07, Anton Litvinov wrote: > Hello, > > I would like to request for approval to push a straight backport of > the fix from JDK 11 to JDK 8. The changeset from JDK 11 applies to JDK > 8 after correction of a file path. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8199748 > JDK 11 changeset: http://hg.openjdk.java.net/jdk/client/rev/b6f4bd0bf173 > JDK 11 review thread: > ??? Approval 1 - > http://mail.openjdk.java.net/pipermail/awt-dev/2018-April/013889.html > ??? Approval 2 - > http://mail.openjdk.java.net/pipermail/awt-dev/2018-April/013902.html > Reviewers: serb, aivanov > > Thank you, > Anton From suokunstar at gmail.com Thu Apr 26 02:24:37 2018 From: suokunstar at gmail.com (T S) Date: Wed, 25 Apr 2018 21:24:37 -0500 Subject: Potential optimization to the GC termination protocol in JDK8 Message-ID: [Problem] The work stealing during the GC takes lots of time to terminate. The Parallel Scavenge in JDK 8 uses a distributed termination protocol to synchronize GC threads. After 2 ? N consecutive unsuccessful steal attempts (steal_best_of_2 function), a GC thread enters the termination procedure, where N is the number of GC threads. Suppose there are N GC threads, it takes 2 * N * N failed attempts before a GC stops. It is inefficient and takes too much time, especially when there are very few GC threads alive. If there are hundreds or thousands of GC happen during the app execution, that is a big waste of time. [Solution] Is that possible to reduce the number of steal attempt during the end of GC? My idea is to record the number of active GC threads (i.e., N_live) that are not yet in the termination protocol. A thread only steals from the pool of active GC threads because the inactive GC threads have no task to be stolen. Accordingly, the criteria for thread termination becomes 2 ? N_live consecutive failed steal attempts. It can reduce the steal attempts to half. Good forward for others' feedbacks. Thanks. Tony -- ********************************** > Tony Suo > Computer Science, University of Texas at Arlington ********************************** From david.holmes at oracle.com Thu Apr 26 02:30:04 2018 From: david.holmes at oracle.com (David Holmes) Date: Thu, 26 Apr 2018 12:30:04 +1000 Subject: Potential optimization to the GC termination protocol in JDK8 In-Reply-To: References: Message-ID: <9b20437c-86e5-f413-e5e4-7f2089fc4182@oracle.com> Re-directing to the hotspot GC mailing list from jdk8u-dev mailing list Please do not reply-all with jdk8u-dev included. David On 26/04/2018 12:24 PM, T S wrote: > [Problem] > The work stealing during the GC takes lots of time to terminate. The > Parallel Scavenge in JDK 8 uses a distributed termination protocol to > synchronize GC threads. After 2 ? N consecutive unsuccessful steal attempts > (steal_best_of_2 function), a GC thread enters the termination procedure, > where N is the number of GC threads. > > Suppose there are N GC threads, it takes 2 * N * N failed attempts before a > GC stops. It is inefficient and takes too much time, especially when there > are very few GC threads alive. If there are hundreds or thousands of GC > happen during the app execution, that is a big waste of time. > > > > [Solution] > Is that possible to reduce the number of steal attempt during the end of > GC? My idea is to record the number of active GC threads (i.e., N_live) > that are not yet in the termination protocol. A thread only steals from the > pool of active GC threads because the inactive GC threads have no task to > be stolen. Accordingly, the criteria for thread termination becomes 2 ? > N_live consecutive failed steal attempts. It can reduce the steal attempts > to half. > > > > Good forward for others' feedbacks. > Thanks. > Tony > > From sean.coffey at oracle.com Thu Apr 26 14:50:55 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 26 Apr 2018 15:50:55 +0100 Subject: CFV: New JDK 8 Updates Committer: Bhanu Prakash Gopularam Message-ID: I hereby nominate Bhanu Prakash Gopularam (bgopularam)to JDK 8 Updates Committer. Bhanu has been working in the Update Release SQE team for last 3.5 years. In Jan 2018 he received his Ph.D degree from University of Mysore for research work on Data Security using Identity and Attribute based Cryptographic schemes. He has contributed a range of fixes to the jdk8u Project [0] Votes are due by 18:00 GMT on May 10th 2018 Only current JDK 8 Updates Committers [1] are eligible to vote on this nomination.? Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. regards, Sean. [0] http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=200&rev=(author(bgopularam)+or+desc(%22bhanu.prakash.gopularam%40oracle.com%22))+and+not+merge() [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From sean.coffey at oracle.com Thu Apr 26 16:19:28 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 26 Apr 2018 17:19:28 +0100 Subject: CFV: New JDK 8 Updates Committer: Bhanu Prakash Gopularam In-Reply-To: References: Message-ID: Vote: yes regards, Sean. On 26/04/2018 15:50, Se?n Coffey wrote: > I hereby nominate Bhanu Prakash Gopularam (bgopularam)to JDK 8 Updates > Committer. > > Bhanu has been working in the Update Release SQE team for last 3.5 > years. In Jan 2018 he received his Ph.D degree from University of > Mysore for research work on Data Security using Identity and Attribute > based Cryptographic schemes. > > He has contributed a range of fixes to the jdk8u Project [0] > > Votes are due by 18:00 GMT on May 10th 2018 > > Only current JDK 8 Updates Committers [1] are eligible to vote on this > nomination.? Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > regards, > Sean. > > [0] > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=200&rev=(author(bgopularam)+or+desc(%22bhanu.prakash.gopularam%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From rob.mckenna at oracle.com Thu Apr 26 16:39:07 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 26 Apr 2018 17:39:07 +0100 Subject: CFV: New JDK 8 Updates Committer: Bhanu Prakash Gopularam In-Reply-To: References: Message-ID: <20180426163907.GE3000@vimes> Vote: yes -Rob On 26/04/18 17:19, Se?n Coffey wrote: > Vote: yes > > regards, > Sean. > > > On 26/04/2018 15:50, Se?n Coffey wrote: > >I hereby nominate Bhanu Prakash Gopularam (bgopularam)to JDK 8 Updates > >Committer. > > > >Bhanu has been working in the Update Release SQE team for last 3.5 years. > >In Jan 2018 he received his Ph.D degree from University of Mysore for > >research work on Data Security using Identity and Attribute based > >Cryptographic schemes. > > > >He has contributed a range of fixes to the jdk8u Project [0] > > > >Votes are due by 18:00 GMT on May 10th 2018 > > > >Only current JDK 8 Updates Committers [1] are eligible to vote on this > >nomination.? Votes must be cast in the open by replying to this mailing > >list. > > > >For Lazy Consensus voting instructions, see [2]. > > > >regards, > >Sean. > > > >[0] http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=200&rev=(author(bgopularam)+or+desc(%22bhanu.prakash.gopularam%40oracle.com%22))+and+not+merge() > >[1] http://openjdk.java.net/census > >[2] http://openjdk.java.net/projects/#committer-vote > > > From aleksej.efimov at oracle.com Thu Apr 26 16:44:12 2018 From: aleksej.efimov at oracle.com (Aleks Efimov) Date: Thu, 26 Apr 2018 17:44:12 +0100 Subject: CFV: New JDK 8 Updates Committer: Bhanu Prakash Gopularam In-Reply-To: References: Message-ID: <87f2a15c-f5c8-3f7e-bafb-c6d5677c3329@oracle.com> Vote: yes On 04/26/2018 03:50 PM, Se?n Coffey wrote: > I hereby nominate Bhanu Prakash Gopularam (bgopularam)to JDK 8 Updates > Committer. > > Bhanu has been working in the Update Release SQE team for last 3.5 > years. In Jan 2018 he received his Ph.D degree from University of > Mysore for research work on Data Security using Identity and Attribute > based Cryptographic schemes. > > He has contributed a range of fixes to the jdk8u Project [0] > > Votes are due by 18:00 GMT on May 10th 2018 > > Only current JDK 8 Updates Committers [1] are eligible to vote on this > nomination.? Votes must be cast in the open by replying to this > mailing list. > > For Lazy Consensus voting instructions, see [2]. > > regards, > Sean. > > [0] > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=200&rev=(author(bgopularam)+or+desc(%22bhanu.prakash.gopularam%40oracle.com%22))+and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From christoph.langer at sap.com Fri Apr 27 06:13:33 2018 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 27 Apr 2018 06:13:33 +0000 Subject: New JDK 8 Updates Committer: Bhanu Prakash Gopularam In-Reply-To: References: Message-ID: Vote: yes Regards Christoph > -----Original Message----- > From: jdk8u-dev [mailto:jdk8u-dev-bounces at openjdk.java.net] On Behalf > Of Se?n Coffey > Sent: Donnerstag, 26. April 2018 16:51 > To: jdk8u-dev at openjdk.java.net > Subject: CFV: New JDK 8 Updates Committer: Bhanu Prakash Gopularam > > I hereby nominate Bhanu Prakash Gopularam (bgopularam)to JDK 8 Updates > Committer. > > Bhanu has been working in the Update Release SQE team for last 3.5 > years. In Jan 2018 he received his Ph.D degree from University of Mysore > for research work on Data Security using Identity and Attribute based > Cryptographic schemes. > > He has contributed a range of fixes to the jdk8u Project [0] > > Votes are due by 18:00 GMT on May 10th 2018 > > Only current JDK 8 Updates Committers [1] are eligible to vote on this > nomination.? Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > regards, > Sean. > > [0] > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=200&rev=(author > (bgopularam)+or+desc(%22bhanu.prakash.gopularam%40oracle.com%22))+ > and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From christoph.langer at sap.com Fri Apr 27 06:19:00 2018 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 27 Apr 2018 06:19:00 +0000 Subject: [8u] Request for Approval: Backport of 8201369: Inet4AddressImpl_getLocalHostName reverse lookup on Solaris only Message-ID: <6897c5d755904459be64fa4c6bd74def@sap.com> Hello, I'd like to request approval for the backport of the fix for JDK-8201369. Bug URL: https://bugs.openjdk.java.net/browse/JDK-8201369 JDK 11 change: http://hg.openjdk.java.net/jdk/jdk/rev/a838e3707f3a 8u-backport webrev: http://cr.openjdk.java.net/~clanger/webrevs/8201369-jdk8.0/ Review Thread: http://mail.openjdk.java.net/pipermail/net-dev/2018-April/011389.html Thanks and best regards Christoph From david.buck at oracle.com Fri Apr 27 07:13:30 2018 From: david.buck at oracle.com (David Buck) Date: Fri, 27 Apr 2018 16:13:30 +0900 Subject: [8u] Request for Approval: Backport of 8201369: Inet4AddressImpl_getLocalHostName reverse lookup on Solaris only In-Reply-To: <6897c5d755904459be64fa4c6bd74def@sap.com> References: <6897c5d755904459be64fa4c6bd74def@sap.com> Message-ID: approved Cheers, -Buck On 2018/04/27 15:19, Langer, Christoph wrote: > Hello, > > I'd like to request approval for the backport of the fix for JDK-8201369. > > Bug URL: https://bugs.openjdk.java.net/browse/JDK-8201369 > JDK 11 change: http://hg.openjdk.java.net/jdk/jdk/rev/a838e3707f3a > 8u-backport webrev: http://cr.openjdk.java.net/~clanger/webrevs/8201369-jdk8.0/ > Review Thread: http://mail.openjdk.java.net/pipermail/net-dev/2018-April/011389.html > > Thanks and best regards > Christoph > From david.buck at oracle.com Fri Apr 27 12:57:31 2018 From: david.buck at oracle.com (David Buck) Date: Fri, 27 Apr 2018 21:57:31 +0900 Subject: [8u] RFA 8041623 and 8048128 Message-ID: <63371f7d-fa7d-8f95-8efe-bd3a7605cc01@oracle.com> Hi! Please approve the backport of the following two fixes from JDK 9 to 8u-dev: [ 8041623: Solaris Studio 12.4 C++ 5.13, CHECK_UNHANDLED_OOPS use of class oop's copy constructor definitions causing error level diagnostic ] bug report: https://bugs.openjdk.java.net/browse/JDK-8041623 JDK 9 code review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-June/012002.html JDK 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/ef650d0ce657 [ 8048128: Fix for Solaris Studio C++ 5.13, CHECK_UNHANDLED_OOPS breaks PPC build ] bug report: https://bugs.openjdk.java.net/browse/JDK-8048128 JDK 9 code review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-July/012085.html JDK 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/29b4f4e94ad7 Both changes apply cleanly to 8u-dev. JPRT run and hotspot testset passes with current compilers. Efficacy of fix manually confirmed by building with SS 12.4 (C++ 5.13). Cheers, -Buck From rob.mckenna at oracle.com Fri Apr 27 13:11:42 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 27 Apr 2018 14:11:42 +0100 Subject: [8u] RFA 8041623 and 8048128 In-Reply-To: <63371f7d-fa7d-8f95-8efe-bd3a7605cc01@oracle.com> References: <63371f7d-fa7d-8f95-8efe-bd3a7605cc01@oracle.com> Message-ID: <20180427131142.GB4834@vimes> Approved -Rob On 27/04/18 21:57, David Buck wrote: > Hi! > > Please approve the backport of the following two fixes from JDK 9 to 8u-dev: > > [ 8041623: Solaris Studio 12.4 C++ 5.13, CHECK_UNHANDLED_OOPS use of class > oop's copy constructor definitions causing error level diagnostic ] > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8041623 > > JDK 9 code review thread: > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-June/012002.html > > JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/ef650d0ce657 > > > [ 8048128: Fix for Solaris Studio C++ 5.13, CHECK_UNHANDLED_OOPS breaks PPC > build ] > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8048128 > > JDK 9 code review thread: > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-July/012085.html > > JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/29b4f4e94ad7 > > Both changes apply cleanly to 8u-dev. JPRT run and hotspot testset passes > with current compilers. Efficacy of fix manually confirmed by building with > SS 12.4 (C++ 5.13). > > Cheers, > -Buck From kevin.walls at oracle.com Sun Apr 29 19:36:25 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Sun, 29 Apr 2018 20:36:25 +0100 Subject: [8u-dev] Request for approval for CR 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013) In-Reply-To: <34c5e1e8-218b-8008-445a-fecb6fcbcc90@oracle.com> References: <34c5e1e8-218b-8008-445a-fecb6fcbcc90@oracle.com> Message-ID: <9992453f-c107-8ee0-ffde-0f3bb43c79e6@oracle.com> Hi, I'd like to request approval to backport from 9 to 8u: 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013) JBS: https://bugs.openjdk.java.net/browse/JDK-8042707 9 changesets: base repo: http://hg.openjdk.java.net/jdk9/jdk9/rev/39ee0ee4f890 jdk repo: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/c622a8ba90ad 9 review thread: http://mail.openjdk.java.net/pipermail/build-dev/2015-January/014029.html Proposed 8u change:http://cr.openjdk.java.net/~kevinw/8042707/webrev.01/ New 8u technical review: http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021850.html Many thanks! Kevin -------- Forwarded Message -------- Subject: Re: [8u] RFR: 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013) Date: Thu, 26 Apr 2018 08:57:41 -0700 From: Erik Joelsson Organization: Oracle Corporation To: Kevin Walls , build-dev at openjdk.java.net Looks good. /Erik On 2018-04-26 01:38, Kevin Walls wrote: > > Thanks Erik - > > I went ahead with the jdk's make/CopyFiles.gmk change, and added > SetupCopyFiles to the base repo's make/common/MakeBase.gmk. > > I updated the webrev, to include base and jdk repos: > > http://cr.openjdk.java.net/~kevinw/8042707/webrev.01/ > > I'm getting these build OK with VS2012, but there will be further > hotspot change at least for VS2013 to be a working option in 8u. > > Thanks > Kevin > (my previous reply was not the the list, so this is the open response!) > > > > On 20/04/2018 23:27, Erik Joelsson wrote: >> The root repo changes look ok. >> >> The changes in Copy-java.base.gmk applies to jdk/make/CopyFiles.gmk. >> Those changes are definitely needed. >> >> /Erik >> >> >> On 2018-04-20 13:18, Kevin Walls wrote: >>> Hi, >>> >>> I'd like to request a review of the backport from 9 to 8u: >>> >>> 8042707: Source changes needed to build JDK 9 with Visual Studio >>> 2013 (VS2013) >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8042707 >>> >>> 9 changesets: >>> base repo: http://hg.openjdk.java.net/jdk9/jdk9/rev/39ee0ee4f890 >>> jdk repo: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/c622a8ba90ad >>> >>> 9 review thread: >>> http://mail.openjdk.java.net/pipermail/build-dev/2015-January/014029.html >>> >>> >>> Notes: >>> base repo: >>> toolchain_windows.m4: quite a bit of manual work, but no conflicts. >>> make/common/MakeBase.gmk: changes in SetupCopyFiles which we don't >>> have in 8u >>> flags.m4: we don't call it COMMON_CXXFLAGS_JDK in 8u, but made the >>> same change. >>> >>> jdk repo: >>> make/copy/Copy-java.base.gmk we don't have in 8u. The other two >>> files apply cleanly. >>> >>> >>> Clearly this backport isn't to change anything about what compilers >>> are supported or recommended, >>> it's just about the build infrastructure. >>> >>> >>> 8u change: webrev of the base repo changes: >>> http://cr.openjdk.java.net/~kevinw/8042707/webrev.00/ >>> >>> Many thanks >>> Kevin >>> >> > From ivan.gerasimov at oracle.com Mon Apr 30 19:16:34 2018 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Mon, 30 Apr 2018 12:16:34 -0700 Subject: [8u-dev] 8193171 : keytool -list displays "JKS" for a PKCS12 keystore Message-ID: <6952bad9-e230-8dce-be2d-2bb8f22c0b4c@oracle.com> Hello! This is 8u-dev only bug fix. It was noticed that the keytool from the latest JDK 8 update release displays type of PKCS12 keystore as JKS. Would you please help review the patch? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8193171 WEBREV: http://cr.openjdk.java.net/~igerasim/8193171/00/webrev/ Thanks in advance! -- With kind regards, Ivan Gerasimov From david.buck at oracle.com Mon Apr 30 21:13:32 2018 From: david.buck at oracle.com (David Buck) Date: Tue, 1 May 2018 06:13:32 +0900 Subject: [8u] RFA 8077420: Build failure with SS12u4 Message-ID: <54a59660-f9bd-14a8-a494-6bf610f54de8@oracle.com> Hi! Please approve the backport of the following fix from JDK 9 to 8u-dev: bug report: https://bugs.openjdk.java.net/browse/JDK-8077420 JDK 9 code review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-April/017930.html JDK 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/4b1c654a2c53 The change applies cleanly to 8u-dev. JPRT run and hotspot testset passes with current compilers. Efficacy of fix manually confirmed by building with SS 12.4 (C++ 5.13). Cheers, -Buck From rob.mckenna at oracle.com Mon Apr 30 22:11:37 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 30 Apr 2018 23:11:37 +0100 Subject: [8u-dev] Request for approval for CR 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013) In-Reply-To: <9992453f-c107-8ee0-ffde-0f3bb43c79e6@oracle.com> References: <34c5e1e8-218b-8008-445a-fecb6fcbcc90@oracle.com> <9992453f-c107-8ee0-ffde-0f3bb43c79e6@oracle.com> Message-ID: <20180430221136.GA9085@vimes> Approved -Rob On 29/04/18 20:36, Kevin Walls wrote: > Hi, > > I'd like to request approval to backport from 9 to 8u: > > 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013) > JBS: https://bugs.openjdk.java.net/browse/JDK-8042707 > > 9 changesets: > base repo: http://hg.openjdk.java.net/jdk9/jdk9/rev/39ee0ee4f890 > jdk repo: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/c622a8ba90ad > > 9 review thread: http://mail.openjdk.java.net/pipermail/build-dev/2015-January/014029.html > > Proposed 8u change:http://cr.openjdk.java.net/~kevinw/8042707/webrev.01/ > > New 8u technical review: > http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021850.html > > Many thanks! > Kevin > > > -------- Forwarded Message -------- > Subject: Re: [8u] RFR: 8042707: Source changes needed to build JDK 9 with > Visual Studio 2013 (VS2013) > Date: Thu, 26 Apr 2018 08:57:41 -0700 > From: Erik Joelsson > Organization: Oracle Corporation > To: Kevin Walls , build-dev at openjdk.java.net > > > > Looks good. > > /Erik > > > On 2018-04-26 01:38, Kevin Walls wrote: > > > >Thanks Erik - > > > >I went ahead with the jdk's make/CopyFiles.gmk change, and added > >SetupCopyFiles to the base repo's make/common/MakeBase.gmk. > > > >I updated the webrev, to include base and jdk repos: > > > >http://cr.openjdk.java.net/~kevinw/8042707/webrev.01/ > > > >I'm getting these build OK with VS2012, but there will be further hotspot > >change at least for VS2013 to be a working option in 8u. > > > >Thanks > >Kevin > >(my previous reply was not the the list, so this is the open response!) > > > > > > > >On 20/04/2018 23:27, Erik Joelsson wrote: > >>The root repo changes look ok. > >> > >>The changes in Copy-java.base.gmk applies to jdk/make/CopyFiles.gmk. > >>Those changes are definitely needed. > >> > >>/Erik > >> > >> > >>On 2018-04-20 13:18, Kevin Walls wrote: > >>>Hi, > >>> > >>>I'd like to request a review of the backport from 9 to 8u: > >>> > >>>8042707: Source changes needed to build JDK 9 with Visual Studio 2013 > >>>(VS2013) > >>>JBS: https://bugs.openjdk.java.net/browse/JDK-8042707 > >>> > >>>9 changesets: > >>>base repo: http://hg.openjdk.java.net/jdk9/jdk9/rev/39ee0ee4f890 > >>>jdk repo: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/c622a8ba90ad > >>> > >>>9 review thread: > >>>http://mail.openjdk.java.net/pipermail/build-dev/2015-January/014029.html > >>> > >>> > >>>Notes: > >>>base repo: > >>>toolchain_windows.m4: quite a bit of manual work, but no conflicts. > >>>make/common/MakeBase.gmk: changes in SetupCopyFiles which we don't > >>>have in 8u > >>>flags.m4: we don't call it COMMON_CXXFLAGS_JDK in 8u, but made the > >>>same change. > >>> > >>>jdk repo: > >>>make/copy/Copy-java.base.gmk we don't have in 8u. The other two files > >>>apply cleanly. > >>> > >>> > >>>Clearly this backport isn't to change anything about what compilers > >>>are supported or recommended, > >>>it's just about the build infrastructure. > >>> > >>> > >>>8u change: webrev of the base repo changes: > >>>http://cr.openjdk.java.net/~kevinw/8042707/webrev.00/ > >>> > >>>Many thanks > >>>Kevin > >>> > >> > > > From rob.mckenna at oracle.com Mon Apr 30 22:12:33 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 30 Apr 2018 23:12:33 +0100 Subject: [8u] RFA 8077420: Build failure with SS12u4 In-Reply-To: <54a59660-f9bd-14a8-a494-6bf610f54de8@oracle.com> References: <54a59660-f9bd-14a8-a494-6bf610f54de8@oracle.com> Message-ID: <20180430221233.GB9085@vimes> Approved -Rob On 01/05/18 06:13, David Buck wrote: > Hi! > > Please approve the backport of the following fix from JDK 9 to 8u-dev: > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8077420 > > JDK 9 code review thread: > http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-April/017930.html > > JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/4b1c654a2c53 > > The change applies cleanly to 8u-dev. JPRT run and hotspot testset passes > with current compilers. Efficacy of fix manually confirmed by building with > SS 12.4 (C++ 5.13). > > Cheers, > -Buck