[8u-dev] RFA for JDK-8179079: Incremental HotSpot builds broken on Windows

[Alexey Ivanov]

Sorry for duplicate request.
Kevin proposes the same changeset, I'll let Kevin proceed as he has many 
other build tweaks.

-- 
Regards,
Alexey

On 18/04/2018 18:13, Alexey Ivanov wrote:
> Hi,
>
> Could you please approve this backport to 8u?
>
>
> Regards,
> Alexey
>
> On 18/04/2018 16:27, Erik Joelsson wrote:
>> Looks good. Thanks for taking care of this backport!
>>
>> /Erik
>>
>>
>> On 2018-04-18 05:06, Alexey Ivanov wrote:
>>> Hi,
>>>
>>> Could you please review the following backport of the build fix for 
>>> Windows:
>>>
>>> jbs: https://bugs.openjdk.java.net/browse/JDK-8179079
>>> review: 
>>> http://mail.openjdk.java.net/pipermail/build-dev/2017-April/019045.html
>>> changeset: http://hg.openjdk.java.net/jdk10/jdk10/rev/6426c94ee05f
>>>
>>> The patch does not apply to 8u:
>>> webrev: http://cr.openjdk.java.net/~aivanov/8179079/jdk8/webrev.0/
>>>
>>>
>>> This problem exists in 8u builds as well. If you try to rebuild 8u, 
>>> you'll get errors:
>>>
>>> make[2]: *** No rule to make target 
>>> '/cygdrive/c/ade/work/jdk8u/build/windows-x86-normal-server-release/jdk/include/jni.h
>>> ', needed by 
>>> '/cygdrive/c/ade/work/jdk8u/build/windows-x86-normal-server-release/jdk/objs/libverify/check_code.obj'. 
>>> Stop.
>>>
>>> It's because the generated dependency file contain CR (\r) character 
>>> at the end of the file name and make interprets it as part of the 
>>> file name.
>>>
>>>
>>> Thank you!
>>>
>>> Regards,
>>> Alexey
>>
>