[8u-dev] Request for approval for CR 8196882: VS2017 Hotspot Defined vsnprintf Function Causes C2084 Already Defined Compilation Error

[Seán Coffey]

Approved.

regards,
Sean.


On 01/08/2018 23:03, Kevin Walls wrote:
> Hi,
>
> I'd like to request approval to backport from 11 to 8u:
>
> 8196882: VS2017 Hotspot Defined vsnprintf Function Causes C2084 
> Already Defined Compilation Error
> JBS: https://bugs.openjdk.java.net/browse/JDK-8196882
>
> 11 changeset:
> http://hg.openjdk.java.net/jdk/hs/rev/eebf559c9e0d
>
> 11 review thread:
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-February/030252.html 
>
> ...to...
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-February/030279.html 
>
>
>
> Proposed 8u change: http://cr.openjdk.java.net/~kevinw/8196882/webrev.02/
>
> New 8u technical review: 
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-August/033639.html
>
> os::vsnprintf previously behaved different on Windows to other 
> platforms.  That method is only used internally in hotspot and the 
> return value is not usually checked - in looking at where it is 
> checked, this change fixes a problem in g1GCPhaseTimes.cpp where we 
> use the return value of vsnprintf incorrectly (code that is gone in 9).
>
> Thanks!
> Kevin
>
>