[8u] Request for enhancement backport approval for 8059038: Create new launcher for SA tools

[Andrew Hughes]

On Tue, 20 Nov 2018 at 17:29, Severin Gehwolf <sgehwolf at redhat.com> wrote:
>
> Hi,
>
> Please approve this enhancement backport request which adds launchers
> for CLHSDB and HSDB (part of the sa-jdi.jar) currently not present in
> JDK 8u. JDK 9+ has 'jshsdb clhsdb' (CLI) and 'jhsdb hsdb' (GUI) for the
> serviceability agent. This patch would make those available in JDK 8u
> too.
>
> The risk of making them available is none. It's not possible to use
> them this way right now. The commands don't exist. Except for a new
> launcher no new code has been added. The launcher delegates to existing
> CLHSDB and HSDB classes.
>
> Testing: New basic test, manual testing that launchers work.
>
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8059038/01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8059038
>
> Thoughts?
>
> Thanks,
> Severin
>

Approved.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222