RFA: 8210647: libsaproc is being compiled without optimization and 8212110: Build of saproc.dll broken on Windows 32 bit after JDK-8210647

[Andrew Hughes]

On Tue, 20 Nov 2018 at 17:07, Severin Gehwolf <sgehwolf at redhat.com> wrote:
>
> Hi,
>
> Please approve the following backports adding optimization switches for
> libsaproc. We have been using this patch in a while now in Fedora
> without issues.
>
>
> 8210647: libsaproc is being compiled without optimization
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210647
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/jdk8/webrev.02/
> Review-thread: http://mail.openjdk.java.net/pipermail/build-dev/2018-November/023918.html
>
> Since the build system in JDK 8 is different from JDK 12 it needed
> another review on build-dev. The 8u change has been reviewed by Erik
> Joelsson and JC Beyler.
>
>
> 8212110: Build of saproc.dll broken on Windows 32 bit after JDK-8210647
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8212110
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8212110/jdk8/webrev.03/
> Review-thread: http://mail.openjdk.java.net/pipermail/build-dev/2018-November/023933.html
>
> Again, build system in JDK 8 is different from JDK 12. It has been
> reviewed by Erik Joelsson and Alex Kashchenko on build-dev.
>
> Testing: Builds on Linux x86_64 and Windows. Manual testing of SA
> functionality.
>
>
> In order to not accidentally break any build it would be appreciated if
> somebody could run this through JPRT.
>
> Thanks,
> Severin
>

Both approved.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222