Re: Proposal for back-porting JFR to OpenJDK8u

[guangyu.zhu]

Hi Mario,

Your consideration is reasonable. Currently it's put in a single file named jfr.jar .

Thanks,
Guangyu
------------------------------------------------------------------
Sender:Mario Torre <neugens at redhat.com>
Sent at:2018 Dec 6 (Thu) 15:41
To:guangyu.zhu <guangyu.zhu at aliyun.com>
Cc:jdk8u-dev <jdk8u-dev at openjdk.java.net>; sanhong.lsh <sanhong.lsh at alibaba-inc.com>; kingsum.chow <kingsum.chow at gmail.com>
Subject:Re: Proposal for back-porting JFR to OpenJDK8u

On Thu, Dec 6, 2018 at 7:33 AM guangyu.zhu <guangyu.zhu at aliyun.com> wrote:
>
> Hi Mario，
>
> Thanks for support! JFR APIs were backported together with the event framework.

That make sense indeed. I think, since those are official API
introduced in 11 (if I recall correctly), we may need to take a bit of
extra care that they aren't included in the base JDK, perhaps we
should put them into tools.jar or something so they act as "external"
libraries? Is that your current approach?

I'm not totally sure about this one though, I think that's part of the
discussion we need to have on the JEP, but I want to avoid the risk
that the upstream version of the JDK has additional API that are not
part of the core specification directly (this is why I think it's fine
if they live in the tools.jar).

Cheers,
Mario

-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898