Proposal for back-porting JFR to OpenJDK8u

[Hohensee, Paul]

Fwiw, I can confirm that the backport issue creation logic works for multiple issues in a single commit comment. Just did it for jdk11u combined backport of 8206075, 8208480, and 8209511.

Paul

On 12/12/18, 8:48 AM, "Andrew Hughes" <gnu.andrew at redhat.com> wrote:

    On Fri, 7 Dec 2018 at 19:16, Daniel D. Daugherty
    <daniel.daugherty at oracle.com> wrote:
    >
    > On 12/7/18 2:05 PM, Andrew Haley wrote:
    > > On 12/7/18 6:57 PM, Daniel D. Daugherty wrote:
    > >> I would think you could list the original bug for the JFR open
    > >> port and all the bug fixes that you knowingly bring along in
    > >> the same changeset. One changeset, multiple bugs listed.
    > > Mmm, but there's going o be some work involved, and do you really want
    > > someone to have to back-port the original buggy patch, commit it with
    > > the exact same bugs, then backport each bug fix? Sure, it's fund for
    > > people with nothing better to do.
    > >
    >
    >  > commit it with
    >  > the exact same bugs, then backport each bug fix?
    >
    > I'm not sure how you got that out of what I said.
    >
    > I'm saying:
    >
    > - pick a point in jdk/jdk for your backport to begin,
    >    e.g., jdk-12+24 snapshot
    > - grab the relevant files (hopefully there won't be
    >    much overlap with non JFR changes)
    > - do the backport to OpenJDK8u
    > - find the original changeset for the JFR port to give
    >    you the first bug ID
    > - find subsequent JFR bug fix changesets to give the
    >    next bug IDs
    > - list all the bug IDs in your single changeset for the
    >    JFR backport to OpenJDK8u.
    >
    > One changeset that lists multiple bug IDs. Not individual
    > backports of each bug fix. Will you miss something in the
    > list? Maybe or maybe not.
    >
    > Dan
    
    That sounds sensible to me. It's similar to what I did with one
    of the big security backports. As long as 'hg log -k' works, so
    I can see the bug IDs are fixed in 8, I'm happy.
    -- 
    Andrew :)
    
    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)
    
    Web Site: http://fuseyism.com
    Twitter: https://twitter.com/gnu_andrew_java
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222