[8u-dev] RFA: 8206075: On x86, assert on unbound assembler Labels used as branch targets

Seán Coffey sean.coffey at oracle.com
Fri Dec 21 09:17:55 UTC 2018


Thanks Paul. I notice that you added me to the Reviewed-By field (and in 
past ones also). I think it's better if you keep that list to technical 
reviewers. If the changeset is (almost) identical to the original fix, 
then that would be the original reviewers. I'm not looking at your 
requests in a strong technical manner. (just from a correctness 
perspective for maintainer purposes)

If a backport change is different from the original feature fix, then a 
new review should be carried out on the relevant technical OpenJDK 
mailing list(s).

regards,
Sean.

On 20/12/2018 20:17, Hohensee, Paul wrote:
> Thanks, Sean and Andrew. I added 'noreg-sqe' to 8206075 and 8208480, emulating 8209511, which already had it. Pushed.
>
> On 12/17/18, 9:27 AM, "Andrew Hughes" <gnu.andrew at redhat.com> wrote:
>
>      On Thu, 13 Dec 2018 at 19:25, Hohensee, Paul <hohensee at amazon.com> wrote:
>      >
>      > It will be applied as a single changeset with multiple bugids. The webrev is the single changeset.
>      >
>      
>      Ok, I see that was the case for 11u too.
>      
>      Approved for this case, as they are related, but let's try and keep to
>      a 1:1 relationship
>      where possible, as it otherwise makes further backports harder.
>      
>      Thanks,
>      --
>      Andrew :)
>      
>      Senior Free Java Software Engineer
>      Red Hat, Inc. (http://www.redhat.com)
>      
>      Web Site: http://fuseyism.com
>      Twitter: https://twitter.com/gnu_andrew_java
>      PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
>      Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
>      
>


More information about the jdk8u-dev mailing list