[RFA] JDK-8194739 Zero port of 8174962: Better interface invocations

[David Buck]

Hi Andrew!

Perhaps we can make the RFA template clearer. I will bring this up with the other maintainers.

While there may be examples where this rule was not strictly enforced in the past, every RFA should include a link to any available public review. It is not so much to “prove” that they original change was properly reviewed, but to make it as easy and as quick as possible for everyone involved to find and review any technical discussion around the original fix that might be of concern to back porting the fix. (For example, code reviews often include discussion of any risk posed by the change.) The idea is to make it easier to find this information. When the list is very active / busy, the time saved trying to hunt down each review thread can really add up.

BTW, thank you for fixing this issue in JDK 8. I am relived to hear that Zero is building again.

Cheers,
-Buck

> On Feb 21, 2018, at 5:45, Andrew Hughes <gnu.andrew at redhat.com> wrote:
> 
> On 20 February 2018 at 07:59, David Buck <david.buck at oracle.com> wrote:
>> Hi Andrew!
>> 
>> Was there a public review [0] of the changes that were pushed into 9/10/11?
>> 
>> Cheers,
>> -Buck
>> 
> 
> Thanks to Andrew Dinn for replying with the details. I presumed that
> a changeset already present in OpenJDK 9 with Reviewed-by tags
> would be sufficient evidence as it has been in the past. It meets all the
> requirements of [0], given that #3 and #4 are not applicable for an
> approval of a clean backport, rather than an 8u patch review. If a link
> to a review thread for another release is required, then it should be listed
> on that page.
> 
> I've now pushed the change [1] so Zero should build again.
> 
> [0] http://openjdk.java.net/projects/jdk8u/approval-template.html
> [1] http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/8bd024c567e7
> 
> Thanks,
> -- 
> Andrew :)
> 
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> Web Site: http://fuseyism.com
> Twitter: https://twitter.com/gnu_andrew_java
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222