[8u] [RFR] Request for Review of Backport of JDK-8078628: linux-zero does not build without precompiled header

Andrew Hughes gnu.andrew at redhat.com
Thu Feb 22 04:01:42 UTC 2018


[CCing hotspot list for review]

Bug: https://bugs.openjdk.java.net/browse/JDK-8078628
Webrev: http://cr.openjdk.java.net/~andrew/openjdk8/8078628/webrev.01/
Review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-April/018239.html

When testing a slowdebug build of Zero for the backport of 8194739, my build
failed because I don't have pre-compiled headers enabled. It seems this
was fixed in OpenJDK 9, but never backported.

The backported version is pretty similar with a few adjustments for context
in the older OpenJDK 8 version. The src/cpu/zero/vm/methodHandles_zero.hpp
are my own addition from the same fix I came up with independently, and stops
multiple inclusions of that header.

Please review and approve for OpenJDK 8 so Zero builds without
precompiled headers
work there.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list