[8u] [RFR] Request for Review of Backport of JDK-8179887: Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

[David Holmes]

Hi Andrew,

As far as I can see this got quite messy. We initially disabled the 
warning to fix the build problem. Then we actually changed the code in 
8179887. But that broke JFR's use of the API:

https://bugs.openjdk.java.net/browse/JDK-8202835

and that and:

https://bugs.openjdk.java.net/browse/JDK-8202794

remain open and unresolved.

I'd be inclined to disable the build warning for 8u rather than make 
code changes (which will likely still break JFR).

David

On 5/07/2018 12:08 PM, Andrew Hughes wrote:
> On 26 June 2018 at 18:39, Andrew Hughes <gnu.andrew at redhat.com> wrote:
>> On 21 June 2018 at 04:56, Andrew Hughes <gnu.andrew at redhat.com> wrote:
>>> [CCing hotspot list for review]
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8179887
>>> Webrev: http://cr.openjdk.java.net/~andrew/openjdk8/8179887/webrev.01/
>>> Review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-April/031746.html
>>>
>>> Patch is basically the same as for OpenJDK 11, except we don't have to
>>> revert 8187667, which isn't present in OpenJDK 8.
>>>
>>> Thanks,
>>> --
>>> Andrew :)
>>>
>>> Senior Free Java Software Engineer
>>> Red Hat, Inc. (http://www.redhat.com)
>>>
>>> Web Site: http://fuseyism.com
>>> Twitter: https://twitter.com/gnu_andrew_java
>>> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
>>> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
>>
>> Ping?
>> --
>> Andrew :)
>>
>> Senior Free Java Software Engineer
>> Red Hat, Inc. (http://www.redhat.com)
>>
>> Web Site: http://fuseyism.com
>> Twitter: https://twitter.com/gnu_andrew_java
>> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
>> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
> 
> Ping x 2?
>