[8u] RFA: 8036003: Add --with-native-debug-symbols=[none|internal|external|zipped]

Tim Bell tim.bell at oracle.com
Thu Jul 19 17:10:22 UTC 2018


Erik:

> When I pushed this, I forgot to add the generated-configure.sh file for
> the open to the changeset. What do I need to do to push the updated
> generated-configure?
>
> Filed bug here: https://bugs.openjdk.java.net/browse/JDK-8207853
>
> Webrev here: http://cr.openjdk.java.net/~erikj/8207853/webrev.01/

Code review looks good.

/Tim

>
> /Erik
>
>
> On 2018-07-19 04:50, Severin Gehwolf wrote:
>> On Thu, 2018-07-19 at 12:41 +0100, Rob McKenna wrote:
>>> Thanks, approved. Please add the noreg-build label to the bug.
>> Done.
>>
>> Thanks, Rob!
>>
>> Cheers,
>> Severin
>>
>>>      -Rob
>>>
>>> On 19/07/18 10:11, Severin Gehwolf wrote:
>>>> Hi Rob,
>>>>
>>>> On Thu, 2018-07-19 at 00:19 +0100, Rob McKenna wrote:
>>>>> Can you please send a separate enchancement backport approval
>>>>> request?
>>>> Done:
>>>> http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-July/007695.html
>>>>
>>>> Thanks,
>>>> Severin
>>>>
>>>>> http://openjdk.java.net/projects/jdk8u/enhancement-template.html
>>>>>
>>>>> On 18/07/18 15:58, Severin Gehwolf wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Please approve this enhancement backport for JDK 8u. It adds a new
>>>>>> configure option:
>>>>>> --with-native-debug-symbols=[none|internal|external|zipped]
>>>>>>
>>>>>> Such an option exists in JDK 9+ already and we've been using the --
>>>>>> with-native-debug-symbols=internal switch for our distribution
>>>>>> OpenJDK
>>>>>> builds ever since. The backport was done in a way so that old
>>>>>> behaviour
>>>>>> keeps working. For example, if the new configure flag is missing this
>>>>>> should be a no-op for existing build configs. However, if the new
>>>>>> option is present, it'll use --with-native-debug-symbols, overriding
>>>>>> old configure flags --disable-debug-symbols and --disable-zip-debug-
>>>>>> info. This enhancement also fixes bug JDK-8207234[1].
>>>>>>
>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8036003
>>>>>> webrev:
>>>>>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8036003/webrev.02/
>>>>>> review-thread:
>>>>>> http://mail.openjdk.java.net/pipermail/build-dev/2018-July/022686.html
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Severin
>>>>>>
>>>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8207234
>



More information about the jdk8u-dev mailing list