[8u-dev] Request for approval for CR 8150426: Wrong cast in metadata_at_put

[Rob McKenna]

Approved

    -Rob

On 12/06/18 20:13, Kevin Walls wrote:
> Hi,
> 
> I'd like to request approval to backport from 9 to 8u:
> 
> 8150426: Wrong cast in metadata_at_put
> JBS: https://bugs.openjdk.java.net/browse/JDK-8150426
> 
> This fixes a build error if you vary the compiler from our defaults.
> 
> 9 changeset:
> URL:   http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/e06c15b0844e
> (diff pasted below)
> 
> 9 review thread:
> http://openjdk.5641.n7.nabble.com/RFR-8150426-Wrong-cast-in-metadata-at-put-td258746.html
> 
> This is a clean backport, or imports with minimal/trivial changes.
> 
> Thanks!
> Kevin
> 
> 
> 
> --- a/src/share/vm/oops/typeArrayOop.hpp	Wed Feb 24 13:18:54 2016 -0500
> 
> +++ b/src/share/vm/oops/typeArrayOop.hpp	Tue Feb 23 18:58:36 2016 -0500
> 
> @@ -129,7 +129,7 @@
> 
>    Metadata* metadata_at(int which) const {
> 
>      return (Metadata*)*long_at_addr(which); }
> 
>    void metadata_at_put(int which, Metadata* contents) {
> 
> -    *long_at_addr(which) = (long)contents;
> 
> +    *long_at_addr(which) = (jlong)contents;
> 
>    }
> 
>  #else
> 
>    Metadata* metadata_at(int which) const {
>