[8u-dev] RFA for 8179675: Build with error on windows with new Cygwin grep

[Rob McKenna]

Approved

    -Rob

On 12/06/18 21:56, Alexey Ivanov wrote:
> Hi,
> 
> Could I get an approval for the following 8u-specific fix?
> 
> Latest webrev:
> http://cr.openjdk.java.net/~aivanov/8179675/jdk8/webrev.0/
> 
> Review thread:
> http://mail.openjdk.java.net/pipermail/build-dev/2018-June/022361.html
> 
> 
> Thank you in advance.
> 
> Regards,
> Alexey
> 
> On 12/06/2018 21:05, Erik Joelsson wrote:
> >Looks good.
> >
> >/Erik
> >
> >
> >On 2018-06-12 11:08, Alexey Ivanov wrote:
> >>Resending with clickable link to the webrev:
> >>http://cr.openjdk.java.net/~aivanov/8179675/jdk8/webrev.0/
> >>
> >>-- 
> >>Alexey
> >>
> >>On 12/06/2018 19:06, Alexey Ivanov wrote:
> >>>Hi,
> >>>
> >>>Could you please review the following fix for 8u-dev?
> >>>
> >>>JBS: https://bugs.openjdk.java.net/browse/JDK-8179675
> >>>webrev: http://cr.openjdk.java.net/~aivanov/8179675/jdk8/webrev.0/
> >>>
> >>>The problem is that newer grep v3.0 does not match the end-of-line if
> >>>the input uses Windows line endings.
> >>>
> >>>The fix removes CR, '\r', from the input before processing with grep.
> >>>
> >>>
> >>>Thank you in advance.
> >>>
> >>>Regards,
> >>>Alexey
> >>
> >
>