[8u-dev] Request for approval for CR 8204872: [8u] VS2017: threadLocalAllocBuffer.inline.hpp(99): error C3680: cannot concatenate user-defined string literals with mismatched literal suffix identifiers

[Rob McKenna]

This will require a codereview as its a new change.

    -Rob

On 15/06/18 12:00, Kevin Walls wrote:
> Hi,
> 
> I'd like to request approval to push to 8u:
> 
> 8204872: [8u] VS2017: threadLocalAllocBuffer.inline.hpp(99): error C3680:
> cannot concatenate user-defined string literals with mismatched literal
> suffix identifiers
> JBS: https://bugs.openjdk.java.net/browse/JDK-8204872
> 
> This is a new change, but a change to whitespace, following  the same
> pattern as 8081202 which is recently backported to 8u, i.e. add a space
> between string literals and macros, to avoid compile errors.
> This wasn't covered by 8081202 as it's in code which was no longer the same
> in 9, due to:
> 8145092: Use Unified Logging for the GC logging
> (which we are not backporting).
> 
> Text diff is below, I've run it in various recent tests, but do let me know
> if a webrev or other approval is required.
> 
> Many thanks
> Kevin
> 
> bash-4.2$ hg status
> M src/share/vm/memory/threadLocalAllocBuffer.inline.hpp
> bash-4.2$ hg diff src/share/vm/memory/threadLocalAllocBuffer.inline.hpp
> diff -r 6688d6c6a225 src/share/vm/memory/threadLocalAllocBuffer.inline.hpp
> --- a/src/share/vm/memory/threadLocalAllocBuffer.inline.hpp     Tue Feb 20
> 07:10:42 2018 -0500
> +++ b/src/share/vm/memory/threadLocalAllocBuffer.inline.hpp     Fri Jun 15
> 03:48:33 2018 -0700
> @@ -94,10 +94,10 @@
> 
>    if (PrintTLAB && Verbose) {
>      Thread* thrd = myThread();
> -    gclog_or_tty->print("TLAB: %s thread: "INTPTR_FORMAT" [id: %2d]"
> -                        " obj: "SIZE_FORMAT
> -                        " free: "SIZE_FORMAT
> -                        " waste: "SIZE_FORMAT"\n",
> +    gclog_or_tty->print("TLAB: %s thread: " INTPTR_FORMAT " [id: %2d]"
> +                        " obj: " SIZE_FORMAT
> +                        " free: " SIZE_FORMAT
> +                        " waste: " SIZE_FORMAT "\n"
>                          "slow", p2i(thrd), thrd->osthread()->thread_id(),
>                          obj_size, free(), refill_waste_limit());
>    }
>