RFA: 8031668: TOOLCHAIN_FIND_COMPILER unexpectedly resolves symbolic links AND 8148351: Only display resolved symlink for compiler, do not change path

[Rob McKenna]

Approved. Please work with the appropriate team to find a sponsor.

    -Rob

On 18/06/18 16:36, Severin Gehwolf wrote:
> Hi,
> 
> Please approve these two backports to JDK 8u-dev which are already in
> JDK 9 and better.
> 
> 8031668: TOOLCHAIN_FIND_COMPILER unexpectedly resolves symbolic links
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8031668/webrev.01/
> hg export: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8031668/JDK-8031668.jdk8.export.patch
> 
> 8148351: Only display resolved symlink for compiler, do not change path
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8148351/webrev.01/
> hg export: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8148351/JDK-8148351.jdk8.export.patch
> 
> Bug 8031668 is a dependency for 8148351 which actually fixes the
> wrapped compiler issue on the JDK 8 tree. The JDK 8 patch of 8031668 is
> the same as for JDK 9, modulo some context changes. After the JDK 8
> patch of 8031668, the JDK 9 patch of 8148351 imports as is.
> 
> The issue at hand is that one cannot build the JDK 8 tree with certain
> compiler wrappers such as cscppc. It currently fails with:
> 
> configure: Using default toolchain gcc (GNU Compiler Collection)
> checking for gcc... /usr/lib64/cscppc/gcc
> checking resolved symbolic links for CC... /usr/bin/cscppc
> checking if CC is disguised ccache... no, keeping CC
> configure: The C compiler (located as /usr/bin/cscppc) does not seem to be the required gcc compiler.
> configure: The result from running with --version was: ""
> configure: error: A gcc compiler is required. Try setting --with-tools-dir.
> configure exiting with result code 1
> 
> After both backports configure with a wrapped GCC succeeds.
> 
> Please note that I'd need an Oracle sponsor for getting this pushed to
> jdk8u-dev since both changes require re-generation of generated-
> configure.sh
> 
> Thanks,
> Severin