[8u-dev] Request for approval for CR 8150688: Fix os_windows siglabel

[Rob McKenna]

Approved

    -Rob

On 19/06/18 07:10, Kevin Walls wrote:
> Hi -
> 
> Actually I had missed a comma change in the ia64 case.
> 
> hotspot runtime dev review of 8u change:
> 
> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2018-June/028681.html
> 
> Thanks
> Kevin
> 
> 
> On 15/06/2018 13:57, Rob McKenna wrote:
> >The changes will need a codereview.
> >
> >     -Rob
> >
> >On 15/06/18 10:16, Kevin Walls wrote:
> >>Hi,
> >>
> >>I'd like to request approval to backport from 9 to 8u:
> >>
> >>8150688: Fix os_windows siglabel
> >>JBS: https://bugs.openjdk.java.net/browse/JDK-8150688
> >>
> >>9 changeset:
> >>URL:   http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/80706cc25494
> >>
> >>9 review thread:
> >>http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-March/018236.html
> >>
> >>Proposed 8u change: http://cr.openjdk.java.net/~kevinw/8150688/webrev.00/
> >>
> >>This is a pretty clean backport. but didn't import automatically: in 8u
> >>there is no "os::get_signal_number()" and some of the def_excpt... lines
> >>didn't apply automatically, but they are the same change.
> >>
> >>This removes some errors when varying the windows compiler in use, still
> >>builds and tests OK on current standard VS compiler.
> >>
> >>Thanks!
> >>Kevin
> >>
>