[8u] Request for Approval for JDK-8008321: compile.cpp verify_graph_edges uses bool as int

[David Buck]

approved for backport to 8u-dev

Cheers,
-Buck

On 2018/06/20 14:47, Andrew Hughes wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8008321
> Webrev: http://cr.openjdk.java.net/~andrew/openjdk8/8008321/webrev.01/
> Original review thread:
> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-June/014851.html
> 
> Fix applies as is to OpenJDK 8.
> 
> Debug build is failing here without this fix:
> 
> /usr/x86_64-pc-linux-gnu/gcc-bin/7.3.0/x86_64-pc-linux-gnu-g++ -DLINUX
> -D_GNU_SOURCE -DIA32 -DASSERT -I.
> -I/home/andrew/projects/openjdk/upstream/jdk8u-dev/hotspot/src/share/vm/prims
> -I/home/andrew/projects/openjdk/upstream/jdk8u-dev/hotspot/src/share/vm
> -I/home/andrew/projects/openjdk/upstream/jdk8u-dev/hotspot/src/share/vm/precompiled
> -I/home/andrew/projects/openjdk/upstream/jdk8u-dev/hotspot/src/cpu/x86/vm
> -I/home/andrew/projects/openjdk/upstream/jdk8u-dev/hotspot/src/os_cpu/linux_x86/vm
> -I/home/andrew/projects/openjdk/upstream/jdk8u-dev/hotspot/src/os/linux/vm
> -I/home/andrew/projects/openjdk/upstream/jdk8u-dev/hotspot/src/os/posix/vm
> -I../generated -DHOTSPOT_RELEASE_VERSION="\"25.71-b00\""
> -DHOTSPOT_BUILD_TARGET="\"debug\"" -DHOTSPOT_BUILD_USER="\"andrew\""
> -DHOTSPOT_LIB_ARCH=\"i386\" -DHOTSPOT_VM_DISTRO="\"OpenJDK\""
> -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_32
> -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_32
> -DTARGET_COMPILER_gcc -DCOMPILER2 -DCOMPILER1 -fno-rtti
> -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility=hidden -m32
> -march=i586 -pipe -fno-strict-aliasing  -g -fno-omit-frame-pointer
> -D_NMT_NOINLINE_ -DVM_LITTLE_ENDIAN -Werror -Wpointer-arith
> -Wsign-compare -Wundef -Wunused-function -Wunused-value   -O2 -pipe
> -march=core2 -ggdb -mno-tls-direct-seg-refs
> -Werror=implicit-function-declaration -fstack-protector-strong
> -std=gnu++98 -DDTRACE_ENABLED -c -MMD -MP -MF
> ../generated/dependencies/compiledICHolder.o.d -fpch-deps -o
> compiledICHolder.o
> /home/andrew/projects/openjdk/upstream/jdk8u-dev/hotspot/src/share/vm/oops/compiledICHolder.cpp
> 
> /home/andrew/projects/openjdk/upstream/jdk8u-dev/hotspot/src/share/vm/opto/compile.cpp:
> In member function 'void Compile::verify_graph_edges(bool)':
> /home/andrew/projects/openjdk/upstream/jdk8u-dev/hotspot/src/share/vm/opto/compile.cpp:3494:25:
> error: use of an operand of type 'bool' in 'operator++' is deprecated
> [-Werror=deprecated]
>             if (dead_nodes++ == 0)
> 
> Thanks,
>