From dmitry.markov at oracle.com Thu Mar 1 10:54:30 2018 From: dmitry.markov at oracle.com (Dmitry Markov) Date: Thu, 1 Mar 2018 10:54:30 +0000 Subject: Request for approval 8187635: On Windows Swing changes keyboard layout on a window activation Message-ID: Hello, Can I get an approval to port the fix for 8187635 to jdk8u-dev, please? The jdk11 patch applies cleanly. JBS: https://bugs.openjdk.java.net/browse/JDK-8187635 Review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2018-February/013631.html JDK11 change: http://hg.openjdk.java.net/jdk/client/rev/838c11e59a38 Thanks, Dmitry From sean.coffey at oracle.com Thu Mar 1 11:02:16 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 1 Mar 2018 11:02:16 +0000 Subject: Request for approval 8187635: On Windows Swing changes keyboard layout on a window activation In-Reply-To: References: Message-ID: <46da3a46-4b8b-146e-bbeb-ea24e330f59d@oracle.com> Approved. regards, Sean. On 01/03/2018 10:54, Dmitry Markov wrote: > Hello, > > Can I get an approval to port the fix for 8187635 to jdk8u-dev, please? The jdk11 patch applies cleanly. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8187635 > Review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2018-February/013631.html > JDK11 change: http://hg.openjdk.java.net/jdk/client/rev/838c11e59a38 > > Thanks, > Dmitry From dalibor.topic at oracle.com Thu Mar 1 13:53:22 2018 From: dalibor.topic at oracle.com (dalibor topic) Date: Thu, 1 Mar 2018 14:53:22 +0100 Subject: [jdk8u-dev] Request for review and approval : 8193892: Impact of noncloneable MessageDigest implementation In-Reply-To: <68128679-b1b1-7fa6-9147-bbdc5a85b4a7@oracle.com> References: <68128679-b1b1-7fa6-9147-bbdc5a85b4a7@oracle.com> Message-ID: <9bdcca0a-0edc-b616-1975-398a853d6777@oracle.com> Thanks, Sean - approved pending positive review. cheers, dalibor topic On 28.02.2018 19:53, Se?n Coffey wrote: > Looking to port the below test to JDK 8u. Almost identical to JDK 11 fix > except I had to the use the old Provider constructor call in MyProvider > code. > > Brad - would you mind confirming for review ? > > bug ID : https://bugs.openjdk.java.net/browse/JDK-8193892 > webrev : http://cr.openjdk.java.net/~coffeys/webrev.8193892.jdk8u/webrev/ > > regards, > Sean. > -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment From christoph.langer at sap.com Fri Mar 2 14:20:34 2018 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 2 Mar 2018 14:20:34 +0000 Subject: Request for Approval: JDK-8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM Message-ID: <7e4e62b3fdc643aebce9d2b4bddd2939@sap.com> Hi, please approve this backport of a change that came in to JDK9 with the big initial Jigsaw modularization patch. Bug: https://bugs.openjdk.java.net/browse/JDK-8197943 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8197943.0/ Review Thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-February/023135.html Thanks Christoph From rob.mckenna at oracle.com Fri Mar 2 14:42:49 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 2 Mar 2018 14:42:49 +0000 Subject: Request for Approval: JDK-8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM In-Reply-To: <7e4e62b3fdc643aebce9d2b4bddd2939@sap.com> References: <7e4e62b3fdc643aebce9d2b4bddd2939@sap.com> Message-ID: <20180302144249.GA3300@vimes> Approved -Rob On 02/03/18 14:20, Langer, Christoph wrote: > Hi, > > please approve this backport of a change that came in to JDK9 with the big initial Jigsaw modularization patch. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8197943 > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8197943.0/ > Review Thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-February/023135.html > > Thanks > Christoph > From sean.coffey at oracle.com Sun Mar 4 20:54:28 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Sun, 4 Mar 2018 20:54:28 +0000 Subject: [jdk8u-dev] Request for review and approval : 8193892: Impact of noncloneable MessageDigest implementation In-Reply-To: <9bdcca0a-0edc-b616-1975-398a853d6777@oracle.com> References: <68128679-b1b1-7fa6-9147-bbdc5a85b4a7@oracle.com> <9bdcca0a-0edc-b616-1975-398a853d6777@oracle.com> Message-ID: Brad, as per off thread comments, the JDK 8u test also needs correction. The test Provider was being registered incorrectly and provided a false pass test result. I've corrected that now and added extra code to ensure the expected provider is always registered during the test. I've updated the webrev : http://cr.openjdk.java.net/~coffeys/webrev.8193892.jdk8u.v2/webrev/ Please review when you've a moment. regards, Sean. On 01/03/2018 13:53, dalibor topic wrote: > Thanks, Sean - approved pending positive review. > > cheers, > dalibor topic > > On 28.02.2018 19:53, Se?n Coffey wrote: >> Looking to port the below test to JDK 8u. Almost identical to JDK 11 >> fix except I had to the use the old Provider constructor call in >> MyProvider code. >> >> Brad - would you mind confirming for review ? >> >> bug ID : https://bugs.openjdk.java.net/browse/JDK-8193892 >> webrev : >> http://cr.openjdk.java.net/~coffeys/webrev.8193892.jdk8u/webrev/ >> >> regards, >> Sean. >> > From christoph.langer at sap.com Tue Mar 6 08:56:49 2018 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 6 Mar 2018 08:56:49 +0000 Subject: Request for Approval: JDK-8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM In-Reply-To: <20180302144249.GA3300@vimes> References: <7e4e62b3fdc643aebce9d2b4bddd2939@sap.com> <20180302144249.GA3300@vimes> Message-ID: <835a5b567bd94a188cd613a5da000ace@sap.com> Thanks Rob, I pushed it. > -----Original Message----- > From: Rob McKenna [mailto:rob.mckenna at oracle.com] > Sent: Freitag, 2. M?rz 2018 15:43 > To: Langer, Christoph > Cc: jdk8u-dev at openjdk.java.net > Subject: Re: Request for Approval: JDK-8197943: Unable to use JDWP API in > JDK 8 to debug JDK 9 VM > > Approved > > -Rob > > On 02/03/18 14:20, Langer, Christoph wrote: > > Hi, > > > > please approve this backport of a change that came in to JDK9 with the big > initial Jigsaw modularization patch. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8197943 > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8197943.0/ > > Review Thread: http://mail.openjdk.java.net/pipermail/serviceability- > dev/2018-February/023135.html > > > > Thanks > > Christoph > > From bradford.wetmore at oracle.com Tue Mar 6 18:17:49 2018 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Tue, 6 Mar 2018 10:17:49 -0800 Subject: [jdk8u-dev] Request for review and approval : 8193892: Impact of noncloneable MessageDigest implementation In-Reply-To: References: <68128679-b1b1-7fa6-9147-bbdc5a85b4a7@oracle.com> <9bdcca0a-0edc-b616-1975-398a853d6777@oracle.com> Message-ID: Looks good, sorry for the delay, I don't check this alias as often. Brad On 3/4/2018 12:54 PM, Se?n Coffey wrote: > Brad, > > as per off thread comments, the JDK 8u test also needs correction. The > test Provider was being registered incorrectly and provided a false pass > test result. I've corrected that now and added extra code to ensure the > expected provider is always registered during the test. > > I've updated the webrev : > > http://cr.openjdk.java.net/~coffeys/webrev.8193892.jdk8u.v2/webrev/ > > Please review when you've a moment. > > regards, > Sean. > > On 01/03/2018 13:53, dalibor topic wrote: >> Thanks, Sean - approved pending positive review. >> >> cheers, >> dalibor topic >> >> On 28.02.2018 19:53, Se?n Coffey wrote: >>> Looking to port the below test to JDK 8u. Almost identical to JDK 11 >>> fix except I had to the use the old Provider constructor call in >>> MyProvider code. >>> >>> Brad - would you mind confirming for review ? >>> >>> bug ID : https://bugs.openjdk.java.net/browse/JDK-8193892 >>> webrev : >>> http://cr.openjdk.java.net/~coffeys/webrev.8193892.jdk8u/webrev/ >>> >>> regards, >>> Sean. >>> >> > From fairoz.matte at oracle.com Wed Mar 7 05:43:32 2018 From: fairoz.matte at oracle.com (Fairoz Matte) Date: Tue, 6 Mar 2018 21:43:32 -0800 (PST) Subject: [8u-dev] Request for approval for JDK-8194642: Improve OOM error reporting for JDK8 Message-ID: <869bfed3-17b4-4944-99e0-4dbecd18de99@default> Hi, Please approve the small enhancement for 8u-dev JBS link - https://bugs.openjdk.java.net/browse/JDK-8194642 Webrev - http://cr.openjdk.java.net/~fmatte/8194642/webrev.01/ Review thread - http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-March/028378.html Thanks, Fairoz From sean.coffey at oracle.com Wed Mar 7 09:47:14 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 7 Mar 2018 09:47:14 +0000 Subject: [8u-dev] Request for approval for JDK-8194642: Improve OOM error reporting for JDK8 In-Reply-To: <869bfed3-17b4-4944-99e0-4dbecd18de99@default> References: <869bfed3-17b4-4944-99e0-4dbecd18de99@default> Message-ID: <91feb288-64ba-2f22-fdd0-a6447e630e51@oracle.com> Fairoz, given the nature of this fix, you'll need to log an enhancement backport request : http://openjdk.java.net/projects/jdk8u/enhancement-template.html Regards, Sean. On 07/03/18 05:43, Fairoz Matte wrote: > Hi, > > Please approve the small enhancement for 8u-dev > > JBS link - https://bugs.openjdk.java.net/browse/JDK-8194642 > > Webrev - http://cr.openjdk.java.net/~fmatte/8194642/webrev.01/ > > Review thread - http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-March/028378.html > > Thanks, > Fairoz From anton.litvinov at oracle.com Wed Mar 7 15:32:56 2018 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Wed, 7 Mar 2018 15:32:56 +0000 Subject: [8u-dev] Request for approval for CR 8198605: Touch keyboard is shown for a non-focusable text component Message-ID: <3500d907-ff75-8b34-5e0f-dccfd9951085@oracle.com> Hello, I would like to request for approval to push a straight backport of the fix from JDK 11 to JDK 8. The changeset from JDK 11 applies to JDK 8 after correction of file paths. Bug: https://bugs.openjdk.java.net/browse/JDK-8198605 JDK 11 changeset: http://hg.openjdk.java.net/jdk/client/rev/517c1f85c13a JDK 11 review thread: ??? Approval 1 - http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013676.html ??? Approval 2 - http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013684.html Reviewers: serb, dmarkov Thank you, Anton From rob.mckenna at oracle.com Wed Mar 7 16:24:52 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 7 Mar 2018 16:24:52 +0000 Subject: [8u-dev] Request for approval for CR 8198605: Touch keyboard is shown for a non-focusable text component In-Reply-To: <3500d907-ff75-8b34-5e0f-dccfd9951085@oracle.com> References: <3500d907-ff75-8b34-5e0f-dccfd9951085@oracle.com> Message-ID: <20180307162452.GB4017@vimes> Approved -Rob On 07/03/18 15:32, Anton Litvinov wrote: > Hello, > > I would like to request for approval to push a straight backport of the fix > from JDK 11 to JDK 8. The changeset from JDK 11 applies to JDK 8 after > correction of file paths. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8198605 > JDK 11 changeset: http://hg.openjdk.java.net/jdk/client/rev/517c1f85c13a > JDK 11 review thread: > ??? Approval 1 - > http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013676.html > ??? Approval 2 - > http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013684.html > Reviewers: serb, dmarkov > > Thank you, > Anton From fairoz.matte at oracle.com Thu Mar 8 10:36:23 2018 From: fairoz.matte at oracle.com (Fairoz Matte) Date: Thu, 8 Mar 2018 02:36:23 -0800 (PST) Subject: [8u-dev] Request for enhancement backport approval for JDK-8194642: Improve OOM error reporting for JDK8 Message-ID: <8771ab30-44ee-48d8-8c83-a4f77b9f2d72@default> Hi, Please approve the small enhancement for 8u-dev JBS link - https://bugs.openjdk.java.net/browse/JDK-8194642 Webrev - http://cr.openjdk.java.net/~fmatte/8194642/webrev.01/ Review thread - http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-March/028378.html This small enhancement is partial backport of JDK-8064814 JDK-8026324 JDK-8026333 and JDK-8026336. Benefits: Compared to JDK9, JDK8u version of the error reporting has too little information on native OOM related problems. This enhancement is to improve the error reporting to handle possible reasons for OOM. Such as 1. (+/-)UseCompressedOops 2. 32 bit 3. Possible suggestions for 64 bit (Already exist with more specific cases) Risks: There is no risk, code changes are part of error reporting, that will be invoked only during crash. Thanks, Fairoz From rob.mckenna at oracle.com Thu Mar 8 17:51:17 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 8 Mar 2018 17:51:17 +0000 Subject: [8u-dev] Request for enhancement backport approval for JDK-8194642: Improve OOM error reporting for JDK8 In-Reply-To: <8771ab30-44ee-48d8-8c83-a4f77b9f2d72@default> References: <8771ab30-44ee-48d8-8c83-a4f77b9f2d72@default> Message-ID: <20180308175117.GA6378@vimes> Thanks Fairoz, this enhancement has been approved. -Rob On 08/03/18 02:36, Fairoz Matte wrote: > Hi, > > Please approve the small enhancement for 8u-dev > > JBS link - https://bugs.openjdk.java.net/browse/JDK-8194642 > > Webrev - http://cr.openjdk.java.net/~fmatte/8194642/webrev.01/ > > Review thread - http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-March/028378.html > > This small enhancement is partial backport of JDK-8064814 JDK-8026324 JDK-8026333 and JDK-8026336. > > Benefits: Compared to JDK9, JDK8u version of the error reporting has too little information on native OOM related problems. > This enhancement is to improve the error reporting to handle possible reasons for OOM. > > Such as > 1. (+/-)UseCompressedOops > 2. 32 bit > 3. Possible suggestions for 64 bit (Already exist with more specific cases) > > Risks: There is no risk, code changes are part of error reporting, that will be invoked only during crash. > > Thanks, > Fairoz From rob.mckenna at oracle.com Thu Mar 8 17:52:54 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 8 Mar 2018 17:52:54 +0000 Subject: [8u-dev] Request for approval for JDK-8194642: Improve OOM error reporting for JDK8 In-Reply-To: <91feb288-64ba-2f22-fdd0-a6447e630e51@oracle.com> References: <869bfed3-17b4-4944-99e0-4dbecd18de99@default> <91feb288-64ba-2f22-fdd0-a6447e630e51@oracle.com> Message-ID: <20180308175254.GB6378@vimes> Approved. (context: http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-March/007292.html) -Rob On 07/03/18 09:47, Se?n Coffey wrote: > Fairoz, > > given the nature of this fix, you'll need to log an enhancement backport > request : > > http://openjdk.java.net/projects/jdk8u/enhancement-template.html > > Regards, > Sean. > > On 07/03/18 05:43, Fairoz Matte wrote: > >Hi, > > > >Please approve the small enhancement for 8u-dev > > > >JBS link - https://bugs.openjdk.java.net/browse/JDK-8194642 > > > >Webrev - http://cr.openjdk.java.net/~fmatte/8194642/webrev.01/ > > > >Review thread - http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-March/028378.html > > > >Thanks, > >Fairoz > From fairoz.matte at oracle.com Fri Mar 9 03:55:18 2018 From: fairoz.matte at oracle.com (Fairoz Matte) Date: Thu, 8 Mar 2018 19:55:18 -0800 (PST) Subject: [8u-dev] Request for approval for JDK-8194642: Improve OOM error reporting for JDK8 In-Reply-To: <20180308175254.GB6378@vimes> References: <869bfed3-17b4-4944-99e0-4dbecd18de99@default> <91feb288-64ba-2f22-fdd0-a6447e630e51@oracle.com> <20180308175254.GB6378@vimes> Message-ID: <234e9e1d-943c-4451-9cf8-c774a4040800@default> Thanks Rob and Sean. > -----Original Message----- > From: Rob McKenna > Sent: Thursday, March 08, 2018 11:23 PM > To: Se?n Coffey > Cc: Fairoz Matte ; jdk8u-dev at openjdk.java.net > Subject: Re: [8u-dev] Request for approval for JDK-8194642: Improve OOM > error reporting for JDK8 > > Approved. > > (context: > http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-March/007292.html) > > -Rob > > On 07/03/18 09:47, Se?n Coffey wrote: > > Fairoz, > > > > given the nature of this fix, you'll need to log an enhancement > > backport request : > > > > http://openjdk.java.net/projects/jdk8u/enhancement-template.html > > > > Regards, > > Sean. > > > > On 07/03/18 05:43, Fairoz Matte wrote: > > >Hi, > > > > > >Please approve the small enhancement for 8u-dev > > > > > >JBS link - https://bugs.openjdk.java.net/browse/JDK-8194642 > > > > > >Webrev - http://cr.openjdk.java.net/~fmatte/8194642/webrev.01/ > > > > > >Review thread - > > >http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-Marc > > >h/028378.html > > > > > >Thanks, > > >Fairoz > > From sean.coffey at oracle.com Fri Mar 9 09:41:12 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 9 Mar 2018 09:41:12 +0000 Subject: [jdk8u-dev] Request for approval : 8197518: Kerberos krb5 authentication: AuthList's put method leads to performance issue Message-ID: Looking to backport this fix to jdk8u-dev. Changes apply cleanly : https://bugs.openjdk.java.net/browse/JDK-8197518 http://hg.openjdk.java.net/jdk/jdk/rev/3fbc7f109dad review : http://mail.openjdk.java.net/pipermail/security-dev/2018-February/016822.html regards, Sean. From rob.mckenna at oracle.com Fri Mar 9 16:09:55 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 9 Mar 2018 16:09:55 +0000 Subject: [jdk8u-dev] Request for approval : 8197518: Kerberos krb5 authentication: AuthList's put method leads to performance issue In-Reply-To: References: Message-ID: <20180309160955.GA3109@vimes> Approved -Rob On 09/03/18 09:41, Se?n Coffey wrote: > Looking to backport this fix to jdk8u-dev. > > Changes apply cleanly : > > https://bugs.openjdk.java.net/browse/JDK-8197518 > http://hg.openjdk.java.net/jdk/jdk/rev/3fbc7f109dad > review : > http://mail.openjdk.java.net/pipermail/security-dev/2018-February/016822.html > > regards, > Sean. > From ivan.gerasimov at oracle.com Mon Mar 12 17:36:16 2018 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Mon, 12 Mar 2018 10:36:16 -0700 Subject: [8u-dev] RFA to backport : 8165463, 8198898 Message-ID: <000e6050-b76a-f1c1-824f-851e8a4b998d@oracle.com> Hello! I'd like to backport these two fixes to jdk8u-dev: 8165463: Native implementation of sunmscapi should use operator new (nothrow) for allocations 8198898: Compilation errors in jdk.crypto.mscapi with VS 2017 The (unshuffled) patches apply cleanly, and the build/testing go fine. Bug: https://bugs.openjdk.java.net/browse/JDK-8165463 Jdk9 review: http://mail.openjdk.java.net/pipermail/security-dev/2016-October/015026.html Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/5651fa4f1478 Bug: https://bugs.openjdk.java.net/browse/JDK-8198898 Jdk11 review: http://mail.openjdk.java.net/pipermail/security-dev/2018-March/016867.html Jdk11 change: http://hg.openjdk.java.net/jdk/jdk/rev/217780dff1bf Thanks in advance! -- With kind regards, Ivan Gerasimov From rob.mckenna at oracle.com Mon Mar 12 22:13:35 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 12 Mar 2018 22:13:35 +0000 Subject: [8u-dev] RFA to backport : 8165463, 8198898 In-Reply-To: <000e6050-b76a-f1c1-824f-851e8a4b998d@oracle.com> References: <000e6050-b76a-f1c1-824f-851e8a4b998d@oracle.com> Message-ID: <20180312221335.GB3652@vimes> Approved -Rob On 12/03/18 10:36, Ivan Gerasimov wrote: > Hello! > > I'd like to backport these two fixes to jdk8u-dev: > > 8165463: Native implementation of sunmscapi should use operator new > (nothrow) for allocations > 8198898: Compilation errors in jdk.crypto.mscapi with VS 2017 > > The (unshuffled) patches apply cleanly, and the build/testing go fine. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8165463 > Jdk9 review: > http://mail.openjdk.java.net/pipermail/security-dev/2016-October/015026.html > Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/5651fa4f1478 > > Bug: https://bugs.openjdk.java.net/browse/JDK-8198898 > Jdk11 review: > http://mail.openjdk.java.net/pipermail/security-dev/2018-March/016867.html > Jdk11 change: http://hg.openjdk.java.net/jdk/jdk/rev/217780dff1bf > > Thanks in advance! > > -- > With kind regards, > Ivan Gerasimov > From anton.litvinov at oracle.com Tue Mar 13 15:27:57 2018 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Tue, 13 Mar 2018 15:27:57 +0000 Subject: [8u-dev] Request for approval for CR 8198606: Touch keyboard does not hide, when a text component looses focus Message-ID: Hello, I would like to request for approval to push a straight backport of the fix from JDK 11 to JDK 8. The changeset from JDK 11 applies to JDK 8 after correction of a file path. Bug: https://bugs.openjdk.java.net/browse/JDK-8198606 JDK 11 changeset: http://hg.openjdk.java.net/jdk/client/rev/b09417148c93 JDK 11 review thread: ??? Approval 1 - http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013718.html ??? Approval 2 - http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013719.html Reviewers: serb, dmarkov Thank you, Anton From rob.mckenna at oracle.com Tue Mar 13 18:50:20 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 13 Mar 2018 18:50:20 +0000 Subject: [8u-dev] Request for approval for CR 8198606: Touch keyboard does not hide, when a text component looses focus In-Reply-To: References: Message-ID: <20180313185020.GA4532@vimes> Approved -Rob On 13/03/18 15:27, Anton Litvinov wrote: > Hello, > > I would like to request for approval to push a straight backport of the fix > from JDK 11 to JDK 8. The changeset from JDK 11 applies to JDK 8 after > correction of a file path. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8198606 > JDK 11 changeset: http://hg.openjdk.java.net/jdk/client/rev/b09417148c93 > JDK 11 review thread: > ??? Approval 1 - > http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013718.html > ??? Approval 2 - > http://mail.openjdk.java.net/pipermail/awt-dev/2018-March/013719.html > Reviewers: serb, dmarkov > > Thank you, > Anton From shafi.s.ahmad at oracle.com Wed Mar 14 07:59:33 2018 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Wed, 14 Mar 2018 00:59:33 -0700 (PDT) Subject: [8u] RFA for backport of JDK-8026331: hs_err improvement: Print if we have seen any OutOfMemoryErrors or StackOverflowErrors Message-ID: Hi, May I get the approval of backport of "JDK-8026331: hs_err improvement: Print if we have seen any OutOfMemoryErrors or StackOverflowErrors" to jdk8u. Webrev: http://cr.openjdk.java.net/~shshahma/8026331/webrev.01/ Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8026331 Jdk9 review: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-June/014957.html Jdk8 review: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030522.html Jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/cf5a0377f578 Jdk8 enhancement request: http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-January/007190.html Testing: jprt -testset hotspot Regards, Shafi From sean.coffey at oracle.com Wed Mar 14 08:26:31 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 14 Mar 2018 08:26:31 +0000 Subject: [8u] RFA for backport of JDK-8026331: hs_err improvement: Print if we have seen any OutOfMemoryErrors or StackOverflowErrors In-Reply-To: References: Message-ID: Approved. regards, Sean. On 14/03/2018 07:59, Shafi Ahmad wrote: > Hi, > > May I get the approval of backport of "JDK-8026331: hs_err improvement: Print if we have seen any OutOfMemoryErrors or StackOverflowErrors" to jdk8u. > > Webrev: http://cr.openjdk.java.net/~shshahma/8026331/webrev.01/ > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8026331 > Jdk9 review: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-June/014957.html > Jdk8 review: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030522.html > Jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/cf5a0377f578 > Jdk8 enhancement request: http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-January/007190.html > > Testing: jprt -testset hotspot > > Regards, > Shafi > From shafi.s.ahmad at oracle.com Fri Mar 16 13:00:03 2018 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Fri, 16 Mar 2018 06:00:03 -0700 (PDT) Subject: [8u-dev] Request for enhancement backport approval for JDK-8026335 and JDK-8035074 Message-ID: Hi! Please consider the following enhancement for approval: bug report: 1. https://bugs.openjdk.java.net/browse/JDK-8035074 2. https://bugs.openjdk.java.net/browse/JDK-8026335 This is an important fix that helps in analyzing the user issues. All standard JPRT tests run and passed (hotspot testset). The change itself is relatively safe as this change emits additional data into the hs_err file without changing any behavior of JVM. It has zero almost impact on JVM. I believe there is negligible risk in including this in JDK 8. Regards, Shafi From rob.mckenna at oracle.com Fri Mar 16 14:27:58 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 16 Mar 2018 14:27:58 +0000 Subject: [8u-dev] Request for enhancement backport approval for JDK-8026335 and JDK-8035074 In-Reply-To: References: Message-ID: <20180316142758.GB3270@vimes> Approved. Please proceed with a push approval request. -Rob On 16/03/18 06:00, Shafi Ahmad wrote: > Hi! > > Please consider the following enhancement for approval: > > bug report: > 1. https://bugs.openjdk.java.net/browse/JDK-8035074 > 2. https://bugs.openjdk.java.net/browse/JDK-8026335 > > This is an important fix that helps in analyzing the user issues. > > All standard JPRT tests run and passed (hotspot testset). > > The change itself is relatively safe as this change emits additional data into the hs_err file without changing any behavior of JVM. > It has zero almost impact on JVM. I believe there is negligible risk in including this in JDK 8. > > Regards, > Shafi From shafi.s.ahmad at oracle.com Fri Mar 16 14:46:17 2018 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Fri, 16 Mar 2018 07:46:17 -0700 (PDT) Subject: [8u-dev] Request for enhancement backport approval for JDK-8026335 and JDK-8035074 In-Reply-To: <20180316142758.GB3270@vimes> References: <20180316142758.GB3270@vimes> Message-ID: <86b200a2-2b77-4f09-925a-4e3907167787@default> Thank you Rob. Regards, Shafi > -----Original Message----- > From: Rob McKenna > Sent: Friday, March 16, 2018 7:58 PM > To: Shafi Ahmad > Cc: jdk8u-dev at openjdk.java.net > Subject: Re: [8u-dev] Request for enhancement backport approval for JDK- > 8026335 and JDK-8035074 > > Approved. Please proceed with a push approval request. > > -Rob > > On 16/03/18 06:00, Shafi Ahmad wrote: > > Hi! > > > > Please consider the following enhancement for approval: > > > > bug report: > > 1. https://bugs.openjdk.java.net/browse/JDK-8035074 > > 2. https://bugs.openjdk.java.net/browse/JDK-8026335 > > > > This is an important fix that helps in analyzing the user issues. > > > > All standard JPRT tests run and passed (hotspot testset). > > > > The change itself is relatively safe as this change emits additional data into > the hs_err file without changing any behavior of JVM. > > It has zero almost impact on JVM. I believe there is negligible risk in > including this in JDK 8. > > > > Regards, > > Shafi From shafi.s.ahmad at oracle.com Fri Mar 16 14:46:39 2018 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Fri, 16 Mar 2018 07:46:39 -0700 (PDT) Subject: [8u] RFA for backport of JDK-8035074 and JDK-8026335 to jdk8u-dev Message-ID: <5258e476-1bd7-4ceb-8b3c-631edb771ff8@default> Hi, May I get the approval of backport of JDK-8035074 and JDK-8026335 to jdk8u. Webrev: http://cr.openjdk.java.net/~shshahma/8026331/webrev.01/ Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8035074 : hs_err improvement: Add time zone information in the hs_err file https://bugs.openjdk.java.net/browse/JDK-8026335 : hs_err improvement: Print exact compressed oops mode and the heap base value Jdk9 review: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-June/014957.html Jdk8 review: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030522.html Jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/cf5a0377f578 Testing: jprt -testset hotspot Regards, Shafi From rob.mckenna at oracle.com Fri Mar 16 15:03:50 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 16 Mar 2018 15:03:50 +0000 Subject: [8u] RFA for backport of JDK-8035074 and JDK-8026335 to jdk8u-dev In-Reply-To: <5258e476-1bd7-4ceb-8b3c-631edb771ff8@default> References: <5258e476-1bd7-4ceb-8b3c-631edb771ff8@default> Message-ID: <20180316150350.GC3270@vimes> Approved. Please add a suitable noreg label to both bugs. -Rob On 16/03/18 07:46, Shafi Ahmad wrote: > Hi, > > May I get the approval of backport of JDK-8035074 and JDK-8026335 to jdk8u. > > Webrev: http://cr.openjdk.java.net/~shshahma/8026331/webrev.01/ > Jdk9 bug: > https://bugs.openjdk.java.net/browse/JDK-8035074 : hs_err improvement: Add time zone information in the hs_err file > https://bugs.openjdk.java.net/browse/JDK-8026335 : hs_err improvement: Print exact compressed oops mode and the heap base value > Jdk9 review: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-June/014957.html > Jdk8 review: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030522.html > Jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/cf5a0377f578 > > Testing: jprt -testset hotspot > > Regards, > Shafi > From rwestrel at redhat.com Fri Mar 16 15:06:02 2018 From: rwestrel at redhat.com (Roland Westrelin) Date: Fri, 16 Mar 2018 16:06:02 +0100 Subject: [8u] RFR + RFA: 8188223: IfNode::range_check_trap_proj() should handler dying subgraph with single if proj Message-ID: We (Red Hat) would like to backport 8188223 to 8u: we're hitting hit with openJFX. The patch doesn't apply cleanly. See below for a new webrev. It was pushed to jdk10 5 months ago and there was no follow up bugs that I'm aware of. https://bugs.openjdk.java.net/browse/JDK-8188223 http://hg.openjdk.java.net/jdk10/master/rev/24ebaf9d7198 New webrev: http://cr.openjdk.java.net/~roland/8188223-8u/webrev.00/ Roland. From rob.mckenna at oracle.com Fri Mar 16 15:44:45 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 16 Mar 2018 15:44:45 +0000 Subject: [8u] RFR + RFA: 8188223: IfNode::range_check_trap_proj() should handler dying subgraph with single if proj In-Reply-To: References: Message-ID: <20180316154445.GA16341@vimes> You may want to seek a codereview from hotspot-dev. Reviewers may or may not monitor this alias. -Rob On 16/03/18 16:06, Roland Westrelin wrote: > > We (Red Hat) would like to backport 8188223 to 8u: we're hitting hit > with openJFX. The patch doesn't apply cleanly. See below for a new > webrev. It was pushed to jdk10 5 months ago and there was no follow up > bugs that I'm aware of. > > https://bugs.openjdk.java.net/browse/JDK-8188223 > http://hg.openjdk.java.net/jdk10/master/rev/24ebaf9d7198 > > New webrev: > > http://cr.openjdk.java.net/~roland/8188223-8u/webrev.00/ > > Roland. From sean.coffey at oracle.com Fri Mar 16 17:02:54 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 16 Mar 2018 17:02:54 +0000 Subject: [jdk8u-dev] Request for enhancement backport approval for 8162362: Introduce system property to control enabled ciphersuites Message-ID: Seeking to backport this enhancement to jdk8u-dev. Two new system properties may be be used to customize the default enabled cipher suites. This is a SunJSSE provider implementation update. The system property "jdk.tls.client.cipherSuites" is used to customize the client side default enabled cipher suites. The system property "jdk.tls.server.cipherSuites" is used to customize the server side default enabled cipher suites. By default, both the property values are not set. Unset or empty property value means there is no customization of the default enabled cipher suites. Explicit setting of enabled cipher suites will override this system property. JBS : https://bugs.openjdk.java.net/browse/JDK-8162362 review thread : http://mail.openjdk.java.net/pipermail/security-dev/2016-August/014689.html -- Regards, Sean. From vladimir.kozlov at oracle.com Fri Mar 16 17:17:13 2018 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Fri, 16 Mar 2018 10:17:13 -0700 Subject: [8u] RFR + RFA: 8188223: IfNode::range_check_trap_proj() should handler dying subgraph with single if proj In-Reply-To: <20180316154445.GA16341@vimes> References: <20180316154445.GA16341@vimes> Message-ID: <6701b18f-dfdc-7d9e-0d18-8fb034643775@oracle.com> Reviewed. The code in jdk 10 was refactored but execution place of the fix is the same. Good. Thanks, Vladimir On 3/16/18 8:44 AM, Rob McKenna wrote: > You may want to seek a codereview from hotspot-dev. Reviewers may or may > not monitor this alias. > > -Rob > > On 16/03/18 16:06, Roland Westrelin wrote: >> >> We (Red Hat) would like to backport 8188223 to 8u: we're hitting hit >> with openJFX. The patch doesn't apply cleanly. See below for a new >> webrev. It was pushed to jdk10 5 months ago and there was no follow up >> bugs that I'm aware of. >> >> https://bugs.openjdk.java.net/browse/JDK-8188223 >> http://hg.openjdk.java.net/jdk10/master/rev/24ebaf9d7198 >> >> New webrev: >> >> http://cr.openjdk.java.net/~roland/8188223-8u/webrev.00/ >> >> Roland. From rob.mckenna at oracle.com Fri Mar 16 18:56:00 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 16 Mar 2018 18:56:00 +0000 Subject: [8u] RFR + RFA: 8188223: IfNode::range_check_trap_proj() should handler dying subgraph with single if proj In-Reply-To: <6701b18f-dfdc-7d9e-0d18-8fb034643775@oracle.com> References: <20180316154445.GA16341@vimes> <6701b18f-dfdc-7d9e-0d18-8fb034643775@oracle.com> Message-ID: <20180316185600.GB16341@vimes> Thanks Vladimir. Approved. Please add a suitable noreg label. -Rob On 16/03/18 10:17, Vladimir Kozlov wrote: > Reviewed. The code in jdk 10 was refactored but execution place of the fix > is the same. Good. > > Thanks, > Vladimir > > On 3/16/18 8:44 AM, Rob McKenna wrote: > >You may want to seek a codereview from hotspot-dev. Reviewers may or may > >not monitor this alias. > > > > -Rob > > > >On 16/03/18 16:06, Roland Westrelin wrote: > >> > >>We (Red Hat) would like to backport 8188223 to 8u: we're hitting hit > >>with openJFX. The patch doesn't apply cleanly. See below for a new > >>webrev. It was pushed to jdk10 5 months ago and there was no follow up > >>bugs that I'm aware of. > >> > >>https://bugs.openjdk.java.net/browse/JDK-8188223 > >>http://hg.openjdk.java.net/jdk10/master/rev/24ebaf9d7198 > >> > >>New webrev: > >> > >>http://cr.openjdk.java.net/~roland/8188223-8u/webrev.00/ > >> > >>Roland. From gromero at linux.vnet.ibm.com Fri Mar 16 23:15:35 2018 From: gromero at linux.vnet.ibm.com (Gustavo Romero) Date: Fri, 16 Mar 2018 20:15:35 -0300 Subject: [8u-dev] Request for Approval for CR 8198794: Hotspot crash on Cassandra 3.11.1 startup with libnuma 2.0.3 Message-ID: <24b8b711-9972-4270-c8bc-bce21bda852c@linux.vnet.ibm.com> Hi, I would like to request the approval for pushing the following change that applies cleanly to jdk8u-dev except for an offset correction and a file path adjust (due to repo consolidation) and fixes a JVM crash when -XX:+UseNUMA is used on a system with libnuma 2.0.3 or older: Bug : https://bugs.openjdk.java.net/browse/JDK-8198794 Change : http://hg.openjdk.java.net/jdk/hs/rev/7fb0ad2d8749 Review Thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030657.html This change is in shared code but is of very low risk since it can be regarded as addressing a sort of corner case on libnuma API v2 implementation where numa_nodes_ptr variable is not defined before the libnuma 2.0.5 (2010). Thus nothing changes for any system that uses a recent libnuma (from Oct 2010 to the present), hence for the great majority of Linux distros releases in use today. Thank you. Best regards, Gustavo From kevin.walls at oracle.com Sat Mar 17 21:17:12 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Sat, 17 Mar 2018 21:17:12 +0000 Subject: [8u-dev] Request for Approval for CR Message-ID: <68681309-053e-2b09-cb83-59c21526455b@oracle.com> Hi, I'd like to request approval to push a backport of: JBS: https://bugs.openjdk.java.net/browse/JDK-8027584 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/a757bcc8bbe4 8u webrev: http://cr.openjdk.java.net/~kevinw/8027584/webrev.00/ It's actually a clean backport/import, except the change of DATE_WHEN_GENERATED which is a date, which I set to the current time when I built this change recently. This bug hits people building on Windows on certain versions of cygwin, and builds fail with a really quite obscure file not found error which appears to make no sense, then you find JDK-8027584.? Yes you can "bash configure --disable-ccache" and carry but I don't think everybody should need to know that every time.? 8-) The change lets me build OK on my laptop where I previously hit that problem, and in JPRT runs on all the jdk 8 platforms. Many thanks Kevin From kevin.walls at oracle.com Sat Mar 17 21:18:57 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Sat, 17 Mar 2018 21:18:57 +0000 Subject: [8u-dev] Request for Approval for CR JDK-8027584: disable ccache by default In-Reply-To: <68681309-053e-2b09-cb83-59c21526455b@oracle.com> References: <68681309-053e-2b09-cb83-59c21526455b@oracle.com> Message-ID: <48f88bb2-25bc-efb9-2b14-0d7ea5462216@oracle.com> Oops. Subject: Re: [8u-dev] Request for Approval for CR JDK-8027584: disable ccache by default On 17/03/2018 21:17, Kevin Walls wrote: > Hi, > > I'd like to request approval to push a backport of: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8027584 > > 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/a757bcc8bbe4 > > 8u webrev: http://cr.openjdk.java.net/~kevinw/8027584/webrev.00/ > > It's actually a clean backport/import, except the change of > DATE_WHEN_GENERATED which is a date, which I set to the current time > when I built this change recently. > > This bug hits people building on Windows on certain versions of > cygwin, and builds fail with a really quite obscure file not found > error which appears to make no sense, then you find JDK-8027584. Yes > you can "bash configure --disable-ccache" and carry but I don't think > everybody should need to know that every time.? 8-) The change lets me > build OK on my laptop where I previously hit that problem, and in JPRT > runs on all the jdk 8 platforms. > > Many thanks > Kevin > > From rob.mckenna at oracle.com Sun Mar 18 16:48:54 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Sun, 18 Mar 2018 16:48:54 +0000 Subject: [8u-dev] Request for Approval for CR In-Reply-To: <68681309-053e-2b09-cb83-59c21526455b@oracle.com> References: <68681309-053e-2b09-cb83-59c21526455b@oracle.com> Message-ID: <20180318164854.GA4203@vimes> Approved -Rob On 17/03/18 21:17, Kevin Walls wrote: > Hi, > > I'd like to request approval to push a backport of: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8027584 > > 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/a757bcc8bbe4 > > 8u webrev: http://cr.openjdk.java.net/~kevinw/8027584/webrev.00/ > > It's actually a clean backport/import, except the change of > DATE_WHEN_GENERATED which is a date, which I set to the current time when I > built this change recently. > > This bug hits people building on Windows on certain versions of cygwin, and > builds fail with a really quite obscure file not found error which appears > to make no sense, then you find JDK-8027584.? Yes you can "bash configure > --disable-ccache" and carry but I don't think everybody should need to know > that every time.? 8-) The change lets me build OK on my laptop where I > previously hit that problem, and in JPRT runs on all the jdk 8 platforms. > > Many thanks > Kevin > > From kevin.walls at oracle.com Sun Mar 18 17:59:23 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Sun, 18 Mar 2018 17:59:23 +0000 Subject: [8u-dev] Request for Approval for CR In-Reply-To: <20180318164854.GA4203@vimes> References: <68681309-053e-2b09-cb83-59c21526455b@oracle.com> <20180318164854.GA4203@vimes> Message-ID: Thanks Rob! On 18/03/2018 16:48, Rob McKenna wrote: > Approved > > -Rob > > On 17/03/18 21:17, Kevin Walls wrote: >> Hi, >> >> I'd like to request approval to push a backport of: >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8027584 >> >> 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/a757bcc8bbe4 >> >> 8u webrev: http://cr.openjdk.java.net/~kevinw/8027584/webrev.00/ >> >> It's actually a clean backport/import, except the change of >> DATE_WHEN_GENERATED which is a date, which I set to the current time when I >> built this change recently. >> >> This bug hits people building on Windows on certain versions of cygwin, and >> builds fail with a really quite obscure file not found error which appears >> to make no sense, then you find JDK-8027584.? Yes you can "bash configure >> --disable-ccache" and carry but I don't think everybody should need to know >> that every time.? 8-) The change lets me build OK on my laptop where I >> previously hit that problem, and in JPRT runs on all the jdk 8 platforms. >> >> Many thanks >> Kevin >> >> From rwestrel at redhat.com Mon Mar 19 12:50:56 2018 From: rwestrel at redhat.com (Roland Westrelin) Date: Mon, 19 Mar 2018 13:50:56 +0100 Subject: [8u] RFR + RFA: 8188223: IfNode::range_check_trap_proj() should handler dying subgraph with single if proj In-Reply-To: <20180316185600.GB16341@vimes> References: <20180316154445.GA16341@vimes> <6701b18f-dfdc-7d9e-0d18-8fb034643775@oracle.com> <20180316185600.GB16341@vimes> Message-ID: > Approved. Please add a suitable noreg label. Done. Thanks for the approval. Roland. From rwestrel at redhat.com Mon Mar 19 12:51:19 2018 From: rwestrel at redhat.com (Roland Westrelin) Date: Mon, 19 Mar 2018 13:51:19 +0100 Subject: [8u] RFR + RFA: 8188223: IfNode::range_check_trap_proj() should handler dying subgraph with single if proj In-Reply-To: <6701b18f-dfdc-7d9e-0d18-8fb034643775@oracle.com> References: <20180316154445.GA16341@vimes> <6701b18f-dfdc-7d9e-0d18-8fb034643775@oracle.com> Message-ID: > Reviewed. The code in jdk 10 was refactored but execution place of the > fix is the same. Good. Thanks for the review. Do I need a sponsor for 8u? Roland. From vladimir.kozlov at oracle.com Mon Mar 19 20:18:04 2018 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Mon, 19 Mar 2018 13:18:04 -0700 Subject: [8u] RFR + RFA: 8188223: IfNode::range_check_trap_proj() should handler dying subgraph with single if proj In-Reply-To: References: <20180316154445.GA16341@vimes> <6701b18f-dfdc-7d9e-0d18-8fb034643775@oracle.com> Message-ID: No, I think you can push your self. We don't do special testing for it. Vladimir On 3/19/18 5:51 AM, Roland Westrelin wrote: > >> Reviewed. The code in jdk 10 was refactored but execution place of the >> fix is the same. Good. > > Thanks for the review. Do I need a sponsor for 8u? > > Roland. > From david.buck at oracle.com Tue Mar 20 11:40:00 2018 From: david.buck at oracle.com (David Buck) Date: Tue, 20 Mar 2018 20:40:00 +0900 Subject: [8u] Request for enhancement backport approval for CR 8033251 - Use DWARF debug symbols for Linux 32-bit as default Message-ID: Hi! Please approve the backport of this serviceability enhancement to JDK 8: https://bugs.openjdk.java.net/browse/JDK-8033251 The change itself does not directly impact the release/product binaries, only the generated debuginfo. As STABS is a legacy technology and not supported in many newer tools (perf, systemtab, etc.), this change will help make JDK 8 on ia32 Linux easier to debug and troubleshoot. This change is also important for our efforts to support building JDK 8 with later versions of GCC. All of the ?standard? tests (JPRT hotspot testset) run and pass. There is a noticeable increase in the size of generated debuginfo, though not an unreasonable amount compared to builds for other platforms (most of which already use DWARF) or the benefit that this change provides. Code review and push approval request to follow. Cheers, -Buck From sean.coffey at oracle.com Tue Mar 20 12:39:02 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Tue, 20 Mar 2018 12:39:02 +0000 Subject: [8u] Request for enhancement backport approval for CR 8033251 - Use DWARF debug symbols for Linux 32-bit as default In-Reply-To: References: Message-ID: Thanks for logging the request Buck. Approved. regards, Sean. On 20/03/2018 11:40, David Buck wrote: > Hi! > > Please approve the backport of this serviceability enhancement to JDK 8: > > https://bugs.openjdk.java.net/browse/JDK-8033251 > > The change itself does not directly impact the release/product binaries, only the generated debuginfo. As STABS is a legacy technology and not supported in many newer tools (perf, systemtab, etc.), this change will help make JDK 8 on ia32 Linux easier to debug and troubleshoot. This change is also important for our efforts to support building JDK 8 with later versions of GCC. All of the ?standard? tests (JPRT hotspot testset) run and pass. There is a noticeable increase in the size of generated debuginfo, though not an unreasonable amount compared to builds for other platforms (most of which already use DWARF) or the benefit that this change provides. Code review and push approval request to follow. > > Cheers, > -Buck From rob.mckenna at oracle.com Tue Mar 20 14:29:30 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 20 Mar 2018 14:29:30 +0000 Subject: [8u-dev] Request for Approval for CR 8198794: Hotspot crash on Cassandra 3.11.1 startup with libnuma 2.0.3 In-Reply-To: <24b8b711-9972-4270-c8bc-bce21bda852c@linux.vnet.ibm.com> References: <24b8b711-9972-4270-c8bc-bce21bda852c@linux.vnet.ibm.com> Message-ID: <20180320142930.GA3533@tecra> Approved -Rob On 16/03/18 20:15, Gustavo Romero wrote: > Hi, > > I would like to request the approval for pushing the following change > that applies cleanly to jdk8u-dev except for an offset correction and > a file path adjust (due to repo consolidation) and fixes a JVM crash > when -XX:+UseNUMA is used on a system with libnuma 2.0.3 or older: > > Bug : https://bugs.openjdk.java.net/browse/JDK-8198794 > Change : http://hg.openjdk.java.net/jdk/hs/rev/7fb0ad2d8749 > Review Thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030657.html > > This change is in shared code but is of very low risk since it can be > regarded as addressing a sort of corner case on libnuma API v2 > implementation where numa_nodes_ptr variable is not defined before > the libnuma 2.0.5 (2010). Thus nothing changes for any system that > uses a recent libnuma (from Oct 2010 to the present), hence for the > great majority of Linux distros releases in use today. > > Thank you. > > > Best regards, > Gustavo > From kevin.walls at oracle.com Tue Mar 20 16:38:37 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Tue, 20 Mar 2018 16:38:37 +0000 Subject: [8u-dev] Request for approval: 8031759: Configure should handle overrides of tools better Message-ID: <17033d62-f584-bb94-d387-61d9c47411fa@oracle.com> Hi, I'd like to request approval to backport to jdk8u: 8031759: Configure should handle overrides of tools better JBS: https://bugs.openjdk.java.net/browse/JDK-8031759 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/rev/82b65f34b79d 8u webrev: http://cr.openjdk.java.net/~kevinw/8031759/webrev.00/ This is mostly straightforward, large parts import cleanly, the parts that didn't are changes to macro names,? and a couple of tools referenced in the 9 change which are not in 8u (OTOOL and LIPO). Also need to take into account this change (avoid creating this problem) : 8033115: Bad merge between 8027584 and 8031759 https://bugs.openjdk.java.net/browse/JDK-8033115 Which is just this edit in common/autoconf/build-performance.m4, included here in the proposed 8u push. -??? BASIC_REQUIRE_PROG(CCACHE, ccache) +??? BASIC_REQUIRE_PROGS(CCACHE, ccache) (I can mark that bug as not present in 8 when done) Then with the .m4 changes in place, ran common/autoconf/autogen.sh to recreate common/autoconf/generated-configure.sh which is included in the webrev/change. Thanks! Kevin From gromero at linux.vnet.ibm.com Tue Mar 20 16:46:01 2018 From: gromero at linux.vnet.ibm.com (Gustavo Romero) Date: Tue, 20 Mar 2018 13:46:01 -0300 Subject: [8u-dev] Request for Approval for CR 8198794: Hotspot crash on Cassandra 3.11.1 startup with libnuma 2.0.3 In-Reply-To: <20180320142930.GA3533@tecra> References: <24b8b711-9972-4270-c8bc-bce21bda852c@linux.vnet.ibm.com> <20180320142930.GA3533@tecra> Message-ID: Hi, On 03/20/2018 11:29 AM, Rob McKenna wrote: > Approved Thank you. @Volker, do you mind to push that fix to jdk8u-dev for me please? Regards, Gustavo > On 16/03/18 20:15, Gustavo Romero wrote: >> Hi, >> >> I would like to request the approval for pushing the following change >> that applies cleanly to jdk8u-dev except for an offset correction and >> a file path adjust (due to repo consolidation) and fixes a JVM crash >> when -XX:+UseNUMA is used on a system with libnuma 2.0.3 or older: >> >> Bug : https://bugs.openjdk.java.net/browse/JDK-8198794 >> Change : http://hg.openjdk.java.net/jdk/hs/rev/7fb0ad2d8749 >> Review Thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030657.html >> >> This change is in shared code but is of very low risk since it can be >> regarded as addressing a sort of corner case on libnuma API v2 >> implementation where numa_nodes_ptr variable is not defined before >> the libnuma 2.0.5 (2010). Thus nothing changes for any system that >> uses a recent libnuma (from Oct 2010 to the present), hence for the >> great majority of Linux distros releases in use today. >> >> Thank you. >> >> >> Best regards, >> Gustavo >> > From rob.mckenna at oracle.com Wed Mar 21 01:04:26 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 21 Mar 2018 01:04:26 +0000 Subject: [8u-dev] Request for approval: 8031759: Configure should handle overrides of tools better In-Reply-To: <17033d62-f584-bb94-d387-61d9c47411fa@oracle.com> References: <17033d62-f584-bb94-d387-61d9c47411fa@oracle.com> Message-ID: <20180321010426.GB2783@vimes> Approved -Rob On 20/03/18 16:38, Kevin Walls wrote: > Hi, > > I'd like to request approval to backport to jdk8u: > > 8031759: Configure should handle overrides of tools better > JBS: https://bugs.openjdk.java.net/browse/JDK-8031759 > 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/rev/82b65f34b79d > > 8u webrev: > http://cr.openjdk.java.net/~kevinw/8031759/webrev.00/ > > This is mostly straightforward, large parts import cleanly, the parts that > didn't are changes to macro names,? and a couple of tools referenced in the > 9 change which are not in 8u (OTOOL and LIPO). > > Also need to take into account this change (avoid creating this problem) : > 8033115: Bad merge between 8027584 and 8031759 > https://bugs.openjdk.java.net/browse/JDK-8033115 > > Which is just this edit in common/autoconf/build-performance.m4, included > here in the proposed 8u push. > -??? BASIC_REQUIRE_PROG(CCACHE, ccache) > +??? BASIC_REQUIRE_PROGS(CCACHE, ccache) > > (I can mark that bug as not present in 8 when done) > > Then with the .m4 changes in place, ran common/autoconf/autogen.sh to > recreate common/autoconf/generated-configure.sh which is included in the > webrev/change. > > Thanks! > Kevin > From kevin.walls at oracle.com Wed Mar 21 09:27:37 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Wed, 21 Mar 2018 09:27:37 +0000 Subject: [8u-dev] Request for approval: 8031759: Configure should handle overrides of tools better In-Reply-To: <20180321010426.GB2783@vimes> References: <17033d62-f584-bb94-d387-61d9c47411fa@oracle.com> <20180321010426.GB2783@vimes> Message-ID: <9e3e7a4d-2549-1ec9-dad8-82485837da33@oracle.com> Great,thanks! On 21/03/2018 01:04, Rob McKenna wrote: > Approved > > -Rob > > On 20/03/18 16:38, Kevin Walls wrote: >> Hi, >> >> I'd like to request approval to backport to jdk8u: >> >> 8031759: Configure should handle overrides of tools better >> JBS: https://bugs.openjdk.java.net/browse/JDK-8031759 >> 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/rev/82b65f34b79d >> >> 8u webrev: >> http://cr.openjdk.java.net/~kevinw/8031759/webrev.00/ >> >> This is mostly straightforward, large parts import cleanly, the parts that >> didn't are changes to macro names,? and a couple of tools referenced in the >> 9 change which are not in 8u (OTOOL and LIPO). >> >> Also need to take into account this change (avoid creating this problem) : >> 8033115: Bad merge between 8027584 and 8031759 >> https://bugs.openjdk.java.net/browse/JDK-8033115 >> >> Which is just this edit in common/autoconf/build-performance.m4, included >> here in the proposed 8u push. >> -??? BASIC_REQUIRE_PROG(CCACHE, ccache) >> +??? BASIC_REQUIRE_PROGS(CCACHE, ccache) >> >> (I can mark that bug as not present in 8 when done) >> >> Then with the .m4 changes in place, ran common/autoconf/autogen.sh to >> recreate common/autoconf/generated-configure.sh which is included in the >> webrev/change. >> >> Thanks! >> Kevin >> From kevin.walls at oracle.com Wed Mar 21 10:16:54 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Wed, 21 Mar 2018 10:16:54 +0000 Subject: [8u-dev] Request for approval (XS): 8033292: jdk9-dev build failed due to configure issue: configure: error: The following variables are unknown to configure: MAKE Message-ID: <7da92418-b80f-1bd2-574b-ca1634cbe954@oracle.com> Hi, I'd like to request approval to backport this change to 8u.? This follows on from 8031759 changes.? Maybe that change is overly strict regarding its error vs warning, or maybe no actual build would be affected... It seems best to backport this small change so nobody is surprised by a failing build. JBS: https://bugs.openjdk.java.net/browse/JDK-8033292 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/rev/bd59753b56bf It's a one-liner change in common/autoconf/basics.m4 to change an error to a warning, plus a regenerated common/autoconf/generated-configure.sh I have pasted in my 8u change below, as it is so small, but can do a webrev if needed. Without this change, running: $ bash configure FOOBAR=mistake gives: configure: error: The following variables are unknown to configure:? FOOBAR With this change, the configure output contains a warning, but continues: configure: WARNING: The following variables might be unknown to configure:? FOOBAR Many thanks Kevin bash-4.2$ hg status M common/autoconf/basics.m4 M common/autoconf/generated-configure.sh bash-4.2$ hg diff diff -r 0e87966d7ff1 common/autoconf/basics.m4 --- a/common/autoconf/basics.m4 Tue Mar 20 09:19:10 2018 -0700 +++ b/common/autoconf/basics.m4 Wed Mar 21 03:09:02 2018 -0700 @@ -250,7 +250,7 @@ ?? if test "x$CONFIGURE_OVERRIDDEN_VARIABLES" != x; then ???? # Replace the separating ! with spaces before presenting for end user. ???? unknown_variables=${CONFIGURE_OVERRIDDEN_VARIABLES//!/ } -??? AC_MSG_ERROR([The following variables are unknown to configure: $unknown_variables]) +??? AC_MSG_WARN([The following variables might be unknown to configure: $unknown_variables]) ?? fi ?]) diff -r 0e87966d7ff1 common/autoconf/generated-configure.sh --- a/common/autoconf/generated-configure.sh??? Tue Mar 20 09:19:10 2018 -0700 +++ b/common/autoconf/generated-configure.sh??? Wed Mar 21 03:09:02 2018 -0700 @@ -4076,7 +4076,7 @@ ?#CUSTOM_AUTOCONF_INCLUDE ?# Do not change or remove the following line, it is needed for consistency checks: -DATE_WHEN_GENERATED=1521554908 +DATE_WHEN_GENERATED=1521626909 ?############################################################################### ?# @@ -47013,7 +47013,8 @@ ?? if test "x$CONFIGURE_OVERRIDDEN_VARIABLES" != x; then ???? # Replace the separating ! with spaces before presenting for end user. ???? unknown_variables=${CONFIGURE_OVERRIDDEN_VARIABLES//!/ } -??? as_fn_error $? "The following variables are unknown to configure: $unknown_variables" "$LINENO" 5 +??? { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: The following variables might be unknown to configure: $unknown_variables" >&5 +$as_echo "$as_me: WARNING: The following variables might be unknown to configure: $unknown_variables" >&2;} ?? fi From rob.mckenna at oracle.com Wed Mar 21 15:50:32 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 21 Mar 2018 15:50:32 +0000 Subject: [8u-dev] Request for approval (XS): 8033292: jdk9-dev build failed due to configure issue: configure: error: The following variables are unknown to configure: MAKE In-Reply-To: <7da92418-b80f-1bd2-574b-ca1634cbe954@oracle.com> References: <7da92418-b80f-1bd2-574b-ca1634cbe954@oracle.com> Message-ID: <20180321155032.GA4603@vimes> Approved -Rob On 21/03/18 10:16, Kevin Walls wrote: > Hi, > > I'd like to request approval to backport this change to 8u.? This follows on > from 8031759 changes.? Maybe that change is overly strict regarding its > error vs warning, or maybe no actual build would be affected... It seems > best to backport this small change so nobody is surprised by a failing > build. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8033292 > 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/rev/bd59753b56bf > > It's a one-liner change in common/autoconf/basics.m4 to change an error to a > warning, plus a regenerated common/autoconf/generated-configure.sh > > I have pasted in my 8u change below, as it is so small, but can do a webrev > if needed. > > Without this change, running: > > $ bash configure FOOBAR=mistake > > gives: > configure: error: The following variables are unknown to configure:? FOOBAR > > With this change, the configure output contains a warning, but continues: > > configure: WARNING: The following variables might be unknown to configure:? > FOOBAR > > Many thanks > Kevin > > > bash-4.2$ hg status > M common/autoconf/basics.m4 > M common/autoconf/generated-configure.sh > bash-4.2$ hg diff > diff -r 0e87966d7ff1 common/autoconf/basics.m4 > --- a/common/autoconf/basics.m4 Tue Mar 20 09:19:10 2018 -0700 > +++ b/common/autoconf/basics.m4 Wed Mar 21 03:09:02 2018 -0700 > @@ -250,7 +250,7 @@ > ?? if test "x$CONFIGURE_OVERRIDDEN_VARIABLES" != x; then > ???? # Replace the separating ! with spaces before presenting for end user. > ???? unknown_variables=${CONFIGURE_OVERRIDDEN_VARIABLES//!/ } > -??? AC_MSG_ERROR([The following variables are unknown to configure: > $unknown_variables]) > +??? AC_MSG_WARN([The following variables might be unknown to configure: > $unknown_variables]) > ?? fi > ?]) > > diff -r 0e87966d7ff1 common/autoconf/generated-configure.sh > --- a/common/autoconf/generated-configure.sh??? Tue Mar 20 09:19:10 2018 > -0700 > +++ b/common/autoconf/generated-configure.sh??? Wed Mar 21 03:09:02 2018 > -0700 > @@ -4076,7 +4076,7 @@ > ?#CUSTOM_AUTOCONF_INCLUDE > > ?# Do not change or remove the following line, it is needed for consistency > checks: > -DATE_WHEN_GENERATED=1521554908 > +DATE_WHEN_GENERATED=1521626909 > > ?############################################################################### > ?# > @@ -47013,7 +47013,8 @@ > ?? if test "x$CONFIGURE_OVERRIDDEN_VARIABLES" != x; then > ???? # Replace the separating ! with spaces before presenting for end user. > ???? unknown_variables=${CONFIGURE_OVERRIDDEN_VARIABLES//!/ } > -??? as_fn_error $? "The following variables are unknown to configure: > $unknown_variables" "$LINENO" 5 > +??? { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: The following > variables might be unknown to configure: $unknown_variables" >&5 > +$as_echo "$as_me: WARNING: The following variables might be unknown to > configure: $unknown_variables" >&2;} > ?? fi > > From shade at redhat.com Wed Mar 21 15:54:33 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 21 Mar 2018 16:54:33 +0100 Subject: [8u] Request for approval for JDK-8169201: Montgomery multiply intrinsic should use correct name Message-ID: It is a really trivial patch: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/110b1774a359 diff -r 96e9e479ff8a src/share/vm/opto/library_call.cpp --- a/src/share/vm/opto/library_call.cpp Thu Aug 24 01:27:02 2017 -0400 +++ b/src/share/vm/opto/library_call.cpp Wed Mar 21 16:49:39 2018 +0100 @@ -6026,7 +6026,7 @@ } assert(UseMontgomeryMultiplyIntrinsic, "not implemented on this platform"); - const char* stubName = "montgomery_square"; + const char* stubName = "montgomery_multiply"; assert(callee()->signature()->size() == 7, "montgomeryMultiply has 7 parameters"); It applies with a bit of fuzz to jdk8-dev. JDK 9 bug: https://bugs.openjdk.java.net/browse/JDK-8169201 JDK 9 RFR: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-November/024899.html We need this to avoid weird bugs in code that relies on intrinsic names: http://mail.openjdk.java.net/pipermail/aarch64-port-dev/2018-March/005424.html Thanks, -Aleksey From kevin.walls at oracle.com Wed Mar 21 16:10:48 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Wed, 21 Mar 2018 16:10:48 +0000 Subject: [8u-dev] Request for approval (XS): 8033292: jdk9-dev build failed due to configure issue: configure: error: The following variables are unknown to configure: MAKE In-Reply-To: <20180321155032.GA4603@vimes> References: <7da92418-b80f-1bd2-574b-ca1634cbe954@oracle.com> <20180321155032.GA4603@vimes> Message-ID: <141d94aa-1949-5d6b-d6aa-4bd1a5a41198@oracle.com> Thanks! On 21/03/2018 15:50, Rob McKenna wrote: > Approved > > -Rob > > On 21/03/18 10:16, Kevin Walls wrote: >> Hi, >> >> I'd like to request approval to backport this change to 8u.? This follows on >> from 8031759 changes.? Maybe that change is overly strict regarding its >> error vs warning, or maybe no actual build would be affected... It seems >> best to backport this small change so nobody is surprised by a failing >> build. >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8033292 >> 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/rev/bd59753b56bf >> >> It's a one-liner change in common/autoconf/basics.m4 to change an error to a >> warning, plus a regenerated common/autoconf/generated-configure.sh >> >> I have pasted in my 8u change below, as it is so small, but can do a webrev >> if needed. >> >> Without this change, running: >> >> $ bash configure FOOBAR=mistake >> >> gives: >> configure: error: The following variables are unknown to configure:? FOOBAR >> >> With this change, the configure output contains a warning, but continues: >> >> configure: WARNING: The following variables might be unknown to configure: >> FOOBAR >> >> Many thanks >> Kevin >> >> >> bash-4.2$ hg status >> M common/autoconf/basics.m4 >> M common/autoconf/generated-configure.sh >> bash-4.2$ hg diff >> diff -r 0e87966d7ff1 common/autoconf/basics.m4 >> --- a/common/autoconf/basics.m4 Tue Mar 20 09:19:10 2018 -0700 >> +++ b/common/autoconf/basics.m4 Wed Mar 21 03:09:02 2018 -0700 >> @@ -250,7 +250,7 @@ >> ?? if test "x$CONFIGURE_OVERRIDDEN_VARIABLES" != x; then >> ???? # Replace the separating ! with spaces before presenting for end user. >> ???? unknown_variables=${CONFIGURE_OVERRIDDEN_VARIABLES//!/ } >> -??? AC_MSG_ERROR([The following variables are unknown to configure: >> $unknown_variables]) >> +??? AC_MSG_WARN([The following variables might be unknown to configure: >> $unknown_variables]) >> ?? fi >> ?]) >> >> diff -r 0e87966d7ff1 common/autoconf/generated-configure.sh >> --- a/common/autoconf/generated-configure.sh??? Tue Mar 20 09:19:10 2018 >> -0700 >> +++ b/common/autoconf/generated-configure.sh??? Wed Mar 21 03:09:02 2018 >> -0700 >> @@ -4076,7 +4076,7 @@ >> ?#CUSTOM_AUTOCONF_INCLUDE >> >> ?# Do not change or remove the following line, it is needed for consistency >> checks: >> -DATE_WHEN_GENERATED=1521554908 >> +DATE_WHEN_GENERATED=1521626909 >> >> ?############################################################################### >> ?# >> @@ -47013,7 +47013,8 @@ >> ?? if test "x$CONFIGURE_OVERRIDDEN_VARIABLES" != x; then >> ???? # Replace the separating ! with spaces before presenting for end user. >> ???? unknown_variables=${CONFIGURE_OVERRIDDEN_VARIABLES//!/ } >> -??? as_fn_error $? "The following variables are unknown to configure: >> $unknown_variables" "$LINENO" 5 >> +??? { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: The following >> variables might be unknown to configure: $unknown_variables" >&5 >> +$as_echo "$as_me: WARNING: The following variables might be unknown to >> configure: $unknown_variables" >&2;} >> ?? fi >> >> From fairoz.matte at oracle.com Thu Mar 22 06:31:16 2018 From: fairoz.matte at oracle.com (Fairoz Matte) Date: Wed, 21 Mar 2018 23:31:16 -0700 (PDT) Subject: [8u-dev] Request for approval for JDK-8194642: Improve OOM error reporting for JDK8 In-Reply-To: <869bfed3-17b4-4944-99e0-4dbecd18de99@default> References: <869bfed3-17b4-4944-99e0-4dbecd18de99@default> Message-ID: <92dfc00f-7da3-4eb1-92f3-e32571ab8f74@default> Hi, Please approve the push request on 8u-dev for small enhancement JBS link - https://bugs.openjdk.java.net/browse/JDK-8194642 Webrev - http://cr.openjdk.java.net/~fmatte/8194642/webrev.01/ Review thread - http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-March/028378.html This enhancement has been approved for 8u-dev - http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-March/007292.html Thanks, Fairoz From david.buck at oracle.com Thu Mar 22 06:38:59 2018 From: david.buck at oracle.com (David Buck) Date: Thu, 22 Mar 2018 15:38:59 +0900 Subject: [8u-dev] Request for approval for JDK-8194642: Improve OOM error reporting for JDK8 In-Reply-To: <92dfc00f-7da3-4eb1-92f3-e32571ab8f74@default> References: <869bfed3-17b4-4944-99e0-4dbecd18de99@default> <92dfc00f-7da3-4eb1-92f3-e32571ab8f74@default> Message-ID: approved Cheers, -Buck On 2018/03/22 15:31, Fairoz Matte wrote: > Hi, > > Please approve the push request on 8u-dev for small enhancement > > JBS link - https://bugs.openjdk.java.net/browse/JDK-8194642 > Webrev - http://cr.openjdk.java.net/~fmatte/8194642/webrev.01/ > > Review thread - http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-March/028378.html > > This enhancement has been approved for 8u-dev - http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-March/007292.html > > Thanks, > Fairoz > From dipak.kumar at oracle.com Thu Mar 22 09:23:29 2018 From: dipak.kumar at oracle.com (Dipak Kumar) Date: Thu, 22 Mar 2018 02:23:29 -0700 (PDT) Subject: [8u-dev] RFA for backport of JDK-8188083 : NullPointerExcpn-java.awt.image.FilteredImageSource.startProduction JDK-8079607 Message-ID: <34bfec29-b74d-4313-a6c0-bd5dd18b5225@default> Hi, May I get the approval of backport of "JDK-8188083: NullPointerExcpn-java.awt.image.FilteredImageSource.startProduction JDK-8079607" to jdk8u-dev. JBS - https://bugs.openjdk.java.net/browse/JDK-8188083 JDK 10 review thread - http://mail.openjdk.java.net/pipermail/2d-dev/2017-November/008675.html JDK10 changeset - http://hg.openjdk.java.net/jdk/client/rev/054fecf0c1d2 JDK 10 changes were applied cleanly to 8u-dev after adjusting the file path and copyright year. Spec changes have not been included in backport. CCC request has been approved. Jdk8u webrev - http://cr.openjdk.java.net/~dkumar/8188083/8u-dev_Backport/webrev.00/ I have tested out all the relevant AWT JTREG tests. Also, ensured that there are no failures related to this on JPRT (Stockholm) queues. Thanks, Dipak From rob.mckenna at oracle.com Thu Mar 22 17:27:29 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 22 Mar 2018 17:27:29 +0000 Subject: [8u-dev] RFA for backport of JDK-8188083 : NullPointerExcpn-java.awt.image.FilteredImageSource.startProduction JDK-8079607 In-Reply-To: <34bfec29-b74d-4313-a6c0-bd5dd18b5225@default> References: <34bfec29-b74d-4313-a6c0-bd5dd18b5225@default> Message-ID: <20180322172729.GA3860@vimes> Approved -Rob On 22/03/18 02:23, Dipak Kumar wrote: > Hi, > > > > May I get the approval of backport of "JDK-8188083: NullPointerExcpn-java.awt.image.FilteredImageSource.startProduction JDK-8079607" to jdk8u-dev. > > > > JBS - https://bugs.openjdk.java.net/browse/JDK-8188083 > > JDK 10 review thread - http://mail.openjdk.java.net/pipermail/2d-dev/2017-November/008675.html > > JDK10 changeset - http://hg.openjdk.java.net/jdk/client/rev/054fecf0c1d2 > > > > JDK 10 changes were applied cleanly to 8u-dev after adjusting the file path and copyright year. Spec changes have not been included in backport. CCC request has been approved. > > > > Jdk8u webrev - http://cr.openjdk.java.net/~dkumar/8188083/8u-dev_Backport/webrev.00/ > > > > I have tested out all the relevant AWT JTREG tests. > > Also, ensured that there are no failures related to this on JPRT (Stockholm) queues. > > > > Thanks, > > Dipak From david.buck at oracle.com Fri Mar 23 08:28:13 2018 From: david.buck at oracle.com (David Buck) Date: Fri, 23 Mar 2018 17:28:13 +0900 Subject: [8u-dev] Request for Approval for CR 8198794: Hotspot crash on Cassandra 3.11.1 startup with libnuma 2.0.3 In-Reply-To: References: <24b8b711-9972-4270-c8bc-bce21bda852c@linux.vnet.ibm.com> <20180320142930.GA3533@tecra> Message-ID: Hi Gustavo! I took the liberty of pushing the fix for you. http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/c2ee42fa54cd Thank you for fixing this bad regression. Cheers, -Buck On 2018/03/21 1:46, Gustavo Romero wrote: > Hi, > > > On 03/20/2018 11:29 AM, Rob McKenna wrote: >> Approved > > Thank you. > > > @Volker, do you mind to push that fix to jdk8u-dev for me please? > > > Regards, > Gustavo > >> On 16/03/18 20:15, Gustavo Romero wrote: >>> Hi, >>> >>> I would like to request the approval for pushing the following change >>> that applies cleanly to jdk8u-dev except for an offset correction and >>> a file path adjust (due to repo consolidation) and fixes a JVM crash >>> when -XX:+UseNUMA is used on a system with libnuma 2.0.3 or older: >>> >>> Bug????????? : https://bugs.openjdk.java.net/browse/JDK-8198794 >>> Change?????? : http://hg.openjdk.java.net/jdk/hs/rev/7fb0ad2d8749 >>> Review Thread: >>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030657.html >>> >>> >>> This change is in shared code but is of very low risk since it can be >>> regarded as addressing a sort of corner case on libnuma API v2 >>> implementation where numa_nodes_ptr variable is not defined before >>> the libnuma 2.0.5 (2010). Thus nothing changes for any system that >>> uses a recent libnuma (from Oct 2010 to the present), hence for the >>> great majority of Linux distros releases in use today. >>> >>> Thank you. >>> >>> >>> Best regards, >>> Gustavo >>> >> > From gromero at linux.vnet.ibm.com Fri Mar 23 14:40:18 2018 From: gromero at linux.vnet.ibm.com (Gustavo Romero) Date: Fri, 23 Mar 2018 11:40:18 -0300 Subject: [8u-dev] Request for Approval for CR 8198794: Hotspot crash on Cassandra 3.11.1 startup with libnuma 2.0.3 In-Reply-To: References: <24b8b711-9972-4270-c8bc-bce21bda852c@linux.vnet.ibm.com> <20180320142930.GA3533@tecra> Message-ID: Hi David! On 03/23/2018 05:28 AM, David Buck wrote: > Hi Gustavo! > > I took the liberty of pushing the fix for you. > > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/c2ee42fa54cd > > Thank you for fixing this bad regression. Thanks a lot for pushing it! :-) Cheers, Gustavo > > Cheers, > -Buck > > On 2018/03/21 1:46, Gustavo Romero wrote: >> Hi, >> >> >> On 03/20/2018 11:29 AM, Rob McKenna wrote: >>> Approved >> >> Thank you. >> >> >> @Volker, do you mind to push that fix to jdk8u-dev for me please? >> >> >> Regards, >> Gustavo >> >>> On 16/03/18 20:15, Gustavo Romero wrote: >>>> Hi, >>>> >>>> I would like to request the approval for pushing the following change >>>> that applies cleanly to jdk8u-dev except for an offset correction and >>>> a file path adjust (due to repo consolidation) and fixes a JVM crash >>>> when -XX:+UseNUMA is used on a system with libnuma 2.0.3 or older: >>>> >>>> Bug????????? : https://bugs.openjdk.java.net/browse/JDK-8198794 >>>> Change?????? : http://hg.openjdk.java.net/jdk/hs/rev/7fb0ad2d8749 >>>> Review Thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030657.html >>>> >>>> This change is in shared code but is of very low risk since it can be >>>> regarded as addressing a sort of corner case on libnuma API v2 >>>> implementation where numa_nodes_ptr variable is not defined before >>>> the libnuma 2.0.5 (2010). Thus nothing changes for any system that >>>> uses a recent libnuma (from Oct 2010 to the present), hence for the >>>> great majority of Linux distros releases in use today. >>>> >>>> Thank you. >>>> >>>> >>>> Best regards, >>>> Gustavo >>>> >>> >> > From rob.mckenna at oracle.com Mon Mar 26 13:49:38 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 26 Mar 2018 14:49:38 +0100 Subject: [jdk8u-dev] Request for enhancement backport approval for 8162362: Introduce system property to control enabled ciphersuites In-Reply-To: References: Message-ID: <20180326134938.GA2726@vimes> Thanks Sean, this has been approved. -Rob On 16/03/18 17:02, Se?n Coffey wrote: > Seeking to backport this enhancement to jdk8u-dev. > > Two new system properties may be be used to customize the default enabled > cipher suites. This is a SunJSSE provider implementation update. > > The system property "jdk.tls.client.cipherSuites" is used to customize the > client side default enabled cipher suites. > > The system property "jdk.tls.server.cipherSuites" is used to customize the > server side default enabled cipher suites. > > By default, both the property values are not set. Unset or empty property > value means there is no customization of the default enabled cipher suites. > Explicit setting of enabled cipher suites will override this system > property. > > JBS : https://bugs.openjdk.java.net/browse/JDK-8162362 > review thread : > http://mail.openjdk.java.net/pipermail/security-dev/2016-August/014689.html > > -- > Regards, > Sean. > From sean.coffey at oracle.com Mon Mar 26 16:55:10 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Mon, 26 Mar 2018 17:55:10 +0100 Subject: [jdk8u-dev] Request for approval : 8162362: Introduce system property to control enabled ciphersuites Message-ID: <771ff518-6953-3d3e-e6b5-c58c46ee2b95@oracle.com> Looking to backport this enhancement to jdk8u-dev. I already have approval to backport the enhancement : http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-March/007338.html JBS : https://bugs.openjdk.java.net/browse/JDK-8162362 Review thread : http://mail.openjdk.java.net/pipermail/security-dev/2016-August/014689.html regards, Sean. From rob.mckenna at oracle.com Mon Mar 26 21:59:03 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 26 Mar 2018 22:59:03 +0100 Subject: [jdk8u-dev] Request for approval : 8162362: Introduce system property to control enabled ciphersuites In-Reply-To: <771ff518-6953-3d3e-e6b5-c58c46ee2b95@oracle.com> References: <771ff518-6953-3d3e-e6b5-c58c46ee2b95@oracle.com> Message-ID: <20180326215903.GB2726@vimes> Approved -Rob On 26/03/18 17:55, Se?n Coffey wrote: > Looking to backport this enhancement to jdk8u-dev. > > I already have approval to backport the enhancement : > > http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-March/007338.html > > JBS : https://bugs.openjdk.java.net/browse/JDK-8162362 > Review thread : > http://mail.openjdk.java.net/pipermail/security-dev/2016-August/014689.html > > regards, > Sean. From dalibor.topic at oracle.com Tue Mar 27 08:13:09 2018 From: dalibor.topic at oracle.com (dalibor topic) Date: Tue, 27 Mar 2018 10:13:09 +0200 Subject: [8u-communication] Oracle's plans to contribute to JDK 8 Updates Project in OpenJDK after Java SE 8 End of Public Updates Message-ID: Hi, Oracle has updated the Oracle Java SE Support Roadmap with a Java SE 8 End of Public Updates Notice. [0] Oracle doesn't plan to contribute further changes to JDK 8 Updates in this OpenJDK Project once updates of Java SE 8 are no longer being posted to its public download site, in January 2019. Users of OpenJDK JDK 8 Updates builds should consider upgrading to JDK 11 at that time. As with JDK 6 and JDK 7 Updates Projects in the past, a suitable party may step forward to maintain this Project once the final Oracle-led JDK 8 Update release has been published. If such a party is nominated, we will discuss how to best enable such a transition on this Project's mailing list. cheers, dalibor topic [0] http://www.oracle.com/technetwork/java/eol-135779.html -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment From shafi.s.ahmad at oracle.com Thu Mar 29 07:28:16 2018 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Thu, 29 Mar 2018 00:28:16 -0700 (PDT) Subject: [8u] RFA for backport of "JDK-8164480: Crash with assert(handler_address == SharedRuntime::compute_compiled_exc_handler(..) failed: Must be the same" to jdk8u-dev Message-ID: <033dc943-dc2c-4273-90c7-88f7496a42bf@default> Hi, May I get the approval of backport of "JDK-8164480: Crash with assert(handler_address == SharedRuntime::compute_compiled_exc_handler(..) failed: Must be the same" to jdk8u-dev" to jdk8u. Webrev: http://cr.openjdk.java.net/~shshahma/8164480/webrev.00/ Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8164480 Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-August/024372.html Jdk8 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/031101.html Testing: jprt -testset hotspot Regards, Shafi From david.buck at oracle.com Thu Mar 29 07:52:18 2018 From: david.buck at oracle.com (David Buck) Date: Thu, 29 Mar 2018 16:52:18 +0900 Subject: [8u] RFA for backport of "JDK-8164480: Crash with assert(handler_address == SharedRuntime::compute_compiled_exc_handler(..) failed: Must be the same" to jdk8u-dev In-Reply-To: <033dc943-dc2c-4273-90c7-88f7496a42bf@default> References: <033dc943-dc2c-4273-90c7-88f7496a42bf@default> Message-ID: <51d3dcf6-905b-7691-23af-90493599b049@oracle.com> approved Cheers, -Buck On 2018/03/29 16:28, Shafi Ahmad wrote: > Hi, > > May I get the approval of backport of "JDK-8164480: Crash with assert(handler_address == SharedRuntime::compute_compiled_exc_handler(..) failed: Must be the same" to jdk8u-dev" to jdk8u. > > Webrev: http://cr.openjdk.java.net/~shshahma/8164480/webrev.00/ > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8164480 > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-August/024372.html > Jdk8 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/031101.html > > Testing: jprt -testset hotspot > > Regards, > Shafi > From shafi.s.ahmad at oracle.com Thu Mar 29 08:32:53 2018 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Thu, 29 Mar 2018 01:32:53 -0700 (PDT) Subject: [8u] RFA for backport of "JDK-8164480: Crash with assert(handler_address == SharedRuntime::compute_compiled_exc_handler(..) failed: Must be the same" to jdk8u-dev In-Reply-To: <51d3dcf6-905b-7691-23af-90493599b049@oracle.com> References: <033dc943-dc2c-4273-90c7-88f7496a42bf@default> <51d3dcf6-905b-7691-23af-90493599b049@oracle.com> Message-ID: <85aac2cf-4dd6-4237-87e5-c22aaeb8d4d6@default> Thank you Buck. Regards, Shafi > -----Original Message----- > From: David Buck > Sent: Thursday, March 29, 2018 1:22 PM > To: Shafi Ahmad ; jdk8u-dev at openjdk.java.net > Subject: Re: [8u] RFA for backport of "JDK-8164480: Crash with > assert(handler_address == > SharedRuntime::compute_compiled_exc_handler(..) failed: Must be the > same" to jdk8u-dev > > approved > > Cheers, > -Buck > > On 2018/03/29 16:28, Shafi Ahmad wrote: > > Hi, > > > > May I get the approval of backport of "JDK-8164480: Crash with > assert(handler_address == > SharedRuntime::compute_compiled_exc_handler(..) failed: Must be the > same" to jdk8u-dev" to jdk8u. > > > > Webrev: http://cr.openjdk.java.net/~shshahma/8164480/webrev.00/ > > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8164480 > > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot- > dev/2016-August/024372.html > > Jdk8 review thread: http://mail.openjdk.java.net/pipermail/hotspot- > dev/2018-March/031101.html > > > > Testing: jprt -testset hotspot > > > > Regards, > > Shafi > > From poonam.bajaj at oracle.com Fri Mar 30 19:39:52 2018 From: poonam.bajaj at oracle.com (Poonam Parhar) Date: Fri, 30 Mar 2018 12:39:52 -0700 Subject: {8u} RFA for backport of JDK-8199406: Performance drop with Java JDK 1.8.0_162-b32 Message-ID: Hello, Please approve this request to backport the following fix to 8u-dev. Bug: JDK-8199406 : Performance drop with Java JDK 1.8.0_162-b32 8u webrev: http://cr.openjdk.java.net/~poonam/8199406/webrev.8u/ 8u review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-March/028645.html 11 Changeset: http://hg.openjdk.java.net/jdk/hs/rev/d6893a76c554 11 Review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-March/028632.html Thanks, Poonam From rob.mckenna at oracle.com Fri Mar 30 19:59:21 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 30 Mar 2018 20:59:21 +0100 Subject: {8u} RFA for backport of JDK-8199406: Performance drop with Java JDK 1.8.0_162-b32 In-Reply-To: References: Message-ID: <20180330195921.GD3761@vimes> Approved -Rob On 30/03/18 12:39, Poonam Parhar wrote: > Hello, > > Please approve this request to backport the following fix to 8u-dev. > > Bug: JDK-8199406 : > Performance drop with Java JDK 1.8.0_162-b32 > 8u webrev: http://cr.openjdk.java.net/~poonam/8199406/webrev.8u/ > 8u review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-March/028645.html > 11 Changeset: http://hg.openjdk.java.net/jdk/hs/rev/d6893a76c554 > 11 Review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-March/028632.html > > Thanks, > Poonam > >