[jdk8u-dev] Request for review and approval : 8193892: Impact of noncloneable MessageDigest implementation

Brad Wetmore bradford.wetmore at oracle.com
Tue Mar 6 18:17:49 UTC 2018


Looks good, sorry for the delay, I don't check this alias as often.

Brad


On 3/4/2018 12:54 PM, Seán Coffey wrote:
> Brad,
> 
> as per off thread comments, the JDK 8u test also needs correction. The 
> test Provider was being registered incorrectly and provided a false pass 
> test result. I've corrected that now and added extra code to ensure the 
> expected provider is always registered during the test.
> 
> I've updated the webrev :
> 
> http://cr.openjdk.java.net/~coffeys/webrev.8193892.jdk8u.v2/webrev/
> 
> Please review when you've a moment.
> 
> regards,
> Sean.
> 
> On 01/03/2018 13:53, dalibor topic wrote:
>> Thanks, Sean - approved pending positive review.
>>
>> cheers,
>> dalibor topic
>>
>> On 28.02.2018 19:53, Seán Coffey wrote:
>>> Looking to port the below test to JDK 8u. Almost identical to JDK 11 
>>> fix except I had to the use the old Provider constructor call in 
>>> MyProvider code.
>>>
>>> Brad - would you mind confirming for review ?
>>>
>>> bug ID : https://bugs.openjdk.java.net/browse/JDK-8193892
>>> webrev : 
>>> http://cr.openjdk.java.net/~coffeys/webrev.8193892.jdk8u/webrev/
>>>
>>> regards,
>>> Sean.
>>>
>>
> 


More information about the jdk8u-dev mailing list