[8u-dev] Request for approval (XS): 8033292: jdk9-dev build failed due to configure issue: configure: error: The following variables are unknown to configure: MAKE

[Kevin Walls]

Hi,

I'd like to request approval to backport this change to 8u.  This 
follows on from 8031759 changes.  Maybe that change is overly strict 
regarding its error vs warning, or maybe no actual build would be 
affected... It seems best to backport this small change so nobody is 
surprised by a failing build.

JBS: https://bugs.openjdk.java.net/browse/JDK-8033292
9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/rev/bd59753b56bf

It's a one-liner change in common/autoconf/basics.m4 to change an error 
to a warning, plus a regenerated common/autoconf/generated-configure.sh

I have pasted in my 8u change below, as it is so small, but can do a 
webrev if needed.

Without this change, running:

$ bash configure FOOBAR=mistake

gives:
configure: error: The following variables are unknown to configure:  FOOBAR

With this change, the configure output contains a warning, but continues:

configure: WARNING: The following variables might be unknown to 
configure:  FOOBAR

Many thanks
Kevin


bash-4.2$ hg status
M common/autoconf/basics.m4
M common/autoconf/generated-configure.sh
bash-4.2$ hg diff
diff -r 0e87966d7ff1 common/autoconf/basics.m4
--- a/common/autoconf/basics.m4 Tue Mar 20 09:19:10 2018 -0700
+++ b/common/autoconf/basics.m4 Wed Mar 21 03:09:02 2018 -0700
@@ -250,7 +250,7 @@
    if test "x$CONFIGURE_OVERRIDDEN_VARIABLES" != x; then
      # Replace the separating ! with spaces before presenting for end user.
      unknown_variables=${CONFIGURE_OVERRIDDEN_VARIABLES//!/ }
-    AC_MSG_ERROR([The following variables are unknown to configure: 
$unknown_variables])
+    AC_MSG_WARN([The following variables might be unknown to configure: 
$unknown_variables])
    fi
  ])

diff -r 0e87966d7ff1 common/autoconf/generated-configure.sh
--- a/common/autoconf/generated-configure.sh    Tue Mar 20 09:19:10 2018 
-0700
+++ b/common/autoconf/generated-configure.sh    Wed Mar 21 03:09:02 2018 
-0700
@@ -4076,7 +4076,7 @@
  #CUSTOM_AUTOCONF_INCLUDE

  # Do not change or remove the following line, it is needed for 
consistency checks:
-DATE_WHEN_GENERATED=1521554908
+DATE_WHEN_GENERATED=1521626909

  ###############################################################################
  #
@@ -47013,7 +47013,8 @@
    if test "x$CONFIGURE_OVERRIDDEN_VARIABLES" != x; then
      # Replace the separating ! with spaces before presenting for end user.
      unknown_variables=${CONFIGURE_OVERRIDDEN_VARIABLES//!/ }
-    as_fn_error $? "The following variables are unknown to configure: 
$unknown_variables" "$LINENO" 5
+    { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: The following 
variables might be unknown to configure: $unknown_variables" >&5
+$as_echo "$as_me: WARNING: The following variables might be unknown to 
configure: $unknown_variables" >&2;}
    fi