[8u-dev] Request for approval JDK-8165489: Missing G1 barrier in Unsafe_GetObjectVolatile

[Aleksey Shipilev]

Hi Rob,

Review had finally happened at hotspot-dev@, see:
  http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-May/032092.html

Thomas ran this through JPRT as well.

-Aleksey

On 04/16/2018 03:41 PM, Rob McKenna wrote:
> This change requires a codereview. As one hasn't been explicitly
> requested in the subject line, then HS reviewers may overlook this
> email.
> 
>     -Rob
> 
> On 13/04/18 18:45, Aleksey Shipilev wrote:
>> Hi,
>>
>> Please approve this fix for 8u. This improves G1 stability in 8u, and provides the base for
>> Shenandoah JDK 8 backport that piggybacks on G1 pre-barriers. The fix does not apply cleanly,
>> because there is also Unsafe_GetObject140 that needs fixing too.
>>
>> JDK 9 bug:
>>   https://bugs.openjdk.java.net/browse/JDK-8165489
>>
>> JDK 9 fix:
>>   http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a696583f5ddb
>>
>> JDK 8u fix:
>>   http://cr.openjdk.java.net/~shade/8165489-8u/webrev.01/
>>
>> Testing: x86_64 build, Shenandoah tests
>>
>> Thanks,
>> -Aleksey