[8u-dev] Request for approval & review: 8202996 - Remove debug print statements from RMI fix

Rob McKenna rob.mckenna at oracle.com
Sat May 12 22:08:41 UTC 2018


D'oh - thanks Petr:

https://bugs.openjdk.java.net/browse/JDK-8202996
http://cr.openjdk.java.net/~robm/8202996/webrev.01/

Note: the test fix println has already been removed.

    -Rob

On 11/05/18 14:09, Seán Coffey wrote:
> Good spot Petr,
> 
> Looks like an issue. I've logged
> https://bugs.openjdk.java.net/browse/JDK-8202996
> 
> The 2nd println statement is not a concern since it's in a testcase.
> 
> Regards,
> Sean.
> 
> On 11/05/18 12:45, Petr Kuzel wrote:
> >Hi,
> >
> >I wonder if http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/d70c21e5b413
> >have not sneaked in few debug messages, namely:
> >
> >                  if (magic == POST) {
> >+                    System.err.println("DISABLED: " + disableIncomingHttp);
> >+                    if (disableIncomingHttp) {
> >+                        throw new RemoteException("RMI over HTTP is disabled");
> >+                    }
> >                      tcpLog.log(Log.BRIEF, "decoding HTTP-wrapped call");
> >
> >and
> >
> >
> >          LocateRegistry.createRegistry(FALLBACK_PORT);
> >
> >
> >
> >+        System.err.println("1-DISABLED: " + System.getProperty("java.rmi.server.disableIncomingHttp"));
> >
> >+
> >
> >
> >   Hope it helps
> >   Cc.
> 


More information about the jdk8u-dev mailing list