[8u-dev] Request for review and approval: JDK-8213154: Update copyright headers of files in src tree that are missing Classpath exception

Martin Balao mbalao at redhat.com
Thu Nov 1 15:37:14 UTC 2018


Hi Andrew,

Thanks for having a look at this.

Webrev.01 without "All rights reserved" and "affiliates" parts:

 *
http://cr.openjdk.java.net/~mbalao/webrevs/8213154/8213154.webrev.01.jdk8u/
 *
http://cr.openjdk.java.net/~mbalao/webrevs/8213154/8213154.webrev.01.jdk8u.zip

Are you okay to go?

Kind regards,
Martin.-

On Thu, Nov 1, 2018 at 8:10 AM, Andrew Hughes <gnu.andrew at redhat.com> wrote:

> On Tue, 30 Oct 2018 at 18:03, Martin Balao <mbalao at redhat.com> wrote:
> >
> > Hi,
> >
> > Can I have a review for the JDK-8 backport of JDK-8213154 ?
> >
> >  *
> > http://cr.openjdk.java.net/~mbalao/webrevs/8213154/
> 8213154.webrev.00.jdk8u/
> >  *
> > http://cr.openjdk.java.net/~mbalao/webrevs/8213154/
> 8213154.webrev.00.jdk8u.zip
> >
> > Thanks,
> > Martin.-
> >
> > --
> > [1] - https://bugs.openjdk.java.net/browse/JDK-8213154
>
> Adding the missing Classpath exception looks fine, but there is no need to
> add
> "All rights reserved" to an RH copyright. Even the "affiliates" part
> is superfluous.
>
> Thanks,
> --
> Andrew :)
>
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> Web Site: http://fuseyism.com
> Twitter: https://twitter.com/gnu_andrew_java
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
>


More information about the jdk8u-dev mailing list