[8u] Request for enhancement backport approval for CR JDK-8029661 - Support TLS v1.2 algorithm in SunPKCS11 provider

Valerie Peng valerie.peng at oracle.com
Tue Nov 6 02:13:05 UTC 2018


Let me validate your patch with a mach5 job.

Testing on only 1 platform with only sun/security/pkcs11 test suite is a 
bit lacking comparing to our general testing requirement before 
integrating the changes.

Thanks,
Valerie

On 10/31/2018 1:13 PM, Martin Balao wrote:
> On Wed, Oct 31, 2018 at 1:22 PM, Andrew Hughes <gnu.andrew at redhat.com 
> <mailto:gnu.andrew at redhat.com>> wrote:
>
>
>     Having 8029661 be that fix alone on 12, but 8029661+8210912 on
>     8u is confusing.  I can understand the desire to pair them, given
>     we know 8029661 breaks the build without the other change, but
>     at the very least, it should be mentioned in the commit message,
>     so it shows up in searches. It doesn't appear to be at present.
>
>
> That's right, thanks for pointing this out.
>
> Webrev.12:
>
>  * 
> http://cr.openjdk.java.net/~mbalao/webrevs/8029661/8029661.webrev.12.jdk8u/ 
> <http://cr.openjdk.java.net/%7Embalao/webrevs/8029661/8029661.webrev.12.jdk8u/>
>  * 
> http://cr.openjdk.java.net/~mbalao/webrevs/8029661/8029661.webrev.12.jdk8u.zip 
> <http://cr.openjdk.java.net/%7Embalao/webrevs/8029661/8029661.webrev.12.jdk8u.zip> 
>
>
> @Valerie: are you okay to go now?
>
> Kind regards,
> Martin.-



More information about the jdk8u-dev mailing list