[8u-dev] Request for approval for 8131048 and 8164920

[Gustavo Romero]

Hi David!

On 10/02/2018 11:17 PM, David Buck wrote:
> Hi Gustavo!
> 
> Would you please file an enhancement backport approval request?
> 
> http://openjdk.java.net/projects/jdk8u/enhancement-template.html

Sure! Thanks.


Cheers,
Gustavo

> Cheers,
> -Buck
> 
> On 2018/10/03 9:50, Gustavo Romero wrote:
>> Hi,
>>
>> Could the following backports be approved please?
>>
>> "8131048: ppc: implement CRC32 intrinsic"
>> Bug           : https://bugs.openjdk.java.net/browse/JDK-8131048
>> jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/3b81bc9fe683
>>
>> "8164920: ppc: enhancement of CRC32 intrinsic"
>> Bug           : https://bugs.openjdk.java.net/browse/JDK-8164920
>> jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/ebbfdf26a4ee
>>
>> Both changes do not apply cleanly to jdk8u and a few adjustments were necessary
>> regarding the file path structure changes from 8 to 9, CPU feature detection
>> (has_vpmsumb), and the C calling convention on PPC64.
>>
>> 8131048 and 8164920 backports have been reviewed by Goetz on hotspot-compiler-dev:
>>
>> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-October/030819.html
>>
>> OpenJDK 8u backport webrev:
>>
>> http://cr.openjdk.java.net/~gromero/crc32_jdk8u/v3/8131048/
>> http://cr.openjdk.java.net/~gromero/crc32_jdk8u/v3/8164920/
>>
>> The backports in question are important for the performance of some Apache
>> Cassandra workloads on PPC64. For instance, YCSB improves throughput by 19%.
>>
>> The 8131048 backport touches shared code but in effect is PPC64-only.
>>
>> Thank you.
>>
>>
>> Best regards,
>> Gustavo
>>
>> PS: I understand that the request for approval for 8u is still done through
>> email and not by setting a proper *-fix-request label in the JBS like it happens
>> for 10, 11, and above, as described in [1].
>>
>> [1] http://openjdk.java.net/projects/jdk-updates/approval.html
>>
>