[8u-dev] Request for approval for CR JDK-8131048 and JDK-8164920

[Gustavo Romero]

On 10/10/2018 12:27 PM, Seán Coffey wrote:
> I think we have all the information needed from your previous emails. I've adjusted the subject line in this email to "request for approval"
> 
> Approved for pushing to jdk8u-dev.

Thanks Sean.

@Andrew, I'm wondering if you so kindly could please sponsor that change now it's approved.


Thanks and best regards,
Gustavo
  
> Regards,
> Sean.
> 
> On 10/10/18 14:11, Gustavo Romero wrote:
>> Hi Sean,
>>
>> On 10/10/2018 05:29 AM, Seán Coffey wrote:
>>> Gustavo,
>>>
>>> this is approved for jdk8u-dev.
>>
>> Thank you so much.
>>
>> Do I need to trigger again a RFA (I did it before this RFE approval by mistake
>> [1]), or this approval is already the final one and so it's ready to be pushed?
>>
>>
>> Best regards,
>> Gustavo
>>
>> [1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-October/007934.html
>>
>>> Regards,
>>> Sean.
>>>
>>> On 05/10/18 17:21, Seán Coffey wrote:
>>>> Thanks for the request Gustavo. I hope to have an answer for you shortly.
>>>>
>>>> Regards,
>>>> Sean.
>>>>
>>>> On 05/10/18 14:06, Gustavo Romero wrote:
>>>>> Hi,
>>>>>
>>>>> Any news on that request?
>>>>>
>>>>> Please let me know if any bit of information is missing so I can provide it.
>>>>>
>>>>> Thanks.
>>>>>
>>>>>
>>>>> Best regards,
>>>>> Gustavo
>>>>>
>>>>> On 10/03/2018 01:00 PM, Gustavo Romero wrote:
>>>>>> Hi,
>>>>>>
>>>>>> I'd like to request an enhancement backport approval for JDK-8131048 [1] and
>>>>>> JDK-8164920 [2]  which will add support for CRC32 intrinsics on PPC64.
>>>>>>
>>>>>> Adding support for the CRC32 intrinsics on PPC64 would be highly beneficial and
>>>>>> important for the performance of several workloads relying on CRC32 methods and
>>>>>> it's specially important for some Apache Cassandra workloads on PPC64. For
>>>>>> instance, YCSB benchmark improves its throughput by 19 % when the CRC32
>>>>>> intrinsics are enabled.
>>>>>>
>>>>>> The risk involved is low and it affects only the PPC64 platform.
>>>>>>
>>>>>> JDK-8131048 and JDK-8164920 backports have been reviewed by Goetz Lindenmaier
>>>>>> on hotspot-compiler-dev ML [3]. The changes were tested on PPC64 LE / Linux,
>>>>>> PPC64 BE / Linux, and PPC64 BE / AIX. No regression was observed.
>>>>>>
>>>>>> The webrevs for OpenJDK 8u can be found in:
>>>>>>
>>>>>> "8131048: ppc: implement CRC32 intrinsic"
>>>>>> http://cr.openjdk.java.net/~gromero/crc32_jdk8u/v3/8131048/
>>>>>>
>>>>>> "8164920: ppc: enhancement of CRC32 intrinsic"
>>>>>> http://cr.openjdk.java.net/~gromero/crc32_jdk8u/v3/8164920/
>>>>>>
>>>>>> Thank you.
>>>>>>
>>>>>>
>>>>>> Best regards,
>>>>>> Gustavo
>>>>>>
>>>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8131048
>>>>>> [2] https://bugs.openjdk.java.net/browse/JDK-8164920
>>>>>> [3] http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-October/030819.html
>>>>>>
>>>>>
>>>>
>>>
>>
>