[8u-dev] RFA (XS): JDK-8211394: CHECK_ must be used in the rhs of an assignment statement within a block
Hohensee, Paul
hohensee at amazon.com
Mon Oct 22 14:55:32 UTC 2018
Yes, my bad on this, and +1 on thanks for backing it out. I'll push the correct patch today if that's ok.
Paul
On 10/21/18, 2:43 PM, "David Holmes" <david.holmes at oracle.com> wrote:
On 20/10/2018 2:01 PM, Ivan Gerasimov wrote:
> The build issue seems to be due that the actual source diff [1]
> contained this change:
>
> + from_field_is_protected, TRAPS);
>
> while the webrev [2] had this:
>
> + from_field_is_protected,
> THREAD);
>
> which, I assume, was building fine.
Yes the patch from the webrev was put through JPRT and everything was fine.
Thanks for doing the backout Ivan.
David H.
> [1] http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/raw-rev/fbc668a76c00
> [2]
> http://cr.openjdk.java.net/~phh/8211394/webrev.00/src/share/vm/classfile/verificationType.cpp.patch
>
>
> With kind regards,
> Ivan
>
> On 10/19/18 8:03 PM, Ivan Gerasimov wrote:
>> Hello!
>>
>> I'm curious how the jdk build passed successfully.
>>
>> I see the following error in JPRT now (failing on all platforms):
>>
>> /s/hotspot/src/share/vm/classfile/verificationType.cpp: In member
>> function 'bool VerificationType::is_reference_assignable_from(const
>> VerificationType&, ClassVerifier*, bool, Thread*)
>> const':/s/hotspot/src/share/vm/classfile/verificationType.cpp:102:
>> error: expected primary-expression before '*' token
>>
>> or, on Windows:
>>
>> \s\hotspot\src\share\vm\classfile\verificationType.cpp(102) : error
>> C2275: 'Thread' : illegal use of this type as an expression
>> C:\jprt\T\P1\020004.robm\s\hotspot\src\share\vm\runtime/thread.hpp(102) :
>> see declaration of 'Thread'
>>
>> I created JDK-8212709 to backout the backport for now.
>>
>> With kind regards,
>>
>> Ivan
>>
>>
>> On 10/19/18 9:54 AM, Hohensee, Paul wrote:
>>> Done and pushed. Thanks!
>>>
>>> On 10/18/18, 8:41 PM, "David Buck" <david.buck at oracle.com> wrote:
>>>
>>> Hi Paul!
>>> Please add an appropriate noreg label [0] to the JBS bug
>>> report.
>>> Once that is done please consider this approved for push to
>>> 8u-dev.
>>> Cheers,
>>> -Buck
>>> [0] https://openjdk.java.net/guide/changePlanning.html#noreg
>>> On 2018/10/19 9:29, David Holmes wrote:
>>> > On 19/10/2018 2:44 AM, Hohensee, Paul wrote:
>>> >> Hi David,
>>> >>
>>> >> Did the jprt job go ok? If so, Rob or Sean, would you please
>>> approve
>>> >> the backport?
>>> >
>>> > Yes - sorry. Didn't expect it to hold this up as it's so trivial.
>>> >
>>> > David
>>> >
>>> >> Thanks,
>>> >>
>>> >> Paul
>>> >>
>>> >> On 10/16/18, 7:06 PM, "David Holmes"
>>> <david.holmes at oracle.com> wrote:
>>> >>
>>> >> On 17/10/2018 8:23 AM, Hohensee, Paul wrote:
>>> >> > Please approve a trivial backport of JDK-8211394 to 8u.
>>> >> >
>>> >> > JBS: https://bugs.openjdk.java.net/browse/JDK-8211394
>>> >> >
>>> >> > Webrev:
>>> http://cr.openjdk.java.net/~phh/8211394/webrev.00/
>>> >> > <http://cr.openjdk.java.net/%7Ephh/8211394/webrev.00/>
>>> >> >
>>> >> > Review thread:
>>> >> >
>>> >>
>>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2018-October/030376.html
>>>
>>> >>
>>> >> >
>>> >> > The patch applies cleanly net of line numbers,
>>> copyright notice
>>> >> > dates, and code that exists in JDK9 but not in JDK8.
>>> The result
>>> >> is a one
>>> >> > line change and a new comment.
>>> >> Looks fine.
>>> >> > It builds and runs jdk8 hotspot jtreg test on a linux
>>> x64 host. If
>>> >> > needed, would someone please run it through jprt?
>>> >> It doesn't really warrant it but I fired it off anyway.
>>> >> Thanks,
>>> >> David
>>> >> > Thanks,
>>> >> >
>>> >> > Paul
>>> >> >
>>> >>
>>>
>>
>
More information about the jdk8u-dev
mailing list