[8u-dev] Request for approval of CR 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

[Hohensee, Paul]

Thanks for your review, Jc. :)

Paul

From: JC Beyler <jcbeyler at google.com>
Date: Tuesday, October 30, 2018 at 8:48 AM
To: "Hohensee, Paul" <hohensee at amazon.com>
Cc: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>, "joe.darcy at oracle.com" <joe.darcy at oracle.com>
Subject: Re: [8u-dev] Request for approval of CR 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Hi all,

If it helps, I reviewed the change and compared it with the JDK11 change and it looks good to me but I'm nor a reviewer, nor someone who understands the gates when considering a backport :)
Jc

On Fri, Oct 26, 2018 at 10:39 AM Hohensee, Paul <hohensee at amazon.com<mailto:hohensee at amazon.com>> wrote:
Ping. :)

On 10/25/18, 8:01 AM, "jdk8u-dev on behalf of Hohensee, Paul" <jdk8u-dev-bounces at openjdk.java.net<mailto:jdk8u-dev-bounces at openjdk.java.net> on behalf of hohensee at amazon.com<mailto:hohensee at amazon.com>> wrote:

    Please approve a G1 serviceability bug backport.

    JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8195115
    CSR: https://bugs.openjdk.java.net/browse/JDK-8196719
    Webrev: http://cr.openjdk.java.net/~phh/8195115/webrev.05/
    Original review thread: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2018-June/022305.html
    Backport review thread: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2018-October/023507.html
    Backport reviewers: tschatzl, jcbeyler

    I don’t know what the process is for approving a CSR associated with a backport, hence cc’ing Joe. The CSR documents the behavior change due to this fix, but as it notes, there is no spec change.

    Thanks,

    Paul



--

Thanks,
Jc