RFR[8u] JDK-8206183: Possible construct EMPTY_STACK and allocation stack, etc. on first use.

Seán Coffey sean.coffey at oracle.com
Tue Sep 18 15:36:05 UTC 2018


Don't forget to submit a request to backport this enhancement also. 
Looks like this request is still pending a review for 8u in any case.

http://openjdk.java.net/projects/jdk8u/enhancement-template.html

regards,
Sean.


On 18/09/2018 08:27, Zhengyu Gu wrote:
> Oops, my bad!
>
> The webrev: http://cr.openjdk.java.net/~zgu/8206183_8u/webrev.00/
>
> You may want to cleanup the text and resubmit RFR.
>
> Thanks,
>
> -Zhengyu
>
> On 09/18/2018 11:12 AM, Leslie Zhai wrote:
>> Hi Zhengyu,
>>
>> $ hg log | head
>> changeset:   8722:16b9bbfaa450
>> tag:         tip
>> user:        phh
>> date:        Fri Sep 14 07:58:22 2018 -0700
>> summary:     8209863: Add a test to verify that -XX:+EnableTracing works
>>
>> changeset:   8721:80ee2541504e
>> user:        phh
>> date:        Thu Aug 23 22:56:32 2018 +0000
>> summary:     8145788: JVM crashes with -XX:+EnableTracing
>>
>> $ patch -Np1 -i /data/project/xiangzhai/jdk8u-dev/JDK-8205965-8u.patch
>>
>> patching file src/share/vm/services/mallocSiteTable.hpp
>> patching file src/share/vm/services/memTracker.hpp
>> patching file src/share/vm/services/virtualMemoryTracker.hpp
>> patching file src/share/vm/utilities/nativeCallStack.cpp
>> patching file src/share/vm/utilities/nativeCallStack.hpp
>>
>> $ patch -Np1 -i /data/project/xiangzhai/jdk8u-dev/JDK-8206183-8u.patch
>>
>> patching file src/share/vm/services/mallocSiteTable.cpp
>> patching file src/share/vm/services/mallocSiteTable.hpp
>> patching file src/share/vm/services/memTracker.cpp
>> patching file src/share/vm/utilities/nativeCallStack.cpp
>> patching file src/share/vm/utilities/nativeCallStack.hpp
>>
>> ----- 8< -------- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---
>>
>> It seems works for me: JDK-8206183-8u.patch could be applied on top 
>> of JDK-8205965-8u.patch
>>
>> Please point out my fault, thanks a lot!
>>
>>
>> 在 2018年09月18日 21:02, Zhengyu Gu 写道:
>>> Hi Leslie,
>>>
>>> This patch could not be applied cleanly on top of JDK-8205965, looks 
>>> like you bypassed JDK-8205965 for this patch?
>>>
>>> We want backports to diverge from original patches as little as 
>>> possible, that include the order of related patches.
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>> On 09/17/2018 10:57 PM, Leslie Zhai wrote:
>>>> Hi Zhengyu,
>>>>
>>>> I would like to backport the fix for:
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8206183
>>>>
>>>> To OpenJDK 8 updates dev:
>>>>
>>>> http://hg.openjdk.java.net/jdk8u/jdk8u-dev
>>>>
>>>> The fix is mostly the same as the version that was committed in 12.
>>>>
>>>> Please generate webrev for me,  thank you very much!
>>>>
>>>> PS: I will run jtreg after compiled with LLVM 8-dev and GCC 9-dev 
>>>> for X86 later.
>>>>
>>>> Thanks,
>>>>
>>>> Leslie Zhai
>>>>
>>



More information about the jdk8u-dev mailing list