[8u-dev] Request for approval for CR 8211124: HotSpot vm_version.cpp should recognise updated VS2017

[Seán Coffey]

Approved.

regards,
Sean.


On 27/09/2018 15:25, Kevin Walls wrote:
> Hi,
>
> I'd like to request approval to backport from the latest jdk repo to 8u:
>
> 8211124: HotSpot vm_version.cpp should recognise updated VS2017
> JBS: https://bugs.openjdk.java.net/browse/JDK-8211124
>
> jdk repo changeset:
> http://hg.openjdk.java.net/jdk/jdk/rev/293c2728644c
>
> hotsot review thread:
> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2018-September/030220.html 
>
>
> This is a clean backport, after a file path change.  8u hotspot diff 
> pasted in below.
>
> Thanks
> Kevin
>
>
> bash-4.2$ hg diff
> diff -r 3fa12c91c20a src/share/vm/runtime/vm_version.cpp
> --- a/src/share/vm/runtime/vm_version.cpp       Wed Sep 26 04:31:35 
> 2018 -0400
> +++ b/src/share/vm/runtime/vm_version.cpp       Thu Sep 27 06:34:58 
> 2018 -0700
> @@ -224,6 +224,8 @@
>          #define HOTSPOT_BUILD_COMPILER "MS VC++ 14.0 (VS2015)"
>        #elif _MSC_VER == 1912
>          #define HOTSPOT_BUILD_COMPILER "MS VC++ 15.5 (VS2017)"
> +      #elif _MSC_VER == 1913
> +        #define HOTSPOT_BUILD_COMPILER "MS VC++ 15.6 (VS2017)"
>        #else
>          #define HOTSPOT_BUILD_COMPILER "unknown MS VC++:" XSTR(_MSC_VER)
>        #endif
> bash-4.2$
>