make reconfigure broken (quoting problem?)

[Martin Buchholz]

Kevin - Thanks.  This looks like the right fix, making jdk8's behavior
consistent with later jdks.

Who will volunteer to check in Kevin's fix?

On Mon, Apr 1, 2019 at 1:54 AM Kevin Walls <kevin.walls at oracle.com> wrote:

> Hi Martin -
>
> I recall "make reconfigure" working but clearly there's a
> complication....  Looks like reconfigure doesn't handle >1 argument.  It
> looks like it's processing all the args to configure as one, rather than
> individually?   I just tried this make change and "make reconfigure" worked
> with two arguments to configure:
>
> diff -r 9a4af54dd074 make/Main.gmk
> --- a/make/Main.gmk     Fri Mar 22 17:51:45 2019 +0000
> +++ b/make/Main.gmk     Mon Apr 01 01:44:05 2019 -0700
> @@ -238,7 +238,7 @@
>          else
>           @$(ECHO) "Re-running configure using default settings"
>          endif
> -       @( cd $(OUTPUT_ROOT) && $(BASH) $(TOPDIR)/configure
> "$(CONFIGURE_COMMAND_LINE)" )
> +       @( cd $(OUTPUT_ROOT) && $(BASH) $(TOPDIR)/configure
> $(CONFIGURE_COMMAND_LINE) )
>
>  .PHONY: langtools corba jaxp jaxws hotspot jdk nashorn images
> overlay-images install test docs
>  .PHONY: langtools-only corba-only jaxp-only jaxws-only hotspot-only
> jdk-only nashorn-only images-only overlay-images-only install-only
> test-only docs-only
>
> I looked in 11u and this isn't a problem there, it's laid out a little
> differently and this happens in make/Init.gmk
>
> Hope that helps,
> Kevin
>
>
> On 30/03/2019 01:48, Martin Buchholz wrote:
>
> It looks to me like this feature was broken at the time of its backport to
> jdk8u
>
> changeset:   2163:2209644bcac4
> user:        kevinw
> date:        2018-04-10 07:46 -0700
> 8034199: Add 'reconfigure' target for re-creating a configuration
> Reviewed-by: ihse, erikj, tbell
>
> Recipe:
> hg update 2209644bcac4 && hg log -r . && bash configure
> --with-toolchain-type=gcc --with-boot-jdk=$HOME/jdk/jdk7 && make
> reconfigure
> ...
> configure: Toolchain type gcc --with-boot-jdk=.../jdk/jdk7 is not valid on
> this platform.
> configure: Valid toolchains: gcc clang.
> configure: error: Cannot continue.
>
>
>
> On Fri, Mar 29, 2019 at 11:35 AM Andrew John Hughes <gnu.andrew at redhat.com>
> wrote:
>
>> On 29/03/2019 16:23, Martin Buchholz wrote:
>> > Recipe:
>> >
>> > ( rm -rf build; set -x; bash configure --with-toolchain-type=gcc
>> > --with-boot-jdk=$HOME/jdk/jdk7 && make reconfigure )
>> > =>
>> > configure: Toolchain type gcc --with-boot-jdk=.../jdk/jdk7 is not valid
>> on
>> > this platform.
>> > configure: Valid toolchains: gcc clang.
>> >
>> > ---
>> > Do y'all always build from scratch?
>> >
>>
>> Personally speaking, not always. It depends what I've altered.
>>
>> Where are you seeing this? jdk8u or jdk8u-dev? And any idea what change
>> caused it?
>>
>> Thanks,
>> --
>> Andrew :)
>>
>> Senior Free Java Software Engineer
>> Red Hat, Inc. (http://www.redhat.com)
>>
>> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
>> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
>> https://keybase.io/gnu_andrew
>>
>>