[PATCH] [8u] Prevent MSDOS8.3 named DLL in built image

[Langer, Christoph]

Hi Ali,

ok, in that case (working with --disable-warnings-as-errors) it might be worth a separate patch.

Then please check whether it’s reasonable to backport a larger part of https://bugs.openjdk.java.net/browse/JDK-8201267. If so, please provide a webrev for it. Otherwise, let me know, too, and I can create a bug for just bringing in your original small fix and run it through the backport process.

Best regards
Christoph

From: Ali Ince <ali.ince at gmail.com>
Sent: Mittwoch, 3. April 2019 00:08
To: Langer, Christoph <christoph.langer at sap.com>
Cc: jdk8u-dev at openjdk.java.net
Subject: Re: [PATCH] [8u] Prevent MSDOS8.3 named DLL in built image

Hi Christoph,

Thanks for your reply. I'm on Windows 10 but can also try a build on Windows 7 (which is AFAIK the oldest supported version by MSFT).

I can build JDK8 with VS2017 for both 32-bit and 64-bit targets. My builds included the `--disable-warnings-as-errors` flag but it seems reasonable to try the build without this flag to see whether it will surface any errors. I'll give it a try and also make (well at least try) a comparison with the JDK11 changeset you've referenced.

Best regards,

Ali

On Mon, Apr 1, 2019 at 7:06 AM Langer, Christoph <christoph.langer at sap.com<mailto:christoph.langer at sap.com>> wrote:
Hi Ali,

generally, I think this makes sense. Maybe, however, there are still some legacy compile environments around somewhere which will have a problem with that, e.g. very old Windows versions? It's hard to tell but it's probably reasonable to try out the fix.

I found the change to be part of a VS2017 enabling fix for JDK11:

https://bugs.openjdk.java.net/browse/JDK-8201267
http://hg.openjdk.java.net/jdk/jdk/rev/7c224ec572d0

So I have a general question: Shouldn't this fix be part of a larger change that would enable VS2017 for JDK8? I assume it won't be the only thing to touch...

Best regards
Christoph



> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-bounces at openjdk.java.net<mailto:jdk8u-dev-bounces at openjdk.java.net>> On Behalf Of Ali
> Ince
> Sent: Donnerstag, 28. März 2019 20:48
> To: jdk8u-dev at openjdk.java.net<mailto:jdk8u-dev at openjdk.java.net>
> Subject: [PATCH] [8u] Prevent MSDOS8.3 named DLL in built image
>
> Hi All,
>
> We're working on building JDK8U with VS2017 at AdoptOpenJDK and found
> out that the new vcruntime140.dll is copied to the built image named as
> `vcrunt~1.dll` which is basically because of the extra call to
> `BASIC_FIXUP_PATH` call in `toolchain_windows.m4` file. If the call is
> removed, everything works fine.
>
> On previous versions of VS, the VC runtime DLL was originally named in 8.3
> style (ex. msvcr100.dll) and BASIC_FIXUP_PATH did not have any affect on
> the file name itself. I've checked with `toolchain_windows.m4` files in jdk11u
> and onwards and also saw that this call doesn't exist.
>
> I've came up with the following patch which removes this call. I'm not sure
> what's the process about updating the checked-in generated_configure.sh
> but I could also add the patch for that if it's required.
>
> Let me know if you have any feedback or comments.
>
> Regards,
>
> Ali
>
> ---------------------------------------------
>
> diff -r e0b7721459ee common/autoconf/toolchain_windows.m4
> --- a/common/autoconf/toolchain_windows.m4    Wed Mar 20 16:32:54 2019
> +0000
> +++ b/common/autoconf/toolchain_windows.m4    Thu Mar 28 00:03:10 2019
> +0000
> @@ -493,7 +493,6 @@
>      if $ECHO "$MSVC_DLL_FILETYPE" | $GREP "$CORRECT_MSVCR_ARCH"
> 2>&1 > /dev/null; then
>        AC_MSG_RESULT([ok])
>        MSVC_DLL="$POSSIBLE_MSVC_DLL"
> -      BASIC_FIXUP_PATH(MSVC_DLL)
>        AC_MSG_CHECKING([for $DLL_NAME])
>        AC_MSG_RESULT([$MSVC_DLL])
>      else
>